Re: [VOTE] Pulsar Release 2.0.0-rc1-incubating Candidate 3

I'd include the Photoshop or Gimp file for a raster image or an SVG or EPS or similar for scalar images. In fact, that's what we do in Log4j for our logo. On 14 May 2018 at 17:29, Justin Mclean wrote: > Hi, > > > Okay. But this is a test "resource" used by other

Re: [VOTE] Pulsar Release 2.0.0-rc1-incubating Candidate 3

Hi, > Okay. But this is a test "resource" used by other sources on testing. Tests resources are not exempt. > Image you are writing an image processing library, you include some > "images" for testing the library. Is it allowed to include those "images" > in the source release? Including

Re: [VOTE] Pulsar Release 2.0.0-rc1-incubating Candidate 3

If it is part of a releasable artifact, then source needs to be provided. > On May 14, 2018, at 2:16 PM, Sijie Guo wrote: > > On Mon, May 14, 2018 at 10:53 AM, Matt Sicker wrote: > >> I'm not sure about a specific policy, but sources by definition aren't

Re: [VOTE] Pulsar Release 2.0.0-rc1-incubating Candidate 3

On Mon, May 14, 2018 at 11:16 AM, Dave Fisher wrote: > Hi - > > > On May 14, 2018, at 10:57 AM, Sijie Guo wrote: > > > > On Sun, May 13, 2018 at 7:49 PM, Matt Sicker wrote: > > > >> On 13 May 2018 at 12:10, Matteo Merli

Re: [VOTE] Pulsar Release 2.0.0-rc1-incubating Candidate 3

On Mon, May 14, 2018 at 10:53 AM, Matt Sicker wrote: > I'm not sure about a specific policy, but sources by definition aren't the > binaries. Sources combine with a tool or tools to create binaries. > Okay. But this is a test "resource" used by other sources on testing. Image

Re: [VOTE] Pulsar Release 2.0.0-rc1-incubating Candidate 3

Hi - > On May 14, 2018, at 10:57 AM, Sijie Guo wrote: > > On Sun, May 13, 2018 at 7:49 PM, Matt Sicker wrote: > >> On 13 May 2018 at 12:10, Matteo Merli wrote: >> >>> The code in question is testing a feature that takes Jars from a

Re: [VOTE] Pulsar Release 2.0.0-rc1-incubating Candidate 3

On Sun, May 13, 2018 at 7:49 PM, Matt Sicker wrote: > On 13 May 2018 at 12:10, Matteo Merli wrote: > > > The code in question is testing a feature that takes Jars from a user and > > execute the code contained. Indeed the Jar should not be in the sources, >

Re: [VOTE] Pulsar Release 2.0.0-rc1-incubating Candidate 3

I'm not sure about a specific policy, but sources by definition aren't the binaries. Sources combine with a tool or tools to create binaries. On 14 May 2018 at 12:41, Sijie Guo wrote: > On Sat, May 12, 2018 at 3:52 PM, Justin Mclean > wrote: > > >

Re: [VOTE] Pulsar Release 2.0.0-rc1-incubating Candidate 3

On Sat, May 12, 2018 at 3:52 PM, Justin Mclean wrote: > Hi, > > Sorry but it’s -1 binding due to compiled code in source release. > Can anyone point me the ASF policy page about this - "compiled code in source release"? > > Frankly I’m surprised to see so many +1s

Re: [VOTE] Pulsar Release 2.0.0-rc1-incubating Candidate 3

On Sun, May 13, 2018 at 7:49 PM Matt Sicker wrote: > By generating the binary jar from source files at test time, you'd avoid > bundling any binary output files. > Correct, we are fixing that and we'll generated a new candidate release. Thanks, Matteo -- Matteo Merli

Re: [VOTE] Pulsar Release 2.0.0-rc1-incubating Candidate 3

On 13 May 2018 at 12:10, Matteo Merli wrote: > The code in question is testing a feature that takes Jars from a user and > execute the code contained. Indeed the Jar should not be in the sources, > though I believe the test is correct here: we need to validate the specific >

Re: [VOTE] Pulsar Release 2.0.0-rc1-incubating Candidate 3

Hi Matt, can you expand a bit more on the issue, because I'm not 100% sure I understand it correctly. > -1 as well. For strange build requirements that need to inject class files, that would still only be applied to the binary artifacts The code in question is testing a feature that takes Jars

Re: [VOTE] Pulsar Release 2.0.0-rc1-incubating Candidate 3

Thanks Justin and Dave, the Jar multifunction.jar is used in the context of some unit tests. I suspect it went in as an quick way to add the test (in this case the functionality is indeed to take a Jar with user code and load it) and then eventually we forgot to automate that in the Maven build.

Re: [VOTE] Pulsar Release 2.0.0-rc1-incubating Candidate 3

-1 as well. For strange build requirements that need to inject class files, that would still only be applied to the binary artifacts (e.g., injecting a module-info.class file at build time rather than requiring Java 9+ to build regardless). On 12 May 2018 at 21:17, Dave Fisher

Re: [VOTE] Pulsar Release 2.0.0-rc1-incubating Candidate 3

Hi Pulsar Devs, Thanks Justin! I know that Pulsar Functions are new. $ jar tvf apache-pulsar-2.0.0-rc1-incubating/pulsar-functions/utils/src/test/resources/multifunction.jar 0 Wed Dec 13 01:00:28 PST 2017 META-INF/ 147 Wed Dec 13 01:00:28 PST 2017 META-INF/MANIFEST.MF 0 Wed Dec 13

Re: [VOTE] Pulsar Release 2.0.0-rc1-incubating Candidate 3

Hi, Sorry but it’s -1 binding due to compiled code in source release. Frankly I’m surprised to see so many +1s with this obvious issue. I checked: - incubating in name - signatures and hashes correct - DISCLAIMER exists - LICENSE and NOTICE good - Unexpected jar in source release [1] - All

Re: [VOTE] Pulsar Release 2.0.0-rc1-incubating Candidate 3

+1 (binding) > On May 11, 2018, at 7:09 PM, Matteo Merli wrote: > > This is the third release candidate for Apache Pulsar, version > 2.0.0-rc1-incubating. > > Pulsar is a highly scalable, low latency messaging platform running on > commodity hardware. It provides simple

Re: [VOTE] Pulsar Release 2.0.0-rc1-incubating Candidate 3

Repeating my +1 (binding) -Taylor > On May 11, 2018, at 8:53 PM, Dave Fisher wrote: > > IPMC - please note that this vote received 3 IPMC votes from the mentors on > the dev list. > > I’ll repeat my +1 (binding) > > Regards, > Dave > > Sent from my iPhone > >> On

Re: [VOTE] Pulsar Release 2.0.0-rc1-incubating Candidate 3

IPMC - please note that this vote received 3 IPMC votes from the mentors on the dev list. I’ll repeat my +1 (binding) Regards, Dave Sent from my iPhone > On May 11, 2018, at 4:09 PM, Matteo Merli wrote: > > This is the third release candidate for Apache Pulsar, version >