Re: [VOTE] Release Airflow 1.10.0 (new vote based on rc4)

+1 (binding) I checked the source tar with the git tag and the License files. We need to specify the third party dependencies version as they may have different License in different version. Please fix it in next around release. Willem Jiang Twitter: willemjiang Weibo: 姜宁willem On Sun, Aug

Re: [VOTE] Release Airflow 1.10.0 (new vote based on rc4)

Hi Bolke The general approach I have used in the past is to find the correct "comment" syntax to allow addition of the license text such that it does not break the language parser. For markdown, that would mean just using an html comment. thanks Hitesh On Mon, Aug 20, 2018 at 10:56 AM Bolke

Re: [VOTE] Release Airflow 1.10.0 (new vote based on rc4)

Appreciated Hitesh. Do you know how to add headers to .MD files? There seems to be no technical standard way[1]. Is there a way to solve this elegantly? Cheers Bolke [1] https://alvinalexander.com/technology/markdown-comments-syntax-not-in-generated-output Sent from my iPhone > On 20 Aug

Re: [VOTE] Release Airflow 1.10.0 (new vote based on rc4)

+1 (binding) Ran through the basic checks. Minor nit which can be fixed in the next release: there are a bunch of documentation files which could have a license header added (e.g. .md, .rst, ) thanks Hitesh On Mon, Aug 20, 2018 at 4:08 AM Bolke de Bruin wrote: > Sorry Willem that should be

Re: [VOTE] Release Airflow 1.10.0 (new vote based on rc4)

Sorry Willem that should be of course. Apologies. Sent from my iPhone > On 20 Aug 2018, at 13:07, Bolke de Bruin wrote: > > Hi William > > You seem to be missing a "4" at the end of the URL? Ah it seems that my > original email had a quirk. Would you mind using the below? > >

Re: [VOTE] Release Airflow 1.10.0 (new vote based on rc4)

Hi William You seem to be missing a "4" at the end of the URL? Ah it seems that my original email had a quirk. Would you mind using the below? https://github.com/apache/incubator-airflow/releases/tag/1.10.0rc4 Thanks! Bolke Sent from my iPhone > On 20 Aug 2018, at 13:03, Willem Jiang wrote:

Re: [VOTE] Release Airflow 1.10.0 (new vote based on rc4)

Hi, The Git tag cannot be accessed. I can only get the 404 error there. https://github.com/apache/incubator-airflow/releases/tag/1.10.0rc Willem Jiang Twitter: willemjiang Weibo: 姜宁willem On Sun, Aug 12, 2018 at 8:25 PM, Bolke de Bruin wrote: > Hello Incubator PMC’ers, > > The Apache

Re: [VOTE] Release Airflow 1.10.0 (new vote based on rc4)

+1 (binding) * Usual checks for disclaimer/sigs/hashes look good * License spot check looks good -Jakob On 19 August 2018 at 07:41, Bolke de Bruin wrote: > Hi, > > We are 7 days into the vote and still lacking 2. Please help in reviewing > it's much appreciated! > > Bolke > > Sent from my

Re: [VOTE] Release Airflow 1.10.0 (new vote based on rc4)

Hi, We are 7 days into the vote and still lacking 2. Please help in reviewing it's much appreciated! Bolke Sent from my iPhone > On 15 Aug 2018, at 20:22, Bolke de Bruin wrote: > > Friendly ping. We are missing 2 votes. > > Cheers > Bolke > > Sent from my iPhone > >> On 14 Aug 2018, at

Re: [VOTE] Release Airflow 1.10.0 (new vote based on rc4)

Friendly ping. We are missing 2 votes. Cheers Bolke Sent from my iPhone > On 14 Aug 2018, at 11:00, Justin Mclean wrote: > > Hi, > > +1 (binding) thanks for fixing up the GPL dependancy issue. > > I checked: > - incubating in name > - signatures and hashes good > - DISCLAIMER exists > - No

Re: [VOTE] Release Airflow 1.10.0 (new vote based on rc4)

Hi, +1 (binding) thanks for fixing up the GPL dependancy issue. I checked: - incubating in name - signatures and hashes good - DISCLAIMER exists - No unexpected binary files - all source files have headers Thanks, Justin - To

Re: [VOTE] Release Airflow 1.10.0 (new vote based on rc4)

Small nit fix. This is the actual vote thread, I accidentally provided a non-existing link. https://mail-archives.apache.org/mod_mbox/airflow-dev/201808.mbox/%3ccef592ae-527a-4e12-96f1-b1767f162...@gmail.com%3e