+1 binding
A few notes:
- Reviewed contents, licenses all look correct.
- hashes line up.
- I'd recommend that the commit you use to vote on is the one that includes
the tagging, so
https://github.com/apache/incubator-kylin/commit/6a9499b4d0fabb54211a8a536c2e18d3fe8b4a5d
should
probably be voted
HI,
+1 binding
I checked:
- artefact has incubating in name
- DISCLAIMER exists
- LICENSE and NOTICE correct
- No unexpected binaries in source
- All source file have Apache headers
- Can compile from source
Thanks,
Justin
-
- Signature files look good
- Hash files look good
- LICENSE file looks good
- NOTICE file looks good
- DISCLAIMER files exists
- Source compiled successfully
- NO 3rd party executables in source artifact
- Source files has correct Apache header
+1 (binding)
On Sat, Nov 7, 2015 at 4:46 PM,
+1 non-binding
md5 passed
no license issue
mvn test passed
On Tue, Nov 10, 2015 at 10:57 AM, Luke Han wrote:
> Forwarding my vote from dev@:
>
> +1 non-binding
>
>
> Best Regards!
> -
>
> Luke Han
>
> On Tue, Nov 10, 2015 at 6:00 AM, Henry Saputra
Forwarding my vote from dev@:
+1 non-binding
Best Regards!
-
Luke Han
On Tue, Nov 10, 2015 at 6:00 AM, Henry Saputra
wrote:
> - Signature files look good
> - Hash files look good
> - LICENSE file looks good
> - NOTICE file looks good
> -
Forwarding my vote from dev@:
+1 binding
Julian
-
To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org
For additional commands, e-mail: general-h...@incubator.apache.org
Thanks Luke for answering this for me; yes the commit (619499b) is
automatically made by the maven, and I picked the last commit made by human
as the base to vote; Just let me know if this is an issue and I can send an
updated version soon. Thanks!
2015-11-09 8:33 GMT+08:00 Luke Han
Hi John,
The commit (619499b) you mentioned is auto generated by maven release
tool during script execution which changed the version to remove SNAPSHOT
just followed latest commit: 708ea3 (by committer).
The main change of this release is to totally remove Google Font,
please refer to
It's a bit confusing, because I would have expected the vote to be based on
commit
https://github.com/apache/incubator-kylin/commit/6a9499b4d0fabb54211a8a536c2e18d3fe8b4a5d
If you follow the commit above, then only KYLIN-999 is included in this
release (over 1.1 release). Whereas if you follow