Re: [VOTE] Pulsar Release 2.0.0-rc1-incubating Candidate 3
Hi Pulsar Devs, Thanks Justin! I know that Pulsar Functions are new. $ jar tvf apache-pulsar-2.0.0-rc1-incubating/pulsar-functions/utils/src/test/resources/multifunction.jar 0 Wed Dec 13 01:00:28 PST 2017 META-INF/ 147 Wed Dec 13 01:00:28 PST 2017 META-INF/MANIFEST.MF 0 Wed Dec 13 00:58:36 PST 2017 org/ 0 Wed Dec 13 00:58:36 PST 2017 org/apache/ 0 Wed Dec 13 00:58:36 PST 2017 org/apache/pulsar/ 0 Wed Dec 13 00:58:36 PST 2017 org/apache/pulsar/functions/ 0 Wed Dec 13 00:58:36 PST 2017 org/apache/pulsar/functions/runtime/ 0 Wed Dec 13 00:58:56 PST 2017 org/apache/pulsar/functions/runtime/functioncache/ 683 Wed Dec 13 00:57:10 PST 2017 org/apache/pulsar/functions/runtime/functioncache/AddFunction.class AddFunction is nowhere in the source. This is something that must be corrected. Sorry, but I am going to change my votes to +0 until there is an explanation. One option would be to remove this test … Please keep the eye out for jars and tars in the source. Regards, Dave > On May 12, 2018, at 3:52 PM, Justin Mclean wrote: > > Hi, > > Sorry but it’s -1 binding due to compiled code in source release. > > Frankly I’m surprised to see so many +1s with this obvious issue. > > I checked: > - incubating in name > - signatures and hashes correct > - DISCLAIMER exists > - LICENSE and NOTICE good > - Unexpected jar in source release [1] > - All source files have headers > > Thanks, > Justin > > > 1. pulsar-functions/utils/src/test/resources/multifunction.jar > - > To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org > For additional commands, e-mail: general-h...@incubator.apache.org > signature.asc Description: Message signed with OpenPGP
Re: [VOTE] Pulsar Release 2.0.0-rc1-incubating Candidate 3
Hi, Sorry but it’s -1 binding due to compiled code in source release. Frankly I’m surprised to see so many +1s with this obvious issue. I checked: - incubating in name - signatures and hashes correct - DISCLAIMER exists - LICENSE and NOTICE good - Unexpected jar in source release [1] - All source files have headers Thanks, Justin 1. pulsar-functions/utils/src/test/resources/multifunction.jar - To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org For additional commands, e-mail: general-h...@incubator.apache.org
Re: [VOTE] Pulsar Release 2.0.0-rc1-incubating Candidate 3
+1 (binding) > On May 11, 2018, at 7:09 PM, Matteo Merli wrote: > > This is the third release candidate for Apache Pulsar, version > 2.0.0-rc1-incubating. > > Pulsar is a highly scalable, low latency messaging platform running on > commodity hardware. It provides simple pub-sub semantics over topics, > guaranteed at-least-once delivery of messages, automatic cursor management > for subscribers, and geo-replication. > > Link to the voting thread on pulsar dev list: > https://lists.apache.org/thread.html/79e78ddc1e1348b8a625e6dcc485cdbb145030fa6546546149d6b1a4@%3Cdev.pulsar.apache.org%3E > > It fixes the following issues: > https://github.com/apache/incubator-pulsar/milestone/12?closed=1 > > *** Please download, test and vote on this release. This vote will stay open > for at least 72 hours *** > > Note that we are voting upon the source (tag), binaries are provided for > convenience. > > Source and binary files: > https://dist.apache.org/repos/dist/dev/incubator/pulsar/pulsar-2.0.0-rc1-incubating-candidate-3/ > > SHA-1 checksums: > b1a392c5935448da195eb927520fe6deb20182fc > apache-pulsar-2.0.0-rc1-incubating-bin.tar.gz > 8c547a3e0afaee3446c770c076d5803e7e7da1c2 > apache-pulsar-2.0.0-rc1-incubating-src.tar.gz > > Maven staging repo: > https://repository.apache.org/content/repositories/orgapachepulsar-1013/ > > The tag to be voted upon: > v2.0.0-rc1-incubating-candidate-3 (9b33a8788f171f98528aeaa9040d16fc702404ef) > https://github.com/apache/incubator-pulsar/releases/tag/v2.0.0-rc1-incubating-candidate-3 > > Pulsar's KEYS file containing PGP keys we use to sign the release: > https://dist.apache.org/repos/dist/release/incubator/pulsar/KEYS > > Please download the the source package, and follow the README to build > and run the Pulsar standalone service. > > -- > Matteo Merli > > -- > Matteo Merli > - To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org For additional commands, e-mail: general-h...@incubator.apache.org
Re: [VOTE] Apache MXNet (incubating) 1.2.0 release RC2
Hi, > Thank you Justin for your inputs and explanation ! I really appreciate your > efforts to evaluate the release. I will extend the vote till Monday 12:00 > PM PDT (if its permitted) to see what other IPMC members have to say about > category b content in the release. Votes last for a minimum of 72 hours there's no real need to set a deadline. Thanks, Justin - To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org For additional commands, e-mail: general-h...@incubator.apache.org
Re: [VOTE] Apache MXNet (incubating) 1.2.0 release RC2
Thank you Justin for your inputs and explanation ! I really appreciate your efforts to evaluate the release. I will extend the vote till Monday 12:00 PM PDT (if its permitted) to see what other IPMC members have to say about category b content in the release. Anirudh On Sat, May 12, 2018 at 12:26 AM, Justin Mclean wrote: > Hi, > > > I think we should be good to add the header for Apache v2.0 license: > >> src/operator/contrib/ctc_include/detail/cpu_ctc.h > >> src/operator/contrib/ctc_include/detail/ctc_helper.h > >> src/operator/contrib/ctc_include/detail/gpu_ctc.h > >> src/operator/contrib/ctc_include/detail/gpu_ctc_kernels.h > >> src/operator/contrib/ctc_include/detail/hostdevice.h > > > > Please confirm. > > Sounds good to me. > > > For the docs directory, we did something similar to what other popular > > Apache projects like spark did: > > https://github.com/apache/spark/tree/master/docs. (adding docs > directory to > > rat-excludes) > > Just because a TLP does something doesn't mean it’s right, the Spark > NOTICE file for instance is a right mess. ASF policy is clear on what > should be done if you include docs in a release. [1] > > > At this point I want to ask you what your blocking concerns are. > > Is it only the CC-BY-2.5 license for DevGuide.md in googletest submodule > or > > is it also the missing headers for contrib and the broad rat excludes ? > > My -1 vote is not a blocker to the release as I said before if you get 3 > +1 votes and more +1 than -1 you can release if you want to. > > IMO (and others may have differing opinions) the missing headers can be > fixed in a later release. The main issue is inclusion of Category B content > in a non binary form in the release. > > Thanks, > Justin > - > To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org > For additional commands, e-mail: general-h...@incubator.apache.org > >
Re: [VOTE] Apache MXNet (incubating) 1.2.0 release RC2
Hi, > I think we should be good to add the header for Apache v2.0 license: >> src/operator/contrib/ctc_include/detail/cpu_ctc.h >> src/operator/contrib/ctc_include/detail/ctc_helper.h >> src/operator/contrib/ctc_include/detail/gpu_ctc.h >> src/operator/contrib/ctc_include/detail/gpu_ctc_kernels.h >> src/operator/contrib/ctc_include/detail/hostdevice.h > > Please confirm. Sounds good to me. > For the docs directory, we did something similar to what other popular > Apache projects like spark did: > https://github.com/apache/spark/tree/master/docs. (adding docs directory to > rat-excludes) Just because a TLP does something doesn't mean it’s right, the Spark NOTICE file for instance is a right mess. ASF policy is clear on what should be done if you include docs in a release. [1] > At this point I want to ask you what your blocking concerns are. > Is it only the CC-BY-2.5 license for DevGuide.md in googletest submodule or > is it also the missing headers for contrib and the broad rat excludes ? My -1 vote is not a blocker to the release as I said before if you get 3 +1 votes and more +1 than -1 you can release if you want to. IMO (and others may have differing opinions) the missing headers can be fixed in a later release. The main issue is inclusion of Category B content in a non binary form in the release. Thanks, Justin - To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org For additional commands, e-mail: general-h...@incubator.apache.org
Re: [VOTE] Apache MXNet (incubating) 1.2.0 release RC2
Hi Justin, Thank you! They were first added as part of this PR: https://github.com/apache/incubator-mxnet/pull/5834. As you can see there is a LICENSE in src/operator/contrib/ctc_include which is Apache v2.0 license. I am assuming that the intention was to keep the license of files in the directory or subdirectory the same. I think we should be good to add the header for Apache v2.0 license: > src/operator/contrib/ctc_include/detail/cpu_ctc.h > src/operator/contrib/ctc_include/detail/ctc_helper.h > src/operator/contrib/ctc_include/detail/gpu_ctc.h > src/operator/contrib/ctc_include/detail/gpu_ctc_kernels.h > src/operator/contrib/ctc_include/detail/hostdevice.h Please confirm. For the docs directory, we did something similar to what other popular Apache projects like spark did: https://github.com/apache/spark/tree/master/docs. (adding docs directory to rat-excludes) At this point I want to ask you what your blocking concerns are. Is it only the CC-BY-2.5 license for DevGuide.md in googletest submodule or is it also the missing headers for contrib and the broad rat excludes ? Anirudh On Fri, May 11, 2018 at 11:38 PM, Justin Mclean wrote: > Hi, > > > In contrib/, I found a few files which don't have a license or have a > > license but not the full text: > > src/operator/contrib/psroi_pooling-inl.h > > src/operator/contrib/ctc_include/detail/cpu_ctc.h > > src/operator/contrib/ctc_include/detail/ctc_helper.h > > src/operator/contrib/ctc_include/detail/gpu_ctc.h > > src/operator/contrib/ctc_include/detail/gpu_ctc_kernels.h > > src/operator/contrib/ctc_include/detail/hostdevice.h > > Well they do have a license it’s just unclear what it is as they have no > header. Do you know where those files came from and how they were licensed? > > > In docs/ directory, the files that don't have a license are the .md, > .html, > > .js , .css, .svg. > > I am assuming that these files don't need a license and thus we are good > to > > put them in rat excludes file. > > .js files are code and as such should have a header either [1] or [2]. The > html files should have a header also [4]. There’s only a few exception for > file not having headers [3] > > Thanks, > Justin > > 1. https://www.apache.org/legal/src-headers.html#headers > 2. https://www.apache.org/legal/src-headers.html#3party > 3. https://www.apache.org/legal/src-headers.html#faq-exceptions > 4. https://www.apache.org/legal/src-headers.html#faq-siteindocs > - > To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org > For additional commands, e-mail: general-h...@incubator.apache.org > >
