Get your point as well, thanks, Justin. :-)
Juan Pan (Trista)
Senior DBA & PPMC of Apache ShardingSphere(Incubating)
E-mail: panj...@apache.org
On 01/8/2020 11:34，Justin Mclean wrote：
Hi,
I noticed this too in my dev vote check too. I want to ask, considering
Got it. Thanks for the explanation. :)
Sheng Wu 吴晟
Twitter, wusheng1108
Justin Mclean 于2020年1月8日周三 上午11:35写道：
> Hi,
>
> > I noticed this too in my dev vote check too. I want to ask, considering
> the
> > source codes were tagged in 12/30/2019, the NOTICE should be right to
> keep
> > in 2019
Hi,
> I noticed this too in my dev vote check too. I want to ask, considering the
> source codes were tagged in 12/30/2019, the NOTICE should be right to keep
> in 2019 for this release.
The year should be the year of publication, but it doesn’t really matter, and
if it did it would be when we
Hi Justin
I noticed this too in my dev vote check too. I want to ask, considering the
source codes were tagged in 12/30/2019, the NOTICE should be right to keep
in 2019 for this release.
Am I right?
Sheng Wu 吴晟
Twitter, wusheng1108
zhangli...@apache.org 于2020年1月8日周三 上午11:21写道：
> > - NOTICE
> - NOTICE has wrong year
Thank you your remind. I will fix it on dev branch soon and ensure it
correct by next release.
--
Liang Zhang (John)
Apache ShardingSphere & Dubbo
Justin Mclean 于2020年1月8日周三 上午9:09写道：
> Hi,
>
> +1 (binding)
>
> I checked:
> - incubating in name
> -
Hi,
+1 (binding)
I checked:
- incubating in name
- signatures and hashes good
- DISCLAIMER exists
- LICENSE and NOTICE fine
- no unexpected binary files
- all source files have ASF headers
- can compile from source
Thanks,
Justin
Hi,
+1 (binding)
I checked:
- incubating in name
- signature and hash good
- DISCLAIMER exists
- LICENSE is OK
- NOTICE has wrong year
- No unexpended binary files
- all source file have ASF headers
- can compile from source
Thanks,
Justin
Hi,
The incubator report has been submitted, if you need to make any last minute
changes please make them here [1] rather than in the wiki.
Thanks,
Justin
1. https://whimsy.apache.org/board/agenda/2020-01-15/Incubator
-
To
