[CANCEL][VOTE] Release Apache Fury(incubating) v0.5.0-rc3
Hi, The release for Apache Fury(incubating) v0.5.0-rc3 is canceled. We didn't include the benchmark code in the source release, but the LICENSE file did contain the reference to benchmark code. This has been fixed in [1] 1. https://github.com/apache/incubator-fury/pull/1562 We will propose a new release candidate in theFury community later. Thanks everyone for helping review this release. Best regards, Chaokun Yang
Re: [VOTE] Release Apache Fury(incubating) v0.5.0-rc3
Hi tison, My previous reply is a little confusing. What the "we don't release furyjs in 0.5.0" means is that we don't upload release bundles to npm in this release. Best, Chaokun Yang On Thu, Apr 25, 2024 at 5:36 PM tison wrote: > Let me first summarize the result of the feedback on LICENSE issues: > > > - there are several references to a benchmark directory, but it is not > included in the release > > This is correct. We made [10] to address it. And We're preparing a new > release candidate. > > [10] https://github.com/apache/incubator-fury/pull/1562 > > > - there seems to be 3rd part code from OpenSumi here [1][2][3][4] > > This is false positive. OpenSumi's release bundle contains the code from > Fury. The origin comes from Fury. > > > - there seems to be code from Ray here [5][6] > > This is false positive. Shawn owns the code and they are "Licensed to the > Apache Software Foundation (ASF) under one or more contributor license > agreements." > > > - this file may have been copied from somewhere [7] > > This is false positive. The content of ArrayAsList is shared above. I > suppose most Java developers would argue that it's a trivial class. Also, > there is no evidence to show other origins possibility. > > To Shawn, > > > We can cooperate with OpenSumi after we make the first formal release of > furyjs under ASF later. > > Although this can be a good way to go, I notice that in this RC the tarball > packages furyjs' code: > > 0.5.0-rc3/apache-fury-incubating-0.5.0-src/javascript > > I'd like to know the details about "we don't release furyjs in 0.5.0" > because you seem to release furyjs' sources in 0.5.0. > > Best, > tison. > > > Shawn Yang 于2024年4月25日周四 17:16写道： > > > Hi tison, > > > > Thanks for the suggestion, we don't release furyjs in 0.5.0. > > > > We can cooperate with OpenSumi after we make the first formal release of > > furyjs > > under ASF later. > > > > Best, > > Chaokun > > > > On Thu, Apr 25, 2024 at 5:11 PM tison wrote: > > > > > Hi Shawn, > > > > > > Thanks for sharing the finding. I can see the dependency from OpenSumi > to > > > Fury as in [1] now. > > > > > > [1] https://github.com/search?q=repo:opensumi/core%20fury=code > > > > > > After we make the first formal release, we can cooperate with OpenSumi > to > > > upgrade to an incubating release and thus update the mention in their > > docs > > > to Apache Fury also, like [2][3]. > > > > > > [2] https://github.com/GreptimeTeam/greptimedb/pull/2653 > > > [3] https://github.com/GreptimeTeam/greptimedb/pull/3168 > > > > > > Best, > > > tison. > > > > > > > > > Shawn Yang 于2024年4月25日周四 17:04写道： > > > > > > > Hi Justin, > > > > > > > > Thanks for sharing this tool. I checked the code in Fury with this > > tool. > > > > > > > > Here is the result: > > > > 1) [5][6] are osscan results. > > > > 2) Those files has duplication with package/lib/worker-host.js in > > > > opensumi[7] > > > > > > > > Opensumi relies on furyjs, so it packaged the code in apache fury > into > > > its > > > > release bundle. > > > > As you can see from the opensumi code repository[8]. There is no such > > > > worker-host.js file, > > > > It's a file generated at opensum build process, which packaged apache > > > > furyjs code into their bundle. > > > > > > > > So I think this is not an issue in fury. > > > > > > > > Do you have further issues? If not, I'll close this vote and start a > > new > > > > release candidate later. > > > > > > > > 1. /javascript/packages/fury/lib/gen/datetime.ts > > > > 2. /javascript/packages/fury/lib/gen/index.ts > > > > 3. /javascript/packages/fury/lib/fury.ts > > > > 4. /javascript/packages/fury/lib/classResolver.ts > > > > 5 > > > > > > > > > > > > > > https://github.com/apache/incubator-fury/assets/12445254/cfa0fb06-bf23-468d-bf76-f9b106467611 > > > > 6. > > > > > > > > > > > > > > https://github.com/apache/incubator-fury/assets/12445254/7698a87d-ffd9-4400-9a79-a2f27f191c1d > > > > 7. https://www.npmjs.com/package/%40opensumi/ide-extension > > > > 8. https://github.com/opensumi/core/ > > > > > > > > -- > > > > Best regards, > > > > Chaokun Yang > > > > > > > > On Thu, Apr 25, 2024 at 1:52 PM tison wrote: > > > > > > > > > Hi Justin, > > > > > > > > > > Thank you, and that's not in a hurry. I'd just like to make the > > status > > > > > clear and ensure we can make progress instead of subjective > arguing. > > > > > > > > > > Now I know you use ScanOSS and I'd suggest other members in Fury > try > > to > > > > > check the project with this tool. I'll try it out if I find some > > time, > > > > and > > > > > I'd appreciate it if you could share how you use this tool to do > > > > compliance > > > > > checks, it would help all the people in the Incubator :D > > > > > > > > > > ::OT:: IIRC ScanOSS CEO or CTO gave a talk at the Dev.Together Conf > > > weeks > > > > > before, now I found a real use case XD. > > > > > > > > > > Best, > > > > > tison. > > > > > > > > > > > > > > > Justin Mclean 于2024年4月25日周四 13:40写道： > >
Re: [VOTE] Release Apache Fury(incubating) v0.5.0-rc3
Let me first summarize the result of the feedback on LICENSE issues: > - there are several references to a benchmark directory, but it is not included in the release This is correct. We made [10] to address it. And We're preparing a new release candidate. [10] https://github.com/apache/incubator-fury/pull/1562 > - there seems to be 3rd part code from OpenSumi here [1][2][3][4] This is false positive. OpenSumi's release bundle contains the code from Fury. The origin comes from Fury. > - there seems to be code from Ray here [5][6] This is false positive. Shawn owns the code and they are "Licensed to the Apache Software Foundation (ASF) under one or more contributor license agreements." > - this file may have been copied from somewhere [7] This is false positive. The content of ArrayAsList is shared above. I suppose most Java developers would argue that it's a trivial class. Also, there is no evidence to show other origins possibility. To Shawn, > We can cooperate with OpenSumi after we make the first formal release of furyjs under ASF later. Although this can be a good way to go, I notice that in this RC the tarball packages furyjs' code: 0.5.0-rc3/apache-fury-incubating-0.5.0-src/javascript I'd like to know the details about "we don't release furyjs in 0.5.0" because you seem to release furyjs' sources in 0.5.0. Best, tison. Shawn Yang 于2024年4月25日周四 17:16写道： > Hi tison, > > Thanks for the suggestion, we don't release furyjs in 0.5.0. > > We can cooperate with OpenSumi after we make the first formal release of > furyjs > under ASF later. > > Best, > Chaokun > > On Thu, Apr 25, 2024 at 5:11 PM tison wrote: > > > Hi Shawn, > > > > Thanks for sharing the finding. I can see the dependency from OpenSumi to > > Fury as in [1] now. > > > > [1] https://github.com/search?q=repo:opensumi/core%20fury=code > > > > After we make the first formal release, we can cooperate with OpenSumi to > > upgrade to an incubating release and thus update the mention in their > docs > > to Apache Fury also, like [2][3]. > > > > [2] https://github.com/GreptimeTeam/greptimedb/pull/2653 > > [3] https://github.com/GreptimeTeam/greptimedb/pull/3168 > > > > Best, > > tison. > > > > > > Shawn Yang 于2024年4月25日周四 17:04写道： > > > > > Hi Justin, > > > > > > Thanks for sharing this tool. I checked the code in Fury with this > tool. > > > > > > Here is the result: > > > 1) [5][6] are osscan results. > > > 2) Those files has duplication with package/lib/worker-host.js in > > > opensumi[7] > > > > > > Opensumi relies on furyjs, so it packaged the code in apache fury into > > its > > > release bundle. > > > As you can see from the opensumi code repository[8]. There is no such > > > worker-host.js file, > > > It's a file generated at opensum build process, which packaged apache > > > furyjs code into their bundle. > > > > > > So I think this is not an issue in fury. > > > > > > Do you have further issues? If not, I'll close this vote and start a > new > > > release candidate later. > > > > > > 1. /javascript/packages/fury/lib/gen/datetime.ts > > > 2. /javascript/packages/fury/lib/gen/index.ts > > > 3. /javascript/packages/fury/lib/fury.ts > > > 4. /javascript/packages/fury/lib/classResolver.ts > > > 5 > > > > > > > > > https://github.com/apache/incubator-fury/assets/12445254/cfa0fb06-bf23-468d-bf76-f9b106467611 > > > 6. > > > > > > > > > https://github.com/apache/incubator-fury/assets/12445254/7698a87d-ffd9-4400-9a79-a2f27f191c1d > > > 7. https://www.npmjs.com/package/%40opensumi/ide-extension > > > 8. https://github.com/opensumi/core/ > > > > > > -- > > > Best regards, > > > Chaokun Yang > > > > > > On Thu, Apr 25, 2024 at 1:52 PM tison wrote: > > > > > > > Hi Justin, > > > > > > > > Thank you, and that's not in a hurry. I'd just like to make the > status > > > > clear and ensure we can make progress instead of subjective arguing. > > > > > > > > Now I know you use ScanOSS and I'd suggest other members in Fury try > to > > > > check the project with this tool. I'll try it out if I find some > time, > > > and > > > > I'd appreciate it if you could share how you use this tool to do > > > compliance > > > > checks, it would help all the people in the Incubator :D > > > > > > > > ::OT:: IIRC ScanOSS CEO or CTO gave a talk at the Dev.Together Conf > > weeks > > > > before, now I found a real use case XD. > > > > > > > > Best, > > > > tison. > > > > > > > > > > > > Justin Mclean 于2024年4月25日周四 13:40写道： > > > > > > > > > HI, > > > > > > > > > > I’m happy to share it, but as I said, I'm travelling right now and > > > don't > > > > > have access. I used ScanOSS workbench, but there are other checkers > > out > > > > > there. And yes, tools like this can sometimes give false positives, > > and > > > > it > > > > > can sometimes be unclear where things were originally copied or, in > > > fact, > > > > > may have been copied themselves. > > > > > > > > > > Kind Regards, > > > > > Justin > > > > > >
Re: [VOTE] Release Apache Fury(incubating) v0.5.0-rc3
> close this vote and start a new release candidate later. There is no blocker to cancel this vote now. You can test the new release packaging logics correctly exclude benchmark license info and we're ready to make the next RC. To cancel a vote. You can send a reply to this thread with a replaced title: [CANCEL][VOTE] Release Apache Fury(incubating) v0.5.0-rc3 This release has been canceled. Due to ... Best, tison. tison 于2024年4月25日周四 17:10写道： > Hi Shawn, > > Thanks for sharing the finding. I can see the dependency from OpenSumi to > Fury as in [1] now. > > [1] https://github.com/search?q=repo:opensumi/core%20fury=code > > After we make the first formal release, we can cooperate with OpenSumi to > upgrade to an incubating release and thus update the mention in their docs > to Apache Fury also, like [2][3]. > > [2] https://github.com/GreptimeTeam/greptimedb/pull/2653 > [3] https://github.com/GreptimeTeam/greptimedb/pull/3168 > > Best, > tison. > > > Shawn Yang 于2024年4月25日周四 17:04写道： > >> Hi Justin, >> >> Thanks for sharing this tool. I checked the code in Fury with this tool. >> >> Here is the result: >> 1) [5][6] are osscan results. >> 2) Those files has duplication with package/lib/worker-host.js in >> opensumi[7] >> >> Opensumi relies on furyjs, so it packaged the code in apache fury into its >> release bundle. >> As you can see from the opensumi code repository[8]. There is no such >> worker-host.js file, >> It's a file generated at opensum build process, which packaged apache >> furyjs code into their bundle. >> >> So I think this is not an issue in fury. >> >> Do you have further issues? If not, I'll close this vote and start a new >> release candidate later. >> >> 1. /javascript/packages/fury/lib/gen/datetime.ts >> 2. /javascript/packages/fury/lib/gen/index.ts >> 3. /javascript/packages/fury/lib/fury.ts >> 4. /javascript/packages/fury/lib/classResolver.ts >> 5 >> >> https://github.com/apache/incubator-fury/assets/12445254/cfa0fb06-bf23-468d-bf76-f9b106467611 >> 6. >> >> https://github.com/apache/incubator-fury/assets/12445254/7698a87d-ffd9-4400-9a79-a2f27f191c1d >> 7. https://www.npmjs.com/package/%40opensumi/ide-extension >> 8. https://github.com/opensumi/core/ >> >> -- >> Best regards, >> Chaokun Yang >> >> On Thu, Apr 25, 2024 at 1:52 PM tison wrote: >> >> > Hi Justin, >> > >> > Thank you, and that's not in a hurry. I'd just like to make the status >> > clear and ensure we can make progress instead of subjective arguing. >> > >> > Now I know you use ScanOSS and I'd suggest other members in Fury try to >> > check the project with this tool. I'll try it out if I find some time, >> and >> > I'd appreciate it if you could share how you use this tool to do >> compliance >> > checks, it would help all the people in the Incubator :D >> > >> > ::OT:: IIRC ScanOSS CEO or CTO gave a talk at the Dev.Together Conf >> weeks >> > before, now I found a real use case XD. >> > >> > Best, >> > tison. >> > >> > >> > Justin Mclean 于2024年4月25日周四 13:40写道： >> > >> > > HI, >> > > >> > > I’m happy to share it, but as I said, I'm travelling right now and >> don't >> > > have access. I used ScanOSS workbench, but there are other checkers >> out >> > > there. And yes, tools like this can sometimes give false positives, >> and >> > it >> > > can sometimes be unclear where things were originally copied or, in >> fact, >> > > may have been copied themselves. >> > > >> > > Kind Regards, >> > > Justin >> > > - >> > > To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org >> > > For additional commands, e-mail: general-h...@incubator.apache.org >> > > >> > > >> > >> >
Re: [VOTE] Release Apache Fury(incubating) v0.5.0-rc3
Hi tison, Thanks for the suggestion, we don't release furyjs in 0.5.0. We can cooperate with OpenSumi after we make the first formal release of furyjs under ASF later. Best, Chaokun On Thu, Apr 25, 2024 at 5:11 PM tison wrote: > Hi Shawn, > > Thanks for sharing the finding. I can see the dependency from OpenSumi to > Fury as in [1] now. > > [1] https://github.com/search?q=repo:opensumi/core%20fury=code > > After we make the first formal release, we can cooperate with OpenSumi to > upgrade to an incubating release and thus update the mention in their docs > to Apache Fury also, like [2][3]. > > [2] https://github.com/GreptimeTeam/greptimedb/pull/2653 > [3] https://github.com/GreptimeTeam/greptimedb/pull/3168 > > Best, > tison. > > > Shawn Yang 于2024年4月25日周四 17:04写道： > > > Hi Justin, > > > > Thanks for sharing this tool. I checked the code in Fury with this tool. > > > > Here is the result: > > 1) [5][6] are osscan results. > > 2) Those files has duplication with package/lib/worker-host.js in > > opensumi[7] > > > > Opensumi relies on furyjs, so it packaged the code in apache fury into > its > > release bundle. > > As you can see from the opensumi code repository[8]. There is no such > > worker-host.js file, > > It's a file generated at opensum build process, which packaged apache > > furyjs code into their bundle. > > > > So I think this is not an issue in fury. > > > > Do you have further issues? If not, I'll close this vote and start a new > > release candidate later. > > > > 1. /javascript/packages/fury/lib/gen/datetime.ts > > 2. /javascript/packages/fury/lib/gen/index.ts > > 3. /javascript/packages/fury/lib/fury.ts > > 4. /javascript/packages/fury/lib/classResolver.ts > > 5 > > > > > https://github.com/apache/incubator-fury/assets/12445254/cfa0fb06-bf23-468d-bf76-f9b106467611 > > 6. > > > > > https://github.com/apache/incubator-fury/assets/12445254/7698a87d-ffd9-4400-9a79-a2f27f191c1d > > 7. https://www.npmjs.com/package/%40opensumi/ide-extension > > 8. https://github.com/opensumi/core/ > > > > -- > > Best regards, > > Chaokun Yang > > > > On Thu, Apr 25, 2024 at 1:52 PM tison wrote: > > > > > Hi Justin, > > > > > > Thank you, and that's not in a hurry. I'd just like to make the status > > > clear and ensure we can make progress instead of subjective arguing. > > > > > > Now I know you use ScanOSS and I'd suggest other members in Fury try to > > > check the project with this tool. I'll try it out if I find some time, > > and > > > I'd appreciate it if you could share how you use this tool to do > > compliance > > > checks, it would help all the people in the Incubator :D > > > > > > ::OT:: IIRC ScanOSS CEO or CTO gave a talk at the Dev.Together Conf > weeks > > > before, now I found a real use case XD. > > > > > > Best, > > > tison. > > > > > > > > > Justin Mclean 于2024年4月25日周四 13:40写道： > > > > > > > HI, > > > > > > > > I’m happy to share it, but as I said, I'm travelling right now and > > don't > > > > have access. I used ScanOSS workbench, but there are other checkers > out > > > > there. And yes, tools like this can sometimes give false positives, > and > > > it > > > > can sometimes be unclear where things were originally copied or, in > > fact, > > > > may have been copied themselves. > > > > > > > > Kind Regards, > > > > Justin > > > > - > > > > To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org > > > > For additional commands, e-mail: general-h...@incubator.apache.org > > > > > > > > > > > > > >
Re: [VOTE] Release Apache Fury(incubating) v0.5.0-rc3
Hi Shawn, Thanks for sharing the finding. I can see the dependency from OpenSumi to Fury as in [1] now. [1] https://github.com/search?q=repo:opensumi/core%20fury=code After we make the first formal release, we can cooperate with OpenSumi to upgrade to an incubating release and thus update the mention in their docs to Apache Fury also, like [2][3]. [2] https://github.com/GreptimeTeam/greptimedb/pull/2653 [3] https://github.com/GreptimeTeam/greptimedb/pull/3168 Best, tison. Shawn Yang 于2024年4月25日周四 17:04写道： > Hi Justin, > > Thanks for sharing this tool. I checked the code in Fury with this tool. > > Here is the result: > 1) [5][6] are osscan results. > 2) Those files has duplication with package/lib/worker-host.js in > opensumi[7] > > Opensumi relies on furyjs, so it packaged the code in apache fury into its > release bundle. > As you can see from the opensumi code repository[8]. There is no such > worker-host.js file, > It's a file generated at opensum build process, which packaged apache > furyjs code into their bundle. > > So I think this is not an issue in fury. > > Do you have further issues? If not, I'll close this vote and start a new > release candidate later. > > 1. /javascript/packages/fury/lib/gen/datetime.ts > 2. /javascript/packages/fury/lib/gen/index.ts > 3. /javascript/packages/fury/lib/fury.ts > 4. /javascript/packages/fury/lib/classResolver.ts > 5 > > https://github.com/apache/incubator-fury/assets/12445254/cfa0fb06-bf23-468d-bf76-f9b106467611 > 6. > > https://github.com/apache/incubator-fury/assets/12445254/7698a87d-ffd9-4400-9a79-a2f27f191c1d > 7. https://www.npmjs.com/package/%40opensumi/ide-extension > 8. https://github.com/opensumi/core/ > > -- > Best regards, > Chaokun Yang > > On Thu, Apr 25, 2024 at 1:52 PM tison wrote: > > > Hi Justin, > > > > Thank you, and that's not in a hurry. I'd just like to make the status > > clear and ensure we can make progress instead of subjective arguing. > > > > Now I know you use ScanOSS and I'd suggest other members in Fury try to > > check the project with this tool. I'll try it out if I find some time, > and > > I'd appreciate it if you could share how you use this tool to do > compliance > > checks, it would help all the people in the Incubator :D > > > > ::OT:: IIRC ScanOSS CEO or CTO gave a talk at the Dev.Together Conf weeks > > before, now I found a real use case XD. > > > > Best, > > tison. > > > > > > Justin Mclean 于2024年4月25日周四 13:40写道： > > > > > HI, > > > > > > I’m happy to share it, but as I said, I'm travelling right now and > don't > > > have access. I used ScanOSS workbench, but there are other checkers out > > > there. And yes, tools like this can sometimes give false positives, and > > it > > > can sometimes be unclear where things were originally copied or, in > fact, > > > may have been copied themselves. > > > > > > Kind Regards, > > > Justin > > > - > > > To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org > > > For additional commands, e-mail: general-h...@incubator.apache.org > > > > > > > > >
Re: [VOTE] Release Apache Fury(incubating) v0.5.0-rc3
Hi Justin, Thanks for sharing this tool. I checked the code in Fury with this tool. Here is the result: 1) [5][6] are osscan results. 2) Those files has duplication with package/lib/worker-host.js in opensumi[7] Opensumi relies on furyjs, so it packaged the code in apache fury into its release bundle. As you can see from the opensumi code repository[8]. There is no such worker-host.js file, It's a file generated at opensum build process, which packaged apache furyjs code into their bundle. So I think this is not an issue in fury. Do you have further issues? If not, I'll close this vote and start a new release candidate later. 1. /javascript/packages/fury/lib/gen/datetime.ts 2. /javascript/packages/fury/lib/gen/index.ts 3. /javascript/packages/fury/lib/fury.ts 4. /javascript/packages/fury/lib/classResolver.ts 5 https://github.com/apache/incubator-fury/assets/12445254/cfa0fb06-bf23-468d-bf76-f9b106467611 6. https://github.com/apache/incubator-fury/assets/12445254/7698a87d-ffd9-4400-9a79-a2f27f191c1d 7. https://www.npmjs.com/package/%40opensumi/ide-extension 8. https://github.com/opensumi/core/ -- Best regards, Chaokun Yang On Thu, Apr 25, 2024 at 1:52 PM tison wrote: > Hi Justin, > > Thank you, and that's not in a hurry. I'd just like to make the status > clear and ensure we can make progress instead of subjective arguing. > > Now I know you use ScanOSS and I'd suggest other members in Fury try to > check the project with this tool. I'll try it out if I find some time, and > I'd appreciate it if you could share how you use this tool to do compliance > checks, it would help all the people in the Incubator :D > > ::OT:: IIRC ScanOSS CEO or CTO gave a talk at the Dev.Together Conf weeks > before, now I found a real use case XD. > > Best, > tison. > > > Justin Mclean 于2024年4月25日周四 13:40写道： > > > HI, > > > > I’m happy to share it, but as I said, I'm travelling right now and don't > > have access. I used ScanOSS workbench, but there are other checkers out > > there. And yes, tools like this can sometimes give false positives, and > it > > can sometimes be unclear where things were originally copied or, in fact, > > may have been copied themselves. > > > > Kind Regards, > > Justin > > - > > To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org > > For additional commands, e-mail: general-h...@incubator.apache.org > > > > >
Re: [VOTE] Release Apache Fury(incubating) v0.5.0-rc3
Hi Justin, Thank you, and that's not in a hurry. I'd just like to make the status clear and ensure we can make progress instead of subjective arguing. Now I know you use ScanOSS and I'd suggest other members in Fury try to check the project with this tool. I'll try it out if I find some time, and I'd appreciate it if you could share how you use this tool to do compliance checks, it would help all the people in the Incubator :D ::OT:: IIRC ScanOSS CEO or CTO gave a talk at the Dev.Together Conf weeks before, now I found a real use case XD. Best, tison. Justin Mclean 于2024年4月25日周四 13:40写道： > HI, > > I’m happy to share it, but as I said, I'm travelling right now and don't > have access. I used ScanOSS workbench, but there are other checkers out > there. And yes, tools like this can sometimes give false positives, and it > can sometimes be unclear where things were originally copied or, in fact, > may have been copied themselves. > > Kind Regards, > Justin > - > To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org > For additional commands, e-mail: general-h...@incubator.apache.org > >
Re: [VOTE] Release Apache Fury(incubating) v0.5.0-rc3
HI, I’m happy to share it, but as I said, I'm travelling right now and don't have access. I used ScanOSS workbench, but there are other checkers out there. And yes, tools like this can sometimes give false positives, and it can sometimes be unclear where things were originally copied or, in fact, may have been copied themselves. Kind Regards, Justin - To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org For additional commands, e-mail: general-h...@incubator.apache.org
Re: [VOTE] Release Apache Fury(incubating) v0.5.0-rc3
> Of course we'd like to add the license info
As you can see, for files we're clear that is derived, we keep their
license headers, and add a link to the origin.
[1]
https://github.com/apache/incubator-fury/blob/dd9f9128d24b418f6a420880c7780ce83d6448a2/licenserc.toml#L28-L54
So what I'm confused about is that you don't want to share how you find the
files questioned are copied and what the origins are.
Of course, if the authors copied it, we would have the answer. But now,
that's not the case. So I ask you to share the evidence you have to support
that [1][2][3][4] is copied. You reply, "It certainly looks like some code
was copied; one file, for instance, is about 70% the same," but you still
wouldn't like to share the reason or name the file and its "origin".
It can be quite easy to proceed that:
[1] is the same as link-A
[2] is the same as link-B
[3] is the same as link-C
[4] is the same as link-D
and we check the content and re-confirm with the author.
Best,
tison.
tison 于2024年4月25日周四 10:50写道：
> > That should be fine, but having an ASF header on the files may be a
> little misleading? What do you think?
>
> Could you elaborate a bit on "misleading"? Shawn owned the code and he
> contributed the code under Apache License 2.0, and also he has filed an
> iCLA. So it follows the headers write:
>
> Licensed to the Apache Software Foundation (ASF) under one
> or more contributor license agreements. See the NOTICE file
> distributed with this work for additional information
> regarding copyright ownership. The ASF licenses this file
> to you under the Apache License, Version 2.0 (the
> "License"); you may not use this file except in compliance
> with the License. You may obtain a copy of the License at
>
>http://www.apache.org/licenses/LICENSE-2.0
>
> Unless required by applicable law or agreed to in writing,
> software distributed under the License is distributed on an
> "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
> KIND, either express or implied. See the License for the
> specific language governing permissions and limitations
> under the License.
>
> > Licensed to the Apache Software Foundation (ASF) under one or more
> contributor license agreements.
>
> Best,
> tison.
>
>
> tison 于2024年4月25日周四 10:47写道：
>
>> > It certainly looks like some code was copied; one file, for instance,
>> is about 70% the same. This is not an issue as it is under a compatible MIT
>> license, but that needs to be mentioned in the LICENSE file.
>>
>> Could you please tell the file name and the file on OpenSumi that is
>> overlapped? Of course we'd like to add the license info if it's the case,
>> and actually I'd generally add a link to the original file. Now we cannot
>> find the origin and the author states that they write the code by
>> themselves.
>>
>> You state that there is 70% the same, as what? It's quite confusing to
>> give such a conclusion without certain reference.
>>
>> > A possible explanation for what has happened here is that the developer
>> used AI to generate the code, and it’s duplicated that code from somewhere.
>> Do you know if that is the case?
>>
>> If you have a tool to check such similarity, could you share it or share
>> the report. When you state a file is copied from elsewhere, there must be
>> an origin. AFAIK we don't use AI to generate this code, if you take a look
>> at the code (please look), the content is:
>>
>> public static class ArrayAsList extends AbstractList implements
>> RandomAccess, java.io.Serializable {
>> private static final Object[] EMPTY = new Object[0];
>> private Object[] array;
>> private int size;
>> public ArrayAsList(int size) { array = new Object[size]; }
>> @Override public int size() { return size; }
>> @Override public boolean add(Object e) { array[size++] = e; return
>> true; }
>> @Override public Object get(int index) { return array[index]; }
>> public void clearArray() { size = 0; array = EMPTY; }
>> public void setArray(Object[] a) { array = a; size = a.length; }
>> public Object[] getArray() { return array; }
>> @Override public Object set(int index, Object element) { throw new
>> UnsupportedOperationException(); }
>> @Override public int indexOf(Object o) { throw new
>> UnsupportedOperationException(); }
>> @Override public boolean contains(Object o) { throw new
>> UnsupportedOperationException(); }
>> @Override public Object[] toArray() { return array; }
>> @Override public Iterator iterator() { return new
>> Iterator() {
>> private int index;
>> @Override public boolean hasNext() { return index < array.length;
>> }
>> @Override public Object next() { return array[index++]; }
>> };
>> }
>> }
>>
>> Getters, trivial add / clear / set, three unsupported methods. The fields
>> and non-inherited methods are also written originally.
>>
>> Best,
>> tison.
>>
>>
>> Justin Mclean 于2024年4月25日周四 10:36写道：
>>
>>> Hi,
>>>
>>> I’m
Re: [VOTE] Release Apache Fury(incubating) v0.5.0-rc3
On Thu, Apr 25, 2024 at 10:36 AM Justin Mclean wrote: > Hi, > > I’m currently travelling and may be slow in responding to emails. > > > The MemoryBufferWritableChannel[5] and MockWritableChannel[6] was > written > > by me before we open-sourced Fury and > > I submitted it to Ray in PR[8] ,which was planned to optimize zero-copy > > serialization in Ray. I think it's OK to include it > > here since both are written by me. > > That should be fine, but having an ASF header on the files may be a little > misleading? What do you think? > As the original author of the code, you typically retain the original copyright to the code. You've simply granted Ray the right to use, distribute, and so on, so adding an Apache header is generally not a problem. > > > For files [1][2][3][4], could you give more details how those files > include > > code from OpenSumi. The OpenSumi core developer > > bytemain[9] does commit some code to Fury, see his commits[10]. But I > > talked to him offline, he said he didn't copy code from > > OpenSumi. > > It certainly looks like some code was copied; one file, for instance, is > about 70% the same. This is not an issue as it is under a compatible MIT > license, but that needs to be mentioned in the LICENSE file. > > > For Fury ArrayAsList, could you give more details how this class is > copied > > from somewhere? It's just a simple wrapper for java > > object arrays. > > A possible explanation for what has happened here is that the developer > used AI to generate the code, and it’s duplicated that code from somewhere. > Do you know if that is the case? > > Kind Regards, > Justin > > > - > To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org > For additional commands, e-mail: general-h...@incubator.apache.org > > -- Best wishes！ CalvinKirs
Re: [VOTE] Release Apache Fury(incubating) v0.5.0-rc3
> That should be fine, but having an ASF header on the files may be a
little misleading? What do you think?
Could you elaborate a bit on "misleading"? Shawn owned the code and he
contributed the code under Apache License 2.0, and also he has filed an
iCLA. So it follows the headers write:
Licensed to the Apache Software Foundation (ASF) under one
or more contributor license agreements. See the NOTICE file
distributed with this work for additional information
regarding copyright ownership. The ASF licenses this file
to you under the Apache License, Version 2.0 (the
"License"); you may not use this file except in compliance
with the License. You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing,
software distributed under the License is distributed on an
"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
KIND, either express or implied. See the License for the
specific language governing permissions and limitations
under the License.
> Licensed to the Apache Software Foundation (ASF) under one or more
contributor license agreements.
Best,
tison.
tison 于2024年4月25日周四 10:47写道：
> > It certainly looks like some code was copied; one file, for instance,
> is about 70% the same. This is not an issue as it is under a compatible MIT
> license, but that needs to be mentioned in the LICENSE file.
>
> Could you please tell the file name and the file on OpenSumi that is
> overlapped? Of course we'd like to add the license info if it's the case,
> and actually I'd generally add a link to the original file. Now we cannot
> find the origin and the author states that they write the code by
> themselves.
>
> You state that there is 70% the same, as what? It's quite confusing to
> give such a conclusion without certain reference.
>
> > A possible explanation for what has happened here is that the developer
> used AI to generate the code, and it’s duplicated that code from somewhere.
> Do you know if that is the case?
>
> If you have a tool to check such similarity, could you share it or share
> the report. When you state a file is copied from elsewhere, there must be
> an origin. AFAIK we don't use AI to generate this code, if you take a look
> at the code (please look), the content is:
>
> public static class ArrayAsList extends AbstractList implements
> RandomAccess, java.io.Serializable {
> private static final Object[] EMPTY = new Object[0];
> private Object[] array;
> private int size;
> public ArrayAsList(int size) { array = new Object[size]; }
> @Override public int size() { return size; }
> @Override public boolean add(Object e) { array[size++] = e; return
> true; }
> @Override public Object get(int index) { return array[index]; }
> public void clearArray() { size = 0; array = EMPTY; }
> public void setArray(Object[] a) { array = a; size = a.length; }
> public Object[] getArray() { return array; }
> @Override public Object set(int index, Object element) { throw new
> UnsupportedOperationException(); }
> @Override public int indexOf(Object o) { throw new
> UnsupportedOperationException(); }
> @Override public boolean contains(Object o) { throw new
> UnsupportedOperationException(); }
> @Override public Object[] toArray() { return array; }
> @Override public Iterator iterator() { return new
> Iterator() {
> private int index;
> @Override public boolean hasNext() { return index < array.length; }
> @Override public Object next() { return array[index++]; }
> };
> }
> }
>
> Getters, trivial add / clear / set, three unsupported methods. The fields
> and non-inherited methods are also written originally.
>
> Best,
> tison.
>
>
> Justin Mclean 于2024年4月25日周四 10:36写道：
>
>> Hi,
>>
>> I’m currently travelling and may be slow in responding to emails.
>>
>> > The MemoryBufferWritableChannel[5] and MockWritableChannel[6] was
>> written
>> > by me before we open-sourced Fury and
>> > I submitted it to Ray in PR[8] ,which was planned to optimize zero-copy
>> > serialization in Ray. I think it's OK to include it
>> > here since both are written by me.
>>
>> That should be fine, but having an ASF header on the files may be a
>> little misleading? What do you think?
>>
>> > For files [1][2][3][4], could you give more details how those files
>> include
>> > code from OpenSumi. The OpenSumi core developer
>> > bytemain[9] does commit some code to Fury, see his commits[10]. But I
>> > talked to him offline, he said he didn't copy code from
>> > OpenSumi.
>>
>> It certainly looks like some code was copied; one file, for instance, is
>> about 70% the same. This is not an issue as it is under a compatible MIT
>> license, but that needs to be mentioned in the LICENSE file.
>>
>> > For Fury ArrayAsList, could you give more details how this class is
>> copied
>> > from somewhere? It's just a simple wrapper for java
>> > object
Re: [VOTE] Release Apache Fury(incubating) v0.5.0-rc3
> It certainly looks like some code was copied; one file, for instance, is
about 70% the same. This is not an issue as it is under a compatible MIT
license, but that needs to be mentioned in the LICENSE file.
Could you please tell the file name and the file on OpenSumi that is
overlapped? Of course we'd like to add the license info if it's the case,
and actually I'd generally add a link to the original file. Now we cannot
find the origin and the author states that they write the code by
themselves.
You state that there is 70% the same, as what? It's quite confusing to give
such a conclusion without certain reference.
> A possible explanation for what has happened here is that the developer
used AI to generate the code, and it’s duplicated that code from somewhere.
Do you know if that is the case?
If you have a tool to check such similarity, could you share it or share
the report. When you state a file is copied from elsewhere, there must be
an origin. AFAIK we don't use AI to generate this code, if you take a look
at the code (please look), the content is:
public static class ArrayAsList extends AbstractList implements
RandomAccess, java.io.Serializable {
private static final Object[] EMPTY = new Object[0];
private Object[] array;
private int size;
public ArrayAsList(int size) { array = new Object[size]; }
@Override public int size() { return size; }
@Override public boolean add(Object e) { array[size++] = e; return
true; }
@Override public Object get(int index) { return array[index]; }
public void clearArray() { size = 0; array = EMPTY; }
public void setArray(Object[] a) { array = a; size = a.length; }
public Object[] getArray() { return array; }
@Override public Object set(int index, Object element) { throw new
UnsupportedOperationException(); }
@Override public int indexOf(Object o) { throw new
UnsupportedOperationException(); }
@Override public boolean contains(Object o) { throw new
UnsupportedOperationException(); }
@Override public Object[] toArray() { return array; }
@Override public Iterator iterator() { return new
Iterator() {
private int index;
@Override public boolean hasNext() { return index < array.length; }
@Override public Object next() { return array[index++]; }
};
}
}
Getters, trivial add / clear / set, three unsupported methods. The fields
and non-inherited methods are also written originally.
Best,
tison.
Justin Mclean 于2024年4月25日周四 10:36写道：
> Hi,
>
> I’m currently travelling and may be slow in responding to emails.
>
> > The MemoryBufferWritableChannel[5] and MockWritableChannel[6] was
> written
> > by me before we open-sourced Fury and
> > I submitted it to Ray in PR[8] ,which was planned to optimize zero-copy
> > serialization in Ray. I think it's OK to include it
> > here since both are written by me.
>
> That should be fine, but having an ASF header on the files may be a little
> misleading? What do you think?
>
> > For files [1][2][3][4], could you give more details how those files
> include
> > code from OpenSumi. The OpenSumi core developer
> > bytemain[9] does commit some code to Fury, see his commits[10]. But I
> > talked to him offline, he said he didn't copy code from
> > OpenSumi.
>
> It certainly looks like some code was copied; one file, for instance, is
> about 70% the same. This is not an issue as it is under a compatible MIT
> license, but that needs to be mentioned in the LICENSE file.
>
> > For Fury ArrayAsList, could you give more details how this class is
> copied
> > from somewhere? It's just a simple wrapper for java
> > object arrays.
>
> A possible explanation for what has happened here is that the developer
> used AI to generate the code, and it’s duplicated that code from somewhere.
> Do you know if that is the case?
>
> Kind Regards,
> Justin
>
>
> -
> To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org
> For additional commands, e-mail: general-h...@incubator.apache.org
>
>
Re: [VOTE] Release Apache Fury(incubating) v0.5.0-rc3
Hi, I’m currently travelling and may be slow in responding to emails. > The MemoryBufferWritableChannel[5] and MockWritableChannel[6] was written > by me before we open-sourced Fury and > I submitted it to Ray in PR[8] ,which was planned to optimize zero-copy > serialization in Ray. I think it's OK to include it > here since both are written by me. That should be fine, but having an ASF header on the files may be a little misleading? What do you think? > For files [1][2][3][4], could you give more details how those files include > code from OpenSumi. The OpenSumi core developer > bytemain[9] does commit some code to Fury, see his commits[10]. But I > talked to him offline, he said he didn't copy code from > OpenSumi. It certainly looks like some code was copied; one file, for instance, is about 70% the same. This is not an issue as it is under a compatible MIT license, but that needs to be mentioned in the LICENSE file. > For Fury ArrayAsList, could you give more details how this class is copied > from somewhere? It's just a simple wrapper for java > object arrays. A possible explanation for what has happened here is that the developer used AI to generate the code, and it’s duplicated that code from somewhere. Do you know if that is the case? Kind Regards, Justin - To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org For additional commands, e-mail: general-h...@incubator.apache.org
Re: [VOTE] Release Apache Fury(incubating) v0.5.0-rc3
Since it's valid that the LICENSE content to benchmark is redundant, I suggest we cancel this RC and start a new RC. In order to resolve the other potential compliance issues before the next RC is out, I'd appreciate if Justin can confirm that the reply above is clear, that is: * 5-6 is authored by Shawn Yang. So he has the right to contribute it to Fury, no matter if the same code is contributed to elsewhere. * 1-4 are false positive as no evidence implies that it's copied from elsewhere. The commit authors confirmed that they don't copy also * 7, especially after the patch [1], is false positive since it's an original class implement by Shawn Yang and for hacking Fury's serialization. The comment "A List which wrap a Java array like `java.util.Arrays.ArrayList`" indicates Shawn feels that the manner to hold a E[] list is similar, but Fury's class maintain size by itself and all the methods are written originally, or just as trivial as a getter/setter. If the comment introduces confusion, I suggest we remove it. [1] https://github.com/apache/incubator-fury/pull/1560/files Best, tison. Shawn Yang 于2024年4月24日周三 15:52写道： > Hi Sebb, > > The published install page[1] should look good now, could you check it > again? > > 1. https://fury.apache.org/docs/start/install > > > Best Regards, > Chaoun Yang > > On Wed, Apr 24, 2024 at 3:44 PM sebb wrote: > > > On Wed, 24 Apr 2024 at 08:29, Shawn Yang > wrote: > > > > > > Hi Sebb, > > > > > > I highlight that the current release is not an asf release in the > install > > > page in PR https://github.com/apache/incubator-fury-site/pull/113. > > > > > > Could you take a look at it again? > > > > I have just looked at the PR you just raised, and it looks OK. > > > > Note that my comment was about the published install page, which is > > still as I described. > > > > > Thanks for taking time to review Fury's release. > > > > > > Best regards, > > > Chaokun Yang > > > > > > On Wed, Apr 24, 2024 at 3:20 PM sebb wrote: > > > > > > > There is now a link to a potential download page, which is great. > > > > > > > > However, the install page does not make it obvious that the 0.4.1 > > > > release is not an ASF release. > > > > That information should be shown prominently at the start of the > page, > > > > not buried in a note near the end. > > > > > > > > On Tue, 23 Apr 2024 at 16:07, Shawn Yang > > wrote: > > > > > > > > > > I updated it in the PR > > > > > https://github.com/apache/incubator-fury-site/pull/112. Sorry for > my > > > > last > > > > > reply, I forgot to put the PR link. > > > > > > > > > > On Tue, Apr 23, 2024 at 10:22 PM sebb wrote: > > > > > > > > > > > On Tue, 23 Apr 2024 at 14:05, Shawn Yang < > shawn.ck.y...@gmail.com> > > > > wrote: > > > > > > > > > > > > > > Hi Sebb, > > > > > > > > > > > > > > I updated the content in the install doc and added notes that > > this > > > > is > > > > > > not > > > > > > > an ASF release. > > > > > > > > > > > > > > And added a download page for download and verify source > release > > > > only. > > > > > > > Currently this page is basically empty, but will be updated > once > > this > > > > > > vote > > > > > > > is done, and updated > > > > > > > to closer.lua according to download-scripts[1]. > > > > > > > > > > > > > > The cross-links to each other are also added. > > > > > > > > > > > > I don't see these changes on the fury.apache.org website. > > > > > > Are they published anywhere? > > > > > > > > > > > > > 1. > > > > > https://infra.apache.org/release-download-pages.html#download-scripts > > > > > > > > > > > > > > Thanks again for pointing those issues out. > > > > > > > > > > > > > > - > > > > > > > Best Regards, > > > > > > > Chaokun Yang > > > > > > > > > > > > > > On Tue, Apr 23, 2024 at 8:22 PM sebb wrote: > > > > > > > > > > > > > > > On Tue, 23 Apr 2024 at 13:08, tison > > wrote: > > > > > > > > > > > > > > > > > > > They could fix the page now, while waiting for the > release > > > > vote to > > > > > > > > > complete. > > > > > > > > > > > > > > > > > > Make sense. At least remove the page/content now to > indicate > > "no > > > > > > Apache > > > > > > > > > release" now. Then it won't be some "forth and back" > updates. > > > > It's a > > > > > > > > timing > > > > > > > > > issue. > > > > > > > > > > > > > > > > > > > Note that the page needs more than just an update to > > version > > > > > > numbers. > > > > > > > > > > It needs closer.lua links to the source bundle, links to > > KEYS, > > > > sigs > > > > > > > > > > and hashes, and verification instructions. > > > > > > > > > > > > > > > > > > Such an install page can be a simplified quick start page. > I > > > > suppose > > > > > > you > > > > > > > > > refer to a download page like [1]. > > > > > > > > > > > > > > > > > > [1] https://hadoop.apache.org/releases.html > > > > > > > > > > > > > > > > Yes, though ideally use closer.lua rather than closer.cgi. > > > > > > > > > > > > > > > > > And yes, Fury doesn't
Re: [VOTE] Release Apache Fury(incubating) v0.5.0-rc3
Hi Sebb, The published install page[1] should look good now, could you check it again? 1. https://fury.apache.org/docs/start/install Best Regards, Chaoun Yang On Wed, Apr 24, 2024 at 3:44 PM sebb wrote: > On Wed, 24 Apr 2024 at 08:29, Shawn Yang wrote: > > > > Hi Sebb, > > > > I highlight that the current release is not an asf release in the install > > page in PR https://github.com/apache/incubator-fury-site/pull/113. > > > > Could you take a look at it again? > > I have just looked at the PR you just raised, and it looks OK. > > Note that my comment was about the published install page, which is > still as I described. > > > Thanks for taking time to review Fury's release. > > > > Best regards, > > Chaokun Yang > > > > On Wed, Apr 24, 2024 at 3:20 PM sebb wrote: > > > > > There is now a link to a potential download page, which is great. > > > > > > However, the install page does not make it obvious that the 0.4.1 > > > release is not an ASF release. > > > That information should be shown prominently at the start of the page, > > > not buried in a note near the end. > > > > > > On Tue, 23 Apr 2024 at 16:07, Shawn Yang > wrote: > > > > > > > > I updated it in the PR > > > > https://github.com/apache/incubator-fury-site/pull/112. Sorry for my > > > last > > > > reply, I forgot to put the PR link. > > > > > > > > On Tue, Apr 23, 2024 at 10:22 PM sebb wrote: > > > > > > > > > On Tue, 23 Apr 2024 at 14:05, Shawn Yang > > > wrote: > > > > > > > > > > > > Hi Sebb, > > > > > > > > > > > > I updated the content in the install doc and added notes that > this > > > is > > > > > not > > > > > > an ASF release. > > > > > > > > > > > > And added a download page for download and verify source release > > > only. > > > > > > Currently this page is basically empty, but will be updated once > this > > > > > vote > > > > > > is done, and updated > > > > > > to closer.lua according to download-scripts[1]. > > > > > > > > > > > > The cross-links to each other are also added. > > > > > > > > > > I don't see these changes on the fury.apache.org website. > > > > > Are they published anywhere? > > > > > > > > > > > 1. > > > https://infra.apache.org/release-download-pages.html#download-scripts > > > > > > > > > > > > Thanks again for pointing those issues out. > > > > > > > > > > > > - > > > > > > Best Regards, > > > > > > Chaokun Yang > > > > > > > > > > > > On Tue, Apr 23, 2024 at 8:22 PM sebb wrote: > > > > > > > > > > > > > On Tue, 23 Apr 2024 at 13:08, tison > wrote: > > > > > > > > > > > > > > > > > They could fix the page now, while waiting for the release > > > vote to > > > > > > > > complete. > > > > > > > > > > > > > > > > Make sense. At least remove the page/content now to indicate > "no > > > > > Apache > > > > > > > > release" now. Then it won't be some "forth and back" updates. > > > It's a > > > > > > > timing > > > > > > > > issue. > > > > > > > > > > > > > > > > > Note that the page needs more than just an update to > version > > > > > numbers. > > > > > > > > > It needs closer.lua links to the source bundle, links to > KEYS, > > > sigs > > > > > > > > > and hashes, and verification instructions. > > > > > > > > > > > > > > > > Such an install page can be a simplified quick start page. I > > > suppose > > > > > you > > > > > > > > refer to a download page like [1]. > > > > > > > > > > > > > > > > [1] https://hadoop.apache.org/releases.html > > > > > > > > > > > > > > Yes, though ideally use closer.lua rather than closer.cgi. > > > > > > > > > > > > > > > And yes, Fury doesn't have a download page yet, and they > should > > > add > > > > > one. > > > > > > > > > > > > > > Agreed. > > > > > > > > > > > > > > > But in my experience it's different from a quickstart install > > > page, > > > > > like > > > > > > > > [2] vs [3]. > > > > > > > > > > > > > > Yes, but that should not be at the expense of a source download > > > page. > > > > > > > It must be easy to find the source download. > > > > > > > The website and the announcement email must link to the > official > > > > > download > > > > > > > page. > > > > > > > > > > > > > > The download and install pages could be cross-linked. > > > > > > > > > > > > > > > [2] https://opendal.apache.org/docs/quickstart#java-binding > > > > > > > > [3] https://opendal.apache.org/download > > > > > > > > > > > > > > > > Best, > > > > > > > > tison. > > > > > > > > > > > > > > > > > > > > > > > > sebb 于2024年4月23日周二 20:00写道： > > > > > > > > > > > > > > > > > On Tue, 23 Apr 2024 at 12:46, tison > > > wrote: > > > > > > > > > > > > > > > > > > > > > I would be very disappointed if the podling published > the > > > code > > > > > > > > > > > *knowing* that the download page is missing or > incorrect. > > > > > > > > > > > > > > > > > > > > IIUC Fury will update the content and delete all the > > > references > > > > > to > > > > > > > prior > > > > > > > > > > releases. > > > > > > > > > > > > > > > > > > Note that the page needs more than just an
Re: [VOTE] Release Apache Fury(incubating) v0.5.0-rc3
On Wed, 24 Apr 2024 at 08:29, Shawn Yang wrote: > > Hi Sebb, > > I highlight that the current release is not an asf release in the install > page in PR https://github.com/apache/incubator-fury-site/pull/113. > > Could you take a look at it again? I have just looked at the PR you just raised, and it looks OK. Note that my comment was about the published install page, which is still as I described. > Thanks for taking time to review Fury's release. > > Best regards, > Chaokun Yang > > On Wed, Apr 24, 2024 at 3:20 PM sebb wrote: > > > There is now a link to a potential download page, which is great. > > > > However, the install page does not make it obvious that the 0.4.1 > > release is not an ASF release. > > That information should be shown prominently at the start of the page, > > not buried in a note near the end. > > > > On Tue, 23 Apr 2024 at 16:07, Shawn Yang wrote: > > > > > > I updated it in the PR > > > https://github.com/apache/incubator-fury-site/pull/112. Sorry for my > > last > > > reply, I forgot to put the PR link. > > > > > > On Tue, Apr 23, 2024 at 10:22 PM sebb wrote: > > > > > > > On Tue, 23 Apr 2024 at 14:05, Shawn Yang > > wrote: > > > > > > > > > > Hi Sebb, > > > > > > > > > > I updated the content in the install doc and added notes that this > > is > > > > not > > > > > an ASF release. > > > > > > > > > > And added a download page for download and verify source release > > only. > > > > > Currently this page is basically empty, but will be updated once this > > > > vote > > > > > is done, and updated > > > > > to closer.lua according to download-scripts[1]. > > > > > > > > > > The cross-links to each other are also added. > > > > > > > > I don't see these changes on the fury.apache.org website. > > > > Are they published anywhere? > > > > > > > > > 1. > > https://infra.apache.org/release-download-pages.html#download-scripts > > > > > > > > > > Thanks again for pointing those issues out. > > > > > > > > > > - > > > > > Best Regards, > > > > > Chaokun Yang > > > > > > > > > > On Tue, Apr 23, 2024 at 8:22 PM sebb wrote: > > > > > > > > > > > On Tue, 23 Apr 2024 at 13:08, tison wrote: > > > > > > > > > > > > > > > They could fix the page now, while waiting for the release > > vote to > > > > > > > complete. > > > > > > > > > > > > > > Make sense. At least remove the page/content now to indicate "no > > > > Apache > > > > > > > release" now. Then it won't be some "forth and back" updates. > > It's a > > > > > > timing > > > > > > > issue. > > > > > > > > > > > > > > > Note that the page needs more than just an update to version > > > > numbers. > > > > > > > > It needs closer.lua links to the source bundle, links to KEYS, > > sigs > > > > > > > > and hashes, and verification instructions. > > > > > > > > > > > > > > Such an install page can be a simplified quick start page. I > > suppose > > > > you > > > > > > > refer to a download page like [1]. > > > > > > > > > > > > > > [1] https://hadoop.apache.org/releases.html > > > > > > > > > > > > Yes, though ideally use closer.lua rather than closer.cgi. > > > > > > > > > > > > > And yes, Fury doesn't have a download page yet, and they should > > add > > > > one. > > > > > > > > > > > > Agreed. > > > > > > > > > > > > > But in my experience it's different from a quickstart install > > page, > > > > like > > > > > > > [2] vs [3]. > > > > > > > > > > > > Yes, but that should not be at the expense of a source download > > page. > > > > > > It must be easy to find the source download. > > > > > > The website and the announcement email must link to the official > > > > download > > > > > > page. > > > > > > > > > > > > The download and install pages could be cross-linked. > > > > > > > > > > > > > [2] https://opendal.apache.org/docs/quickstart#java-binding > > > > > > > [3] https://opendal.apache.org/download > > > > > > > > > > > > > > Best, > > > > > > > tison. > > > > > > > > > > > > > > > > > > > > > sebb 于2024年4月23日周二 20:00写道： > > > > > > > > > > > > > > > On Tue, 23 Apr 2024 at 12:46, tison > > wrote: > > > > > > > > > > > > > > > > > > > I would be very disappointed if the podling published the > > code > > > > > > > > > > *knowing* that the download page is missing or incorrect. > > > > > > > > > > > > > > > > > > IIUC Fury will update the content and delete all the > > references > > > > to > > > > > > prior > > > > > > > > > releases. > > > > > > > > > > > > > > > > Note that the page needs more than just an update to version > > > > numbers. > > > > > > > > It needs closer.lua links to the source bundle, links to KEYS, > > sigs > > > > > > > > and hashes, and verification instrructions. > > > > > > > > > > > > > > > > > Or instead, Fury can keep these references and state clearly > > it's > > > > > > prior > > > > > > > > > releases. > > > > > > > > > > > > > > > > > > My comment above is with an assumption that prior releases > > ref > > > > will > > > > > > be > > > > > > > > > removed. But if the PPMC wants to keep
Re: [VOTE] Release Apache Fury(incubating) v0.5.0-rc3
Hi Sebb, I highlight that the current release is not an asf release in the install page in PR https://github.com/apache/incubator-fury-site/pull/113. Could you take a look at it again? Thanks for taking time to review Fury's release. Best regards, Chaokun Yang On Wed, Apr 24, 2024 at 3:20 PM sebb wrote: > There is now a link to a potential download page, which is great. > > However, the install page does not make it obvious that the 0.4.1 > release is not an ASF release. > That information should be shown prominently at the start of the page, > not buried in a note near the end. > > On Tue, 23 Apr 2024 at 16:07, Shawn Yang wrote: > > > > I updated it in the PR > > https://github.com/apache/incubator-fury-site/pull/112. Sorry for my > last > > reply, I forgot to put the PR link. > > > > On Tue, Apr 23, 2024 at 10:22 PM sebb wrote: > > > > > On Tue, 23 Apr 2024 at 14:05, Shawn Yang > wrote: > > > > > > > > Hi Sebb, > > > > > > > > I updated the content in the install doc and added notes that this > is > > > not > > > > an ASF release. > > > > > > > > And added a download page for download and verify source release > only. > > > > Currently this page is basically empty, but will be updated once this > > > vote > > > > is done, and updated > > > > to closer.lua according to download-scripts[1]. > > > > > > > > The cross-links to each other are also added. > > > > > > I don't see these changes on the fury.apache.org website. > > > Are they published anywhere? > > > > > > > 1. > https://infra.apache.org/release-download-pages.html#download-scripts > > > > > > > > Thanks again for pointing those issues out. > > > > > > > > - > > > > Best Regards, > > > > Chaokun Yang > > > > > > > > On Tue, Apr 23, 2024 at 8:22 PM sebb wrote: > > > > > > > > > On Tue, 23 Apr 2024 at 13:08, tison wrote: > > > > > > > > > > > > > They could fix the page now, while waiting for the release > vote to > > > > > > complete. > > > > > > > > > > > > Make sense. At least remove the page/content now to indicate "no > > > Apache > > > > > > release" now. Then it won't be some "forth and back" updates. > It's a > > > > > timing > > > > > > issue. > > > > > > > > > > > > > Note that the page needs more than just an update to version > > > numbers. > > > > > > > It needs closer.lua links to the source bundle, links to KEYS, > sigs > > > > > > > and hashes, and verification instructions. > > > > > > > > > > > > Such an install page can be a simplified quick start page. I > suppose > > > you > > > > > > refer to a download page like [1]. > > > > > > > > > > > > [1] https://hadoop.apache.org/releases.html > > > > > > > > > > Yes, though ideally use closer.lua rather than closer.cgi. > > > > > > > > > > > And yes, Fury doesn't have a download page yet, and they should > add > > > one. > > > > > > > > > > Agreed. > > > > > > > > > > > But in my experience it's different from a quickstart install > page, > > > like > > > > > > [2] vs [3]. > > > > > > > > > > Yes, but that should not be at the expense of a source download > page. > > > > > It must be easy to find the source download. > > > > > The website and the announcement email must link to the official > > > download > > > > > page. > > > > > > > > > > The download and install pages could be cross-linked. > > > > > > > > > > > [2] https://opendal.apache.org/docs/quickstart#java-binding > > > > > > [3] https://opendal.apache.org/download > > > > > > > > > > > > Best, > > > > > > tison. > > > > > > > > > > > > > > > > > > sebb 于2024年4月23日周二 20:00写道： > > > > > > > > > > > > > On Tue, 23 Apr 2024 at 12:46, tison > wrote: > > > > > > > > > > > > > > > > > I would be very disappointed if the podling published the > code > > > > > > > > > *knowing* that the download page is missing or incorrect. > > > > > > > > > > > > > > > > IIUC Fury will update the content and delete all the > references > > > to > > > > > prior > > > > > > > > releases. > > > > > > > > > > > > > > Note that the page needs more than just an update to version > > > numbers. > > > > > > > It needs closer.lua links to the source bundle, links to KEYS, > sigs > > > > > > > and hashes, and verification instrructions. > > > > > > > > > > > > > > > Or instead, Fury can keep these references and state clearly > it's > > > > > prior > > > > > > > > releases. > > > > > > > > > > > > > > > > My comment above is with an assumption that prior releases > ref > > > will > > > > > be > > > > > > > > removed. But if the PPMC wants to keep it, they should > update the > > > > > > > > description. > > > > > > > > > > > > > > They could fix the page now, while waiting for the release > vote to > > > > > > > complete. > > > > > > > > > > > > > > > Best, > > > > > > > > tison. > > > > > > > > > > > > > > > > > > > > > > > > sebb 于2024年4月23日周二 19:35写道： > > > > > > > > > > > > > > > > > On Tue, 23 Apr 2024 at 09:42, tison > > > wrote: > > > > > > > > > > > > > > > > > > > > > There is no indication that 0.4.1 is not an ASF >
Re: [VOTE] Release Apache Fury(incubating) v0.5.0-rc3
There is now a link to a potential download page, which is great. However, the install page does not make it obvious that the 0.4.1 release is not an ASF release. That information should be shown prominently at the start of the page, not buried in a note near the end. On Tue, 23 Apr 2024 at 16:07, Shawn Yang wrote: > > I updated it in the PR > https://github.com/apache/incubator-fury-site/pull/112. Sorry for my last > reply, I forgot to put the PR link. > > On Tue, Apr 23, 2024 at 10:22 PM sebb wrote: > > > On Tue, 23 Apr 2024 at 14:05, Shawn Yang wrote: > > > > > > Hi Sebb, > > > > > > I updated the content in the install doc and added notes that this is > > not > > > an ASF release. > > > > > > And added a download page for download and verify source release only. > > > Currently this page is basically empty, but will be updated once this > > vote > > > is done, and updated > > > to closer.lua according to download-scripts[1]. > > > > > > The cross-links to each other are also added. > > > > I don't see these changes on the fury.apache.org website. > > Are they published anywhere? > > > > > 1. https://infra.apache.org/release-download-pages.html#download-scripts > > > > > > Thanks again for pointing those issues out. > > > > > > - > > > Best Regards, > > > Chaokun Yang > > > > > > On Tue, Apr 23, 2024 at 8:22 PM sebb wrote: > > > > > > > On Tue, 23 Apr 2024 at 13:08, tison wrote: > > > > > > > > > > > They could fix the page now, while waiting for the release vote to > > > > > complete. > > > > > > > > > > Make sense. At least remove the page/content now to indicate "no > > Apache > > > > > release" now. Then it won't be some "forth and back" updates. It's a > > > > timing > > > > > issue. > > > > > > > > > > > Note that the page needs more than just an update to version > > numbers. > > > > > > It needs closer.lua links to the source bundle, links to KEYS, sigs > > > > > > and hashes, and verification instructions. > > > > > > > > > > Such an install page can be a simplified quick start page. I suppose > > you > > > > > refer to a download page like [1]. > > > > > > > > > > [1] https://hadoop.apache.org/releases.html > > > > > > > > Yes, though ideally use closer.lua rather than closer.cgi. > > > > > > > > > And yes, Fury doesn't have a download page yet, and they should add > > one. > > > > > > > > Agreed. > > > > > > > > > But in my experience it's different from a quickstart install page, > > like > > > > > [2] vs [3]. > > > > > > > > Yes, but that should not be at the expense of a source download page. > > > > It must be easy to find the source download. > > > > The website and the announcement email must link to the official > > download > > > > page. > > > > > > > > The download and install pages could be cross-linked. > > > > > > > > > [2] https://opendal.apache.org/docs/quickstart#java-binding > > > > > [3] https://opendal.apache.org/download > > > > > > > > > > Best, > > > > > tison. > > > > > > > > > > > > > > > sebb 于2024年4月23日周二 20:00写道： > > > > > > > > > > > On Tue, 23 Apr 2024 at 12:46, tison wrote: > > > > > > > > > > > > > > > I would be very disappointed if the podling published the code > > > > > > > > *knowing* that the download page is missing or incorrect. > > > > > > > > > > > > > > IIUC Fury will update the content and delete all the references > > to > > > > prior > > > > > > > releases. > > > > > > > > > > > > Note that the page needs more than just an update to version > > numbers. > > > > > > It needs closer.lua links to the source bundle, links to KEYS, sigs > > > > > > and hashes, and verification instrructions. > > > > > > > > > > > > > Or instead, Fury can keep these references and state clearly it's > > > > prior > > > > > > > releases. > > > > > > > > > > > > > > My comment above is with an assumption that prior releases ref > > will > > > > be > > > > > > > removed. But if the PPMC wants to keep it, they should update the > > > > > > > description. > > > > > > > > > > > > They could fix the page now, while waiting for the release vote to > > > > > > complete. > > > > > > > > > > > > > Best, > > > > > > > tison. > > > > > > > > > > > > > > > > > > > > > sebb 于2024年4月23日周二 19:35写道： > > > > > > > > > > > > > > > On Tue, 23 Apr 2024 at 09:42, tison > > wrote: > > > > > > > > > > > > > > > > > > > There is no indication that 0.4.1 is not an ASF release. > > > > > > > > > > > > > > > > > > You may found that the group id is not org.apache.fury also. > > > > > > > > > > > > > > > > Whilst this is true, it is still not obvious that this is not > > an > > > > ASF > > > > > > > > release; it is easy to overlook this minor detail. > > > > > > > > > > > > > > > > Indeed, there is no such indication for the GoLang, Javascript > > or > > > > Rust > > > > > > > > binaries. > > > > > > > > > > > > > > > > > This is an intermediate state that we would update the > > content > > > > as: > > > > > > > > > > > > > > > > > > > > > > > > > > > org.apache.fury > > > >
Re: [VOTE] Release Apache Fury(incubating) v0.5.0-rc3
Hi Justin, Thanks for helping review this release. The MemoryBufferWritableChannel[5] and MockWritableChannel[6] was written by me before we open-sourced Fury and I submitted it to Ray in PR[8] ,which was planned to optimize zero-copy serialization in Ray. I think it's OK to include it here since both are written by me. For files [1][2][3][4], could you give more details how those files include code from OpenSumi. The OpenSumi core developer bytemain[9] does commit some code to Fury, see his commits[10]. But I talked to him offline, he said he didn't copy code from OpenSumi. For Fury ArrayAsList, could you give more details how this class is copied from somewhere? It's just a simple wrapper for java object arrays. Fury just implements some basic interfaces of java Collection. I don't think we can write this class in another way without following the Java Collection interface. To reduce confusion, I removed some methods which don't get invoked in PR[11]. But as tison said, this may not resolve your concerns. For the benchmark issue, thanks for pointing this out. We excluded the benchmark directory in the source release, but didn't remove license reference from LICENSE file. I'll fix this later. 1. /javascript/packages/fury/lib/gen/datetime.ts 2. /javascript/packages/fury/lib/gen/index.ts 3. /javascript/packages/fury/lib/fury.ts 4. /javascript/packages/fury/lib/classResolver.ts 5. /java/fury-core/src/main/java/org/apache/fury/io/MemoryBufferWritableChannel.java 6. /java/fury-core/src/main/java/org/apache/fury/io/MockWritableChannel.java 7. /java/fury-core/src/main/java/org/apache/fury/serializer/collection/ArrayAsList.java 8. https://github.com/ray-project/ray/pull/21256 9. https://github.com/bytemain 10. https://github.com/apache/incubator-fury/commits?author=bytemain 11. https://github.com/apache/incubator-fury/pull/1560 On Wed, Apr 24, 2024 at 11:40 AM Justin Mclean wrote: > HI, > > Sorry, it’s -1 (binding) from me as it looks like there is additional > third-party code without correct headers or mentioned in LICENSE. > > I checked: > - incubating in name > - signatures and hashes are fine > - LICENSE has some issues (see below) > - NOTICE is fine > - It looks like some 3rd party code incorrectly has ASF headers (see below) > - All source files have ASF headers > > For the LICENSE file: > - there are several references to a benchmark directory, but it is not > included in the release > - there seems to be 3rd part code from OpenSumi here [1][2][3][4] > - there seems to be code from Ray here [5][6] > - this file may have been copied from somewhere [7] > > Kind Regards, > Justin > > 1. /javascript/packages/fury/lib/gen/datetime.ts > 2. /javascript/packages/fury/lib/gen/index.ts > 3. /javascript/packages/fury/lib/fury.ts > 4. /javascript/packages/fury/lib/classResolver.ts > 5. > /java/fury-core/src/main/java/org/apache/fury/io/MemoryBufferWritableChannel.java > 6. > /java/fury-core/src/main/java/org/apache/fury/io/MockWritableChannel.java > 7. > /java/fury-core/src/main/java/org/apache/fury/serializer/collection/ArrayAsList.java > - > To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org > For additional commands, e-mail: general-h...@incubator.apache.org > >
Re: [VOTE] Release Apache Fury(incubating) v0.5.0-rc3
Hi Justin, Thanks for verifying potential compliance issue. For 1-6 that you specify certain possible origins, do you have a report of the overlap files? I try to search the content of datetime.ts in OpenSumi but fail to find a result: https://github.com/search?q=repo:opensumi/core%20DateSerializerGenerator=code Also cc @chaokunyang and @weipeng if you're sure they're originally copied from elsewhere. For 7, the class seems no more than a thin wrapper of ArrayList that can be written by any Java developer. The file author confirmed that it was written by himself independently. Although Fury committers open [1] to make some changes, I don't think it can resolve any issue in your description if exist. [1] https://github.com/apache/incubator-fury/pull/1560 Best, tison. Justin Mclean 于2024年4月24日周三 11:40写道： > HI, > > Sorry, it’s -1 (binding) from me as it looks like there is additional > third-party code without correct headers or mentioned in LICENSE. > > I checked: > - incubating in name > - signatures and hashes are fine > - LICENSE has some issues (see below) > - NOTICE is fine > - It looks like some 3rd party code incorrectly has ASF headers (see below) > - All source files have ASF headers > > For the LICENSE file: > - there are several references to a benchmark directory, but it is not > included in the release > - there seems to be 3rd part code from OpenSumi here [1][2][3][4] > - there seems to be code from Ray here [5][6] > - this file may have been copied from somewhere [7] > > Kind Regards, > Justin > > 1. /javascript/packages/fury/lib/gen/datetime.ts > 2. /javascript/packages/fury/lib/gen/index.ts > 3. /javascript/packages/fury/lib/fury.ts > 4. /javascript/packages/fury/lib/classResolver.ts > 5. > /java/fury-core/src/main/java/org/apache/fury/io/MemoryBufferWritableChannel.java > 6. > /java/fury-core/src/main/java/org/apache/fury/io/MockWritableChannel.java > 7. > /java/fury-core/src/main/java/org/apache/fury/serializer/collection/ArrayAsList.java > - > To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org > For additional commands, e-mail: general-h...@incubator.apache.org > >
Re: [VOTE] Release Apache Fury(incubating) v0.5.0-rc3
HI, Sorry, it’s -1 (binding) from me as it looks like there is additional third-party code without correct headers or mentioned in LICENSE. I checked: - incubating in name - signatures and hashes are fine - LICENSE has some issues (see below) - NOTICE is fine - It looks like some 3rd party code incorrectly has ASF headers (see below) - All source files have ASF headers For the LICENSE file: - there are several references to a benchmark directory, but it is not included in the release - there seems to be 3rd part code from OpenSumi here [1][2][3][4] - there seems to be code from Ray here [5][6] - this file may have been copied from somewhere [7] Kind Regards, Justin 1. /javascript/packages/fury/lib/gen/datetime.ts 2. /javascript/packages/fury/lib/gen/index.ts 3. /javascript/packages/fury/lib/fury.ts 4. /javascript/packages/fury/lib/classResolver.ts 5. /java/fury-core/src/main/java/org/apache/fury/io/MemoryBufferWritableChannel.java 6. /java/fury-core/src/main/java/org/apache/fury/io/MockWritableChannel.java 7. /java/fury-core/src/main/java/org/apache/fury/serializer/collection/ArrayAsList.java - To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org For additional commands, e-mail: general-h...@incubator.apache.org
Re: [VOTE] Release Apache Fury(incubating) v0.5.0-rc3
I updated it in the PR https://github.com/apache/incubator-fury-site/pull/112. Sorry for my last reply, I forgot to put the PR link. On Tue, Apr 23, 2024 at 10:22 PM sebb wrote: > On Tue, 23 Apr 2024 at 14:05, Shawn Yang wrote: > > > > Hi Sebb, > > > > I updated the content in the install doc and added notes that this is > not > > an ASF release. > > > > And added a download page for download and verify source release only. > > Currently this page is basically empty, but will be updated once this > vote > > is done, and updated > > to closer.lua according to download-scripts[1]. > > > > The cross-links to each other are also added. > > I don't see these changes on the fury.apache.org website. > Are they published anywhere? > > > 1. https://infra.apache.org/release-download-pages.html#download-scripts > > > > Thanks again for pointing those issues out. > > > > - > > Best Regards, > > Chaokun Yang > > > > On Tue, Apr 23, 2024 at 8:22 PM sebb wrote: > > > > > On Tue, 23 Apr 2024 at 13:08, tison wrote: > > > > > > > > > They could fix the page now, while waiting for the release vote to > > > > complete. > > > > > > > > Make sense. At least remove the page/content now to indicate "no > Apache > > > > release" now. Then it won't be some "forth and back" updates. It's a > > > timing > > > > issue. > > > > > > > > > Note that the page needs more than just an update to version > numbers. > > > > > It needs closer.lua links to the source bundle, links to KEYS, sigs > > > > > and hashes, and verification instructions. > > > > > > > > Such an install page can be a simplified quick start page. I suppose > you > > > > refer to a download page like [1]. > > > > > > > > [1] https://hadoop.apache.org/releases.html > > > > > > Yes, though ideally use closer.lua rather than closer.cgi. > > > > > > > And yes, Fury doesn't have a download page yet, and they should add > one. > > > > > > Agreed. > > > > > > > But in my experience it's different from a quickstart install page, > like > > > > [2] vs [3]. > > > > > > Yes, but that should not be at the expense of a source download page. > > > It must be easy to find the source download. > > > The website and the announcement email must link to the official > download > > > page. > > > > > > The download and install pages could be cross-linked. > > > > > > > [2] https://opendal.apache.org/docs/quickstart#java-binding > > > > [3] https://opendal.apache.org/download > > > > > > > > Best, > > > > tison. > > > > > > > > > > > > sebb 于2024年4月23日周二 20:00写道： > > > > > > > > > On Tue, 23 Apr 2024 at 12:46, tison wrote: > > > > > > > > > > > > > I would be very disappointed if the podling published the code > > > > > > > *knowing* that the download page is missing or incorrect. > > > > > > > > > > > > IIUC Fury will update the content and delete all the references > to > > > prior > > > > > > releases. > > > > > > > > > > Note that the page needs more than just an update to version > numbers. > > > > > It needs closer.lua links to the source bundle, links to KEYS, sigs > > > > > and hashes, and verification instrructions. > > > > > > > > > > > Or instead, Fury can keep these references and state clearly it's > > > prior > > > > > > releases. > > > > > > > > > > > > My comment above is with an assumption that prior releases ref > will > > > be > > > > > > removed. But if the PPMC wants to keep it, they should update the > > > > > > description. > > > > > > > > > > They could fix the page now, while waiting for the release vote to > > > > > complete. > > > > > > > > > > > Best, > > > > > > tison. > > > > > > > > > > > > > > > > > > sebb 于2024年4月23日周二 19:35写道： > > > > > > > > > > > > > On Tue, 23 Apr 2024 at 09:42, tison > wrote: > > > > > > > > > > > > > > > > > There is no indication that 0.4.1 is not an ASF release. > > > > > > > > > > > > > > > > You may found that the group id is not org.apache.fury also. > > > > > > > > > > > > > > Whilst this is true, it is still not obvious that this is not > an > > > ASF > > > > > > > release; it is easy to overlook this minor detail. > > > > > > > > > > > > > > Indeed, there is no such indication for the GoLang, Javascript > or > > > Rust > > > > > > > binaries. > > > > > > > > > > > > > > > This is an intermediate state that we would update the > content > > > as: > > > > > > > > > > > > > > > > > > > > > > > > org.apache.fury > > > > > > > > fury-core > > > > > > > > 0.5.0 > > > > > > > > > > > > > > > > > > > > > > > > And then the content is correct. > > > > > > > > > > > > > > Strictly speaking the content of the Maven reference to 0.4.1 > is > > > not > > > > > > > 'incorrect'. > > > > > > > The problem is that the page does not make it clear that the > > > release > > > > > > > is not an ASF release. > > > > > > > > > > > > > > It's OK to refer to prior releases, but the reader must be > clearly > > > > > > > informed of their provenance. > > > > > > > > > > > > > > > If we make any workaround or patch to make > > >
Re: [VOTE] Release Apache Fury(incubating) v0.5.0-rc3
On Tue, 23 Apr 2024 at 14:05, Shawn Yang wrote: > > Hi Sebb, > > I updated the content in the install doc and added notes that this is not > an ASF release. > > And added a download page for download and verify source release only. > Currently this page is basically empty, but will be updated once this vote > is done, and updated > to closer.lua according to download-scripts[1]. > > The cross-links to each other are also added. I don't see these changes on the fury.apache.org website. Are they published anywhere? > 1. https://infra.apache.org/release-download-pages.html#download-scripts > > Thanks again for pointing those issues out. > > - > Best Regards, > Chaokun Yang > > On Tue, Apr 23, 2024 at 8:22 PM sebb wrote: > > > On Tue, 23 Apr 2024 at 13:08, tison wrote: > > > > > > > They could fix the page now, while waiting for the release vote to > > > complete. > > > > > > Make sense. At least remove the page/content now to indicate "no Apache > > > release" now. Then it won't be some "forth and back" updates. It's a > > timing > > > issue. > > > > > > > Note that the page needs more than just an update to version numbers. > > > > It needs closer.lua links to the source bundle, links to KEYS, sigs > > > > and hashes, and verification instructions. > > > > > > Such an install page can be a simplified quick start page. I suppose you > > > refer to a download page like [1]. > > > > > > [1] https://hadoop.apache.org/releases.html > > > > Yes, though ideally use closer.lua rather than closer.cgi. > > > > > And yes, Fury doesn't have a download page yet, and they should add one. > > > > Agreed. > > > > > But in my experience it's different from a quickstart install page, like > > > [2] vs [3]. > > > > Yes, but that should not be at the expense of a source download page. > > It must be easy to find the source download. > > The website and the announcement email must link to the official download > > page. > > > > The download and install pages could be cross-linked. > > > > > [2] https://opendal.apache.org/docs/quickstart#java-binding > > > [3] https://opendal.apache.org/download > > > > > > Best, > > > tison. > > > > > > > > > sebb 于2024年4月23日周二 20:00写道： > > > > > > > On Tue, 23 Apr 2024 at 12:46, tison wrote: > > > > > > > > > > > I would be very disappointed if the podling published the code > > > > > > *knowing* that the download page is missing or incorrect. > > > > > > > > > > IIUC Fury will update the content and delete all the references to > > prior > > > > > releases. > > > > > > > > Note that the page needs more than just an update to version numbers. > > > > It needs closer.lua links to the source bundle, links to KEYS, sigs > > > > and hashes, and verification instrructions. > > > > > > > > > Or instead, Fury can keep these references and state clearly it's > > prior > > > > > releases. > > > > > > > > > > My comment above is with an assumption that prior releases ref will > > be > > > > > removed. But if the PPMC wants to keep it, they should update the > > > > > description. > > > > > > > > They could fix the page now, while waiting for the release vote to > > > > complete. > > > > > > > > > Best, > > > > > tison. > > > > > > > > > > > > > > > sebb 于2024年4月23日周二 19:35写道： > > > > > > > > > > > On Tue, 23 Apr 2024 at 09:42, tison wrote: > > > > > > > > > > > > > > > There is no indication that 0.4.1 is not an ASF release. > > > > > > > > > > > > > > You may found that the group id is not org.apache.fury also. > > > > > > > > > > > > Whilst this is true, it is still not obvious that this is not an > > ASF > > > > > > release; it is easy to overlook this minor detail. > > > > > > > > > > > > Indeed, there is no such indication for the GoLang, Javascript or > > Rust > > > > > > binaries. > > > > > > > > > > > > > This is an intermediate state that we would update the content > > as: > > > > > > > > > > > > > > > > > > > > > org.apache.fury > > > > > > > fury-core > > > > > > > 0.5.0 > > > > > > > > > > > > > > > > > > > > > And then the content is correct. > > > > > > > > > > > > Strictly speaking the content of the Maven reference to 0.4.1 is > > not > > > > > > 'incorrect'. > > > > > > The problem is that the page does not make it clear that the > > release > > > > > > is not an ASF release. > > > > > > > > > > > > It's OK to refer to prior releases, but the reader must be clearly > > > > > > informed of their provenance. > > > > > > > > > > > > > If we make any workaround or patch to make > > > > > > > it "look good", it would be updated as soon as 0.5.0 is > > released. So > > > > I > > > > > > > won't treat that as a release blocker. > > > > > > > > > > > > I would be very disappointed if the podling published the code > > > > > > *knowing* that the download page is missing or incorrect. > > > > > > > > > > > > > Best, > > > > > > > tison. > > > > > > > > > > > > > > > > > > > > > sebb 于2024年4月23日周二 15:59写道： > > > > > > > > > > > > > > > On Mon, 22 Apr 2024 at 10:11, PJ
Re: [VOTE] Release Apache Fury(incubating) v0.5.0-rc3
Hi Sebb, I updated the content in the install doc and added notes that this is not an ASF release. And added a download page for download and verify source release only. Currently this page is basically empty, but will be updated once this vote is done, and updated to closer.lua according to download-scripts[1]. The cross-links to each other are also added. 1. https://infra.apache.org/release-download-pages.html#download-scripts Thanks again for pointing those issues out. - Best Regards, Chaokun Yang On Tue, Apr 23, 2024 at 8:22 PM sebb wrote: > On Tue, 23 Apr 2024 at 13:08, tison wrote: > > > > > They could fix the page now, while waiting for the release vote to > > complete. > > > > Make sense. At least remove the page/content now to indicate "no Apache > > release" now. Then it won't be some "forth and back" updates. It's a > timing > > issue. > > > > > Note that the page needs more than just an update to version numbers. > > > It needs closer.lua links to the source bundle, links to KEYS, sigs > > > and hashes, and verification instructions. > > > > Such an install page can be a simplified quick start page. I suppose you > > refer to a download page like [1]. > > > > [1] https://hadoop.apache.org/releases.html > > Yes, though ideally use closer.lua rather than closer.cgi. > > > And yes, Fury doesn't have a download page yet, and they should add one. > > Agreed. > > > But in my experience it's different from a quickstart install page, like > > [2] vs [3]. > > Yes, but that should not be at the expense of a source download page. > It must be easy to find the source download. > The website and the announcement email must link to the official download > page. > > The download and install pages could be cross-linked. > > > [2] https://opendal.apache.org/docs/quickstart#java-binding > > [3] https://opendal.apache.org/download > > > > Best, > > tison. > > > > > > sebb 于2024年4月23日周二 20:00写道： > > > > > On Tue, 23 Apr 2024 at 12:46, tison wrote: > > > > > > > > > I would be very disappointed if the podling published the code > > > > > *knowing* that the download page is missing or incorrect. > > > > > > > > IIUC Fury will update the content and delete all the references to > prior > > > > releases. > > > > > > Note that the page needs more than just an update to version numbers. > > > It needs closer.lua links to the source bundle, links to KEYS, sigs > > > and hashes, and verification instrructions. > > > > > > > Or instead, Fury can keep these references and state clearly it's > prior > > > > releases. > > > > > > > > My comment above is with an assumption that prior releases ref will > be > > > > removed. But if the PPMC wants to keep it, they should update the > > > > description. > > > > > > They could fix the page now, while waiting for the release vote to > > > complete. > > > > > > > Best, > > > > tison. > > > > > > > > > > > > sebb 于2024年4月23日周二 19:35写道： > > > > > > > > > On Tue, 23 Apr 2024 at 09:42, tison wrote: > > > > > > > > > > > > > There is no indication that 0.4.1 is not an ASF release. > > > > > > > > > > > > You may found that the group id is not org.apache.fury also. > > > > > > > > > > Whilst this is true, it is still not obvious that this is not an > ASF > > > > > release; it is easy to overlook this minor detail. > > > > > > > > > > Indeed, there is no such indication for the GoLang, Javascript or > Rust > > > > > binaries. > > > > > > > > > > > This is an intermediate state that we would update the content > as: > > > > > > > > > > > > > > > > > > org.apache.fury > > > > > > fury-core > > > > > > 0.5.0 > > > > > > > > > > > > > > > > > > And then the content is correct. > > > > > > > > > > Strictly speaking the content of the Maven reference to 0.4.1 is > not > > > > > 'incorrect'. > > > > > The problem is that the page does not make it clear that the > release > > > > > is not an ASF release. > > > > > > > > > > It's OK to refer to prior releases, but the reader must be clearly > > > > > informed of their provenance. > > > > > > > > > > > If we make any workaround or patch to make > > > > > > it "look good", it would be updated as soon as 0.5.0 is > released. So > > > I > > > > > > won't treat that as a release blocker. > > > > > > > > > > I would be very disappointed if the podling published the code > > > > > *knowing* that the download page is missing or incorrect. > > > > > > > > > > > Best, > > > > > > tison. > > > > > > > > > > > > > > > > > > sebb 于2024年4月23日周二 15:59写道： > > > > > > > > > > > > > On Mon, 22 Apr 2024 at 10:11, PJ Fanning > > > > wrote: > > > > > > > > > > > > > > > > Hi Sebb, > > > > > > > > This email thread is a vote for an RC. If this vote passes, > > > v0.5.0 > > > > > > > > will be the first release of Fury since it became a podling. > > > > > > > > We will add a download page but at the moment, there is > nothing > > > to > > > > > > > > link to there (except perhaps a KEYS file). > > > > > > > > > > > > > > > > The Install
Re: [VOTE] Release Apache Fury(incubating) v0.5.0-rc3
On Tue, 23 Apr 2024 at 13:08, tison wrote: > > > They could fix the page now, while waiting for the release vote to > complete. > > Make sense. At least remove the page/content now to indicate "no Apache > release" now. Then it won't be some "forth and back" updates. It's a timing > issue. > > > Note that the page needs more than just an update to version numbers. > > It needs closer.lua links to the source bundle, links to KEYS, sigs > > and hashes, and verification instructions. > > Such an install page can be a simplified quick start page. I suppose you > refer to a download page like [1]. > > [1] https://hadoop.apache.org/releases.html Yes, though ideally use closer.lua rather than closer.cgi. > And yes, Fury doesn't have a download page yet, and they should add one. Agreed. > But in my experience it's different from a quickstart install page, like > [2] vs [3]. Yes, but that should not be at the expense of a source download page. It must be easy to find the source download. The website and the announcement email must link to the official download page. The download and install pages could be cross-linked. > [2] https://opendal.apache.org/docs/quickstart#java-binding > [3] https://opendal.apache.org/download > > Best, > tison. > > > sebb 于2024年4月23日周二 20:00写道： > > > On Tue, 23 Apr 2024 at 12:46, tison wrote: > > > > > > > I would be very disappointed if the podling published the code > > > > *knowing* that the download page is missing or incorrect. > > > > > > IIUC Fury will update the content and delete all the references to prior > > > releases. > > > > Note that the page needs more than just an update to version numbers. > > It needs closer.lua links to the source bundle, links to KEYS, sigs > > and hashes, and verification instrructions. > > > > > Or instead, Fury can keep these references and state clearly it's prior > > > releases. > > > > > > My comment above is with an assumption that prior releases ref will be > > > removed. But if the PPMC wants to keep it, they should update the > > > description. > > > > They could fix the page now, while waiting for the release vote to > > complete. > > > > > Best, > > > tison. > > > > > > > > > sebb 于2024年4月23日周二 19:35写道： > > > > > > > On Tue, 23 Apr 2024 at 09:42, tison wrote: > > > > > > > > > > > There is no indication that 0.4.1 is not an ASF release. > > > > > > > > > > You may found that the group id is not org.apache.fury also. > > > > > > > > Whilst this is true, it is still not obvious that this is not an ASF > > > > release; it is easy to overlook this minor detail. > > > > > > > > Indeed, there is no such indication for the GoLang, Javascript or Rust > > > > binaries. > > > > > > > > > This is an intermediate state that we would update the content as: > > > > > > > > > > > > > > > org.apache.fury > > > > > fury-core > > > > > 0.5.0 > > > > > > > > > > > > > > > And then the content is correct. > > > > > > > > Strictly speaking the content of the Maven reference to 0.4.1 is not > > > > 'incorrect'. > > > > The problem is that the page does not make it clear that the release > > > > is not an ASF release. > > > > > > > > It's OK to refer to prior releases, but the reader must be clearly > > > > informed of their provenance. > > > > > > > > > If we make any workaround or patch to make > > > > > it "look good", it would be updated as soon as 0.5.0 is released. So > > I > > > > > won't treat that as a release blocker. > > > > > > > > I would be very disappointed if the podling published the code > > > > *knowing* that the download page is missing or incorrect. > > > > > > > > > Best, > > > > > tison. > > > > > > > > > > > > > > > sebb 于2024年4月23日周二 15:59写道： > > > > > > > > > > > On Mon, 22 Apr 2024 at 10:11, PJ Fanning > > wrote: > > > > > > > > > > > > > > Hi Sebb, > > > > > > > This email thread is a vote for an RC. If this vote passes, > > v0.5.0 > > > > > > > will be the first release of Fury since it became a podling. > > > > > > > We will add a download page but at the moment, there is nothing > > to > > > > > > > link to there (except perhaps a KEYS file). > > > > > > > > > > > > > > The Install page does need to be updated to not mention > > snapshots. > > > > > > > > > > > > If 0.5.0 is to be the first ASF release, then the Install page is > > very > > > > > > misleading. > > > > > > > > > > > > There is no indication that 0.4.1 is not an ASF release. > > > > > > > > > > > > > Thanks, > > > > > > > PJ > > > > > > > > > > > > > > On Mon, 22 Apr 2024 at 10:35, sebb wrote: > > > > > > > > > > > > > > > > On Sat, 20 Apr 2024 at 16:26, Shawn Yang < > > shawn.ck.y...@gmail.com> > > > > > > wrote: > > > > > > > > > > > > > > > > > > Hello everyone, > > > > > > > > > > > > > > > > > > This is a call for the vote to release Apache > > Fury(Incubating) > > > > > > v0.5.0-rc3. > > > > > > > > > > > > > > > > > > The Apache Fury community has voted and approved the release > > of > > > > > > Apache > > > > > > > > >
Re: [VOTE] Release Apache Fury(incubating) v0.5.0-rc3
> They could fix the page now, while waiting for the release vote to complete. Make sense. At least remove the page/content now to indicate "no Apache release" now. Then it won't be some "forth and back" updates. It's a timing issue. > Note that the page needs more than just an update to version numbers. > It needs closer.lua links to the source bundle, links to KEYS, sigs > and hashes, and verification instructions. Such an install page can be a simplified quick start page. I suppose you refer to a download page like [1]. [1] https://hadoop.apache.org/releases.html And yes, Fury doesn't have a download page yet, and they should add one. But in my experience it's different from a quickstart install page, like [2] vs [3]. [2] https://opendal.apache.org/docs/quickstart#java-binding [3] https://opendal.apache.org/download Best, tison. sebb 于2024年4月23日周二 20:00写道： > On Tue, 23 Apr 2024 at 12:46, tison wrote: > > > > > I would be very disappointed if the podling published the code > > > *knowing* that the download page is missing or incorrect. > > > > IIUC Fury will update the content and delete all the references to prior > > releases. > > Note that the page needs more than just an update to version numbers. > It needs closer.lua links to the source bundle, links to KEYS, sigs > and hashes, and verification instrructions. > > > Or instead, Fury can keep these references and state clearly it's prior > > releases. > > > > My comment above is with an assumption that prior releases ref will be > > removed. But if the PPMC wants to keep it, they should update the > > description. > > They could fix the page now, while waiting for the release vote to > complete. > > > Best, > > tison. > > > > > > sebb 于2024年4月23日周二 19:35写道： > > > > > On Tue, 23 Apr 2024 at 09:42, tison wrote: > > > > > > > > > There is no indication that 0.4.1 is not an ASF release. > > > > > > > > You may found that the group id is not org.apache.fury also. > > > > > > Whilst this is true, it is still not obvious that this is not an ASF > > > release; it is easy to overlook this minor detail. > > > > > > Indeed, there is no such indication for the GoLang, Javascript or Rust > > > binaries. > > > > > > > This is an intermediate state that we would update the content as: > > > > > > > > > > > > org.apache.fury > > > > fury-core > > > > 0.5.0 > > > > > > > > > > > > And then the content is correct. > > > > > > Strictly speaking the content of the Maven reference to 0.4.1 is not > > > 'incorrect'. > > > The problem is that the page does not make it clear that the release > > > is not an ASF release. > > > > > > It's OK to refer to prior releases, but the reader must be clearly > > > informed of their provenance. > > > > > > > If we make any workaround or patch to make > > > > it "look good", it would be updated as soon as 0.5.0 is released. So > I > > > > won't treat that as a release blocker. > > > > > > I would be very disappointed if the podling published the code > > > *knowing* that the download page is missing or incorrect. > > > > > > > Best, > > > > tison. > > > > > > > > > > > > sebb 于2024年4月23日周二 15:59写道： > > > > > > > > > On Mon, 22 Apr 2024 at 10:11, PJ Fanning > wrote: > > > > > > > > > > > > Hi Sebb, > > > > > > This email thread is a vote for an RC. If this vote passes, > v0.5.0 > > > > > > will be the first release of Fury since it became a podling. > > > > > > We will add a download page but at the moment, there is nothing > to > > > > > > link to there (except perhaps a KEYS file). > > > > > > > > > > > > The Install page does need to be updated to not mention > snapshots. > > > > > > > > > > If 0.5.0 is to be the first ASF release, then the Install page is > very > > > > > misleading. > > > > > > > > > > There is no indication that 0.4.1 is not an ASF release. > > > > > > > > > > > Thanks, > > > > > > PJ > > > > > > > > > > > > On Mon, 22 Apr 2024 at 10:35, sebb wrote: > > > > > > > > > > > > > > On Sat, 20 Apr 2024 at 16:26, Shawn Yang < > shawn.ck.y...@gmail.com> > > > > > wrote: > > > > > > > > > > > > > > > > Hello everyone, > > > > > > > > > > > > > > > > This is a call for the vote to release Apache > Fury(Incubating) > > > > > v0.5.0-rc3. > > > > > > > > > > > > > > > > The Apache Fury community has voted and approved the release > of > > > > > Apache > > > > > > > > Fury(incubating) v0.5.0-rc3. We now kindly request the IPMC > > > members > > > > > > > > review and vote for this release. > > > > > > > > > > > > > > > > Apache Fury(incubating) - A blazingly fast multi-language > > > > > serialization > > > > > > > > framework powered by JIT and zero-copy. > > > > > > > > > > > > > > > > Fury community vote thread: > > > > > > > > > https://lists.apache.org/thread/g49qt1v99d0ncfvonng39lcs1s56m7v5 > > > > > > > > > > > > > > > > Vote result thread: > > > > > > > > > https://lists.apache.org/thread/9rtl03g650pojyfb5d67785tffyo4hbs > > > > > > > > > > > > > > > > The release candidate: > > > > > > > > >
Re: [VOTE] Release Apache Fury(incubating) v0.5.0-rc3
+1 binding Please remember to update the installation page, replace the current content with the first Apache release, and remove all the prior releases refs, once this release is concluded. Otherwise, if you'd like to keep the refs to prior releases, make it clear that they are not Apache releases. I checked: [x] Download Fury is valid. [x] Checksums and PGP signatures are valid. apache-fury-incubating-0.5.0-src.tar.gz gpg: Signature made 三 4/17 23:49:45 2024 CST gpg:using RSA key 1E2CDAE4C08AD7D694D1CB139D7BE8E45E580BA4 gpg: Good signature from "chaokunyang (CODE SIGNING KEY) < chaokuny...@apache.org>" [unknown] gpg: WARNING: This key is not certified with a trusted signature! gpg: There is no indication that the signature belongs to the owner. Primary key fingerprint: 1E2C DAE4 C08A D7D6 94D1 CB13 9D7B E8E4 5E58 0BA4 [x] Source code distributions have correct names matching the current release. [x] LICENSE, NOTICE, and DISCLAIMER files are correct. [x] All files have license headers if necessary. [x] No compiled archives bundled in source archive. [x] Build from source: # work on macOS M2 & JDK 22 cd java mvn clean install -DskipTests=true # work on macOS M2 & nightly toolchain cd rust cargo test Best, tison. tison 于2024年4月23日周二 19:44写道： > > I would be very disappointed if the podling published the code > > *knowing* that the download page is missing or incorrect. > > IIUC Fury will update the content and delete all the references to prior > releases. > > Or instead, Fury can keep these references and state clearly it's prior > releases. > > My comment above is with an assumption that prior releases ref will be > removed. But if the PPMC wants to keep it, they should update the > description. > > Best, > tison. > > > sebb 于2024年4月23日周二 19:35写道： > >> On Tue, 23 Apr 2024 at 09:42, tison wrote: >> > >> > > There is no indication that 0.4.1 is not an ASF release. >> > >> > You may found that the group id is not org.apache.fury also. >> >> Whilst this is true, it is still not obvious that this is not an ASF >> release; it is easy to overlook this minor detail. >> >> Indeed, there is no such indication for the GoLang, Javascript or Rust >> binaries. >> >> > This is an intermediate state that we would update the content as: >> > >> > >> > org.apache.fury >> > fury-core >> > 0.5.0 >> > >> > >> > And then the content is correct. >> >> Strictly speaking the content of the Maven reference to 0.4.1 is not >> 'incorrect'. >> The problem is that the page does not make it clear that the release >> is not an ASF release. >> >> It's OK to refer to prior releases, but the reader must be clearly >> informed of their provenance. >> >> > If we make any workaround or patch to make >> > it "look good", it would be updated as soon as 0.5.0 is released. So I >> > won't treat that as a release blocker. >> >> I would be very disappointed if the podling published the code >> *knowing* that the download page is missing or incorrect. >> >> > Best, >> > tison. >> > >> > >> > sebb 于2024年4月23日周二 15:59写道： >> > >> > > On Mon, 22 Apr 2024 at 10:11, PJ Fanning >> wrote: >> > > > >> > > > Hi Sebb, >> > > > This email thread is a vote for an RC. If this vote passes, v0.5.0 >> > > > will be the first release of Fury since it became a podling. >> > > > We will add a download page but at the moment, there is nothing to >> > > > link to there (except perhaps a KEYS file). >> > > > >> > > > The Install page does need to be updated to not mention snapshots. >> > > >> > > If 0.5.0 is to be the first ASF release, then the Install page is very >> > > misleading. >> > > >> > > There is no indication that 0.4.1 is not an ASF release. >> > > >> > > > Thanks, >> > > > PJ >> > > > >> > > > On Mon, 22 Apr 2024 at 10:35, sebb wrote: >> > > > > >> > > > > On Sat, 20 Apr 2024 at 16:26, Shawn Yang > > >> > > wrote: >> > > > > > >> > > > > > Hello everyone, >> > > > > > >> > > > > > This is a call for the vote to release Apache Fury(Incubating) >> > > v0.5.0-rc3. >> > > > > > >> > > > > > The Apache Fury community has voted and approved the release of >> > > Apache >> > > > > > Fury(incubating) v0.5.0-rc3. We now kindly request the IPMC >> members >> > > > > > review and vote for this release. >> > > > > > >> > > > > > Apache Fury(incubating) - A blazingly fast multi-language >> > > serialization >> > > > > > framework powered by JIT and zero-copy. >> > > > > > >> > > > > > Fury community vote thread: >> > > > > > >> https://lists.apache.org/thread/g49qt1v99d0ncfvonng39lcs1s56m7v5 >> > > > > > >> > > > > > Vote result thread: >> > > > > > >> https://lists.apache.org/thread/9rtl03g650pojyfb5d67785tffyo4hbs >> > > > > > >> > > > > > The release candidate: >> > > > > > >> https://dist.apache.org/repos/dist/dev/incubator/fury/0.5.0-rc3/ >> > > > > > >> > > > > > This release has been signed with a PGP available here: >> > > > > > https://downloads.apache.org/incubator/fury/KEYS >> > > > > > >> > > > > >> > > > >
Re: [VOTE] Release Apache Fury(incubating) v0.5.0-rc3
On Tue, 23 Apr 2024 at 12:46, tison wrote: > > > I would be very disappointed if the podling published the code > > *knowing* that the download page is missing or incorrect. > > IIUC Fury will update the content and delete all the references to prior > releases. Note that the page needs more than just an update to version numbers. It needs closer.lua links to the source bundle, links to KEYS, sigs and hashes, and verification instrructions. > Or instead, Fury can keep these references and state clearly it's prior > releases. > > My comment above is with an assumption that prior releases ref will be > removed. But if the PPMC wants to keep it, they should update the > description. They could fix the page now, while waiting for the release vote to complete. > Best, > tison. > > > sebb 于2024年4月23日周二 19:35写道： > > > On Tue, 23 Apr 2024 at 09:42, tison wrote: > > > > > > > There is no indication that 0.4.1 is not an ASF release. > > > > > > You may found that the group id is not org.apache.fury also. > > > > Whilst this is true, it is still not obvious that this is not an ASF > > release; it is easy to overlook this minor detail. > > > > Indeed, there is no such indication for the GoLang, Javascript or Rust > > binaries. > > > > > This is an intermediate state that we would update the content as: > > > > > > > > > org.apache.fury > > > fury-core > > > 0.5.0 > > > > > > > > > And then the content is correct. > > > > Strictly speaking the content of the Maven reference to 0.4.1 is not > > 'incorrect'. > > The problem is that the page does not make it clear that the release > > is not an ASF release. > > > > It's OK to refer to prior releases, but the reader must be clearly > > informed of their provenance. > > > > > If we make any workaround or patch to make > > > it "look good", it would be updated as soon as 0.5.0 is released. So I > > > won't treat that as a release blocker. > > > > I would be very disappointed if the podling published the code > > *knowing* that the download page is missing or incorrect. > > > > > Best, > > > tison. > > > > > > > > > sebb 于2024年4月23日周二 15:59写道： > > > > > > > On Mon, 22 Apr 2024 at 10:11, PJ Fanning wrote: > > > > > > > > > > Hi Sebb, > > > > > This email thread is a vote for an RC. If this vote passes, v0.5.0 > > > > > will be the first release of Fury since it became a podling. > > > > > We will add a download page but at the moment, there is nothing to > > > > > link to there (except perhaps a KEYS file). > > > > > > > > > > The Install page does need to be updated to not mention snapshots. > > > > > > > > If 0.5.0 is to be the first ASF release, then the Install page is very > > > > misleading. > > > > > > > > There is no indication that 0.4.1 is not an ASF release. > > > > > > > > > Thanks, > > > > > PJ > > > > > > > > > > On Mon, 22 Apr 2024 at 10:35, sebb wrote: > > > > > > > > > > > > On Sat, 20 Apr 2024 at 16:26, Shawn Yang > > > > wrote: > > > > > > > > > > > > > > Hello everyone, > > > > > > > > > > > > > > This is a call for the vote to release Apache Fury(Incubating) > > > > v0.5.0-rc3. > > > > > > > > > > > > > > The Apache Fury community has voted and approved the release of > > > > Apache > > > > > > > Fury(incubating) v0.5.0-rc3. We now kindly request the IPMC > > members > > > > > > > review and vote for this release. > > > > > > > > > > > > > > Apache Fury(incubating) - A blazingly fast multi-language > > > > serialization > > > > > > > framework powered by JIT and zero-copy. > > > > > > > > > > > > > > Fury community vote thread: > > > > > > > https://lists.apache.org/thread/g49qt1v99d0ncfvonng39lcs1s56m7v5 > > > > > > > > > > > > > > Vote result thread: > > > > > > > https://lists.apache.org/thread/9rtl03g650pojyfb5d67785tffyo4hbs > > > > > > > > > > > > > > The release candidate: > > > > > > > https://dist.apache.org/repos/dist/dev/incubator/fury/0.5.0-rc3/ > > > > > > > > > > > > > > This release has been signed with a PGP available here: > > > > > > > https://downloads.apache.org/incubator/fury/KEYS > > > > > > > > > > > > > > > > > > > I could not find a proper download page for the release. > > > > > > This must have links to the source bundle which must use > > closer.lua, > > > > > > as well as links to KEYS, sigs and hashes, with instructions on > > how to > > > > > > validate downloads. > > > > > > > > > > > > There is an install page on the website at > > > > > > https://fury.apache.org/docs/start/install, but that does not > > link to > > > > > > any source bundle. > > > > > > > > > > > > Furthermore, the install page links to nightly snapshots; this is > > not > > > > > > allowed except on a page intended for Fury developers, who should > > be > > > > > > made aware that nightly code has not been vetted. > > > > > > > > > > > > > Git tag for the release: > > > > > > > https://github.com/apache/incubator-fury/releases/tag/v0.5.0-rc3 > > > > > > > > > > > > > > Git commit for the release: > > > > > > > > > > > > >
Re: [VOTE] Release Apache Fury(incubating) v0.5.0-rc3
> I would be very disappointed if the podling published the code > *knowing* that the download page is missing or incorrect. IIUC Fury will update the content and delete all the references to prior releases. Or instead, Fury can keep these references and state clearly it's prior releases. My comment above is with an assumption that prior releases ref will be removed. But if the PPMC wants to keep it, they should update the description. Best, tison. sebb 于2024年4月23日周二 19:35写道： > On Tue, 23 Apr 2024 at 09:42, tison wrote: > > > > > There is no indication that 0.4.1 is not an ASF release. > > > > You may found that the group id is not org.apache.fury also. > > Whilst this is true, it is still not obvious that this is not an ASF > release; it is easy to overlook this minor detail. > > Indeed, there is no such indication for the GoLang, Javascript or Rust > binaries. > > > This is an intermediate state that we would update the content as: > > > > > > org.apache.fury > > fury-core > > 0.5.0 > > > > > > And then the content is correct. > > Strictly speaking the content of the Maven reference to 0.4.1 is not > 'incorrect'. > The problem is that the page does not make it clear that the release > is not an ASF release. > > It's OK to refer to prior releases, but the reader must be clearly > informed of their provenance. > > > If we make any workaround or patch to make > > it "look good", it would be updated as soon as 0.5.0 is released. So I > > won't treat that as a release blocker. > > I would be very disappointed if the podling published the code > *knowing* that the download page is missing or incorrect. > > > Best, > > tison. > > > > > > sebb 于2024年4月23日周二 15:59写道： > > > > > On Mon, 22 Apr 2024 at 10:11, PJ Fanning wrote: > > > > > > > > Hi Sebb, > > > > This email thread is a vote for an RC. If this vote passes, v0.5.0 > > > > will be the first release of Fury since it became a podling. > > > > We will add a download page but at the moment, there is nothing to > > > > link to there (except perhaps a KEYS file). > > > > > > > > The Install page does need to be updated to not mention snapshots. > > > > > > If 0.5.0 is to be the first ASF release, then the Install page is very > > > misleading. > > > > > > There is no indication that 0.4.1 is not an ASF release. > > > > > > > Thanks, > > > > PJ > > > > > > > > On Mon, 22 Apr 2024 at 10:35, sebb wrote: > > > > > > > > > > On Sat, 20 Apr 2024 at 16:26, Shawn Yang > > > wrote: > > > > > > > > > > > > Hello everyone, > > > > > > > > > > > > This is a call for the vote to release Apache Fury(Incubating) > > > v0.5.0-rc3. > > > > > > > > > > > > The Apache Fury community has voted and approved the release of > > > Apache > > > > > > Fury(incubating) v0.5.0-rc3. We now kindly request the IPMC > members > > > > > > review and vote for this release. > > > > > > > > > > > > Apache Fury(incubating) - A blazingly fast multi-language > > > serialization > > > > > > framework powered by JIT and zero-copy. > > > > > > > > > > > > Fury community vote thread: > > > > > > https://lists.apache.org/thread/g49qt1v99d0ncfvonng39lcs1s56m7v5 > > > > > > > > > > > > Vote result thread: > > > > > > https://lists.apache.org/thread/9rtl03g650pojyfb5d67785tffyo4hbs > > > > > > > > > > > > The release candidate: > > > > > > https://dist.apache.org/repos/dist/dev/incubator/fury/0.5.0-rc3/ > > > > > > > > > > > > This release has been signed with a PGP available here: > > > > > > https://downloads.apache.org/incubator/fury/KEYS > > > > > > > > > > > > > > > > I could not find a proper download page for the release. > > > > > This must have links to the source bundle which must use > closer.lua, > > > > > as well as links to KEYS, sigs and hashes, with instructions on > how to > > > > > validate downloads. > > > > > > > > > > There is an install page on the website at > > > > > https://fury.apache.org/docs/start/install, but that does not > link to > > > > > any source bundle. > > > > > > > > > > Furthermore, the install page links to nightly snapshots; this is > not > > > > > allowed except on a page intended for Fury developers, who should > be > > > > > made aware that nightly code has not been vetted. > > > > > > > > > > > Git tag for the release: > > > > > > https://github.com/apache/incubator-fury/releases/tag/v0.5.0-rc3 > > > > > > > > > > > > Git commit for the release: > > > > > > > > > > https://github.com/apache/incubator-fury/commit/fae06330edd049bb960536e978a45b97bca66faf > > > > > > > > > > > > Maven staging repo: > > > > > > > > > https://repository.apache.org/content/repositories/orgapachefury-1003 > > > > > > > > > > > > How to Build and Test, please refer to: > > > > > > > > > > https://github.com/apache/incubator-fury/blob/main/docs/guide/DEVELOPMENT.md > > > > > > > > > > > > The vote will be open for at least 72 hours or until the > necessary > > > number > > > > > > of votes is reached. > > > > > > > > > > > > Please vote accordingly: > > > > > > > > >
Re: [VOTE] Release Apache Fury(incubating) v0.5.0-rc3
On Tue, 23 Apr 2024 at 09:42, tison wrote: > > > There is no indication that 0.4.1 is not an ASF release. > > You may found that the group id is not org.apache.fury also. Whilst this is true, it is still not obvious that this is not an ASF release; it is easy to overlook this minor detail. Indeed, there is no such indication for the GoLang, Javascript or Rust binaries. > This is an intermediate state that we would update the content as: > > > org.apache.fury > fury-core > 0.5.0 > > > And then the content is correct. Strictly speaking the content of the Maven reference to 0.4.1 is not 'incorrect'. The problem is that the page does not make it clear that the release is not an ASF release. It's OK to refer to prior releases, but the reader must be clearly informed of their provenance. > If we make any workaround or patch to make > it "look good", it would be updated as soon as 0.5.0 is released. So I > won't treat that as a release blocker. I would be very disappointed if the podling published the code *knowing* that the download page is missing or incorrect. > Best, > tison. > > > sebb 于2024年4月23日周二 15:59写道： > > > On Mon, 22 Apr 2024 at 10:11, PJ Fanning wrote: > > > > > > Hi Sebb, > > > This email thread is a vote for an RC. If this vote passes, v0.5.0 > > > will be the first release of Fury since it became a podling. > > > We will add a download page but at the moment, there is nothing to > > > link to there (except perhaps a KEYS file). > > > > > > The Install page does need to be updated to not mention snapshots. > > > > If 0.5.0 is to be the first ASF release, then the Install page is very > > misleading. > > > > There is no indication that 0.4.1 is not an ASF release. > > > > > Thanks, > > > PJ > > > > > > On Mon, 22 Apr 2024 at 10:35, sebb wrote: > > > > > > > > On Sat, 20 Apr 2024 at 16:26, Shawn Yang > > wrote: > > > > > > > > > > Hello everyone, > > > > > > > > > > This is a call for the vote to release Apache Fury(Incubating) > > v0.5.0-rc3. > > > > > > > > > > The Apache Fury community has voted and approved the release of > > Apache > > > > > Fury(incubating) v0.5.0-rc3. We now kindly request the IPMC members > > > > > review and vote for this release. > > > > > > > > > > Apache Fury(incubating) - A blazingly fast multi-language > > serialization > > > > > framework powered by JIT and zero-copy. > > > > > > > > > > Fury community vote thread: > > > > > https://lists.apache.org/thread/g49qt1v99d0ncfvonng39lcs1s56m7v5 > > > > > > > > > > Vote result thread: > > > > > https://lists.apache.org/thread/9rtl03g650pojyfb5d67785tffyo4hbs > > > > > > > > > > The release candidate: > > > > > https://dist.apache.org/repos/dist/dev/incubator/fury/0.5.0-rc3/ > > > > > > > > > > This release has been signed with a PGP available here: > > > > > https://downloads.apache.org/incubator/fury/KEYS > > > > > > > > > > > > > I could not find a proper download page for the release. > > > > This must have links to the source bundle which must use closer.lua, > > > > as well as links to KEYS, sigs and hashes, with instructions on how to > > > > validate downloads. > > > > > > > > There is an install page on the website at > > > > https://fury.apache.org/docs/start/install, but that does not link to > > > > any source bundle. > > > > > > > > Furthermore, the install page links to nightly snapshots; this is not > > > > allowed except on a page intended for Fury developers, who should be > > > > made aware that nightly code has not been vetted. > > > > > > > > > Git tag for the release: > > > > > https://github.com/apache/incubator-fury/releases/tag/v0.5.0-rc3 > > > > > > > > > > Git commit for the release: > > > > > > > https://github.com/apache/incubator-fury/commit/fae06330edd049bb960536e978a45b97bca66faf > > > > > > > > > > Maven staging repo: > > > > > > > https://repository.apache.org/content/repositories/orgapachefury-1003 > > > > > > > > > > How to Build and Test, please refer to: > > > > > > > https://github.com/apache/incubator-fury/blob/main/docs/guide/DEVELOPMENT.md > > > > > > > > > > The vote will be open for at least 72 hours or until the necessary > > number > > > > > of votes is reached. > > > > > > > > > > Please vote accordingly: > > > > > > > > > > [ ] +1 approve > > > > > [ ] +0 no opinion > > > > > [ ] -1 disapprove with the reason > > > > > > > > > > To learn more about apache fury, please see https://fury.apache.org/ > > > > > > > > > > Checklist for reference: > > > > > > > > > > [ ] Download links are valid. > > > > > [ ] Checksums and signatures. > > > > > [ ] LICENSE/NOTICE files exist > > > > > [ ] No unexpected binary files > > > > > [ ] All source files have ASF headers > > > > > [ ] Can compile from source > > > > > > > > > > > > > > > Thanks, > > > > > > > > > > Chaokun Yang > > > > > > > > - > > > > To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org > > > > For additional commands,
Re: [VOTE] Release Apache Fury(incubating) v0.5.0-rc3
> There is no indication that 0.4.1 is not an ASF release. You may found that the group id is not org.apache.fury also. This is an intermediate state that we would update the content as: org.apache.fury fury-core 0.5.0 And then the content is correct. If we make any workaround or patch to make it "look good", it would be updated as soon as 0.5.0 is released. So I won't treat that as a release blocker. Best, tison. sebb 于2024年4月23日周二 15:59写道： > On Mon, 22 Apr 2024 at 10:11, PJ Fanning wrote: > > > > Hi Sebb, > > This email thread is a vote for an RC. If this vote passes, v0.5.0 > > will be the first release of Fury since it became a podling. > > We will add a download page but at the moment, there is nothing to > > link to there (except perhaps a KEYS file). > > > > The Install page does need to be updated to not mention snapshots. > > If 0.5.0 is to be the first ASF release, then the Install page is very > misleading. > > There is no indication that 0.4.1 is not an ASF release. > > > Thanks, > > PJ > > > > On Mon, 22 Apr 2024 at 10:35, sebb wrote: > > > > > > On Sat, 20 Apr 2024 at 16:26, Shawn Yang > wrote: > > > > > > > > Hello everyone, > > > > > > > > This is a call for the vote to release Apache Fury(Incubating) > v0.5.0-rc3. > > > > > > > > The Apache Fury community has voted and approved the release of > Apache > > > > Fury(incubating) v0.5.0-rc3. We now kindly request the IPMC members > > > > review and vote for this release. > > > > > > > > Apache Fury(incubating) - A blazingly fast multi-language > serialization > > > > framework powered by JIT and zero-copy. > > > > > > > > Fury community vote thread: > > > > https://lists.apache.org/thread/g49qt1v99d0ncfvonng39lcs1s56m7v5 > > > > > > > > Vote result thread: > > > > https://lists.apache.org/thread/9rtl03g650pojyfb5d67785tffyo4hbs > > > > > > > > The release candidate: > > > > https://dist.apache.org/repos/dist/dev/incubator/fury/0.5.0-rc3/ > > > > > > > > This release has been signed with a PGP available here: > > > > https://downloads.apache.org/incubator/fury/KEYS > > > > > > > > > > I could not find a proper download page for the release. > > > This must have links to the source bundle which must use closer.lua, > > > as well as links to KEYS, sigs and hashes, with instructions on how to > > > validate downloads. > > > > > > There is an install page on the website at > > > https://fury.apache.org/docs/start/install, but that does not link to > > > any source bundle. > > > > > > Furthermore, the install page links to nightly snapshots; this is not > > > allowed except on a page intended for Fury developers, who should be > > > made aware that nightly code has not been vetted. > > > > > > > Git tag for the release: > > > > https://github.com/apache/incubator-fury/releases/tag/v0.5.0-rc3 > > > > > > > > Git commit for the release: > > > > > https://github.com/apache/incubator-fury/commit/fae06330edd049bb960536e978a45b97bca66faf > > > > > > > > Maven staging repo: > > > > > https://repository.apache.org/content/repositories/orgapachefury-1003 > > > > > > > > How to Build and Test, please refer to: > > > > > https://github.com/apache/incubator-fury/blob/main/docs/guide/DEVELOPMENT.md > > > > > > > > The vote will be open for at least 72 hours or until the necessary > number > > > > of votes is reached. > > > > > > > > Please vote accordingly: > > > > > > > > [ ] +1 approve > > > > [ ] +0 no opinion > > > > [ ] -1 disapprove with the reason > > > > > > > > To learn more about apache fury, please see https://fury.apache.org/ > > > > > > > > Checklist for reference: > > > > > > > > [ ] Download links are valid. > > > > [ ] Checksums and signatures. > > > > [ ] LICENSE/NOTICE files exist > > > > [ ] No unexpected binary files > > > > [ ] All source files have ASF headers > > > > [ ] Can compile from source > > > > > > > > > > > > Thanks, > > > > > > > > Chaokun Yang > > > > > > - > > > To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org > > > For additional commands, e-mail: general-h...@incubator.apache.org > > > > > > > - > > To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org > > For additional commands, e-mail: general-h...@incubator.apache.org > > > > - > To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org > For additional commands, e-mail: general-h...@incubator.apache.org > >
Re: [VOTE] Release Apache Fury(incubating) v0.5.0-rc3
On Mon, 22 Apr 2024 at 10:11, PJ Fanning wrote: > > Hi Sebb, > This email thread is a vote for an RC. If this vote passes, v0.5.0 > will be the first release of Fury since it became a podling. > We will add a download page but at the moment, there is nothing to > link to there (except perhaps a KEYS file). > > The Install page does need to be updated to not mention snapshots. If 0.5.0 is to be the first ASF release, then the Install page is very misleading. There is no indication that 0.4.1 is not an ASF release. > Thanks, > PJ > > On Mon, 22 Apr 2024 at 10:35, sebb wrote: > > > > On Sat, 20 Apr 2024 at 16:26, Shawn Yang wrote: > > > > > > Hello everyone, > > > > > > This is a call for the vote to release Apache Fury(Incubating) v0.5.0-rc3. > > > > > > The Apache Fury community has voted and approved the release of Apache > > > Fury(incubating) v0.5.0-rc3. We now kindly request the IPMC members > > > review and vote for this release. > > > > > > Apache Fury(incubating) - A blazingly fast multi-language serialization > > > framework powered by JIT and zero-copy. > > > > > > Fury community vote thread: > > > https://lists.apache.org/thread/g49qt1v99d0ncfvonng39lcs1s56m7v5 > > > > > > Vote result thread: > > > https://lists.apache.org/thread/9rtl03g650pojyfb5d67785tffyo4hbs > > > > > > The release candidate: > > > https://dist.apache.org/repos/dist/dev/incubator/fury/0.5.0-rc3/ > > > > > > This release has been signed with a PGP available here: > > > https://downloads.apache.org/incubator/fury/KEYS > > > > > > > I could not find a proper download page for the release. > > This must have links to the source bundle which must use closer.lua, > > as well as links to KEYS, sigs and hashes, with instructions on how to > > validate downloads. > > > > There is an install page on the website at > > https://fury.apache.org/docs/start/install, but that does not link to > > any source bundle. > > > > Furthermore, the install page links to nightly snapshots; this is not > > allowed except on a page intended for Fury developers, who should be > > made aware that nightly code has not been vetted. > > > > > Git tag for the release: > > > https://github.com/apache/incubator-fury/releases/tag/v0.5.0-rc3 > > > > > > Git commit for the release: > > > https://github.com/apache/incubator-fury/commit/fae06330edd049bb960536e978a45b97bca66faf > > > > > > Maven staging repo: > > > https://repository.apache.org/content/repositories/orgapachefury-1003 > > > > > > How to Build and Test, please refer to: > > > https://github.com/apache/incubator-fury/blob/main/docs/guide/DEVELOPMENT.md > > > > > > The vote will be open for at least 72 hours or until the necessary number > > > of votes is reached. > > > > > > Please vote accordingly: > > > > > > [ ] +1 approve > > > [ ] +0 no opinion > > > [ ] -1 disapprove with the reason > > > > > > To learn more about apache fury, please see https://fury.apache.org/ > > > > > > Checklist for reference: > > > > > > [ ] Download links are valid. > > > [ ] Checksums and signatures. > > > [ ] LICENSE/NOTICE files exist > > > [ ] No unexpected binary files > > > [ ] All source files have ASF headers > > > [ ] Can compile from source > > > > > > > > > Thanks, > > > > > > Chaokun Yang > > > > - > > To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org > > For additional commands, e-mail: general-h...@incubator.apache.org > > > > - > To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org > For additional commands, e-mail: general-h...@incubator.apache.org > - To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org For additional commands, e-mail: general-h...@incubator.apache.org
Re: [VOTE] Release Apache Fury(incubating) v0.5.0-rc3
Hi Sebb, Thanks for reviewing the Fury release. You are right that the snapshot packages should not be included in the project website according to the apache release policy[1]. I created a PR[2] to fix this. It won't block this vote. For download pages, as PJ said, we haven't released Fury since it became a podling. So we didn't add download pages yet. If this vote passes, we will add download pages later according to the release-download-pages document, which is your suggestion too. 1. https://www.apache.org/legal/release-policy.html#what 2. https://github.com/apache/incubator-fury-site/pull/111/ 3. https://infra.apache.org/release-download-pages.html On Mon, Apr 22, 2024 at 4:35 PM sebb wrote: > On Sat, 20 Apr 2024 at 16:26, Shawn Yang wrote: > > > > Hello everyone, > > > > This is a call for the vote to release Apache Fury(Incubating) > v0.5.0-rc3. > > > > The Apache Fury community has voted and approved the release of Apache > > Fury(incubating) v0.5.0-rc3. We now kindly request the IPMC members > > review and vote for this release. > > > > Apache Fury(incubating) - A blazingly fast multi-language serialization > > framework powered by JIT and zero-copy. > > > > Fury community vote thread: > > https://lists.apache.org/thread/g49qt1v99d0ncfvonng39lcs1s56m7v5 > > > > Vote result thread: > > https://lists.apache.org/thread/9rtl03g650pojyfb5d67785tffyo4hbs > > > > The release candidate: > > https://dist.apache.org/repos/dist/dev/incubator/fury/0.5.0-rc3/ > > > > This release has been signed with a PGP available here: > > https://downloads.apache.org/incubator/fury/KEYS > > > > I could not find a proper download page for the release. > This must have links to the source bundle which must use closer.lua, > as well as links to KEYS, sigs and hashes, with instructions on how to > validate downloads. > > There is an install page on the website at > https://fury.apache.org/docs/start/install, but that does not link to > any source bundle. > > Furthermore, the install page links to nightly snapshots; this is not > allowed except on a page intended for Fury developers, who should be > made aware that nightly code has not been vetted. > > > Git tag for the release: > > https://github.com/apache/incubator-fury/releases/tag/v0.5.0-rc3 > > > > Git commit for the release: > > > https://github.com/apache/incubator-fury/commit/fae06330edd049bb960536e978a45b97bca66faf > > > > Maven staging repo: > > https://repository.apache.org/content/repositories/orgapachefury-1003 > > > > How to Build and Test, please refer to: > > > https://github.com/apache/incubator-fury/blob/main/docs/guide/DEVELOPMENT.md > > > > The vote will be open for at least 72 hours or until the necessary number > > of votes is reached. > > > > Please vote accordingly: > > > > [ ] +1 approve > > [ ] +0 no opinion > > [ ] -1 disapprove with the reason > > > > To learn more about apache fury, please see https://fury.apache.org/ > > > > Checklist for reference: > > > > [ ] Download links are valid. > > [ ] Checksums and signatures. > > [ ] LICENSE/NOTICE files exist > > [ ] No unexpected binary files > > [ ] All source files have ASF headers > > [ ] Can compile from source > > > > > > Thanks, > > > > Chaokun Yang > > - > To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org > For additional commands, e-mail: general-h...@incubator.apache.org > >
Re: [VOTE] Release Apache Fury(incubating) v0.5.0-rc3
Hi Suyan, Thanks for reviewing Fury release and the suggestions. We will update our build document to give a more detailed environment requirements later. On Monday, April 22, 2024, Suyan wrote: > +1 non-binding > Apache ID: suyanhanx > > I checked: > > [x] Download links are valid. > [x] Checksums and signaturesgpg: Signature made Wed Apr 17 23:49:45 2024 > CST > gpg:using RSA key 1E2CDAE4C08AD7D694D1CB139D7BE8E45E580BA4 > gpg: checking the trustdb > gpg: marginals needed: 3 completes needed: 1 trust model: pgp > gpg: depth: 0 valid: 22 signed: 0 trust: 0-, 0q, 0n, 0m, 0f, 22u > gpg: next trustdb check due at 2024-05-25 > gpg: Good signature from "chaokunyang (CODE SIGNING KEY) > " [ultimate]. > > [x] LICENSE/NOTICE files exist > [x] No unexpected binary files > [x] All source files have ASF headers > [x] Can compile from source > > I built packages for three languages, java, javaScript, and rust.They > all finished fine. > > But when I was compiling the javascript package since you are using > node-gyp, > it also relies on a specific range of versions of Python. > My local Python version is newer, which gave me some unexpected > dependency issues. > You guys might want to give more explicit guidance on environment > requirements. > > refs: > - https://github.com/nodejs/node-gyp/issues/2869 > > Sincerely, > Suyan > > Shawn Yang 于2024年4月20日周六 23:26写道： > > > > Hello everyone, > > > > This is a call for the vote to release Apache Fury(Incubating) > v0.5.0-rc3. > > > > The Apache Fury community has voted and approved the release of Apache > > Fury(incubating) v0.5.0-rc3. We now kindly request the IPMC members > > review and vote for this release. > > > > Apache Fury(incubating) - A blazingly fast multi-language serialization > > framework powered by JIT and zero-copy. > > > > Fury community vote thread: > > https://lists.apache.org/thread/g49qt1v99d0ncfvonng39lcs1s56m7v5 > > > > Vote result thread: > > https://lists.apache.org/thread/9rtl03g650pojyfb5d67785tffyo4hbs > > > > The release candidate: > > https://dist.apache.org/repos/dist/dev/incubator/fury/0.5.0-rc3/ > > > > This release has been signed with a PGP available here: > > https://downloads.apache.org/incubator/fury/KEYS > > > > Git tag for the release: > > https://github.com/apache/incubator-fury/releases/tag/v0.5.0-rc3 > > > > Git commit for the release: > > https://github.com/apache/incubator-fury/commit/ > fae06330edd049bb960536e978a45b97bca66faf > > > > Maven staging repo: > > https://repository.apache.org/content/repositories/orgapachefury-1003 > > > > How to Build and Test, please refer to: > > https://github.com/apache/incubator-fury/blob/main/docs/ > guide/DEVELOPMENT.md > > > > The vote will be open for at least 72 hours or until the necessary number > > of votes is reached. > > > > Please vote accordingly: > > > > [ ] +1 approve > > [ ] +0 no opinion > > [ ] -1 disapprove with the reason > > > > To learn more about apache fury, please see https://fury.apache.org/ > > > > Checklist for reference: > > > > [ ] Download links are valid. > > [ ] Checksums and signatures. > > [ ] LICENSE/NOTICE files exist > > [ ] No unexpected binary files > > [ ] All source files have ASF headers > > [ ] Can compile from source > > > > > > Thanks, > > > > Chaokun Yang > > - > To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org > For additional commands, e-mail: general-h...@incubator.apache.org > >
Re: [VOTE] Release Apache Fury(incubating) v0.5.0-rc3
Hi Sebb, This email thread is a vote for an RC. If this vote passes, v0.5.0 will be the first release of Fury since it became a podling. We will add a download page but at the moment, there is nothing to link to there (except perhaps a KEYS file). The Install page does need to be updated to not mention snapshots. Thanks, PJ On Mon, 22 Apr 2024 at 10:35, sebb wrote: > > On Sat, 20 Apr 2024 at 16:26, Shawn Yang wrote: > > > > Hello everyone, > > > > This is a call for the vote to release Apache Fury(Incubating) v0.5.0-rc3. > > > > The Apache Fury community has voted and approved the release of Apache > > Fury(incubating) v0.5.0-rc3. We now kindly request the IPMC members > > review and vote for this release. > > > > Apache Fury(incubating) - A blazingly fast multi-language serialization > > framework powered by JIT and zero-copy. > > > > Fury community vote thread: > > https://lists.apache.org/thread/g49qt1v99d0ncfvonng39lcs1s56m7v5 > > > > Vote result thread: > > https://lists.apache.org/thread/9rtl03g650pojyfb5d67785tffyo4hbs > > > > The release candidate: > > https://dist.apache.org/repos/dist/dev/incubator/fury/0.5.0-rc3/ > > > > This release has been signed with a PGP available here: > > https://downloads.apache.org/incubator/fury/KEYS > > > > I could not find a proper download page for the release. > This must have links to the source bundle which must use closer.lua, > as well as links to KEYS, sigs and hashes, with instructions on how to > validate downloads. > > There is an install page on the website at > https://fury.apache.org/docs/start/install, but that does not link to > any source bundle. > > Furthermore, the install page links to nightly snapshots; this is not > allowed except on a page intended for Fury developers, who should be > made aware that nightly code has not been vetted. > > > Git tag for the release: > > https://github.com/apache/incubator-fury/releases/tag/v0.5.0-rc3 > > > > Git commit for the release: > > https://github.com/apache/incubator-fury/commit/fae06330edd049bb960536e978a45b97bca66faf > > > > Maven staging repo: > > https://repository.apache.org/content/repositories/orgapachefury-1003 > > > > How to Build and Test, please refer to: > > https://github.com/apache/incubator-fury/blob/main/docs/guide/DEVELOPMENT.md > > > > The vote will be open for at least 72 hours or until the necessary number > > of votes is reached. > > > > Please vote accordingly: > > > > [ ] +1 approve > > [ ] +0 no opinion > > [ ] -1 disapprove with the reason > > > > To learn more about apache fury, please see https://fury.apache.org/ > > > > Checklist for reference: > > > > [ ] Download links are valid. > > [ ] Checksums and signatures. > > [ ] LICENSE/NOTICE files exist > > [ ] No unexpected binary files > > [ ] All source files have ASF headers > > [ ] Can compile from source > > > > > > Thanks, > > > > Chaokun Yang > > - > To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org > For additional commands, e-mail: general-h...@incubator.apache.org > - To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org For additional commands, e-mail: general-h...@incubator.apache.org
Re: [VOTE] Release Apache Fury(incubating) v0.5.0-rc3
On Sat, 20 Apr 2024 at 16:26, Shawn Yang wrote: > > Hello everyone, > > This is a call for the vote to release Apache Fury(Incubating) v0.5.0-rc3. > > The Apache Fury community has voted and approved the release of Apache > Fury(incubating) v0.5.0-rc3. We now kindly request the IPMC members > review and vote for this release. > > Apache Fury(incubating) - A blazingly fast multi-language serialization > framework powered by JIT and zero-copy. > > Fury community vote thread: > https://lists.apache.org/thread/g49qt1v99d0ncfvonng39lcs1s56m7v5 > > Vote result thread: > https://lists.apache.org/thread/9rtl03g650pojyfb5d67785tffyo4hbs > > The release candidate: > https://dist.apache.org/repos/dist/dev/incubator/fury/0.5.0-rc3/ > > This release has been signed with a PGP available here: > https://downloads.apache.org/incubator/fury/KEYS > I could not find a proper download page for the release. This must have links to the source bundle which must use closer.lua, as well as links to KEYS, sigs and hashes, with instructions on how to validate downloads. There is an install page on the website at https://fury.apache.org/docs/start/install, but that does not link to any source bundle. Furthermore, the install page links to nightly snapshots; this is not allowed except on a page intended for Fury developers, who should be made aware that nightly code has not been vetted. > Git tag for the release: > https://github.com/apache/incubator-fury/releases/tag/v0.5.0-rc3 > > Git commit for the release: > https://github.com/apache/incubator-fury/commit/fae06330edd049bb960536e978a45b97bca66faf > > Maven staging repo: > https://repository.apache.org/content/repositories/orgapachefury-1003 > > How to Build and Test, please refer to: > https://github.com/apache/incubator-fury/blob/main/docs/guide/DEVELOPMENT.md > > The vote will be open for at least 72 hours or until the necessary number > of votes is reached. > > Please vote accordingly: > > [ ] +1 approve > [ ] +0 no opinion > [ ] -1 disapprove with the reason > > To learn more about apache fury, please see https://fury.apache.org/ > > Checklist for reference: > > [ ] Download links are valid. > [ ] Checksums and signatures. > [ ] LICENSE/NOTICE files exist > [ ] No unexpected binary files > [ ] All source files have ASF headers > [ ] Can compile from source > > > Thanks, > > Chaokun Yang - To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org For additional commands, e-mail: general-h...@incubator.apache.org
Re: [VOTE] Release Apache Fury(incubating) v0.5.0-rc3
+1 non-binding Apache ID: suyanhanx I checked: [x] Download links are valid. [x] Checksums and signaturesgpg: Signature made Wed Apr 17 23:49:45 2024 CST gpg:using RSA key 1E2CDAE4C08AD7D694D1CB139D7BE8E45E580BA4 gpg: checking the trustdb gpg: marginals needed: 3 completes needed: 1 trust model: pgp gpg: depth: 0 valid: 22 signed: 0 trust: 0-, 0q, 0n, 0m, 0f, 22u gpg: next trustdb check due at 2024-05-25 gpg: Good signature from "chaokunyang (CODE SIGNING KEY) " [ultimate]. [x] LICENSE/NOTICE files exist [x] No unexpected binary files [x] All source files have ASF headers [x] Can compile from source I built packages for three languages, java, javaScript, and rust.They all finished fine. But when I was compiling the javascript package since you are using node-gyp, it also relies on a specific range of versions of Python. My local Python version is newer, which gave me some unexpected dependency issues. You guys might want to give more explicit guidance on environment requirements. refs: - https://github.com/nodejs/node-gyp/issues/2869 Sincerely, Suyan Shawn Yang 于2024年4月20日周六 23:26写道： > > Hello everyone, > > This is a call for the vote to release Apache Fury(Incubating) v0.5.0-rc3. > > The Apache Fury community has voted and approved the release of Apache > Fury(incubating) v0.5.0-rc3. We now kindly request the IPMC members > review and vote for this release. > > Apache Fury(incubating) - A blazingly fast multi-language serialization > framework powered by JIT and zero-copy. > > Fury community vote thread: > https://lists.apache.org/thread/g49qt1v99d0ncfvonng39lcs1s56m7v5 > > Vote result thread: > https://lists.apache.org/thread/9rtl03g650pojyfb5d67785tffyo4hbs > > The release candidate: > https://dist.apache.org/repos/dist/dev/incubator/fury/0.5.0-rc3/ > > This release has been signed with a PGP available here: > https://downloads.apache.org/incubator/fury/KEYS > > Git tag for the release: > https://github.com/apache/incubator-fury/releases/tag/v0.5.0-rc3 > > Git commit for the release: > https://github.com/apache/incubator-fury/commit/fae06330edd049bb960536e978a45b97bca66faf > > Maven staging repo: > https://repository.apache.org/content/repositories/orgapachefury-1003 > > How to Build and Test, please refer to: > https://github.com/apache/incubator-fury/blob/main/docs/guide/DEVELOPMENT.md > > The vote will be open for at least 72 hours or until the necessary number > of votes is reached. > > Please vote accordingly: > > [ ] +1 approve > [ ] +0 no opinion > [ ] -1 disapprove with the reason > > To learn more about apache fury, please see https://fury.apache.org/ > > Checklist for reference: > > [ ] Download links are valid. > [ ] Checksums and signatures. > [ ] LICENSE/NOTICE files exist > [ ] No unexpected binary files > [ ] All source files have ASF headers > [ ] Can compile from source > > > Thanks, > > Chaokun Yang - To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org For additional commands, e-mail: general-h...@incubator.apache.org
Re: [VOTE] Release Apache Fury(incubating) v0.5.0-rc3
+1 binding [x] Download links are valid. [x] Checksums and signatures. gpg: Signature made Wed 17 Apr 2024 11:49:45 PM CST gpg:using RSA key 1E2CDAE4C08AD7D694D1CB139D7BE8E45E580BA4 gpg: checking the trustdb gpg: marginals needed: 3 completes needed: 1 trust model: pgp gpg: depth: 0 valid: 26 signed: 0 trust: 0-, 0q, 0n, 0m, 0f, 26u gpg: next trustdb check due at 2024-05-25 gpg: Good signature from "chaokunyang (CODE SIGNING KEY) " [ultimate] apache-fury-incubating-0.5.0-src.tar.gz: OK [x] LICENSE/NOTICE files exist [x] No unexpected binary files [x] All source files have ASF headers [x] fury-rust can compile from source on archlinux x86-64 Finished dev [unoptimized + debuginfo] target(s) in 5.73s cargo b 6.96s user 0.77s system 133% cpu 5.784 total On Sat, Apr 20, 2024, at 23:25, Shawn Yang wrote: > Hello everyone, > > This is a call for the vote to release Apache Fury(Incubating) v0.5.0-rc3. > > The Apache Fury community has voted and approved the release of Apache > Fury(incubating) v0.5.0-rc3. We now kindly request the IPMC members > review and vote for this release. > > Apache Fury(incubating) - A blazingly fast multi-language serialization > framework powered by JIT and zero-copy. > > Fury community vote thread: > https://lists.apache.org/thread/g49qt1v99d0ncfvonng39lcs1s56m7v5 > > Vote result thread: > https://lists.apache.org/thread/9rtl03g650pojyfb5d67785tffyo4hbs > > The release candidate: > https://dist.apache.org/repos/dist/dev/incubator/fury/0.5.0-rc3/ > > This release has been signed with a PGP available here: > https://downloads.apache.org/incubator/fury/KEYS > > Git tag for the release: > https://github.com/apache/incubator-fury/releases/tag/v0.5.0-rc3 > > Git commit for the release: > https://github.com/apache/incubator-fury/commit/fae06330edd049bb960536e978a45b97bca66faf > > Maven staging repo: > https://repository.apache.org/content/repositories/orgapachefury-1003 > > How to Build and Test, please refer to: > https://github.com/apache/incubator-fury/blob/main/docs/guide/DEVELOPMENT.md > > The vote will be open for at least 72 hours or until the necessary number > of votes is reached. > > Please vote accordingly: > > [ ] +1 approve > [ ] +0 no opinion > [ ] -1 disapprove with the reason > > To learn more about apache fury, please see https://fury.apache.org/ > > Checklist for reference: > > [ ] Download links are valid. > [ ] Checksums and signatures. > [ ] LICENSE/NOTICE files exist > [ ] No unexpected binary files > [ ] All source files have ASF headers > [ ] Can compile from source > > > Thanks, > > Chaokun Yang -- Xuanwo - To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org For additional commands, e-mail: general-h...@incubator.apache.org
Re: [VOTE] Release Apache Fury(incubating) v0.5.0-rc3
+1. [x] Download Fury is valid. [x] Checksums and PGP signatures are valid. [x] Source code distributions have correct names matching the current release. [x] LICENSE and NOTICE files are correct. [x] All files have license headers if necessary. [x] No compiled archives bundled in source archive. [x] Can compile from source. PJ Fanning 于2024年4月20日周六 23:56写道： > +1 binding carried over from PPMC vote > > On Sat 20 Apr 2024, 17:26 Shawn Yang, wrote: > > > Hello everyone, > > > > This is a call for the vote to release Apache Fury(Incubating) > v0.5.0-rc3. > > > > The Apache Fury community has voted and approved the release of Apache > > Fury(incubating) v0.5.0-rc3. We now kindly request the IPMC members > > review and vote for this release. > > > > Apache Fury(incubating) - A blazingly fast multi-language serialization > > framework powered by JIT and zero-copy. > > > > Fury community vote thread: > > https://lists.apache.org/thread/g49qt1v99d0ncfvonng39lcs1s56m7v5 > > > > Vote result thread: > > https://lists.apache.org/thread/9rtl03g650pojyfb5d67785tffyo4hbs > > > > The release candidate: > > https://dist.apache.org/repos/dist/dev/incubator/fury/0.5.0-rc3/ > > > > This release has been signed with a PGP available here: > > https://downloads.apache.org/incubator/fury/KEYS > > > > Git tag for the release: > > https://github.com/apache/incubator-fury/releases/tag/v0.5.0-rc3 > > > > Git commit for the release: > > > > > https://github.com/apache/incubator-fury/commit/fae06330edd049bb960536e978a45b97bca66faf > > > > Maven staging repo: > > https://repository.apache.org/content/repositories/orgapachefury-1003 > > > > How to Build and Test, please refer to: > > > > > https://github.com/apache/incubator-fury/blob/main/docs/guide/DEVELOPMENT.md > > > > The vote will be open for at least 72 hours or until the necessary number > > of votes is reached. > > > > Please vote accordingly: > > > > [ ] +1 approve > > [ ] +0 no opinion > > [ ] -1 disapprove with the reason > > > > To learn more about apache fury, please see https://fury.apache.org/ > > > > Checklist for reference: > > > > [ ] Download links are valid. > > [ ] Checksums and signatures. > > [ ] LICENSE/NOTICE files exist > > [ ] No unexpected binary files > > [ ] All source files have ASF headers > > [ ] Can compile from source > > > > > > Thanks, > > > > Chaokun Yang > > > -- Thanks, Xin
Re: [VOTE] Release Apache Fury(incubating) v0.5.0-rc3
+1 binding carried over from PPMC vote On Sat 20 Apr 2024, 17:26 Shawn Yang, wrote: > Hello everyone, > > This is a call for the vote to release Apache Fury(Incubating) v0.5.0-rc3. > > The Apache Fury community has voted and approved the release of Apache > Fury(incubating) v0.5.0-rc3. We now kindly request the IPMC members > review and vote for this release. > > Apache Fury(incubating) - A blazingly fast multi-language serialization > framework powered by JIT and zero-copy. > > Fury community vote thread: > https://lists.apache.org/thread/g49qt1v99d0ncfvonng39lcs1s56m7v5 > > Vote result thread: > https://lists.apache.org/thread/9rtl03g650pojyfb5d67785tffyo4hbs > > The release candidate: > https://dist.apache.org/repos/dist/dev/incubator/fury/0.5.0-rc3/ > > This release has been signed with a PGP available here: > https://downloads.apache.org/incubator/fury/KEYS > > Git tag for the release: > https://github.com/apache/incubator-fury/releases/tag/v0.5.0-rc3 > > Git commit for the release: > > https://github.com/apache/incubator-fury/commit/fae06330edd049bb960536e978a45b97bca66faf > > Maven staging repo: > https://repository.apache.org/content/repositories/orgapachefury-1003 > > How to Build and Test, please refer to: > > https://github.com/apache/incubator-fury/blob/main/docs/guide/DEVELOPMENT.md > > The vote will be open for at least 72 hours or until the necessary number > of votes is reached. > > Please vote accordingly: > > [ ] +1 approve > [ ] +0 no opinion > [ ] -1 disapprove with the reason > > To learn more about apache fury, please see https://fury.apache.org/ > > Checklist for reference: > > [ ] Download links are valid. > [ ] Checksums and signatures. > [ ] LICENSE/NOTICE files exist > [ ] No unexpected binary files > [ ] All source files have ASF headers > [ ] Can compile from source > > > Thanks, > > Chaokun Yang >
[VOTE] Release Apache Fury(incubating) v0.5.0-rc3
Hello everyone, This is a call for the vote to release Apache Fury(Incubating) v0.5.0-rc3. The Apache Fury community has voted and approved the release of Apache Fury(incubating) v0.5.0-rc3. We now kindly request the IPMC members review and vote for this release. Apache Fury(incubating) - A blazingly fast multi-language serialization framework powered by JIT and zero-copy. Fury community vote thread: https://lists.apache.org/thread/g49qt1v99d0ncfvonng39lcs1s56m7v5 Vote result thread: https://lists.apache.org/thread/9rtl03g650pojyfb5d67785tffyo4hbs The release candidate: https://dist.apache.org/repos/dist/dev/incubator/fury/0.5.0-rc3/ This release has been signed with a PGP available here: https://downloads.apache.org/incubator/fury/KEYS Git tag for the release: https://github.com/apache/incubator-fury/releases/tag/v0.5.0-rc3 Git commit for the release: https://github.com/apache/incubator-fury/commit/fae06330edd049bb960536e978a45b97bca66faf Maven staging repo: https://repository.apache.org/content/repositories/orgapachefury-1003 How to Build and Test, please refer to: https://github.com/apache/incubator-fury/blob/main/docs/guide/DEVELOPMENT.md The vote will be open for at least 72 hours or until the necessary number of votes is reached. Please vote accordingly: [ ] +1 approve [ ] +0 no opinion [ ] -1 disapprove with the reason To learn more about apache fury, please see https://fury.apache.org/ Checklist for reference: [ ] Download links are valid. [ ] Checksums and signatures. [ ] LICENSE/NOTICE files exist [ ] No unexpected binary files [ ] All source files have ASF headers [ ] Can compile from source Thanks, Chaokun Yang
