Re: [VOTE] Release Apache NLPCraft (Incubating) 0.5.0

2020-05-05 Thread Justin Mclean
Hi, > thanks a lot for the comments and keeping us honest. I want to make sure we > are on the same page: do you see these issues as critical or they can be > addressed in the consequent release? Next release is fine by me. Thanks, Justin

Re: [VOTE] Release Apache NLPCraft (Incubating) 0.5.0

2020-05-05 Thread Konstantin Boudnik
Justin, thanks a lot for the comments and keeping us honest. I want to make sure we are on the same page: do you see these issues as critical or they can be addressed in the consequent release? Thanks, On 2020-05-05 06:02, Justin Mclean wrote: Hi, Fixed in master. However, there are

Re: [VOTE] Release Apache NLPCraft (Incubating) 0.5.0

2020-05-04 Thread Justin Mclean
Hi, > Fixed in master. However, there are still questions on hoThw NOTICE file > should look like for binary releases. Generally the way that is handles is too have seperate NOTICE (and LICENSE) files one for teh source release and one for the binary convienance. > These are the model files

Re: [VOTE] Release Apache NLPCraft (Incubating) 0.5.0

2020-05-04 Thread Aaron Radzinski
Justin, Thank you for noticing this. See below... -- Aaron Radzinski On Fri, May 1, 2020 at 11:01 PM Justin Mclean wrote: > HI, > > I know the vote has all ready passed but I can see a couple of issues > here: > - LICENSE is missing the appendix > Fixed in master. - As noted the NOTICE is

Re: [VOTE] Release Apache NLPCraft (Incubating) 0.5.0

2020-05-02 Thread Justin Mclean
HI, I know the vote has all ready passed but I can see a couple of issues here: - LICENSE is missing the appendix - As noted the NOTICE is not correct. License are not lined in NOTICE they are licensed in LICENSE and need to be the full text. Dependancies don’t need to be listed only that that

[RESULT] [VOTE] Release Apache NLPCraft (Incubating) 0.5.0

2020-04-29 Thread Nikita Ivanov
Hi, The vote to release Apache NLPCraft (incubating) 0.5.0 has passed with 3 +1 binding votes. Binding votes are: - Paul King - Furkan KAMACI - Konstantin Boudnik Vote thread:

Re: [VOTE] Release Apache NLPCraft (Incubating) 0.5.0

2020-04-28 Thread Furkan KAMACI
Hi, +1 from me (binding, carrying over my vote). I checked: - Incubating in name - DISCLAIMER exists - LICENSE is fine - NOTICE should be fixed (which is a minor issue) - No unexpected binary files - Checked PGP signatures - Checked Checksums - Code compiles and tests successfully run - Apache

Re: [VOTE] Release Apache NLPCraft (Incubating) 0.5.0

2020-04-27 Thread Paul King
+1 (binding) Checked: + DISCLAIMER exists + incubating in name + no unexpected binary files + signature okay (from https://dist.apache.org/repos/dist/release/incubator/nlpcraft/KEYS) + checksum okay + LICENSE okay + NOTICE lines 1-5 correct (remove lines 6-95 for next release, they aren't

Re: [VOTE] Release Apache NLPCraft (Incubating) 0.5.0

2020-04-26 Thread Konstantin Boudnik
+1 [binding] Checked - signatures - license compliance - checksums Thank you. --   Cos On 2020-04-23 12:52, Aaron Radzinski wrote: Hello all, This is a call for a vote to release Apache NLPCraft (incubating) version 0.5.0. The Apache NLPCraft community has voted on and approved a proposal

Re: [VOTE] Release Apache NLPCraft (Incubating) 0.5.0

2020-04-23 Thread Nikita Ivanov
Got it, thanks for clearing that up. Best, -- Nikita Ivanov On Thu, Apr 23, 2020 at 3:46 PM Paul King wrote: > Okay, I didn't know that wording was there. Standard practice is to always > wait at least 72hrs unless there are exceptional circumstances such as: > * cancelling the vote early

Re: [VOTE] Release Apache NLPCraft (Incubating) 0.5.0

2020-04-23 Thread Paul King
Okay, I didn't know that wording was there. Standard practice is to always wait at least 72hrs unless there are exceptional circumstances such as: * cancelling the vote early when it needs an obvious fix * when there is a security issue in the release which needs prompt releasing * the entire PMC

Re: [VOTE] Release Apache NLPCraft (Incubating) 0.5.0

2020-04-23 Thread Nikita Ivanov
Paul - this is the language that's proposed as a template in https://incubator.apache.org/policy/incubation.html#releases Thanks, -- Nikita Ivanov On Thu, Apr 23, 2020 at 1:04 AM Paul King wrote: > Just on process, the "or until a necessary number of votes are reached" > won't apply. You

Re: [VOTE] Release Apache NLPCraft (Incubating) 0.5.0

2020-04-23 Thread Paul King
Just on process, the "or until a necessary number of votes are reached" won't apply. You might get 3 +1s straight away and a -1 a couple of days later. If that was the total votes, that would still be counted as a failing vote. Cheers, Paul. On Thu, Apr 23, 2020 at 3:52 PM Aaron Radzinski

[VOTE] Release Apache NLPCraft (Incubating) 0.5.0

2020-04-22 Thread Aaron Radzinski
Hello all, This is a call for a vote to release Apache NLPCraft (incubating) version 0.5.0. The Apache NLPCraft community has voted on and approved a proposal to release Apache NLPCraft (Incubating) version 0.5.0. We would like to request the Incubator PMC members review and vote on this