[RESULT] [VOTE] Release Apache NetBeans 9.0 RC1 (incubating) rc1

2018-05-28 Thread Emilian Bold
Thanks to all who voted! The release has PASSED with the following IPMC votes: +1 Ate Douma (binding) +1 Bertrand Delacretaz (binding) +1 Mark Struberg (binding) +0 Justin Mclean (binding) Also, 3 community members voted +1 on the IPMC thread. 10 members of the Apache NetBeans PPMC and Apache

Re: [VOTE] Release Apache NetBeans 9.0 RC1 (incubating) rc1

2018-05-28 Thread Wade Chandler
+1 non-binding On Sun, May 27, 2018, 17:32 Mark Struberg wrote: > Hi folks! > > Justin, thanks for talking such a deep look and catching those flaws, > really appreciated! > > Here is my personal view: It's just test data, and if we can guarantee > that the test data

Re: [VOTE] Release Apache NetBeans 9.0 RC1 (incubating) rc1

2018-05-27 Thread Mark Struberg
Hi folks! Justin, thanks for talking such a deep look and catching those flaws, really appreciated! Here is my personal view: It's just test data, and if we can guarantee that the test data is IP clean then it's not a problem. I remember other ASF projects which have class files compiled with

Re: [VOTE] Release Apache NetBeans 9.0 RC1 (incubating) rc1

2018-05-27 Thread Emilian Bold
Silly question but must Apache releases include test data? Is there a restriction on such minor binary files in the repository or just binary files in the release zip? I see no problem excluding all the tests in future NetBeans releases. --emi ‐‐‐ Original Message ‐‐‐ On 27 May 2018

Re: [VOTE] Release Apache NetBeans 9.0 RC1 (incubating) rc1

2018-05-26 Thread Jan Lahoda
On Sun, May 27, 2018 at 12:20 AM, Justin Mclean wrote: > Hi, > > > I wonder where exactly (most) of these files come from. > > Sorry, many apologies, and my mistake as I looked at your last release by > accident. Changing my vote to +0 (binding). > > I can still see the

Re: [VOTE] Release Apache NetBeans 9.0 RC1 (incubating) rc1

2018-05-26 Thread Geertjan Wielenga
Only binding votes from Ate and Bertrand thus far. Gj On Sunday, May 27, 2018, Justin Mclean wrote: > Hi, > > > If we create an issue for removing that ZIP file, will you change your +0 > > to +1? > > I’ve not had a chance to go over everything yet, it’s not a small

Re: [VOTE] Release Apache NetBeans 9.0 RC1 (incubating) rc1

2018-05-26 Thread Justin Mclean
Hi, > If we create an issue for removing that ZIP file, will you change your +0 > to +1? I’ve not had a chance to go over everything yet, it’s not a small simple release. Remember you only need 3 +1’s binding votes (which I think you have) and more +1’s than -1’s to make a release. Thanks,

Re: [VOTE] Release Apache NetBeans 9.0 RC1 (incubating) rc1

2018-05-26 Thread Geertjan Wielenga
If we create an issue for removing that ZIP file, will you change your +0 to +1? Gj On Sunday, May 27, 2018, Justin Mclean wrote: > Hi, > > > I wonder where exactly (most) of these files come from. > > Sorry, many apologies, and my mistake as I looked at your last

Re: [VOTE] Release Apache NetBeans 9.0 RC1 (incubating) rc1

2018-05-26 Thread Justin Mclean
Hi, > I wonder where exactly (most) of these files come from. Sorry, many apologies, and my mistake as I looked at your last release by accident. Changing my vote to +0 (binding). I can still see the md5 hashes in the office release area [1] these should be removed (but that’s a minor

Re: [VOTE] Release Apache NetBeans 9.0 RC1 (incubating) rc1

2018-05-26 Thread Jan Lahoda
Hi Justin, I wonder where exactly (most) of these files come from. I just did: $ wget https://dist.apache.org/repos/dist/dev/incubator/netbeans/incubating-netbeans-java/incubating-9.0-rc1-rc1/incubating-netbeans-java-9.0-rc1-source.zip [this is the URL from the first e-mail in this thread] $

Re: [VOTE] Release Apache NetBeans 9.0 RC1 (incubating) rc1

2018-05-26 Thread Glenn Holmer
On 2018/05/20 22:33:02, Emilian Bold wrote: > The Apache NetBeans community has voted on and approved a proposal to > release Apache NetBeans 9.0 RC1 (incubating) rc1. We now kindly > request that the Incubator PMC members review and vote on this > incubator release candidate.

Re: [VOTE] Release Apache NetBeans 9.0 RC1 (incubating) rc1

2018-05-26 Thread Geertjan Wielenga
AFAIK these have all been removed, I removed several of these myself. Gj On Saturday, May 26, 2018, Justin Mclean wrote: > > Hi, > > > Please check that your rat exclusions have not been set to too wide and > rat shovel pick up these issues. > > Correcting: > >

Re: [VOTE] Release Apache NetBeans 9.0 RC1 (incubating) rc1

2018-05-26 Thread Justin Mclean
Hi, > Please check that your rat exclusions have not been set to too wide and rat > shovel pick up these issues. Correcting: Please check that your rat exclusions have not been set to too wide as rat should pick up these issues. Thanks, Justin

Re: [VOTE] Release Apache NetBeans 9.0 RC1 (incubating) rc1

2018-05-26 Thread Justin Mclean
Hi, Sorry but it -1 binding from me as the source release contains compiled code. It’s not an open source release if it contains jars that contain compiled code e.g. [1][2] And before you ask there is no exception for test resources. If you need compiled code make it compile as part of the

Re: [VOTE] Release Apache NetBeans 9.0 RC1 (incubating) rc1

2018-05-26 Thread Geertjan Wielenga
+1 (non binding) Signatures verified after importing the 1CCF4647 key from here: https://dist.apache.org/repos/dist/release/incubator/netbeans/KEYS SHA1 digests match. DISCLAIMER and NOTICE look good. nbbuild/rat-exclusions.txt, we need to work on making it smaller, but we have documented

Re: [VOTE] Release Apache NetBeans 9.0 RC1 (incubating) rc1

2018-05-25 Thread Jan Lahoda
On Wed, May 23, 2018 at 10:44 PM, Ate Douma wrote: > > > On 2018-05-23 20:57, Emilian Bold wrote: > >> Ate, could we get a vote on this release? >> > > Sure :-) > > >> If you look at https://cwiki.apache.org/confl >> uence/display/NETBEANS/Apache+NetBeans+9.0+RC1 we are already

Re: [VOTE] Release Apache NetBeans 9.0 RC1 (incubating) rc1

2018-05-24 Thread Emilian Bold
Thanks Ate! We still need a few more votes this week the close voting. --emi ‐‐‐ Original Message ‐‐‐ On 23 May 2018 11:44 PM, Ate Douma wrote: > On 2018-05-23 20:57, Emilian Bold wrote: > > > Ate, could we get a vote on this release? > > Sure :-) > > > If you look

Re: [VOTE] Release Apache NetBeans 9.0 RC1 (incubating) rc1

2018-05-23 Thread Ate Douma
On 2018-05-23 20:57, Emilian Bold wrote: Ate, could we get a vote on this release? Sure :-) If you look at https://cwiki.apache.org/confluence/display/NETBEANS/Apache+NetBeans+9.0+RC1 we are already making progress on the (non-blocking) issues reported. Yes, thanks for creating the

Re: [VOTE] Release Apache NetBeans 9.0 RC1 (incubating) rc1

2018-05-23 Thread Emilian Bold
Ate, could we get a vote on this release? If you look at https://cwiki.apache.org/confluence/display/NETBEANS/Apache+NetBeans+9.0+RC1 we are already making progress on the (non-blocking) issues reported. --emi ‐‐‐ Original Message ‐‐‐ On 21 May 2018 3:54 PM, Ate Douma

Re: [VOTE] Release Apache NetBeans 9.0 RC1 (incubating) rc1

2018-05-23 Thread Bertrand Delacretaz
On Wed, May 23, 2018 at 5:35 PM, Emilian Bold wrote: > I have created these issues to track these licenses... Thank you - I have set the fix version to 9.0 on these issues, IIUC that's the correct way to make sure they are fixed before the non-RC release? With this I

Re: [VOTE] Release Apache NetBeans 9.0 RC1 (incubating) rc1

2018-05-23 Thread Emilian Bold
> A number of licenses mentioned in the LICENSE file are not mentioned > at https://www.apache.org/legal/resolved.html, have they been cleared > and if so do we have URLs of those clearances or discussions? > > That's the following licenses: > ISO-8879-SGML > EDL-1.0 > W3C2 > OASIS > WSDL-2004 I

Re: [VOTE] Release Apache NetBeans 9.0 RC1 (incubating) rc1

2018-05-23 Thread Matt Sicker
On 23 May 2018 at 09:18, Justin Mclean wrote: > IMO (but just my personal opinion) it does nothing to serve the users > other than to confuse them that GPL software may be bundled or may be a > dependancy of the software. License checkers will flag this as an issue as >

Re: [VOTE] Release Apache NetBeans 9.0 RC1 (incubating) rc1

2018-05-23 Thread Justin Mclean
Hi, > So, overall, it seems to me it is a better service for the users of the > release to have the license included, than to hide it? IMO (but just my personal opinion) it does nothing to serve the users other than to confuse them that GPL software may be bundled or may be a dependancy of the

Re: [VOTE] Release Apache NetBeans 9.0 RC1 (incubating) rc1

2018-05-23 Thread Bertrand Delacretaz
On Wed, May 23, 2018 at 3:59 PM, Geertjan Wielenga wrote: > ...I believe > they are orphaned license files with their related libraries removed or > resolved. We do need to investigate this, though I do not believe they’re a > blocker for the release

Re: [VOTE] Release Apache NetBeans 9.0 RC1 (incubating) rc1

2018-05-23 Thread Geertjan Wielenga
Or at least the 2nd comment in that issue lists those licenses. I believe they are orphaned license files with their related libraries removed or resolved. We do need to investigate this, though I do not believe they’re a blocker for the release candidate. Gj On Wednesday, May 23, 2018, Geertjan

Re: [VOTE] Release Apache NetBeans 9.0 RC1 (incubating) rc1

2018-05-23 Thread Geertjan Wielenga
The list of licenses in the issue are the same as yours. It is a known issue and discussed there, see the description of the issue, which has a list of licenses that matches yours. Gj On Wednesday, May 23, 2018, Bertrand Delacretaz wrote: > On Wed, May 23, 2018 at

Re: [VOTE] Release Apache NetBeans 9.0 RC1 (incubating) rc1

2018-05-23 Thread Bertrand Delacretaz
On Wed, May 23, 2018 at 3:38 PM, Geertjan Wielenga wrote: > ...The license files listed in the Rat report are known and an issue exists >>> for solving this: >>> https://issues.apache.org/jira/browse/NETBEANS-305 ... It's not clear to me whether that ticket

Re: [VOTE] Release Apache NetBeans 9.0 RC1 (incubating) rc1

2018-05-23 Thread Geertjan Wielenga
And the open issue is mentioned directly in the vote thread itself by Emilian: The license files listed in the Rat report are known and an issue exists >> for solving this: > > >> https://issues.apache.org/jira/browse/NETBEANS-305 > > Gj On Wed, May 23, 2018 at 3:35 PM, Geertjan Wielenga <

Re: [VOTE] Release Apache NetBeans 9.0 RC1 (incubating) rc1

2018-05-23 Thread Geertjan Wielenga
See this page, most/several items are mentioned there, including the new splash screen: https://cwiki.apache.org/confluence/display/NETBEANS/Apache+NetBeans+9.0+RC1 Note that we're not working on the final release of Apache NetBeans, but on its release candidate. Indeed, this is confusing --

Re: [VOTE] Release Apache NetBeans 9.0 RC1 (incubating) rc1

2018-05-23 Thread Bertrand Delacretaz
On Mon, May 21, 2018 at 12:33 AM, Emilian Bold wrote: > We now kindly request that the Incubator PMC members review and vote on this > incubator release candidate... -1 for the release of incubating-netbeans-java-9.0-rc1-source.zip for now due to the below open

Re: [VOTE] Release Apache NetBeans 9.0 RC1 (incubating) rc1

2018-05-22 Thread Emilian Bold
> b) Justin provided detailed feedback on the 9.0-Beta-RC3 on (possible) > needed improvements/fixes for the binary dist LICENSE/NOTICE file [2], > thereafter recorded as a todo action list on the wiki [3] (end of page). > Some of those points have been addressed (marked DONE), but many/most >

Re: [VOTE] Release Apache NetBeans 9.0 RC1 (incubating) rc1

2018-05-21 Thread Jan Lahoda
On Mon, May 21, 2018 at 10:20 PM, Justin Mclean wrote: > Hi, > > > Quote from Apache Legal FAQ: > > https://www.apache.org/legal/resolved.html#prohibited > > > > "[...] For example, using a GPL'ed tool during the build is OK, however > > including GPL'ed source code is

Re: [VOTE] Release Apache NetBeans 9.0 RC1 (incubating) rc1

2018-05-21 Thread Justin Mclean
Hi, > Quote from Apache Legal FAQ: > https://www.apache.org/legal/resolved.html#prohibited > > "[...] For example, using a GPL'ed tool during the build is OK, however > including GPL'ed source code is not.[...]" > > Apache Netbeans uses external tools when building and at least GPLv2- > CP >

Re: [VOTE] Release Apache NetBeans 9.0 RC1 (incubating) rc1

2018-05-21 Thread Emilian Bold
Yes, I saw here http://www.apache.org/dev/release-publishing.html that > .md5's in dist.apache.org/repos/dist/release/ must be removed manually. And I was planning on doing just that after the vote. I've also wondered why we generate MD5s to begin with... I've added

Re: [VOTE] Release Apache NetBeans 9.0 RC1 (incubating) rc1

2018-05-21 Thread sebb
On 20 May 2018 at 23:33, Emilian Bold wrote: > Hi all, > > The Apache NetBeans community has voted on and approved a proposal to release > Apache NetBeans 9.0 RC1 (incubating) rc1. > > We now kindly request that the Incubator PMC members review and vote on this >

Re: [VOTE] Release Apache NetBeans 9.0 RC1 (incubating) rc1

2018-05-21 Thread Matthias Bläsing
[Resend incuding general@incubator.apache.org] Hi Ate, Am Montag, den 21.05.2018, 14:54 +0200 schrieb Ate Douma: > a) nbbuild/licenses folder still has the GPL license file, which I > thought/expected no longer should be needed with the fix from > NETBEANS-305 [1]? > Is there still a GPL usage

Re: [VOTE] Release Apache NetBeans 9.0 RC1 (incubating) rc1

2018-05-21 Thread Ate Douma
I'm inclined to vote positive on this RC1, overall looks great! - verified the MD5 and SHA1, and PGP signatures with the ASC files. - executed rat check (ant rat) and verified the report. - build and run the source (using JDK8), and all seems fine. However I still have two questions: a)

[VOTE] Release Apache NetBeans 9.0 RC1 (incubating) rc1

2018-05-20 Thread Emilian Bold
Hi all, The Apache NetBeans community has voted on and approved a proposal to release Apache NetBeans 9.0 RC1 (incubating) rc1. We now kindly request that the Incubator PMC members review and vote on this incubator release candidate. Apache NetBeans 9.0 RC1 (incubating) vote thread: