Re: [VOTE] Release Apache ShenYu (incubating) 2.4.0 [ROUND 2]

2021-08-06 Thread Atri Sharma
+1 (binding) checked: - incubating in name - DISCLAIMER exists - LICENSE and NOTICE are good - All source files have ASF headers - On Thu, 5 Aug 2021, 20:51 Kevin Ratnasekera, wrote: > +1 ( binding ) > > I checked the following. > > - Incubating in name. > > - PGP Signatures. > > - SHA512

Re: [VOTE] Release Apache ShenYu (incubating) 2.4.0 [ROUND 2]

2021-08-06 Thread Jean-Baptiste Onofré
+1 (binding) I quickly checked: - LICENSE and NOTICE files are there and look good - DISCLAIMER is there - ASF headers - Build is OK Regards JB On 06/08/2021 11:45, Willem Jiang wrote: +1 binding. I checked : The Git tag is right for me. There are no binary files in the Source release kit. I

Re: [VOTE] Release Apache ShenYu (incubating) 2.4.0 [ROUND 2]

2021-08-06 Thread Willem Jiang
+1 binding. I checked : The Git tag is right for me. There are no binary files in the Source release kit. I can build the code from source. License and NOTICE files look good to me. Willem Jiang Twitter: willemjiang Weibo: 姜宁willem On Wed, Aug 4, 2021 at 10:59 AM Zhang Yonglun wrote: > >

Re: [VOTE] Release Apache ShenYu (incubating) 2.4.0 [ROUND 2]

2021-08-05 Thread Kevin Ratnasekera
+1 ( binding ) I checked the following. - Incubating in name. - PGP Signatures. - SHA512 Checksums. - DISCLAIMER exists. - LICENSE and NOTICE are fine. - Maven Build passes on MacOS. Regards Kevin On Thu, Aug 5, 2021 at 6:26 PM 张铎(Duo Zhang) wrote: > +1 (binding) > > Checked sigs and

Re: [VOTE] Release Apache ShenYu (incubating) 2.4.0 [ROUND 2]

2021-08-05 Thread Duo Zhang
+1 (binding) Checked sigs and sums: Matched DISCLAIMER: In place LICENSE and NOTICE: In place Built from source(jdk-11.0.11): 'mvn clean install -DskipTests', passed Rat check: Passed Xun Liu 于2021年8月5日周四 上午9:46写道: > > +1 (non-binding) from me, I have checked the following items: > > -

Re: [VOTE] Release Apache ShenYu (incubating) 2.4.0 [ROUND 2]

2021-08-04 Thread Xun Liu
+1 (non-binding) from me, I have checked the following items: - Incubating in name - LICENSE and NOTICE is fine - DISCLAIMER exists - All links are valid - No unexpected binary files - All ASF files have ASF headers - Checksums and PGP signatures are valid. - No compiled archives bundled in

Re: [VOTE] Release Apache ShenYu (incubating) 2.4.0 [ROUND 2]

2021-08-04 Thread Justin Mclean
Hi, +1 (binding) I checked: - incubating in name - signatures and hashes are fine - DISCLAIMER exists - LICENSE and NOTICE are good - All source files have ASF headers - No unexpected binary files - Can compile from source Thanks, Justin

Re: [VOTE] Release Apache ShenYu (incubating) 2.4.0 [ROUND 2]

2021-08-04 Thread Justin Mclean
Hi, It’s recommend that (P)PMC members write down what they check when voting, but you will see some variation from project to project on this and some TLP don’t do this at all. It also recommended that you encourage your mentors to vote and get mentor votes on your releases, but it’s not a

Re: [VOTE] Release Apache ShenYu (incubating) 2.4.0 [ROUND 2]

2021-08-04 Thread Zhang Yonglun
Hi Sheng, > If there is nothing checked by them, it is hard to say they could be > counted as a binding(PPMC level) vote. I would be glad to change the result from 12 +1 votes to 6 +1 votes if the rest 6 votes are invalid. Before that, I'd like to make sure whether the rest 6 votes are invalid

Re: [VOTE] Release Apache ShenYu (incubating) 2.4.0 [ROUND 2]

2021-08-04 Thread Sheng Wu
Inline Zhang Yonglun 于2021年8月4日周三 上午11:38写道: > > Hi Sheng, > > Thanks for your comments. > > > all the incubating process is about letting the > > PPMC having enough knowledge and practices to check the release, > > making sure it follows the policies. > > I agree with you. I have talked with

Re: [VOTE] Release Apache ShenYu (incubating) 2.4.0 [ROUND 2]

2021-08-03 Thread Zhang Yonglun
Hi Sheng, Thanks for your comments. > all the incubating process is about letting the > PPMC having enough knowledge and practices to check the release, > making sure it follows the policies. I agree with you. I have talked with all PPMC members and let them check all items in the list before

Re: [VOTE] Release Apache ShenYu (incubating) 2.4.0 [ROUND 2]

2021-08-03 Thread Sheng Wu
Hi I just reviewed your vote, https://lists.apache.org/thread.html/r2c48a513573f6031d38ad669d6c5e2784ff43964f4cbd75b00ea1205%40%3Cdev.shenyu.apache.org%3E There are only 3-4 PPMC members showing what they checked, others are only having a simple +1, but from the vote result, there are 12 PPMC

[VOTE] Release Apache ShenYu (incubating) 2.4.0 [ROUND 2]

2021-08-03 Thread Zhang Yonglun
Hello Incubator Community, This is a call for vote to release Apache ShenYu (incubating) version 2.4.0. The Apache ShenYu community has voted on and approved a proposal to release Apache ShenYu (incubating) version 2.4.0. We now kindly request the Incubator PMC members review and vote on this