Re: [VOTE] Release apache-singa-incubating-2.0.0 (RC1)

2019-04-20 Thread Chonho Lee
Hello all, The vote for releasing Apache Singa (incubating) 2.0.0 is now closed. Vote result: 3 (+1 binding) (Alan Gates, Justin Mclean, Thejas Nair) 0 ( 0 binding) 0 (-1 binding) The vote has passed. Thank you for taking the time to review the release. Minor issues raised during the vote have

Re: [VOTE] Release apache-singa-incubating-2.0.0 (RC1)

2019-04-19 Thread Thejas Nair
+1 binding On Wed, Apr 17, 2019 at 8:24 PM Justin Mclean wrote: > Hi, > > +1 (binding) See other email for what I reviewed. > > Thanks, > Justin > > - > To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org > For

Re: [VOTE] Release apache-singa-incubating-2.0.0 (RC1)

2019-04-17 Thread Justin Mclean
Hi, +1 (binding) See other email for what I reviewed. Thanks, Justin - To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org For additional commands, e-mail: general-h...@incubator.apache.org

Re: [CANCEL][VOTE] Release apache-singa-incubating-2.0.0 (RC1)

2019-04-17 Thread Wang Wei
Thanks for the suggestion! We have created the jira ticket: https://issues.apache.org/jira/projects/SINGA/issues/SINGA-447. We would kindly request the Incubator PMC members to continue reviewing the release and voting on this thread. Regards, Wei On Wed, Apr 17, 2019 at 8:17 PM Justin Mclean

Re: [CANCEL][VOTE] Release apache-singa-incubating-2.0.0 (RC1)

2019-04-17 Thread Justin Mclean
Hi, > Can we reopen the voting thread and create a jira ticket for this issue? I would do this and just ignore the cancel thread and fix in the next release. Thanks, Justin - To unsubscribe, e-mail:

Re: [CANCEL][VOTE] Release apache-singa-incubating-2.0.0 (RC1)

2019-04-17 Thread Wang Wei
Hi Justin, Can we reopen the voting thread and create a jira ticket for this issue? Or is it better to fix it and then start the voting again since we have already canceled it? Thanks. Regards, Wei On Wed, Apr 17, 2019 at 11:52 AM Justin Mclean wrote: > Hi, > > > We are canceling this voting

Re: [CANCEL][VOTE] Release apache-singa-incubating-2.0.0 (RC1)

2019-04-16 Thread Justin Mclean
Hi, > We are canceling this voting to fix the license issue pointed by Justin. Which seems odd given they are very minor and I hadn’t voted -1. Something like this can be fixed in a future release. In fact I had intended to vote +1. Thanks, Justin

[CANCEL][VOTE] Release apache-singa-incubating-2.0.0 (RC1)

2019-04-16 Thread Chonho Lee
We are canceling this voting to fix the license issue pointed by Justin. Thanks! On Thu, Apr 11, 2019 at 10:21 AM Chonho Lee wrote: > Hi all, > > The SINGA community has voted on and approved a proposal to release Apache > SINGA 2.0.0 (incubating). > > The vote thread is at: > >

Re: [VOTE] Release apache-singa-incubating-2.0.0 (RC1)

2019-04-15 Thread Justin Mclean
Hi, > convert.py is explained in the LICENSE file > https://github.com/apache/incubator-singa/blob/master/LICENSE#L448 > Do we still need to include the header in [1]? Up to you. Files can get separated from where come from (like this one) and it then becomes unclear of what it’s license is

Re: [VOTE] Release apache-singa-incubating-2.0.0 (RC1)

2019-04-15 Thread Wang Wei
Hi Justin, convert.py is explained in the LICENSE file https://github.com/apache/incubator-singa/blob/master/LICENSE#L448 Do we still need to include the header in [1]? Thanks! Best Wei On Mon, Apr 15, 2019 at 6:06 AM Justin Mclean wrote: > Hi, > > I checked: > - incubating in name > -

Re: [VOTE] Release apache-singa-incubating-2.0.0 (RC1)

2019-04-14 Thread Justin Mclean
Hi, I checked: - incubating in name - signatures and hashes good - DISLAMIER exists - LICENSE file good - NOTICE year needs updating - No unexpected binary files in releases - All source files have headers except this one [1] - Don't have a setup suitable to compile Thanks, Justin 1.

Re: [VOTE] Release apache-singa-incubating-2.0.0 (RC1)

2019-04-11 Thread Alan Gates
Forwarding my +1 from the dev list. Checked signatures, sha, did a quick check to make sure files without headers were referenced in LICENSE or NOTICE, looked for binary files in the distribution. Alan. On Wed, Apr 10, 2019 at 6:21 PM Chonho Lee wrote: > Hi all, > > The SINGA community has

[VOTE] Release apache-singa-incubating-2.0.0 (RC1)

2019-04-10 Thread Chonho Lee
Hi all, The SINGA community has voted on and approved a proposal to release Apache SINGA 2.0.0 (incubating). The vote thread is at: http://mail-archives.apache.org/mod_mbox/singa-dev/201904.mbox/%3CCADVfyeuVVE6SZe_%2B6A5OpApY5rDRhBWCfv8H1uZ%2BZuz1NR17_g%40mail.gmail.com%3E and the result is at: