Re: Github pull request hooks

2014-02-10 Thread Suresh Marru
Hi Daniel (and Sergio and others for all the comments), You rock for such a quick implementation. I think we would like to have enable this for Airavata projects. I will run it by the PMC and if we have a general agreement I will create a INFRA jira. Thanks again, Suresh On Feb 10, 2014, at 10

Re: Github pull request hooks

2014-02-10 Thread Sergio Fernández
On 10/02/14 16:42, Ted Dunning wrote: On Mon, Feb 10, 2014 at 7:01 AM, Sergio Fernández wrote: On 10/02/14 14:49, Daniel Gruno wrote: I would suggest you create a new JIRA ticket with this _wish_ and label is as Git+Wilderness, and I'll try to figure out whether we can support this or not. I'

Re: Github pull request hooks

2014-02-10 Thread Sergio Fernández
Thanks Rob. I missed the mail from Jan 20, but with Jake and your help I found it. Thanks. On 10/02/14 16:42, Rob Vesse wrote: Sergio You have to manually edit a file in the private committers area of the Apache SVN repo. The specific file you need to edit and how to edit it was detailed in an

Re: Github pull request hooks

2014-02-10 Thread Rob Vesse
Sergio You have to manually edit a file in the private committers area of the Apache SVN repo. The specific file you need to edit and how to edit it was detailed in an email from Noah Slater that went out on the committers@a.o list on 20th January. It's a private list so I am avoiding mentioning

Re: Github pull request hooks

2014-02-10 Thread Ted Dunning
On Mon, Feb 10, 2014 at 7:01 AM, Sergio Fernández < sergio.fernan...@salzburgresearch.at> wrote: > On 10/02/14 14:49, Daniel Gruno wrote: > >> I would suggest you create a new JIRA ticket with this _wish_ and label >> is as Git+Wilderness, and I'll try to figure out whether we can support >> this

Re: Github pull request hooks

2014-02-10 Thread Jake Farrell
You can add your id to https://svn.apache.org/repos/private/committers/docs/github_team.txt -Jake On Mon, Feb 10, 2014 at 10:03 AM, Sergio Fernández < sergio.fernan...@salzburgresearch.at> wrote: > BTW, where is the mapping file between asf ids and github ones? > I've seen some members of the

Re: Github pull request hooks

2014-02-10 Thread Daniel Gruno
Oh well, I went ahead and implemented this :3 GitHub comments that either include a JIRA ticket name or are made on a PR whose title includes a JIRA ticket name, will result in a comment being made in that specific JIRA ticket, similar to what is posted on the ML. This will result in some double p

Re: Github pull request hooks

2014-02-10 Thread Sergio Fernández
BTW, where is the mapping file between asf ids and github ones? I've seen some members of the apache organization there, but it looks there were manually added or so. Thanks! On 10/02/14 16:01, Sergio Fernández wrote: On 10/02/14 14:49, Daniel Gruno wrote: I would suggest you create a new JIR

Re: Github pull request hooks

2014-02-10 Thread Sergio Fernández
On 10/02/14 14:49, Daniel Gruno wrote: I would suggest you create a new JIRA ticket with this _wish_ and label is as Git+Wilderness, and I'll try to figure out whether we can support this or not. I'd prefer it does not create new issues in Jira. What currently it does, post a comment if any is

Re: Github pull request hooks

2014-02-10 Thread Daniel Gruno
cc'ing infra, as this is really an infra topic. Yes, it is possible - anything is possible, but it will require quite a lot of work from Infra to make this possible. I would suggest you create a new JIRA ticket with this _wish_ and label is as Git+Wilderness, and I'll try to figure out whether we

Re: Github pull request hooks

2014-02-10 Thread Suresh Marru
Daniel & Jake, This is simply nice, appreciate your efforts in integrating this on a quick turn around. Can I become more greedy and ask a follow on question/request? In addition to (or arguably in place of) dev list emails, is it possible to have ASF JIRA tickets updated with github PR’s? I me

Re: Github pull request hooks

2014-02-10 Thread Sergio Fernández
Very cool, guys! On 08/02/14 23:42, Matei Zaharia wrote: Thanks for the very quick action on this, Daniel and Jake! Matei On Feb 8, 2014, at 3:51 AM, Daniel Gruno wrote: Let me just get some information across to podlings wondering about this new GitHub stuff we've added, and what is suppor

Re: Github pull request hooks

2014-02-08 Thread Matei Zaharia
Thanks for the very quick action on this, Daniel and Jake! Matei On Feb 8, 2014, at 3:51 AM, Daniel Gruno wrote: > Let me just get some information across to podlings wondering about this > new GitHub stuff we've added, and what is supported so far: > > - It is now possible to relay new GitHub

Re: Github pull request hooks

2014-02-08 Thread Daniel Gruno
Let me just get some information across to podlings wondering about this new GitHub stuff we've added, and what is supported so far: - It is now possible to relay new GitHub PRs, comments on PRs and closing/reopening of PRs to your mailing list. - It is also possible for all committers in a proje

Re: Github pull request hooks

2014-02-07 Thread Henry Saputra
Ah looks like the missing PR title only happen for the emails describing comments from the Github pull requests. - Henry On Fri, Feb 7, 2014 at 12:55 PM, Henry Saputra wrote: > Hi Jake, > > Looks like all the emails from the PR has the same subject: > "[GitHub] incubator-spark pull request:" > >

Re: Github pull request hooks

2014-02-07 Thread Daniel Gruno
We had a bit of a snafu on adding PR titles to the subject lines, but it's been taken care of now. With regards, Daniel. On 02/07/2014 09:57 PM, Henry Saputra wrote: > Ah looks like the missing PR title only happen for the emails > describing comments from the Github pull requests. > > - Henry >

Re: Github pull request hooks

2014-02-07 Thread Henry Saputra
Hi Jake, Looks like all the emails from the PR has the same subject: "[GitHub] incubator-spark pull request:" Is there a way to get the Title of the pull request included in the Subject line? Thanks, Henry On Fri, Feb 7, 2014 at 8:30 AM, Jake Farrell wrote: > I just wanted to follow up on my

Re: Github pull request hooks

2014-02-07 Thread Michael Joyce
That is great news! Thanks Jake and Daniel. -- Joyce On Fri, Feb 7, 2014 at 8:51 AM, Henry Saputra wrote: > W00t! Looks like it is working :) > > Thanks Jake and Daniel. > > - Henry > > On Friday, February 7, 2014, Jake Farrell wrote: > > > I just wanted to follow up on my previous comments a

Re: Github pull request hooks

2014-02-07 Thread Henry Saputra
W00t! Looks like it is working :) Thanks Jake and Daniel. - Henry On Friday, February 7, 2014, Jake Farrell wrote: > I just wanted to follow up on my previous comments about the Github > webhooks not posting comments, Daniel Gruno and I have been debugging the > Github webhooks we had in place

Github pull request hooks

2014-02-07 Thread Jake Farrell
I just wanted to follow up on my previous comments about the Github webhooks not posting comments, Daniel Gruno and I have been debugging the Github webhooks we had in place to send pull request notifications and we have fixed it so comments for issues and pull requests will now go to the dev@ list