On 27/11/2007, Henri Yandell <[EMAIL PROTECTED]> wrote:
> +1, with various minor notes.
Thanks!
> Signatures are good. MD5s are good.
>
> The src tgz contains:
>
> > jakarta-jmeter-2.3.1RC1/bin/jmeter
> > jakarta-jmeter-2.3.1RC1/bin/jmeter-server
> > jakarta-jmeter-2.3.1RC1/bin/jmeter.sh
>
> but the src zip does not.
>
Oops! Those are run-time only files, and should not be in either source archive.
> Otherwise the archives seem the same.
>
> The build fails for just the source. I know the README says to unpack
> both source and binary, but it would be good if the build.xml could
> state that too. It's an odd thing to do.
It's because of the number and size of the libraries - there are some
8Mb of them.
They obviously have to be in the binary distribution; seems wasteful
and unnecessary to include them in the source as well.
I'll add some checks/messages to build.xml to make it clearer.
> =-=-=-=
> Buildfile: build.xml
>
> clean:
> [delete] DEPRECATED - Use of the implicit FileSet is deprecated.
> Use a nested fileset element instead.
>
> BUILD FAILED
> /Users/hen/apache/tmp/jakarta-jmeter-2.3.1RC1/build.xml:1349:
> /Users/hen/apache/tmp/jakarta-jmeter-2.3.1RC1/lib/ext not found.
> =-=-=-=-=
> The build succeeds once I follow the instructions correctly; and
> JMeter started happily (though I didn't test actually using it).
>
> "ant test" fails; there are two failures and one error. I'm running on
> OS X 10.4, JDK 1.5, Ant 1.6.5.
>
> Error: 1)
> org.apache.jmeter.protocol.http.sampler.TestHTTPSamplersAgainstHttpMirrorServerjava.lang.Exception:
> Could not start mirror server
This is intermittent. I've fixed it for future releases.
> Failure: 1)
> BSH1(org.apache.jmeter.functions.PackageTest)junit.framework.AssertionFailedError:
> BeanShell not present
> Failure: 2)
> testTimerBSH(org.apache.jmeter.timers.PackageTest)junit.framework.AssertionFailedError:
> expected:<60> but was:<0>
These are both because BeanShell is not present.
The test output needs to make this clearer.
> Website wise, the download binary and download source links should be
> changed to a single Download link pointing to:
>
> http://jakarta.apache.org/site/downloads/downloads_jmeter.cgi
OK, I'll fix that for later releases.
> The bugs page has a typo (Bugzilla + BugZilla).
OK.
> Hen
>
> On Nov 24, 2007 2:45 PM, sebb <[EMAIL PROTECTED]> wrote:
> > I've created JMeter 2.3.1 RC1 in the directory:
> >
> > http://people.apache.org/~sebb/jmeter-2.3.1/dist
> >
> > Site/Docs are here:
> > http://people.apache.org/~sebb/jmeter-2.3.1/docs
> >
> > Tag:
> > http://svn.apache.org/repos/asf/jakarta/jmeter/tags/v2_3_1RC1
> >
> > Keys are here:
> > http://svn.apache.org/repos/asf/jakarta/jmeter/trunk/KEYS.txt
> > also
> > http://www.apache.org/dist/jakarta/jmeter/KEYS
> >
> > All feedback (and votes!) welcome.
> >
> > [ ]+1 - the release candidate is OK
> > [ ]-1 - there is a problem (please indicate what it is)
> >
> > The vote will remain open for at least 72 hours.
> >
> > If the vote passes, the intention is to create a formal 2.3.1 release
> > from the RC1 tag.
> >
> > Here's my:
> >
> > +1
> >
> > sebb AT apache DOT org
> >
> > -
> > To unsubscribe, e-mail: [EMAIL PROTECTED]
> > For additional commands, e-mail: [EMAIL PROTECTED]
> >
> >
>
> -
> To unsubscribe, e-mail: [EMAIL PROTECTED]
> For additional commands, e-mail: [EMAIL PROTECTED]
>
>
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
