Re: [ofa-general] [PATCH] RDMA/CMA: Use neigh_event_send() to initiate neighbour discovery.

2007-09-16 Thread Or Gerlitz
Steve Wise wrote: RDMA/CMA: Use neigh_event_send() to initiate neighbour discovery. Calling arp_send() to initiate neighbour discovery (ND) doesn't do the full ND protocol. Namely, it doesn't handle retransmitting the arp request if it is dropped. The function neigh_event_send() does all this.

Re: [ofa-general] [PATCH] opensm: build improvements

2007-09-16 Thread Yevgeny Kliteynik
Great, thanks !!! This and the bunch of previous build-related patches really simplifies the build. -- Yevgeny Sasha Khapyorsky wrote: Build and link OpenSM against libibumad. libibcommon header files and libraries in order: local tree, then installed. Signed-off-by: Sasha Khapyorsky [EMAIL

[ofa-general] Re: [PATCH 0/10 REV5] Implement skb batching and support in IPoIB/E1000

2007-09-16 Thread Or Gerlitz
Krishna Kumar [EMAIL PROTECTED] date Aug 22, 2007 11:28 AM subject [PATCH 0/10 Rev4] Implement skb batching and support in IPoIB Issues: I am getting a huge amount of retransmissions for both TCP and TCP No Delay cases for IPoIB (which explains the slight degradation for some

Re: [ofa-general] Re: InfiniBand/RDMA merge plans for 2.6.24

2007-09-16 Thread Or Gerlitz
Shirley Ma wrote: Since ehca can support 4K MTU, we would like to see a patch in IPoIB to allow link MTU to be up to 4K instead of current 2K for 2.6.24 kernel. The idea is IPoIB link MTU will pick up a return value from SM's default broadcast MTU. This patch should be a small patch, I

[ofa-general] Re: [GIT PULL ofed-1.3] cxgb3 bug fixes

2007-09-16 Thread Michael S. Tsirkin
OK, I'll be doing this by merging ofed_1_2_c into ofed_kernel and then removing 029. Quoting Steve Wise [EMAIL PROTECTED]: Subject: [GIT PULL ofed-1.3] cxgb3 bug fixes For ofed-1.3, please pull from: git://git.openfabrics.org/~swise/ofed-1.3 ofed_kernel The 1.3 patch series is identical to the

[ofa-general] Re: [GIT PULL ofed_1_2_c] cxgb3 bug fixes

2007-09-16 Thread Michael S. Tsirkin
Done. I'll push soon. Quoting Steve Wise [EMAIL PROTECTED]: Subject: [GIT PULL ofed_1_2_c] cxgb3 bug fixes Vlad (Michael/Tziporet in Vlad's absence), Please integrate the following cxgb3 bug fixes into ofed-1.2.5. All of these patches are either in 2.6.23 or merged into Jeff Garzik's upstream

Re: [ofa-general] InfiniBand/RDMA merge plans for 2.6.24

2007-09-16 Thread Or Gerlitz
Roland Dreier wrote: With 2.6.24 probably opening in the not-too-distant future, it's probably a good time to review what my plans are for when the merge window opens. Core: - Sean's QoS changes. These look fine at first glance, and I just plan to understand the backwards compatibility

[ofa-general] ofa_1_3_kernel 20070916-0200 daily build status

2007-09-16 Thread Vladimir Sokolovsky
/vlad/tmp/ofa_1_3_kernel-20070916-0200_linux-2.6.19_powerpc_check/drivers/infiniband/hw/ehca/ehca_main.c:936: error: invalid type argument of '-' /home/vlad/tmp/ofa_1_3_kernel-20070916-0200_linux-2.6.19_powerpc_check/drivers/infiniband/hw/ehca/ehca_main.c:939: error: invalid type argument

[ofa-general] Re: RFC: modify upstream code to make backporting easier

2007-09-16 Thread Michael S. Tsirkin
Quoting Roland Dreier [EMAIL PROTECTED]: Subject: Re: RFC: modify upstream code to make backporting easier I wonder whether it's acceptable in cases such as this to add a wrapper in upstream code. For example, upstream could have: #ifndef pci_get_revision #define

[ofa-general] Re: [RFC] [PATCH 1/5 v3] ib/ipoib: specify Traffic Class with PR queries for QoS support

2007-09-16 Thread Or Gerlitz
Sean Hefty wrote: To support QoS within and between subnets, modify IPoIB to request specific Traffic Class values with path record queries, using the value associated with the IPoIB broadcast group. Signed-off-by: Sean Hefty [EMAIL PROTECTED] See some comments I made on this at v1 and v2 of

Re: [ofa-general] [RFC] [PATCH 0/5 v2] rdma/cm: add ability to specifytype of service

2007-09-16 Thread Or Gerlitz
Sean Hefty wrote: Provide support to specify a type of service for a communication identifier. A new function call is used when dealing with IPv4 addresses. For IPv6 addresses, the ToS is specified through the traffic class field in the sockaddr_in6 structure. Signed-off-by: Sean Hefty [EMAIL

Re: [ofa-general] [RFC] [PATCH 2/5 v2] ib/sa: add new QoS fields to path record

2007-09-16 Thread Or Gerlitz
Sean Hefty wrote: The QoS annex defines new fields for path records. Add them to the ib_sa for consumers that want to use them. Signed-off-by: Sean Hefty [EMAIL PROTECTED] Reviewed-by: Or Gerlitz [EMAIL PROTECTED] --- drivers/infiniband/core/sa_query.c | 10 +++---

[ofa-general] Re: [PATCH v2] iw_cxgb3: Support iwarp-only interfaces to avoid 4-tuple conflicts.

2007-09-16 Thread Evgeniy Polyakov
Hi Steve. On Sat, Sep 15, 2007 at 10:56:46AM -0500, Steve Wise ([EMAIL PROTECTED]) wrote: The iWARP driver must translate all listens on address 0.0.0.0 to the set of rdma-only ip addresses for the device in question. This prevents incoming connect requests to the TCP ipaddresses from going

[ofa-general] Re: [PATCH] osm: QoS - changing 'no_qos' option to 'qos'

2007-09-16 Thread Sasha Khapyorsky
On 16:01 Tue 11 Sep , Yevgeny Kliteynik wrote: Changing OpenSM option no_qos with default value 'TRUE 'to qos with deafult value 'FALSE' Signed-off-by: Yevgeny Kliteynik [EMAIL PROTECTED] Applied. Thanks. Sasha ___ general mailing list

[ofa-general] Re: [PATCH 0/10 REV5] Implement skb batching and support in IPoIB/E1000

2007-09-16 Thread David Miller
From: jamal [EMAIL PROTECTED] Date: Sun, 16 Sep 2007 20:29:18 -0400 On Sun, 2007-16-09 at 16:17 -0700, David Miller wrote: The only major complaint I have about this patch series is that the IPoIB part should just be one big changeset. Dave, you do realize that i have been investing my

[ofa-general] Re: [PATCH 0/10 REV5] Implement skb batching and support in IPoIB/E1000

2007-09-16 Thread jamal
On Sun, 2007-16-09 at 18:02 -0700, David Miller wrote: I do. And I'm reviewing and applying several hundred patches a day. What's the point? :-) Reading the commentary made me think you were about to swallow that with one more change by the time i wake up;- I still think this work -

[ofa-general] Re: [PATCH 0/10 REV5] Implement skb batching and support in IPoIB/E1000

2007-09-16 Thread David Miller
From: jamal [EMAIL PROTECTED] Date: Sun, 16 Sep 2007 22:14:21 -0400 I still think this work - despite my vested interest - needs more scrutiny from a performance perspective. Absolutely. There are tertiary issues I'm personally interested in, for example how well this stuff works when we

[ofa-general] Re: [PATCH 0/10 REV5] Implement skb batching and support in IPoIB/E1000

2007-09-16 Thread jamal
On Sun, 2007-16-09 at 19:25 -0700, David Miller wrote: There are tertiary issues I'm personally interested in, for example how well this stuff works when we enable software GSO on a non-TSO capable card. In such a case the GSO segment should be split right before we hit the driver and then

[ofa-general] Re: [PATCH 0/10 REV5] Implement skb batching and support in IPoIB/E1000

2007-09-16 Thread David Miller
From: jamal [EMAIL PROTECTED] Date: Sun, 16 Sep 2007 23:01:43 -0400 I think GSO is still useful on top of this. In my patches anything with gso gets put into the batch list and shot down the driver. Ive never considered checking whether the nic is TSO capable, that may be something worth

[ofa-general] Re: [PATCH 3/10 REV5] [sched] Modify qdisc_run to support batching

2007-09-16 Thread Krishna Kumar2
Hi Evgeniy, Evgeniy Polyakov [EMAIL PROTECTED] wrote on 09/14/2007 05:45:19 PM: + if (skb-next) { + int count = 0; + + do { +struct sk_buff *nskb = skb-next; + +skb-next = nskb-next; +__skb_queue_tail(dev-skb_blist, nskb);

[ofa-general] Re: [PATCH 2/10 REV5] [core] Add skb_blist support for batching

2007-09-16 Thread Krishna Kumar2
Hi Evgeniy, Evgeniy Polyakov [EMAIL PROTECTED] wrote on 09/14/2007 06:16:38 PM: + if (dev-features NETIF_F_BATCH_SKBS) { + /* Driver supports batching skb */ + dev-skb_blist = kmalloc(sizeof *dev-skb_blist, GFP_KERNEL); + if (dev-skb_blist) +

[ofa-general] Re: [PATCH 10/10 REV5] [E1000] Implement batching

2007-09-16 Thread Krishna Kumar2
Hi Evgeniy, Evgeniy Polyakov [EMAIL PROTECTED] wrote on 09/14/2007 06:17:14 PM: if (unlikely(skb-len = 0)) { dev_kfree_skb_any(skb); - return NETDEV_TX_OK; + return NETDEV_TX_DROPPED; } This changes could actually go as own patch, although not sure it is

[ofa-general] Re: [PATCH 0/10 REV5] Implement skb batching and support in IPoIB/E1000

2007-09-16 Thread Krishna Kumar2
Hi Dave, David Miller [EMAIL PROTECTED] wrote on 09/17/2007 04:47:48 AM: The only major complaint I have about this patch series is that the IPoIB part should just be one big changeset. Otherwise the tree is not bisectable, for example the initial ipoib header file change breaks the build.

[ofa-general] Re: [PATCH 1/10 REV5] [Doc] HOWTO Documentation for batching

2007-09-16 Thread Krishna Kumar2
Hi Randy, Randy Dunlap [EMAIL PROTECTED] wrote on 09/15/2007 12:07:09 AM: + To fix this problem, error cases where driver xmit gets called with a + skb must code as follows: + 1. If driver xmit cannot get tx lock, return NETDEV_TX_LOCKED + as usual. This allows qdisc to

[ofa-general] Re: [PATCH 1/10 REV5] [Doc] HOWTO Documentation for batching

2007-09-16 Thread Jeff Garzik
Please remove me from the CC list. I get this via netdev, and not having said a single thing in the thread, I don't feel the need to be CC'd on every email. The CC list is pretty massive as it is, anyway. Jeff ___ general mailing list

[ofa-general] Re: [PATCH 0/10 REV5] Implement skb batching and support in IPoIB/E1000

2007-09-16 Thread Krishna Kumar2
Hi Or, So with ipoib/mthca you still see this 1 : 18.5K retransmission rate (with no noticeable retransmission increase for E1000) you were reporting at the V4 post?! if this is the case, I think it calls for further examination, where help from Mellanox could ease things, I guess. What I

[ofa-general] Re: [PATCH 0/10 REV5] Implement skb batching and support in IPoIB/E1000

2007-09-16 Thread Krishna Kumar2
[Removing Jeff as requested from thread :) ] Hi Dave, David Miller [EMAIL PROTECTED] wrote on 09/17/2007 07:55:02 AM: From: jamal [EMAIL PROTECTED] Date: Sun, 16 Sep 2007 22:14:21 -0400 I still think this work - despite my vested interest - needs more scrutiny from a performance

[ofa-general] nightly osm_sim report 2007-09-17:normal completion

2007-09-16 Thread kliteyn
OSM Simulation Regression Summary [Generated mail - please do NOT reply] OpenSM binary date = 2007-09-16 OpenSM git rev = Sun_Sep_16_18:47:46_2007 [8224cc5e3f6e5ce03d783e674b4eaa6e1cf37acd] ibutils git rev = Tue_Sep_4_17:57:34_2007 [4bf283f6a0d7c0264c3a1d2de92745e457585fdb] Total=520