[ofa-general] [PATCH linux-2.6] bonding: two small fixes for IPoIB support

2007-10-15 Thread Jay Vosburgh
Shoua Signed-off-by: Jay Vosburgh <[EMAIL PROTECTED]> --- drivers/net/bonding/bond_main.c | 11 +-- drivers/net/bonding/bonding.h |4 ++-- 2 files changed, 7 insertions(+), 8 deletions(-) diff --git a/drivers/net/bonding/bond_main.c b/drivers/net/bonding/bond_main.c index d

[ofa-general] Re: [PATCH V7 0/8] net/bonding: ADD IPoIB support for the bonding driver

2007-10-15 Thread Jay Vosburgh
Jeff Garzik <[EMAIL PROTECTED]> wrote: >Jay Vosburgh wrote: >> Since I see you've just pushed it, do you want a patch to >> correct just the two individual things, or would you rather have new >> patches? > > >On top of what was just pushed, please.

[ofa-general] Re: [PATCH V7 0/8] net/bonding: ADD IPoIB support for the bonding driver

2007-10-15 Thread Jay Vosburgh
, do you want a patch to correct just the two individual things, or would you rather have new patches? -J --- -Jay Vosburgh, IBM Linux Technology Center, [EMAIL PROTECTED] ___ general mailing list general@lists.openfabrics.org http://l

Re: [ofa-general] Re: [PATCH V6 0/9] net/bonding: ADD IPoIB support for the bonding driver

2007-10-02 Thread Jay Vosburgh
Jeff Garzik <[EMAIL PROTECTED]> wrote: >Moni Shoua wrote: >> Jay Vosburgh wrote: >>> ACK patches 3 - 9. >>> >>> Roland, are you comfortable with the IB changes in patches 1 and 2? >>> >>> Jeff, when Roland acks patches 1 and 2,

[ofa-general] Re: [PATCH V6 0/9] net/bonding: ADD IPoIB support for the bonding driver

2007-09-25 Thread Jay Vosburgh
ACK patches 3 - 9. Roland, are you comfortable with the IB changes in patches 1 and 2? Jeff, when Roland acks patches 1 and 2, please apply all 9. -J --- -Jay Vosburgh, IBM Linux Technology Center, [EMAIL PROTECTED] Moni Shoua <[EMAIL PROTECTED]>

[ofa-general] Re: [PATCH 02/11] IB/ipoib: Notify the world before doing unregister

2007-09-17 Thread Jay Vosburgh
e would make the ipoib module dependent upon having the bonding module loaded (to resolve all of the symbols)? -J --- -Jay Vosburgh, IBM Linux Technology Center, [EMAIL PROTECTED] ___ general mailing list general@lists.openfabrics.org h

[ofa-general] [PATCH 11/11] bonding: Optionally allow ethernet slaves to keep own MAC

2007-09-14 Thread Jay Vosburgh
s automatically enabled for IB slaves), applicable only to active-backup mode. Includes documentation update. Updates bonding driver version to 3.2.0. Signed-off-by: Jay Vosburgh <[EMAIL PROTECTED]> --- Documentation/networking/bonding.txt | 33 +++ drivers

[ofa-general] [PATCH 10/11] net/bonding: Destroy bonding master when last slave is gone

2007-09-14 Thread Jay Vosburgh
s are still valid. Destroying the bond when slave_cnt is zero ensures that these functions be used anymore. Signed-off-by: Moni Shoua <[EMAIL PROTECTED]> Acked-by: Jay Vosburgh <[EMAIL PROTECTED]> --- drivers/net/bonding/bond_main.c | 45 +

[ofa-general] [PATCH 9/11] net/bonding: Delay sending of gratuitous ARP to avoid failure

2007-09-14 Thread Jay Vosburgh
From: Moni Shoua <[EMAIL PROTECTED]> Delay sending a gratuitous_arp when LINK_STATE_LINKWATCH_PENDING bit in dev->state field is on. This improves the chances for the arp packet to be transmitted. Signed-off-by: Moni Shoua <[EMAIL PROTECTED]> Acked-by: Jay Vosburgh &l

[ofa-general] [PATCH 08/11] net/bonding: Handle wrong assumptions that slave is always an Ethernet device

2007-09-14 Thread Jay Vosburgh
From: Moni Shoua <[EMAIL PROTECTED]> bonding sometimes uses Ethernet constants (such as MTU and address length) which are not good when it enslaves non Ethernet devices (such as InfiniBand). Signed-off-by: Moni Shoua <[EMAIL PROTECTED]> Acked-by: Jay Vosburgh <[EMAIL PROTECTED]>

[ofa-general] [PATCH 07/11] net/bonding: Enable IP multicast for bonding IPoIB devices

2007-09-14 Thread Jay Vosburgh
ddress. This is b/c ip_eth_mc_map() is called where for multicast joins taking place after the enslavement another ip_xxx_mc_map() is called (eg ip_ib_mc_map() when the bond type is ARPHRD_INFINIBAND) Signed-off-by: Moni Shoua <[EMAIL PROTECTED]> Signed-off-by: Or Gerlitz <[EMAIL PROTECTED]

[ofa-general] [PATCH 06/11] net/bonding: Enable bonding to enslave netdevices not supporting set_mac_address()

2007-09-14 Thread Jay Vosburgh
ent by bonding when fail-over occurs (this is already done by the bonding code). Signed-off-by: Moni Shoua <[EMAIL PROTECTED]> Signed-off-by: Or Gerlitz <[EMAIL PROTECTED]> Acked-by: Jay Vosburgh <[EMAIL PROTECTED]> --- drivers/net/bonding/bond_main.c | 87 +++

[ofa-general] [PATCH 05/11] net/bonding: Enable bonding to enslave non ARPHRD_ETHER

2007-09-14 Thread Jay Vosburgh
PROTECTED]> Signed-off-by: Or Gerlitz <[EMAIL PROTECTED]> Acked-by: Jay Vosburgh <[EMAIL PROTECTED]> --- drivers/net/bonding/bond_main.c | 39 +++ 1 files changed, 39 insertions(+), 0 deletions(-) diff --git a/drivers/net/bonding/bond_main

[ofa-general] [PATCH 04/11] IB/ipoib: Verify address handle validity on send

2007-09-14 Thread Jay Vosburgh
packet on a new slave that uses an old ipoib_neigh. This patch detects and prevents this from happenning. Signed-off-by: Moni Shoua <[EMAIL PROTECTED]> Signed-off-by: Or Gerlitz <[EMAIL PROTECTED]> Acked-by: Jay Vosburgh <[EMAIL PROTECTED]> --- drivers/infiniband/ulp/ipoib/ipoi

[ofa-general] [PATCH 03/11] IB/ipoib: Bound the net device to the ipoib_neigh structue

2007-09-14 Thread Jay Vosburgh
ighbour dev one, when n->dev->flags has the IFF_MASTER bit set. Signed-off-by: Moni Shoua <[EMAIL PROTECTED]> Signed-off-by: Or Gerlitz <[EMAIL PROTECTED]> Acked-by: Jay Vosburgh <[EMAIL PROTECTED]> --- drivers/infiniband/ulp/ipoib/ipoib.h |4 +++- drivers/

[ofa-general] [PATCH 00/11] IPoIB support for bonding

2007-09-14 Thread Jay Vosburgh
Following is patch set to provide IPoIB support for bonding in active-backup mode. Patches 1 - 10 were originally posted by Moni Shoua <[EMAIL PROTECTED]>. The changes look reasonable to me, but others (for IB and net/core changes) probably need to ack. Patch 11 modifies the IB "

[ofa-general] [PATCH 01/11] IB/ipoib: Export call to call_netdevice_notifiers and add new private flag

2007-09-14 Thread Jay Vosburgh
Both changes are used in bonding slaves that wish to inform the bonding master about coming detachment. Signed-off-by: Moni Shoua <[EMAIL PROTECTED]> Acked-by: Jay Vosburgh <[EMAIL PROTECTED]> --- include/linux/if.h |1 + net/core/dev.c |1 + 2 files changed, 2 insertio

[ofa-general] [PATCH 02/11] IB/ipoib: Notify the world before doing unregister

2007-09-14 Thread Jay Vosburgh
en the IPoIB net device is a slave of a bonding master, let the master know that the IPoIB device is about to unregister (but before calling unregister). Signed-off-by: Moni Shoua <[EMAIL PROTECTED]> Acked-by: Jay Vosburgh <[EMAIL PROTECTED]> --- drivers/infiniband/ulp/ipoib/i

Re: [ofa-general] Re: [PATCH V4 10/10] net/bonding: Destroy bonding master when last slave is gone

2007-08-29 Thread Jay Vosburgh
Moni Shoua <[EMAIL PROTECTED]> wrote: >Jay Vosburgh wrote: >> Moni Shoua <[EMAIL PROTECTED]> wrote: >> >>> When bonding enslaves non Ethernet devices it takes pointers to functions >>> in the module that owns the slaves. In this case it becomes uns

[ofa-general] Re: [PATCH V4 10/10] net/bonding: Destroy bonding master when last slave is gone

2007-08-28 Thread Jay Vosburgh
tic change I'd rather not introduce if it's not necessary. -J --- -Jay Vosburgh, IBM Linux Technology Center, [EMAIL PROTECTED] ___ general mailing list general@lists.openfabrics.org http://lists.openfabrics.org/cgi-bin/mailman/listinf

[ofa-general] Re: [PATCH V4 8/10] net/bonding: Handlle wrong assumptions that slave is always an Ethernet device

2007-08-28 Thread Jay Vosburgh
bond_dev->hard_header_len); Since non-IB bonding masters are run through ether_setup, which sets hard_header_len to ETH_HLEN, the max() is probably unnecessary, and I think this could just be bond_dev->hard_header_len. -J --- -Jay Vosburgh, IBM Linux Tech

[ofa-general] Re: [PATCH V3 7/7] net/bonding: Delay sending of gratuitous ARP to avoid failure

2007-07-30 Thread Jay Vosburgh
=== >--- net-2.6.orig/drivers/net/bonding/bonding.h 2007-07-25 15:20:10.0 >+0300 >+++ net-2.6/drivers/net/bonding/bonding.h 2007-07-26 18:42:43.652087660 >+0300 >@@ -203,6 +203,7 @@ struct bonding { > struct vlan_group *vlgrp; >