Re: [ofa-general] [PATCH] ib_ipoib: fix race detaching from mcast group before attaching

2007-03-19 Thread Roland Dreier
What's the theory here? It's not obvious why moving the call to ib_sa_free_multicast() fixes the race... ___ general mailing list general@lists.openfabrics.org http://lists.openfabrics.org/cgi-bin/mailman/listinfo/general To unsubscribe, please visit

RE: [ofa-general] [PATCH] ib_ipoib: fix race detaching from mcast group before attaching

2007-03-19 Thread Sean Hefty
What's the theory here? It's not obvious why moving the call to ib_sa_free_multicast() fixes the race... The attach QP only occurs in the context of the multicast callback thread. ib_sa_free_multicast() blocks until the callback returns, which ensures that the detach check/call (which is now

Re: [ofa-general] [PATCH] ib_ipoib: fix race detaching from mcast group before attaching

2007-03-19 Thread Roland Dreier
The attach QP only occurs in the context of the multicast callback thread. ib_sa_free_multicast() blocks until the callback returns, which ensures that the detach check/call (which is now done after ib_sa_free_multicast) cannot race with the attach call. OK, makes sense. Do we have

[ofa-general] [PATCH] ib_ipoib: fix race detaching from mcast group before attaching

2007-03-08 Thread Sean Hefty
I believe this is a simple fix for the detach before attach race that Roland pointed out. I only did some limited testing on my systems, so I can't say that it will fully fix bug report 400. Roland, if this looks good to you, let me know and I can push it out to my git tree. Signed-off-by: Sean