Re: [VOTE] Release Apache DataSketches-cpp 2.0.0-incubating-rc2

2020-05-22 Thread Justin Mclean
Hi, +1 (binding) I checked: - incubating in name - signatures and hashes are fine - LICENSE and NOTICE good - No unexpected binary files - This file [1] is missing an ASF header an/or is of unknown license. I’m guessing it just missing a header? - Can compile from source It might be a good

Re: [VOTE] Release Apache DataSketches-cpp 2.0.0-incubating-rc2

2020-05-19 Thread Furkan KAMACI
Hi, +1 from me (binding, carrying over). I checked: - Incubating in name - DISCLAIMER-WIP exists - LICENSE and NOTICE are fine - Checked PGP signatures - Checked Checksums - cmake, make, make test for cpp - python wrapper build (tried with python3) Kind Regards, Furkan KAMACI On Wed, May 20,