[gentoo-commits] repo/gentoo:master commit in: sci-libs/rocSOLVER/files/, sci-libs/rocSOLVER/
commit: 640e352f19bbc428ce82f043b15f6677dfdc26ea
Author: Benda Xu gentoo org>
AuthorDate: Fri Jul 28 14:34:37 2023 +
Commit: Benda XU gentoo org>
CommitDate: Sat Jul 29 02:54:49 2023 +
URL:https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=640e352f
sci-libs/rocSOLVER: non-versioned dependency on libfmt.
Version bump to 5.4.2, in line with rocBLAS.
Bug: https://bugs.gentoo.org/908651
Signed-off-by: Benda Xu gentoo.org>
sci-libs/rocSOLVER/Manifest| 1 +
.../rocSOLVER/files/rocSOLVER-5.4.2-libfmt9.patch | 34 ++
...LVER-5.1.3.ebuild => rocSOLVER-5.1.3-r1.ebuild} | 6 ++--
...cSOLVER-5.1.3.ebuild => rocSOLVER-5.4.2.ebuild} | 11 +++
4 files changed, 42 insertions(+), 10 deletions(-)
diff --git a/sci-libs/rocSOLVER/Manifest b/sci-libs/rocSOLVER/Manifest
index 24a5bc028509..35de2a25db03 100644
--- a/sci-libs/rocSOLVER/Manifest
+++ b/sci-libs/rocSOLVER/Manifest
@@ -1 +1,2 @@
DIST rocSOLVER-5.1.3.tar.gz 545627 BLAKE2B
2cca24a1310efba7f8c66d1614fb50704221ebc8aa50d6aba11083baf9a7427575642fd28218ce80f8a7b83d3406348c2dd18373fb32e533509d01d37cf06927
SHA512
38e7a4ed6b67e83960ad3416d1008f82f895d19dc85427cd6f9c76f00b1ce18f78a4dd73d1ab53ffe81588890cd5545315029e903e2e09b85d6cfb854d405753
+DIST rocSOLVER-5.4.2.tar.gz 674866 BLAKE2B
0628353d567da92e3f7c3a11e19859329f3ea916184d554ee9c7172084ee4698c93408f397f493331d4dc47d833c56ead41bb4445081ba9ac73809ca0478770c
SHA512
b3a60c65a18c3864568e1e0b1524850eb1b322f6005cf8a2763c9b457e43e03c8ce74be1d13f3cc3adef1f6ac979f54fb903831f4a60447a9a915a40dcbe5ff6
diff --git a/sci-libs/rocSOLVER/files/rocSOLVER-5.4.2-libfmt9.patch
b/sci-libs/rocSOLVER/files/rocSOLVER-5.4.2-libfmt9.patch
new file mode 100644
index ..3e0ef897b71e
--- /dev/null
+++ b/sci-libs/rocSOLVER/files/rocSOLVER-5.4.2-libfmt9.patch
@@ -0,0 +1,34 @@
+commit bafa8f30b6f83d5f02bb65bb47b2943a0cb3c290
+Author: Cory Bloor
+Date: Wed Jan 25 14:52:35 2023 -0700
+
+Fix use of fmt 9.0 and later in logging test (#515)
+
+The implicitly defined formatter that rocsolver was using for
+std::filesystem::path has been removed from fmt 9.0 and later.
+
+This change doesn't actually fix compatibility with the official
+fmt 9.0 or 9.1 releases, because those releases are still
+incompatible with HIP. However, the change is sufficient for using
+rocsolver with fmt@9 from Spack (because the fix has been backported).
+
+diff --git a/clients/gtest/logging_gtest.cpp b/clients/gtest/logging_gtest.cpp
+index e4f594a..da7ae04 100644
+--- a/clients/gtest/logging_gtest.cpp
b/clients/gtest/logging_gtest.cpp
+@@ -1,5 +1,5 @@
+ /*
+- * Copyright (c) 2022 Advanced Micro Devices, Inc.
++ * Copyright (c) 2022-2023 Advanced Micro Devices, Inc.
+ * */
+
+ #include
+@@ -49,7 +49,7 @@ protected:
+ {
+ if(HasFailure() && std::getenv("ROCSOLVER_TEST_DEBUG"))
+ fmt::print(stderr, "ROCSOLVER_TEST_DEBUG is set so {} was not
removed.\n",
+- log_filepath);
++ log_filepath.string());
+ else
+ EXPECT_TRUE(fs::remove(log_filepath));
+ }
diff --git a/sci-libs/rocSOLVER/rocSOLVER-5.1.3.ebuild
b/sci-libs/rocSOLVER/rocSOLVER-5.1.3-r1.ebuild
similarity index 94%
copy from sci-libs/rocSOLVER/rocSOLVER-5.1.3.ebuild
copy to sci-libs/rocSOLVER/rocSOLVER-5.1.3-r1.ebuild
index e2db9aba2a19..11cedfb8deff 100644
--- a/sci-libs/rocSOLVER/rocSOLVER-5.1.3.ebuild
+++ b/sci-libs/rocSOLVER/rocSOLVER-5.1.3-r1.ebuild
@@ -1,4 +1,4 @@
-# Copyright 1999-2022 Gentoo Authors
+# Copyright 1999-2023 Gentoo Authors
# Distributed under the terms of the GNU General Public License v2
EAPI=8
@@ -19,8 +19,8 @@ IUSE="test benchmark"
REQUIRED_USE="${ROCM_REQUIRED_USE}"
RDEPEND="dev-util/hip
- sci-libs/rocBLAS:${SLOT}[${ROCM_USEDEP}]
- =dev-libs/libfmt-8*
+ sci-libs/rocBLAS[${ROCM_USEDEP}]
+ dev-libs/libfmt
benchmark? ( virtual/blas )"
DEPEND="${RDEPEND}"
BDEPEND="test? ( dev-cpp/gtest
diff --git a/sci-libs/rocSOLVER/rocSOLVER-5.1.3.ebuild
b/sci-libs/rocSOLVER/rocSOLVER-5.4.2.ebuild
similarity index 89%
rename from sci-libs/rocSOLVER/rocSOLVER-5.1.3.ebuild
rename to sci-libs/rocSOLVER/rocSOLVER-5.4.2.ebuild
index e2db9aba2a19..dce60e072b37 100644
--- a/sci-libs/rocSOLVER/rocSOLVER-5.1.3.ebuild
+++ b/sci-libs/rocSOLVER/rocSOLVER-5.4.2.ebuild
@@ -1,4 +1,4 @@
-# Copyright 1999-2022 Gentoo Authors
+# Copyright 1999-2023 Gentoo Authors
# Distributed under the terms of the GNU General Public License v2
EAPI=8
@@ -19,18 +19,15 @@ IUSE="test benchmark"
REQUIRED_USE="${ROCM_REQUIRED_USE}"
RDEPEND="dev-util/hip
- sci-libs/rocBLAS:${SLOT}[${ROCM_USEDEP}]
- =dev-libs/libfmt-8*
+ sci-libs/rocBLAS[${ROCM_USEDEP}]
+
[gentoo-commits] repo/gentoo:master commit in: sci-libs/rocSOLVER/files/, sci-libs/rocSOLVER/
commit: e9a8348da87fb46b8e959b2a0bf29cd298159cf1
Author: Andreas Sturmlechner gentoo org>
AuthorDate: Sun Dec 18 11:36:02 2022 +
Commit: Andreas Sturmlechner gentoo org>
CommitDate: Mon Dec 19 14:00:05 2022 +
URL:https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=e9a8348d
sci-libs/rocSOLVER: drop 4.3.0-r1
Signed-off-by: Andreas Sturmlechner gentoo.org>
sci-libs/rocSOLVER/Manifest| 1 -
.../files/rocSOLVER-4.3.0-link-blas.patch | 21 --
sci-libs/rocSOLVER/rocSOLVER-4.3.0-r1.ebuild | 75 --
3 files changed, 97 deletions(-)
diff --git a/sci-libs/rocSOLVER/Manifest b/sci-libs/rocSOLVER/Manifest
index d0a72473309d..5ec5697c61bf 100644
--- a/sci-libs/rocSOLVER/Manifest
+++ b/sci-libs/rocSOLVER/Manifest
@@ -1,3 +1,2 @@
-DIST rocSOLVER-4.3.0.tar.gz 454249 BLAKE2B
727ae416d85c5a19983257d2a0b01836013c1d69cddf3334b2c1b808b96b401db938b46b7ecf1e7faf26ff555374d1d3abed74abbe7be47110a36b44019469ee
SHA512
2910e1cfad4d17a2877e2ae572d80179b84903c632652571c01bd12856c92c22e073ea1005ed9aac04244b4c502a7e0c18d96445e57658ae8eb5b320bada549b
DIST rocSOLVER-5.0.2.tar.gz 530085 BLAKE2B
f3c3594b5ee2703424da289cc0c520a589da28f9d3f4c04d81cace35a4f77f3ca79ff9a1e7139d83d7a2ae1907083aded99b5d9fbe216d81b225dc1b9fc4105b
SHA512
ab349044aba0c1b6b7d0019d15f2bdf068805d2da73790f424ae90835f2d7dd4137d0a641d8edbf98fcb190989f0d0fa57dfc448a376a19e21fd62940046b3a1
DIST rocSOLVER-5.1.3.tar.gz 545627 BLAKE2B
2cca24a1310efba7f8c66d1614fb50704221ebc8aa50d6aba11083baf9a7427575642fd28218ce80f8a7b83d3406348c2dd18373fb32e533509d01d37cf06927
SHA512
38e7a4ed6b67e83960ad3416d1008f82f895d19dc85427cd6f9c76f00b1ce18f78a4dd73d1ab53ffe81588890cd5545315029e903e2e09b85d6cfb854d405753
diff --git a/sci-libs/rocSOLVER/files/rocSOLVER-4.3.0-link-blas.patch
b/sci-libs/rocSOLVER/files/rocSOLVER-4.3.0-link-blas.patch
deleted file mode 100644
index 407582831142..
--- a/sci-libs/rocSOLVER/files/rocSOLVER-4.3.0-link-blas.patch
+++ /dev/null
@@ -1,21 +0,0 @@
-Should link blas otherwise ld return error adding symbols: DSO missing from
command line
orig/clients/benchmarks/CMakeLists.txt
-+++ rocSOLVER-rocm-4.3.0/clients/benchmarks/CMakeLists.txt
-@@ -17,6 +17,7 @@ target_include_directories( rocsolver-be
- )
-
- target_link_libraries( rocsolver-bench PRIVATE
-+ blas
- cblas
- lapack
- Threads::Threads
orig/clients/gtest/CMakeLists.txt
-+++ rocSOLVER-rocm-4.3.0/clients/gtest/CMakeLists.txt
-@@ -87,6 +87,7 @@ target_include_directories( rocsolver-te
- )
-
- target_link_libraries( rocsolver-test PRIVATE
-+ blas
- cblas
- lapack
- GTest::GTest
diff --git a/sci-libs/rocSOLVER/rocSOLVER-4.3.0-r1.ebuild
b/sci-libs/rocSOLVER/rocSOLVER-4.3.0-r1.ebuild
deleted file mode 100644
index 6287d7b096d5..
--- a/sci-libs/rocSOLVER/rocSOLVER-4.3.0-r1.ebuild
+++ /dev/null
@@ -1,75 +0,0 @@
-# Copyright 1999-2022 Gentoo Authors
-# Distributed under the terms of the GNU General Public License v2
-
-EAPI=7
-
-inherit cmake
-
-DESCRIPTION="Implementation of a subset of LAPACK functionality on the ROCm
platform"
-HOMEPAGE="https://github.com/ROCmSoftwarePlatform/rocSOLVER;
-SRC_URI="https://github.com/ROCmSoftwarePlatform/rocSOLVER/archive/rocm-${PV}.tar.gz
-> rocSOLVER-${PV}.tar.gz"
-
-LICENSE="BSD"
-KEYWORDS="~amd64"
-SLOT="0/$(ver_cut 1-2)"
-
-IUSE="test benchmark"
-
-RDEPEND="dev-util/hip
- sci-libs/rocBLAS:${SLOT}
- benchmark? ( virtual/blas )"
-DEPEND="${RDEPEND}"
-BDEPEND="test? ( dev-cpp/gtest
- virtual/blas )"
-
-PATCHES=(
- "${FILESDIR}/rocSOLVER-4.2.0-add-stdint-header.patch"
- "${FILESDIR}/rocSOLVER-4.3.0-link-blas.patch"
-)
-
-RESTRICT="!test? ( test )"
-
-S=${WORKDIR}/${PN}-rocm-${PV}
-
-src_prepare() {
- sed -e "s: PREFIX rocsolver:# PREFIX rocsolver:" -i
library/src/CMakeLists.txt
- sed -e
"s:\$:\$:" -i
library/src/CMakeLists.txt
- sed -e "s:rocm_install_symlink_subdir( rocsolver
):#rocm_install_symlink_subdir( rocsolver ):" -i library/src/CMakeLists.txt
-
- cmake_src_prepare
-}
-
-src_configure() {
- # Grant access to the device
- addwrite /dev/kfd
- addpredict /dev/dri/
-
- local mycmakeargs=(
- -Wno-dev
- -DCMAKE_SKIP_RPATH=ON
- -DCMAKE_INSTALL_PREFIX="${EPREFIX}/usr/"
- -DCMAKE_INSTALL_INCLUDEDIR="${EPREFIX}/usr/include/rocsolver"
- -DBUILD_CLIENTS_SAMPLES=NO
- -DBUILD_CLIENTS_TESTS=$(usex test ON OFF)
- -DBUILD_CLIENTS_BENCHMARKS=$(usex benchmark ON OFF)
- ${AMDGPU_TARGETS+-DAMDGPU_TARGETS="${AMDGPU_TARGETS}"}
- )
-
- CXX="hipcc" cmake_src_configure
-}
-
-src_test() {
- addwrite /dev/kfd
- addwrite /dev/dri/
- cd "${BUILD_DIR}/clients/staging" || die
- LD_LIBRARY_PATH="${BUILD_DIR}/library/src" ./rocsolver-test || die
-}
-
-src_install() {
- cmake_src_install
-
- if use
[gentoo-commits] repo/gentoo:master commit in: sci-libs/rocSOLVER/files/, sci-libs/rocSOLVER/
commit: b3cd05705d2a74e713b497ce76a9decd3f277541
Author: Yiyang Wu gmail com>
AuthorDate: Thu Sep 22 03:36:49 2022 +
Commit: Andrew Ammerlaan gentoo org>
CommitDate: Thu Sep 22 10:18:42 2022 +
URL:https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=b3cd0570
sci-libs/rocSOLVER: clean redundant file
Fixes QA warning
Signed-off-by: Yiyang Wu gmail.com>
Closes: https://github.com/gentoo/gentoo/pull/27394
Signed-off-by: Andrew Ammerlaan gentoo.org>
.../rocSOLVER/files/rocSOLVER-5.1.3-libfmt8.patch | 173 -
sci-libs/rocSOLVER/rocSOLVER-5.1.3.ebuild | 2 +-
2 files changed, 1 insertion(+), 174 deletions(-)
diff --git a/sci-libs/rocSOLVER/files/rocSOLVER-5.1.3-libfmt8.patch
b/sci-libs/rocSOLVER/files/rocSOLVER-5.1.3-libfmt8.patch
deleted file mode 100644
index 3f2c0553689b..
--- a/sci-libs/rocSOLVER/files/rocSOLVER-5.1.3-libfmt8.patch
+++ /dev/null
@@ -1,173 +0,0 @@
-Backported from upstream to fix dev-cpp/libfmt-8 compatibility
-
-remove changes of CHANGELOG.md from original git commit
-
-From 2bbfb8976f6e4d667499c77e41a6433850063e88 Mon Sep 17 00:00:00 2001
-From: Cory Bloor
-Date: Tue, 8 Feb 2022 23:53:57 -0700
-Subject: [PATCH] Fix compatibility with fmt v8.1 (#371)
-
-* Make rocsolver_logvalue fmt specializations const
-
-This allows for compile-time format string processing in fmt v8.0.
-
-* Fix compatibility with fmt v7.1
-
-* Update CHANGELOG.md
- CHANGELOG.md | 2 ++
- library/src/include/rocsolver_logvalue.hpp | 38 +-
- 2 files changed, 25 insertions(+), 15 deletions(-)
-
-diff --git a/library/src/include/rocsolver_logvalue.hpp
b/library/src/include/rocsolver_logvalue.hpp
-index 199f8d57d..9b3791031 100644
a/library/src/include/rocsolver_logvalue.hpp
-+++ b/library/src/include/rocsolver_logvalue.hpp
-@@ -1,5 +1,5 @@
- /*
-- * Copyright (c) 2021 Advanced Micro Devices, Inc.
-+ * Copyright (c) 2021-2022 Advanced Micro Devices, Inc.
- * */
-
- #pragma once
-@@ -8,6 +8,14 @@
-
- #include "rocsolver_datatype2string.hpp"
-
-+/* The format function for user-defined types cannot be const before fmt v8.0
-+ but must be const in fmt v8.1 if the type is used in a tuple. */
-+#if FMT_VERSION < 8
-+#define ROCSOLVER_FMT_CONST
-+#else
-+#define ROCSOLVER_FMT_CONST const
-+#endif
-+
- /***
- * Wrapper for types passed to logger, so we can more easily adjust the
- * default way of printing built-in types without doing it globally. (e.g.
-@@ -37,7 +45,7 @@ template
- struct formatter> : formatter
- {
- template
--auto format(rocsolver_logvalue wrapper, FormatCtx& ctx)
-+auto format(rocsolver_logvalue wrapper, FormatCtx& ctx)
ROCSOLVER_FMT_CONST
- {
- return formatter::format(wrapper.value, ctx);
- }
-@@ -49,7 +57,7 @@ template <>
- struct formatter> : formatter
- {
- template
--auto format(rocsolver_logvalue wrapper, FormatCtx& ctx)
-+auto format(rocsolver_logvalue wrapper, FormatCtx& ctx)
ROCSOLVER_FMT_CONST
- {
- return formatter::format(wrapper.value ? '1' : '0', ctx);
- }
-@@ -58,7 +66,7 @@ template <>
- struct formatter> : formatter
- {
- template
--auto format(rocsolver_logvalue wrapper, FormatCtx& ctx)
-+auto format(rocsolver_logvalue wrapper, FormatCtx&
ctx) ROCSOLVER_FMT_CONST
- {
- return formatter::format(rocblas2char_operation(wrapper.value),
ctx);
- }
-@@ -67,7 +75,7 @@ template <>
- struct formatter> : formatter
- {
- template
--auto format(rocsolver_logvalue wrapper, FormatCtx& ctx)
-+auto format(rocsolver_logvalue wrapper, FormatCtx& ctx)
ROCSOLVER_FMT_CONST
- {
- return formatter::format(rocblas2char_fill(wrapper.value), ctx);
- }
-@@ -76,7 +84,7 @@ template <>
- struct formatter> : formatter
- {
- template
--auto format(rocsolver_logvalue wrapper, FormatCtx& ctx)
-+auto format(rocsolver_logvalue wrapper, FormatCtx& ctx)
ROCSOLVER_FMT_CONST
- {
- return formatter::format(rocblas2char_diagonal(wrapper.value),
ctx);
- }
-@@ -85,7 +93,7 @@ template <>
- struct formatter> : formatter
- {
- template
--auto format(rocsolver_logvalue wrapper, FormatCtx& ctx)
-+auto format(rocsolver_logvalue wrapper, FormatCtx& ctx)
ROCSOLVER_FMT_CONST
- {
- return formatter::format(rocblas2char_side(wrapper.value), ctx);
- }
-@@ -94,7 +102,7 @@ template <>
- struct formatter> : formatter
- {
- template
--auto format(rocsolver_logvalue wrapper, FormatCtx& ctx)
-+auto format(rocsolver_logvalue wrapper, FormatCtx& ctx)
ROCSOLVER_FMT_CONST
- {
- return formatter::format(rocblas2char_direct(wrapper.value),
ctx);
- }
-@@ -104,7 +112,7 @@ template <>
-
[gentoo-commits] repo/gentoo:master commit in: sci-libs/rocSOLVER/files/, sci-libs/rocSOLVER/
commit: 317b5671286e85ab9a197195d4751248efa882e4
Author: YiyangWu gmail com>
AuthorDate: Sun May 1 09:18:16 2022 +
Commit: Benda XU gentoo org>
CommitDate: Tue May 3 05:41:32 2022 +
URL:https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=317b5671
sci-libs/rocSOLVER: bump version to 5.0.2
According to
https://github.com/ROCmSoftwarePlatform/rocSOLVER/issues/367#issuecomment-1099821708
hip and low-level runtimes of rocm does not need to be the same version
with high-level libraries. Loosen dev-util/hip SLOT dependencies
All tests passed on single Radeon RX 6700XT
Package-Manager: Portage-3.0.30, Repoman-3.0.3
Signed-off-by: Yiyang Wu gmail.com>
Signed-off-by: Benda Xu gentoo.org>
sci-libs/rocSOLVER/Manifest| 1 +
.../rocSOLVER/files/rocSOLVER-5.0.2-libfmt8.patch | 173 +
sci-libs/rocSOLVER/rocSOLVER-5.0.2.ebuild | 77 +
3 files changed, 251 insertions(+)
diff --git a/sci-libs/rocSOLVER/Manifest b/sci-libs/rocSOLVER/Manifest
index e0d75a8c6951..4a48b1da3b26 100644
--- a/sci-libs/rocSOLVER/Manifest
+++ b/sci-libs/rocSOLVER/Manifest
@@ -1 +1,2 @@
DIST rocSOLVER-4.3.0.tar.gz 454249 BLAKE2B
727ae416d85c5a19983257d2a0b01836013c1d69cddf3334b2c1b808b96b401db938b46b7ecf1e7faf26ff555374d1d3abed74abbe7be47110a36b44019469ee
SHA512
2910e1cfad4d17a2877e2ae572d80179b84903c632652571c01bd12856c92c22e073ea1005ed9aac04244b4c502a7e0c18d96445e57658ae8eb5b320bada549b
+DIST rocSOLVER-5.0.2.tar.gz 530085 BLAKE2B
f3c3594b5ee2703424da289cc0c520a589da28f9d3f4c04d81cace35a4f77f3ca79ff9a1e7139d83d7a2ae1907083aded99b5d9fbe216d81b225dc1b9fc4105b
SHA512
ab349044aba0c1b6b7d0019d15f2bdf068805d2da73790f424ae90835f2d7dd4137d0a641d8edbf98fcb190989f0d0fa57dfc448a376a19e21fd62940046b3a1
diff --git a/sci-libs/rocSOLVER/files/rocSOLVER-5.0.2-libfmt8.patch
b/sci-libs/rocSOLVER/files/rocSOLVER-5.0.2-libfmt8.patch
new file mode 100644
index ..3f2c0553689b
--- /dev/null
+++ b/sci-libs/rocSOLVER/files/rocSOLVER-5.0.2-libfmt8.patch
@@ -0,0 +1,173 @@
+Backported from upstream to fix dev-cpp/libfmt-8 compatibility
+
+remove changes of CHANGELOG.md from original git commit
+
+From 2bbfb8976f6e4d667499c77e41a6433850063e88 Mon Sep 17 00:00:00 2001
+From: Cory Bloor
+Date: Tue, 8 Feb 2022 23:53:57 -0700
+Subject: [PATCH] Fix compatibility with fmt v8.1 (#371)
+
+* Make rocsolver_logvalue fmt specializations const
+
+This allows for compile-time format string processing in fmt v8.0.
+
+* Fix compatibility with fmt v7.1
+
+* Update CHANGELOG.md
+---
+ CHANGELOG.md | 2 ++
+ library/src/include/rocsolver_logvalue.hpp | 38 +-
+ 2 files changed, 25 insertions(+), 15 deletions(-)
+
+diff --git a/library/src/include/rocsolver_logvalue.hpp
b/library/src/include/rocsolver_logvalue.hpp
+index 199f8d57d..9b3791031 100644
+--- a/library/src/include/rocsolver_logvalue.hpp
b/library/src/include/rocsolver_logvalue.hpp
+@@ -1,5 +1,5 @@
+ /*
+- * Copyright (c) 2021 Advanced Micro Devices, Inc.
++ * Copyright (c) 2021-2022 Advanced Micro Devices, Inc.
+ * */
+
+ #pragma once
+@@ -8,6 +8,14 @@
+
+ #include "rocsolver_datatype2string.hpp"
+
++/* The format function for user-defined types cannot be const before fmt v8.0
++ but must be const in fmt v8.1 if the type is used in a tuple. */
++#if FMT_VERSION < 8
++#define ROCSOLVER_FMT_CONST
++#else
++#define ROCSOLVER_FMT_CONST const
++#endif
++
+ /***
+ * Wrapper for types passed to logger, so we can more easily adjust the
+ * default way of printing built-in types without doing it globally. (e.g.
+@@ -37,7 +45,7 @@ template
+ struct formatter> : formatter
+ {
+ template
+-auto format(rocsolver_logvalue wrapper, FormatCtx& ctx)
++auto format(rocsolver_logvalue wrapper, FormatCtx& ctx)
ROCSOLVER_FMT_CONST
+ {
+ return formatter::format(wrapper.value, ctx);
+ }
+@@ -49,7 +57,7 @@ template <>
+ struct formatter> : formatter
+ {
+ template
+-auto format(rocsolver_logvalue wrapper, FormatCtx& ctx)
++auto format(rocsolver_logvalue wrapper, FormatCtx& ctx)
ROCSOLVER_FMT_CONST
+ {
+ return formatter::format(wrapper.value ? '1' : '0', ctx);
+ }
+@@ -58,7 +66,7 @@ template <>
+ struct formatter> : formatter
+ {
+ template
+-auto format(rocsolver_logvalue wrapper, FormatCtx& ctx)
++auto format(rocsolver_logvalue wrapper, FormatCtx&
ctx) ROCSOLVER_FMT_CONST
+ {
+ return formatter::format(rocblas2char_operation(wrapper.value),
ctx);
+ }
+@@ -67,7 +75,7 @@ template <>
+ struct formatter> : formatter
+ {
+ template
+-auto format(rocsolver_logvalue wrapper, FormatCtx& ctx)
++auto format(rocsolver_logvalue wrapper, FormatCtx& ctx)
