Re: [gentoo-dev] [PATCH] user.eclass: die if hard coded UID or GID is already in use

2019-05-27 Thread Robin H. Johnson
On Mon, May 27, 2019 at 08:44:09PM -0400, Mike Gilbert wrote: > On Mon, May 27, 2019 at 11:45 AM William Hubbs wrote: > > > > If a package hard codes the UID or GID when adding a user or group to > > the system and that UID/GID already exists, we should abort rather than > > changing the UID/GID.

Re: [gentoo-dev] [PATCH] user.eclass: die if hard coded UID or GID is already in use

2019-05-27 Thread Michał Górny
On Mon, 2019-05-27 at 10:45 -0500, William Hubbs wrote: > If a package hard codes the UID or GID when adding a user or group to > the system and that UID/GID already exists, we should abort rather than > changing the UID/GID. I think the major usage of this argument is not to enforce a specific

Re: [gentoo-portage-dev] [PATCH] Don't modify /etc/mtab from temporary namespaces

2019-05-27 Thread Zac Medico
On 5/27/19 1:23 PM, i.Dark_Templar wrote: > These records are never removed and just pollute > /etc/mtab if that's a regular file. > And if /etc/mtab isn't a regular file, > then attempts to modify it are pointless. > --- > lib/portage/process.py | 2 +- > 1 file changed, 1 insertion(+), 1

Re: [gentoo-dev] [PATCH] user.eclass: die if hard coded UID or GID is already in use

2019-05-27 Thread Mike Gilbert
On Mon, May 27, 2019 at 11:45 AM William Hubbs wrote: > > If a package hard codes the UID or GID when adding a user or group to > the system and that UID/GID already exists, we should abort rather than > changing the UID/GID. These functions have behaved this way for a long time. What problem

[gentoo-portage-dev] [PATCH] Don't modify /etc/mtab from temporary namespaces

2019-05-27 Thread i.Dark_Templar
These records are never removed and just pollute /etc/mtab if that's a regular file. And if /etc/mtab isn't a regular file, then attempts to modify it are pointless. --- lib/portage/process.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/portage/process.py

[gentoo-dev] [PATCH] user.eclass: die if hard coded UID or GID is already in use

2019-05-27 Thread William Hubbs
If a package hard codes the UID or GID when adding a user or group to the system and that UID/GID already exists, we should abort rather than changing the UID/GID. --- eclass/user.eclass | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/eclass/user.eclass