Le mardi 10 septembre 2013 à 17:10 +0200, Fabian Groffen a écrit :
On 10-09-2013 06:22:38 -0400, Ian Stakenvicius wrote:
pkg_preinst() {
gnome2_gdk_pixbuf_savelist
+
+ # Make sure loaders.cache belongs to gdk-pixbuf alone
+ local
On 11-09-2013 10:51:22 +0200, Gilles Dartiguelongue wrote:
shouldn't that be EROOT ?
and ED in that case too
Do we still use that in EAPI 3 ?
EROOT = ROOT + EPREFIX
ED = D + EPREFIX
Unless I misunderstand your question, that means yes, we do to me.
Fabian
--
Fabian Groffen
Gentoo
On 2013-09-09, at 7:31 PM, Alex Xu alex_y...@yahoo.ca wrote:
On 09/09/13 08:29 PM, Gilles Dartiguelongue wrote:
[1;32mIndex: gdk-pixbuf-2.28.2.ebuild[0;0m
[1;32m===[0;0m
[1;32mRCS file:
On 10-09-2013 06:22:38 -0400, Ian Stakenvicius wrote:
pkg_preinst() {
gnome2_gdk_pixbuf_savelist
+
+ # Make sure loaders.cache belongs to gdk-pixbuf alone
+ local cache=usr/$(get_libdir)/${PN}-2.0/2.10.0/loaders.cache
+
+ if [[ -e ${ROOT}${cache} ]]; then
+
As a follow up to this discussion, I came with the attached patch. It
appears to work ok for regular merges and binpkg merges with
FEATURES=collision-protect.
Per my reading of PMS it does not appear to violate anything so I guess
it is ok.
--
Gilles Dartiguelongue e...@gentoo.org
Gentoo
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
On 09/10/2013 02:29 AM, Gilles Dartiguelongue wrote:
As a follow up to this discussion, I came with the attached patch.
It appears to work ok for regular merges and binpkg merges with
FEATURES=collision-protect.
Per my reading of PMS it does
On 09/09/13 08:29 PM, Gilles Dartiguelongue wrote:
[1;32mIndex: gdk-pixbuf-2.28.2.ebuild[0;0m
[1;32m===[0;0m
[1;32mRCS file:
/var/cvsroot/gentoo-x86/x11-libs/gdk-pixbuf/gdk-pixbuf-2.28.2.ebuild,v[0;0m
[1;32mretrieving
One last point to handle, how to migrate gdk-pixbuf.cache so that it is
owned by the ebuild ?
I've discussed this with Michał and it seems two options are possible.
1. rm the file on the filesystem in pkg_preinst in gdk-pixbuf ebuild
pros:
- works immediately without fiddling with profiles
Dnia 2013-09-04, o godz. 20:57:41
Gilles Dartiguelongue e...@gentoo.org napisał(a):
One last point to handle, how to migrate gdk-pixbuf.cache so that it is
owned by the ebuild ?
I've discussed this with Michał and it seems two options are possible.
1. rm the file on the filesystem in
On 09/04/2013 12:44 PM, Gilles Dartiguelongue wrote:
Le mercredi 04 septembre 2013 à 15:23 -0400, Ian Stakenvicius a écrit :
If you want to do that *and* maintain whatever is currently in that
file, you can use the trick sys-apps/openrc used to do: in
pkg_preinst, copy the system file (if it
Le mercredi 04 septembre 2013 à 15:48 -0400, Ian Stakenvicius a écrit :
On 04/09/13 03:44 PM, Gilles Dartiguelongue wrote:
Le mercredi 04 septembre 2013 à 15:23 -0400, Ian Stakenvicius a
écrit : [snip]
By gdk-pixbuf.cache , you mean the 'loaders.cache' file that the
eclass is now
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA256
On 04/09/13 04:19 PM, Gilles Dartiguelongue wrote:
Le mercredi 04 septembre 2013 à 15:48 -0400, Ian Stakenvicius a
écrit :
You had FEATURES=collision-protect enabled or the default
FEATURES=protect-owned ?
the default, but since I only
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA256
On 04/09/13 03:48 PM, Ian Stakenvicius wrote:
No, it still does collide that first time if
FEATURES=collision-protect is enabled. In fact, I do not
believe there is (by design) any way for this ebuild to 'take
ownership' of a file it doesn't
Le samedi 31 août 2013 à 18:44 +0200, Gilles Dartiguelongue a écrit :
Le samedi 31 août 2013 à 16:49 +0200, Michał Górny a écrit :
Dnia 2013-08-31, o godz. 15:00:43
Gilles Dartiguelongue e...@gentoo.org napisał(a):
Le samedi 31 août 2013 à 13:40 +0200, Michał Górny a écrit :
+
Dnia 2013-09-01, o godz. 13:29:27
Gilles Dartiguelongue e...@gentoo.org napisał(a):
Le samedi 31 août 2013 à 18:44 +0200, Gilles Dartiguelongue a écrit :
Le samedi 31 août 2013 à 16:49 +0200, Michał Górny a écrit :
Dnia 2013-08-31, o godz. 15:00:43
Gilles Dartiguelongue e...@gentoo.org
Updated diffs + gdk-pixbuf handling.
Tested with success locally.
--
Gilles Dartiguelongue e...@gentoo.org
Gentoo
Index: gnome2.eclass
===
RCS file: /var/cvsroot/gentoo-x86/eclass/gnome2.eclass,v
retrieving revision 1.122
diff -u
As described here:
https://bugs.gentoo.org/show_bug.cgi?id=483128
This is a very lightweight patch to support the few packages that
provide gdk pixbuf loaders. The ones I know of are: gdk-pixbuf itself,
librsvg and libopenraw and emul-gtklibs but more could be missing simply
because they do not
Dnia 2013-08-31, o godz. 13:07:41
Gilles Dartiguelongue e...@gentoo.org napisał(a):
+# @FUNCTION: gnome2_gdk_pixbuf_savelist
+# @DESCRIPTION:
+# Find if there is any gdk-pixbuf loader to install and save the list in
+# GNOME2_ECLASS_GDK_PIXBUF_LOADERS variable.
+# This function should be
Le samedi 31 août 2013 à 13:40 +0200, Michał Górny a écrit :
Dnia 2013-08-31, o godz. 13:07:41
Gilles Dartiguelongue e...@gentoo.org napisał(a):
+# @FUNCTION: gnome2_gdk_pixbuf_savelist
+# @DESCRIPTION:
+# Find if there is any gdk-pixbuf loader to install and save the list in
+#
On 31/08/13 09:00 AM, Gilles Dartiguelongue wrote:
And please ensure to remove it in pkg_postrm() when last version
of gdk-pixbuf is unmerged.
I am not clear on this last sentence. Could you reformulate it please ?
Ensure that the loaders.cache file is removed correctly when all
versions of
Dnia 2013-08-31, o godz. 15:00:43
Gilles Dartiguelongue e...@gentoo.org napisał(a):
Le samedi 31 août 2013 à 13:40 +0200, Michał Górny a écrit :
+ cat ${tmp_file}
${EROOT}usr/$(get_libdir)/gdk-pixbuf-2.0/2.10.0/loaders.cache
Why not mv or cp? Also you need '|| die' here since 'cat'
Le samedi 31 août 2013 à 16:49 +0200, Michał Górny a écrit :
Dnia 2013-08-31, o godz. 15:00:43
Gilles Dartiguelongue e...@gentoo.org napisał(a):
Le samedi 31 août 2013 à 13:40 +0200, Michał Górny a écrit :
+ cat ${tmp_file}
22 matches
Mail list logo
