Re: [gentoo-dev] [PATCH] user.eclass: die if hard coded UID or GID is already in use

2019-05-29 Thread Marek Szuba
On 2019-05-27 16:45, William Hubbs wrote: > If a package hard codes the UID or GID when adding a user or group to > the system and that UID/GID already exists, we should abort rather than > changing the UID/GID. +1. It is of course my personal opinion but years of having been working with

Re: [gentoo-dev] [PATCH] user.eclass: die if hard coded UID or GID is already in use

2019-05-28 Thread Alec Warner
On Tue, May 28, 2019 at 11:05 AM Mike Gilbert wrote: > On Tue, May 28, 2019 at 10:43 AM William Hubbs > wrote: > > > > On Tue, May 28, 2019 at 02:21:23AM -0400, Mike Gilbert wrote: > > > On Tue, May 28, 2019 at 1:41 AM Robin H. Johnson > wrote: > > > > > > > > On Mon, May 27, 2019 at

Re: [gentoo-dev] [PATCH] user.eclass: die if hard coded UID or GID is already in use

2019-05-28 Thread Mike Gilbert
On Tue, May 28, 2019 at 10:43 AM William Hubbs wrote: > > On Tue, May 28, 2019 at 02:21:23AM -0400, Mike Gilbert wrote: > > On Tue, May 28, 2019 at 1:41 AM Robin H. Johnson wrote: > > > > > > On Mon, May 27, 2019 at 08:44:09PM -0400, Mike Gilbert wrote: > > > > On Mon, May 27, 2019 at 11:45 AM

Re: [gentoo-dev] [PATCH] user.eclass: die if hard coded UID or GID is already in use

2019-05-28 Thread William Hubbs
On Tue, May 28, 2019 at 02:21:23AM -0400, Mike Gilbert wrote: > On Tue, May 28, 2019 at 1:41 AM Robin H. Johnson wrote: > > > > On Mon, May 27, 2019 at 08:44:09PM -0400, Mike Gilbert wrote: > > > On Mon, May 27, 2019 at 11:45 AM William Hubbs > > > wrote: > > > > > > > > If a package hard codes

Re: [gentoo-dev] [PATCH] user.eclass: die if hard coded UID or GID is already in use

2019-05-28 Thread Mike Gilbert
On Tue, May 28, 2019 at 1:41 AM Robin H. Johnson wrote: > > On Mon, May 27, 2019 at 08:44:09PM -0400, Mike Gilbert wrote: > > On Mon, May 27, 2019 at 11:45 AM William Hubbs wrote: > > > > > > If a package hard codes the UID or GID when adding a user or group to > > > the system and that UID/GID

Re: [gentoo-dev] [PATCH] user.eclass: die if hard coded UID or GID is already in use

2019-05-27 Thread Robin H. Johnson
On Mon, May 27, 2019 at 08:44:09PM -0400, Mike Gilbert wrote: > On Mon, May 27, 2019 at 11:45 AM William Hubbs wrote: > > > > If a package hard codes the UID or GID when adding a user or group to > > the system and that UID/GID already exists, we should abort rather than > > changing the UID/GID.

Re: [gentoo-dev] [PATCH] user.eclass: die if hard coded UID or GID is already in use

2019-05-27 Thread Michał Górny
On Mon, 2019-05-27 at 10:45 -0500, William Hubbs wrote: > If a package hard codes the UID or GID when adding a user or group to > the system and that UID/GID already exists, we should abort rather than > changing the UID/GID. I think the major usage of this argument is not to enforce a specific

Re: [gentoo-dev] [PATCH] user.eclass: die if hard coded UID or GID is already in use

2019-05-27 Thread Mike Gilbert
On Mon, May 27, 2019 at 11:45 AM William Hubbs wrote: > > If a package hard codes the UID or GID when adding a user or group to > the system and that UID/GID already exists, we should abort rather than > changing the UID/GID. These functions have behaved this way for a long time. What problem

[gentoo-dev] [PATCH] user.eclass: die if hard coded UID or GID is already in use

2019-05-27 Thread William Hubbs
If a package hard codes the UID or GID when adding a user or group to the system and that UID/GID already exists, we should abort rather than changing the UID/GID. --- eclass/user.eclass | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/eclass/user.eclass