Re: [gentoo-dev] [PATCH 01/12] toolchain.eclass: remove EAPI 5 and 6

2022-02-01 Thread Andreas K. Huettel
> Dilfridge had a proposal to ensure 3/6/12 month old systems could still > upgrade, and I'm wondering if this could break those systems. > > There are 3 commits in the last year that finally removed the EAPI 5/6 > toolchain consumers: > 486b77ab8d28c5bfd5a4bdfc5f9a5f432ffde563 >

Re: [gentoo-dev] [PATCH 01/12] toolchain.eclass: remove EAPI 5 and 6

2022-02-01 Thread Robin H. Johnson
At a technical level, it looks fine. But I want to clarify interaction for old systems. Dilfridge had a proposal to ensure 3/6/12 month old systems could still upgrade, and I'm wondering if this could break those systems. There are 3 commits in the last year that finally removed the EAPI 5/6

Re: [gentoo-dev] [PATCH 01/12] toolchain.eclass: remove EAPI 5 and 6

2022-01-29 Thread Sam James
> On 29 Jan 2022, at 17:31, David Seifert wrote: > > Signed-off-by: David Seifert > -- series lgtm Best, sam signature.asc Description: Message signed with OpenPGP

Re: [gentoo-dev] [PATCH 01/12] toolchain.eclass: remove EAPI 5 and 6

2022-01-29 Thread Michał Górny
The series LGTM from visual review. Note that I haven't verified the variable moves in wider context. -- Best regards, Michał Górny

[gentoo-dev] [PATCH 01/12] toolchain.eclass: remove EAPI 5 and 6

2022-01-29 Thread David Seifert
Signed-off-by: David Seifert --- eclass/toolchain.eclass | 110 +++- 1 file changed, 40 insertions(+), 70 deletions(-) diff --git a/eclass/toolchain.eclass b/eclass/toolchain.eclass index 61718f0d9a0..741b6dfbbcc 100644 --- a/eclass/toolchain.eclass +++