Re: [gentoo-dev] Calling unknown commands in an ebuild

2010-02-08 Thread Peter Volkov
В Вск, 07/02/2010 в 21:24 -0500, Mike Frysinger пишет: it might also be useful to add a default epatch() to the initial env that would be clobbered when the inherit occurred. epatch() { die you need to inherit eutils.eclass to use epatch ; } After fixing breakage that was introduced by

[gentoo-dev] Calling unknown commands in an ebuild

2010-02-07 Thread Stelian Ionescu
Wouldn't it be a good idea to use set -e in the ebuild environment ? I've seen cases of ebuilds calling epatch without inheriting from eutils which compiled and installed (apparently) fine but possibly broken binaries. Examples of cases where set -e would have helped: 303849, 297063, 260279,

Re: [gentoo-dev] Calling unknown commands in an ebuild

2010-02-07 Thread Zac Medico
On 02/07/2010 01:10 PM, Stelian Ionescu wrote: Wouldn't it be a good idea to use set -e in the ebuild environment ? I've seen cases of ebuilds calling epatch without inheriting from eutils which compiled and installed (apparently) fine but possibly broken binaries. Examples of cases where set

Re: [gentoo-dev] Calling unknown commands in an ebuild

2010-02-07 Thread Tomas Touceda
El 07/02/2010, a las 18:19, Zac Medico zmed...@gentoo.org escribió: On 02/07/2010 01:10 PM, Stelian Ionescu wrote: Wouldn't it be a good idea to use set -e in the ebuild environment ? I've seen cases of ebuilds calling epatch without inheriting from eutils which compiled and installed

Re: [gentoo-dev] Calling unknown commands in an ebuild

2010-02-07 Thread Stelian Ionescu
On Sun, 2010-02-07 at 14:19 -0800, Zac Medico wrote: On 02/07/2010 01:10 PM, Stelian Ionescu wrote: Wouldn't it be a good idea to use set -e in the ebuild environment ? I've seen cases of ebuilds calling epatch without inheriting from eutils which compiled and installed (apparently) fine

Re: [gentoo-dev] Calling unknown commands in an ebuild

2010-02-07 Thread Mike Frysinger
On Sunday 07 February 2010 16:10:10 Stelian Ionescu wrote: Wouldn't it be a good idea to use set -e in the ebuild environment ? I've seen cases of ebuilds calling epatch without inheriting from eutils which compiled and installed (apparently) fine but possibly broken binaries. this is not the

Re: [gentoo-dev] Calling unknown commands in an ebuild

2010-02-07 Thread Mike Frysinger
On Sunday 07 February 2010 17:19:43 Zac Medico wrote: On 02/07/2010 01:10 PM, Stelian Ionescu wrote: Wouldn't it be a good idea to use set -e in the ebuild environment ? I've seen cases of ebuilds calling epatch without inheriting from eutils which compiled and installed (apparently) fine

Re: [gentoo-dev] Calling unknown commands in an ebuild

2010-02-07 Thread Rémi Cardona
Le 08/02/2010 03:24, Mike Frysinger a écrit : if we wanted to specifically target semi-common errors (and i think 'epatch' w/out eutils.eclass falls into this category), then a repoman check would be good. it might also be useful to add a default epatch() to the initial env that would be