[gentoo-dev] Initial review for github-snapshot.eclass

2011-05-31 Thread Michał Górny
Hello all, As I suggested earlier, I'm attaching an example implementation of github-snapshot.eclass. All the eclass does is providing a default src_unpack() unpacking the github snapshot into ${S}. Right now it simply does call default src_unpack() and then does a fuzzy `mv' but that can change

Re: [gentoo-dev] Initial review for github-snapshot.eclass

2011-05-31 Thread William Hubbs
Hi, If you use this eclass, how should your ebuild specify the commit you want to take the snapshot from? Your example doesn't show how to do that. William pgpmaKTWUJ4tm.pgp Description: PGP signature

Re: [gentoo-dev] Initial review for github-snapshot.eclass

2011-05-31 Thread Mike Gilbert
On Tue, May 31, 2011 at 10:24 AM, Michał Górny mgo...@gentoo.org wrote: Hello all, As I suggested earlier, I'm attaching an example implementation of github-snapshot.eclass. case ${EAPI:-0} in 0|1) die EAPI ${EAPI} unsupported.;; 2|3|4) ;; *) die

Re: [gentoo-dev] Initial review for github-snapshot.eclass

2011-05-31 Thread Michał Górny
On Tue, 31 May 2011 15:07:17 -0400 Mike Gilbert floppymas...@gmail.com wrote: case ${EAPI:-0} in 0|1) die EAPI ${EAPI} unsupported.;; 2|3|4) ;; *) die github-snapshot.eclass API in EAPI ${EAPI} not yet established. esac Why are EAPI 0 and 1 unsupported? I don't see

Re: [gentoo-dev] Initial review for github-snapshot.eclass

2011-05-31 Thread William Hubbs
On Tue, May 31, 2011 at 04:24:23PM +0200, Michał Górny wrote: EAPI=4 inherit github-snapshot DESCRIPTION=Random github package HOMEPAGE=https://github.com/foo/bar; bar is actually ${PN}. SRC_URI=http://github.com/foo/${PN}/tarball/${P} - ${P}.tar.gz The first ${P} above isn't right,

Re: [gentoo-dev] Initial review for github-snapshot.eclass

2011-05-31 Thread Michał Górny
On Tue, 31 May 2011 14:28:00 -0500 William Hubbs willi...@gentoo.org wrote: On Tue, May 31, 2011 at 04:24:23PM +0200, Michał Górny wrote: EAPI=4 inherit github-snapshot DESCRIPTION=Random github package HOMEPAGE=https://github.com/foo/bar; bar is actually ${PN}. AFAIK it is a

Re: [gentoo-dev] Initial review for github-snapshot.eclass

2011-05-31 Thread Brian Harring
On Tue, May 31, 2011 at 04:24:23PM +0200, Michał Górny wrote: Hello all, As I suggested earlier, I'm attaching an example implementation of github-snapshot.eclass. All the eclass does is providing a default src_unpack() unpacking the github snapshot into ${S}. Right now it simply does

Re: [gentoo-dev] Initial review for github-snapshot.eclass

2011-05-31 Thread Michał Górny
On Tue, 31 May 2011 13:40:42 -0700 Brian Harring ferri...@gmail.com wrote: A function to generate a github url for SRC_URI is likely warranted; should they ever grow mirrors/change their scheme, we can change it in one spot. Plus it makes it easier for ebuild devs to specify the url ;) I