Re: [gentoo-dev] Modular texlive eclasses up for review

2007-10-10 Thread Alexis Ballier
On Tue, 09 Oct 2007 14:49:05 +0200 Francesco Riosa [EMAIL PROTECTED] wrote: Roy Marples ha scritto: On Tue, 2007-10-09 at 13:17 +0200, Alexis Ballier wrote: if [ ${f/config/} != ${f} ] Should be if [ ${f#*config*} != ${f} ] Should be if [ ${f#*config} != ${f} ] the

Re: [gentoo-dev] Modular texlive eclasses up for review

2007-10-09 Thread Roy Marples
On Tue, 2007-10-09 at 01:03 +0200, Alexis Ballier wrote: On Mon, 8 Oct 2007 23:47:31 +0200 Alexis Ballier [EMAIL PROTECTED] wrote: Hi list, Try 2, after dberkholz comments on irc: - replaced test by [] - removed useless use of cat Alexis. grep '^!' ${i} | tr ' ' '=' |sort|uniq

Re: [gentoo-dev] Modular texlive eclasses up for review

2007-10-09 Thread Alexis Ballier
On Tue, 09 Oct 2007 08:13:31 +0100 Roy Marples [EMAIL PROTECTED] wrote: grep '^!' ${i} | tr ' ' '=' |sort|uniq ${T}/jobs Could be done with a 1 sed and 1 sort call, but whatever floats your boat. well as this is very inspired from texlive install-pkg.sh script, I'd prefer not differing that

Re: [gentoo-dev] Modular texlive eclasses up for review

2007-10-09 Thread Roy Marples
On Tue, 2007-10-09 at 13:17 +0200, Alexis Ballier wrote: if [ ${f/config/} != ${f} ] Should be if [ ${f#*config*} != ${f} ] changed that one, the semantics looks better indeed; what is wanted here is to exclude $f containing config. Am I missing something when I understand it as the

Re: [gentoo-dev] Modular texlive eclasses up for review

2007-10-09 Thread Francesco Riosa
Roy Marples ha scritto: On Tue, 2007-10-09 at 13:17 +0200, Alexis Ballier wrote: if [ ${f/config/} != ${f} ] Should be if [ ${f#*config*} != ${f} ] Should be if [ ${f#*config} != ${f} ] the 2nd asterisk is not needed, symmetry apart changed that one, the semantics looks better

[gentoo-dev] Modular texlive eclasses up for review

2007-10-08 Thread Alexis Ballier
Hi list, attached are two new eclasses I'm planning to commit soon. I'm sending 'em as some reviewing never hurts, but I hope they're perfectly fine ;) texlive-common.eclass : helper eclass for handling the texmf tree; it contains variable definitions used by texlive ebuilds and two functions :

Re: [gentoo-dev] Modular texlive eclasses up for review

2007-10-08 Thread Alexis Ballier
On Mon, 8 Oct 2007 23:47:31 +0200 Alexis Ballier [EMAIL PROTECTED] wrote: Hi list, Try 2, after dberkholz comments on irc: - replaced test by [] - removed useless use of cat Alexis. texlive-common.eclass Description: Binary data texlive-module.eclass Description: Binary data

Re: [gentoo-dev] Modular texlive eclasses up for review

2007-10-08 Thread Jeroen Roovers
On Tue, 9 Oct 2007 01:03:17 +0200 Alexis Ballier [EMAIL PROTECTED] wrote: Hi list, A bit of documentation for the (exported) functions would be nice. And maybe some red tape to show where the exported bits end/start. And short bits of text explaining why some of the variables are needed and