-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Please let the python herd review distutils-r1 conversions until you
feel safe about it.


On 08/16/2013 11:54 AM, Manuel Rueger (mrueg) wrote:
> Index: synaptiks-0.8.1-r3.ebuild 
> ===================================================================
>
> 
# Copyright 1999-2013 Gentoo Foundation
> # Distributed under the terms of the GNU General Public License v2 
> # $Header:
> /var/cvsroot/gentoo-x86/kde-misc/synaptiks/synaptiks-0.8.1-r3.ebuild,v
> 1.1 2013/08/16 09:54:19 mrueg Exp $
> 
> EAPI=5
> 
> KDE_HANDBOOK=optional PYTHON_COMPAT=( python2_6 python2_7 ) inherit
> kde4-base distutils-r1
> 
> DESCRIPTION="Touchpad configuration and management tool for KDE" 
> HOMEPAGE="http://synaptiks.readthedocs.org"; 
> SRC_URI="mirror://pypi/s/${PN}/${P}.tar.bz2"
> 
> LICENSE="BSD-2" SLOT="4" KEYWORDS="~amd64 ~x86" IUSE="debug doc
> +upower"
> 

You are missing [${PYTHON_USEDEP}] all over the place.
The add_kdebase_dep pykde4 seems to break it further.

> RDEPEND=" >=dev-python/PyQt4-4.7 >=dev-python/pyudev-0.8[pyqt4] 
> dev-python/setuptools $(add_kdebase_dep pykde4) || ( (
> $(add_kdebase_dep kdesdk-scripts) ) ( $(add_kdebase_dep
> kde-dev-scripts) ) ) virtual/python-argparse 
> >=x11-drivers/xf86-input-synaptics-1.3 >=x11-libs/libXi-1.4 
> x11-libs/libXtst upower? ( dev-python/dbus-python sys-power/upower
> )" DEPEND="${RDEPEND} app-text/docbook-xsl-stylesheets 
> sys-devel/gettext

These might not need [${PYTHON_USEDEP}] if scripts are called directly
only.

> doc? ( dev-python/sphinx dev-python/sphinxcontrib-issuetracker )"
> 

You overwrite distutils-r1_src_prepare, that leads to:
* PATCHES array does not work
* epatch_user is disabled
* DISTUTILS_IN_SOURCE_BUILD would not work
* _disable_ez_setup is not carried out

> src_prepare() { epatch "${FILESDIR}/${P}-templatesfix.patch"\ 
> "${FILESDIR}/${PN}-0.8.1-removedfeatures.patch" }
> 
> src_compile() { distutils-r1_src_compile if use doc; then einfo
> "Generation of documentation" pushd doc > /dev/null sphinx-build .
> _build || die popd > /dev/null fi }
> 
> src_install() { distutils-r1_src_install if use doc; then dohtml -r
> doc/_build/* fi }
> 
> 
> 
> 

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.20 (GNU/Linux)
Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/

iQEcBAEBAgAGBQJSDmJbAAoJEFpvPKfnPDWzyDsIAJZ6aSG8kA1BnI+3v0LE4Sjm
8Q7hQvUsY2Ww+Dh/H6NYysftURnZDo/zq/PGiAJSTRAsbCSI13iWRTO9c7oq3ZwF
zQAT+ur+ThHRd77eKHh3pzMX7zIlad/ZT+NPNaGuBNNGXL021YaPIl1roDnTQVDD
rFYTgrb5A9s7NxF9u4vF+mTF9NYkSvHP4Em4QYVeGeHIrt/lfvBCiJ5r8rAwYb8b
oVDX6fGcjmneEoTD2VfRb3GVHJSRtRTXLqXyLkk9KUoyPMR7PnJrDRBMVm7ewNqL
PHwqfnUu9u5FKxYzZ8grJDChmA8GOku8MUufVrAW5mzHQSMQNRqa8GfowefvSgg=
=FohH
-----END PGP SIGNATURE-----

Reply via email to