Le jeudi 02 février 2012 à 01:44 +0530, Nirbheek Chauhan a écrit :
ECLASS-VARIABLE: FTP_URI
# @DEFAULT-UNSET
# @DESCRIPTION: The ftp URI prefix for the release tarballs and
language packs.
: ${FTP_URI:=}
It might be a good idea to prefix this generic variable by MOZ_ as
well.
--
Gilles
please post it inline to make review easier
# @MAINTAINER: mozi...@gentoo.org
# @AUTHOR: Nirbheek Chauhan nirbh...@gentoo.org
goes on newline, not inlined
# @DESCRIPTION: Array containing the list of language pack xpis available
text starts on the next line, not the existing line
#
On Fri, Feb 3, 2012 at 3:26 PM, Mike Frysinger vap...@gentoo.org wrote:
please post it inline to make review easier
# @MAINTAINER: mozi...@gentoo.org
# @AUTHOR: Nirbheek Chauhan nirbh...@gentoo.org
goes on newline, not inlined
Fixed
# @DESCRIPTION: Array containing the list of language
On Friday 03 February 2012 11:44:42 Nirbheek Chauhan wrote:
On Fri, Feb 3, 2012 at 3:26 PM, Mike Frysinger vap...@gentoo.org wrote:
mozlinguas() {
missing eclass documentation
Is it really needed for private functions? Nothing should ever call this.
needed ? no. nice ? sure. up to
On Sat, Feb 4, 2012 at 12:57 AM, Mike Frysinger vap...@gentoo.org wrote:
On Friday 03 February 2012 11:44:42 Nirbheek Chauhan wrote:
On Fri, Feb 3, 2012 at 3:26 PM, Mike Frysinger vap...@gentoo.org
wrote:
mozlinguas() {
missing eclass documentation
Is it really needed for private
On Friday, February 03, 2012 10:14:42 PM Nirbheek Chauhan wrote:
if [[ ${x} = en ]] || [[ ${x} = en-US ]]; then
should be == imo
Fixed
I prefer == for [[ too, but no difference. = is required for [ by POSIX but
Bash allows either (bad though). The real issue is executing
On Thu, Feb 2, 2012 at 12:55 AM, Nirbheek Chauhan nirbh...@gentoo.org wrote:
I'd love to have the attached eclass reviewed before I commit it. For
those using gmail, here's a web copy: http://i.cx/ahp
(git.o.g.o/mozilla)
After comments from mgorny on #gentoo-dev, I've made the following
