Re: [gentoo-dev] Re: Requiring two sets of eyes for all eclass commits

2010-04-26 Thread Paul Varner
On Sun, 2010-04-25 at 13:11 +0300, Petteri Räty wrote: > On 04/25/2010 01:06 PM, Ryan Hill wrote: > > On Sat, 24 Apr 2010 20:40:54 +0300 > > Petteri Räty wrote: > > > >> What do you think about not allowing commits to eclasses without > >> mentioning an another developer who has reviewed and appr

[gentoo-dev] Re: Requiring two sets of eyes for all eclass commits

2010-04-25 Thread Ryan Hill
On Sun, 25 Apr 2010 05:01:17 -0700 Alec Warner wrote: > On Sun, Apr 25, 2010 at 4:36 AM, Ryan Hill wrote: > > said eclasses need to be reviewed before committing.  But enforcing it > > through > > cvs is never going to fly.  Just use common sense. > > Sure it will; you just need to create the

Re: [gentoo-dev] Re: Requiring two sets of eyes for all eclass commits

2010-04-25 Thread Richard Freeman
On 04/25/2010 07:36 AM, Ryan Hill wrote: People make mistakes. Agreed - at work I've often found a quality mindset that is 100% focused on preventing mistakes, and I've found that these kinds of systems are almost equally as focused on preventing them from being fixed (three minutes to fix a

Re: [gentoo-dev] Re: Requiring two sets of eyes for all eclass commits

2010-04-25 Thread Alec Warner
On Sun, Apr 25, 2010 at 4:36 AM, Ryan Hill wrote: > On Sun, 25 Apr 2010 13:11:11 +0300 > Petteri Räty wrote: > >> On 04/25/2010 01:06 PM, Ryan Hill wrote: > >> > I think it's a good idea to strongly encourage it, but actually forcing it >> > through cvs?  No thanks.  I'm not tracking down another

[gentoo-dev] Re: Requiring two sets of eyes for all eclass commits

2010-04-25 Thread Ryan Hill
On Sun, 25 Apr 2010 13:11:11 +0300 Petteri Räty wrote: > On 04/25/2010 01:06 PM, Ryan Hill wrote: > > I think it's a good idea to strongly encourage it, but actually forcing it > > through cvs? No thanks. I'm not tracking down another dev just to fix a > > spelling mistake. :P > > How did the

Re: [gentoo-dev] Re: Requiring two sets of eyes for all eclass commits

2010-04-25 Thread Petteri Räty
On 04/25/2010 01:06 PM, Ryan Hill wrote: > On Sat, 24 Apr 2010 20:40:54 +0300 > Petteri Räty wrote: > >> What do you think about not allowing commits to eclasses without >> mentioning an another developer who has reviewed and approved the diff >> in the commit message? There's enough people on ge

[gentoo-dev] Re: Requiring two sets of eyes for all eclass commits

2010-04-25 Thread Ryan Hill
On Sat, 24 Apr 2010 20:40:54 +0300 Petteri Räty wrote: > What do you think about not allowing commits to eclasses without > mentioning an another developer who has reviewed and approved the diff > in the commit message? There's enough people on gentoo-dev for urgent > stuff too. I think it's a g