Re: [gentoo-dev] make_desktop_entry in eutils.eclass

2007-02-01 Thread Mike Frysinger
On Thursday 01 February 2007, Thomas de Grenier de Latour wrote: local desktop_file=$(make_desktop_entry -v ...) || die semi-unrelated, this die will never be called by design, use of the local keyword overrides the exit status of the subshell in the assignment ... you'd need to write it:

Re: [gentoo-dev] make_desktop_entry in eutils.eclass

2007-02-01 Thread Jim Ramsay
Thomas de Grenier de Latour wrote: On Wed, 31 Jan 2007 23:30:53 -0500, Mike Frysinger [EMAIL PROTECTED] wrote: about the only thing that'd work is an additional parameter called cruft that'd be passed unfiltered into the .desktop file You can also imagine a -v switch, which would make

Re: [gentoo-dev] make_desktop_entry in eutils.eclass

2007-02-01 Thread Mike Frysinger
On Thursday 01 February 2007, Jim Ramsay wrote: Nice. I like this idea, and humbly request that someone implement it in this way, or give me permission to do so. that assumes format limitations ... an additional cruft argument would be more likely to be merged -mike pgpGG8puWkLxF.pgp

Re: [gentoo-dev] make_desktop_entry in eutils.eclass

2007-01-31 Thread Jim Ramsay
Mike Frysinger wrote: On Tuesday 30 January 2007 16:10, Jim Ramsay wrote: In other words, I propose that this function should probably do 'basename' on $exec before using it for the .desktop filename. no ... the point of using $exec is to make sure the .desktop file is unique i'll

Re: [gentoo-dev] make_desktop_entry in eutils.eclass

2007-01-31 Thread Mike Frysinger
On Wednesday 31 January 2007, Jim Ramsay wrote: Personally I'd rather just add one line to my ebuild as opposed to creating and maintaining a .desktop file in the files directory. This would just add a useful feature for those who want that level of flexibility. which is rarely needed/wanted

Re: [gentoo-dev] make_desktop_entry in eutils.eclass

2007-01-31 Thread Thomas de Grenier de Latour
On Wed, 31 Jan 2007 23:30:53 -0500, Mike Frysinger [EMAIL PROTECTED] wrote: about the only thing that'd work is an additional parameter called cruft that'd be passed unfiltered into the .desktop file You can also imagine a -v switch, which would make this function print the full path (with its

[gentoo-dev] make_desktop_entry in eutils.eclass

2007-01-30 Thread Jim Ramsay
I have a few suggestions for the make_desktop_entry function in eutils.eclass: 1 - Allow me to pass in a full application path. If you pass in the full path to an executable as the first argument, it comes up with a crazy filename like this:

Re: [gentoo-dev] make_desktop_entry in eutils.eclass

2007-01-30 Thread Mike Frysinger
On Tuesday 30 January 2007 16:10, Jim Ramsay wrote: In other words, I propose that this function should probably do 'basename' on $exec before using it for the .desktop filename. no ... the point of using $exec is to make sure the .desktop file is unique i'll change it to sanitize the filename