Re: [gentoo-dev] strict-aliasing rules, don't break them

2006-06-19 Thread Flammie Pirinen
2006-06-17, Harald van Dijk sanoi, jotta: [F]orce LC_ALL=C to make that work, unless you want to check for every translation of the warning. You can also check against current locale’s translation of the warning using gettext(1) or such to extract it. -- Flammie, Gentoo Linux Documentation’s

[gentoo-dev] strict-aliasing rules, don't break them

2006-06-17 Thread Luca Barbato
You may aware or not that there is a nice optimization (more effective if you have some registers to spare) based on how you access memory thought variables. Since it wasn't that effective and didn't break anything it is enabled since -O2. Problem: recent gcc are doing some quite smart tricks

Re: [gentoo-dev] strict-aliasing rules, don't break them

2006-06-17 Thread Diego 'Flameeyes' Pettenò
On Saturday 17 June 2006 12:17, Luca Barbato wrote: Long term solution: The best long term solution would have been to fix the code, but actually I didn't ever found a quick explanation of how to fix this kind of code... -- Diego Flameeyes Pettenò - http://farragut.flameeyes.is-a-geek.org/

Re: [gentoo-dev] strict-aliasing rules, don't break them

2006-06-17 Thread Diego 'Flameeyes' Pettenò
On Saturday 17 June 2006 13:43, Luca Barbato wrote: you can use unions or rewrite completely the line using it in another way, in certain case the type pun is the quickest solution so it's better to append -fno-strict-aliasing in the Makefile. Err give me an example of the line, a lot of strict

Re: [gentoo-dev] strict-aliasing rules, don't break them

2006-06-17 Thread Harald van Dijk
On Sat, Jun 17, 2006 at 01:57:33PM +0200, Diego 'Flameeyes' Pettenò wrote: On Saturday 17 June 2006 13:43, Luca Barbato wrote: you can use unions or rewrite completely the line using it in another way, in certain case the type pun is the quickest solution so it's better to append

Re: [gentoo-dev] strict-aliasing rules, don't break them

2006-06-17 Thread Kevin F. Quinn
Easiest way to find these is to stick -Wall in global CFLAGS (or just -Wstrict-aliasing if you want to be more specific), and grep the build log for 'will break strict aliasing' (LC_ALL=C obviously). Such issues should be filed upstream, I guess, to either get the Makefile to forcibly set

Re: [gentoo-dev] strict-aliasing rules, don't break them

2006-06-17 Thread Ciaran McCreesh
On Sat, 17 Jun 2006 15:20:52 +0200 Harald van Dijk [EMAIL PROTECTED] wrote: | and then accessing {first, null}, or {null, last} as a struct dl_node | the way to fix the code would be to rewrite the code to use arrays | of pointers instead of simply three pointer members. There is no | valid way to

Re: [gentoo-dev] strict-aliasing rules, don't break them

2006-06-17 Thread Harald van Dijk
On Sat, Jun 17, 2006 at 03:32:36PM +0200, Kevin F. Quinn wrote: Easiest way to find these is to stick -Wall in global CFLAGS (or just -Wstrict-aliasing if you want to be more specific), and grep the build log for 'will break strict aliasing' (LC_ALL=C obviously). That warning is given for

Re: [gentoo-dev] strict-aliasing rules, don't break them

2006-06-17 Thread Harald van Dijk
On Sat, Jun 17, 2006 at 02:28:28PM +0100, Ciaran McCreesh wrote: On Sat, 17 Jun 2006 15:20:52 +0200 Harald van Dijk [EMAIL PROTECTED] wrote: | and then accessing {first, null}, or {null, last} as a struct dl_node | the way to fix the code would be to rewrite the code to use arrays | of

Re: [gentoo-dev] strict-aliasing rules, don't break them

2006-06-17 Thread Luca Barbato
Harald van Dijk wrote: That warning is given for valid code too. Please only add -fno-strict-aliasing if you actually find a package misbehaves without it, or if you have verified that there is indeed an aliasing violation in the code. Or just bug upstream to either avoid ugly code or just

Re: [gentoo-dev] strict-aliasing rules, don't break them

2006-06-17 Thread Mike Frysinger
some more docs: http://gcc.gnu.org/bugs.html#nonbugs_c Casting does not work as expected when optimization is turned on -mike pgpnrnzc6upFu.pgp Description: PGP signature

Re: [gentoo-dev] strict-aliasing rules, don't break them

2006-06-17 Thread Harald van Dijk
On Sat, Jun 17, 2006 at 01:15:58PM -0400, Mike Frysinger wrote: On Saturday 17 June 2006 06:17, Luca Barbato wrote: Long term solution: 1- check your new package for aliasing compliance, and if you have time fix it in the code or in the makefile, if you haven't append -fno-strict-aliasing

Re: [gentoo-dev] strict-aliasing rules, don't break them

2006-06-17 Thread pvdabeel
On Sat, Jun 17, 2006 at 03:35:10PM +0200, Harald van D??k wrote: On Sat, Jun 17, 2006 at 03:32:36PM +0200, Kevin F. Quinn wrote: Easiest way to find these is to stick -Wall in global CFLAGS (or just -Wstrict-aliasing if you want to be more specific), and grep the build log for 'will break

Re: [gentoo-dev] strict-aliasing rules, don't break them

2006-06-17 Thread Diego 'Flameeyes' Pettenò
So, just for people to know.. On Saturday 17 June 2006 15:32, Kevin F. Quinn wrote: kde-base/kdm-3.5.1 Fixed in latest ~arch (and upstream) media-libs/faad2-2.0-r11 Fixed in latest ~arch media-libs/xine-lib-1.1.2_pre20060328-r9 Fixed in latest ~arch (and upstream) media-video/vlc-0.8.5-r1