Re: [gentoo-dev] [PATCH 1/2] eclass/cargo.eclass: add cargo_src_configure

2020-06-13 Thread Kent Fredric
On Fri, 12 Jun 2020 09:24:11 -0700 Georgy Yakovlev wrote: > Not sure if --features=default will activate default set and how it > will react to being passed along. > > --no-default-features --features default > IDK, looks kinda unnatural. > > I have a feeling that we'll get more boilerplate

Re: [gentoo-dev] [PATCH 1/2] eclass/cargo.eclass: add cargo_src_configure

2020-06-12 Thread Georgy Yakovlev
On 6/12/20 11:59 AM, Luca Barbato wrote: > On 12/06/2020 18:24, Georgy Yakovlev wrote: >> On 6/12/20 4:16 AM, Luca Barbato wrote: >>> On 12/06/2020 11:04, Georgy Yakovlev wrote: +# cargo_src_configure --no-default-features >>> >>> Shall we default in not-defaulting so we can spare some

Re: [gentoo-dev] [PATCH 1/2] eclass/cargo.eclass: add cargo_src_configure

2020-06-12 Thread Luca Barbato
On 12/06/2020 18:24, Georgy Yakovlev wrote: On 6/12/20 4:16 AM, Luca Barbato wrote: On 12/06/2020 11:04, Georgy Yakovlev wrote: +# cargo_src_configure --no-default-features Shall we default in not-defaulting so we can spare some boilerplate? I don't think so. Let me explain. First of

Re: [gentoo-dev] [PATCH 1/2] eclass/cargo.eclass: add cargo_src_configure

2020-06-12 Thread Georgy Yakovlev
On 6/12/20 6:03 AM, Kent Fredric wrote: I've replied privately by mistake, replying to the list again. > On Fri, 12 Jun 2020 02:04:51 -0700 > Georgy Yakovlev wrote: > >> +# cargo_src_configure --no-default-features > > Looking at the source, I don't see how this is passed from this command

Re: [gentoo-dev] [PATCH 1/2] eclass/cargo.eclass: add cargo_src_configure

2020-06-12 Thread Georgy Yakovlev
On 6/12/20 4:16 AM, Luca Barbato wrote: > On 12/06/2020 11:04, Georgy Yakovlev wrote: >> +# cargo_src_configure --no-default-features > > Shall we default in not-defaulting so we can spare some boilerplate? I don't think so. Let me explain. First of all, this will force to explicitly

Re: [gentoo-dev] [PATCH 1/2] eclass/cargo.eclass: add cargo_src_configure

2020-06-12 Thread Kent Fredric
On Fri, 12 Jun 2020 02:04:51 -0700 Georgy Yakovlev wrote: > +#cargo_src_configure --no-default-features Looking at the source, I don't see how this is passed from this command to anything. > + # transform array from simple feature list > + # to multiple cargo args: > + #

Re: [gentoo-dev] [PATCH 1/2] eclass/cargo.eclass: add cargo_src_configure

2020-06-12 Thread Luca Barbato
On 12/06/2020 11:04, Georgy Yakovlev wrote: +# cargo_src_configure --no-default-features Shall we default in not-defaulting so we can spare some boilerplate? lu