Re: [gentoo-dev] [PATCH 1/7] multibuild: introduce a generic framework for custom phase functions.

2013-03-10 Thread Ciaran McCreesh
On Sun, 10 Mar 2013 16:46:41 +0100 Michał Górny wrote: > On Sun, 10 Mar 2013 15:26:29 + > Ciaran McCreesh wrote: > > On Sun, 10 Mar 2013 14:48:06 +0100 > > Michał Górny wrote: > > > Well, unless we're talking about a theoretical package mangler > > > which intentionally uses internal, old ve

Re: [gentoo-dev] [PATCH 1/7] multibuild: introduce a generic framework for custom phase functions.

2013-03-10 Thread Michał Górny
On Sun, 10 Mar 2013 15:26:29 + Ciaran McCreesh wrote: > On Sun, 10 Mar 2013 14:48:06 +0100 > Michał Górny wrote: > > Well, unless we're talking about a theoretical package mangler which > > intentionally uses internal, old version of bash to prove the point. > > That's a good idea, maybe we

Re: [gentoo-dev] [PATCH 1/7] multibuild: introduce a generic framework for custom phase functions.

2013-03-10 Thread Ciaran McCreesh
On Sun, 10 Mar 2013 14:48:06 +0100 Michał Górny wrote: > Well, unless we're talking about a theoretical package mangler which > intentionally uses internal, old version of bash to prove the point. That's a good idea, maybe we'll do that. Sounds like a good way of doing better input validation. Pe

Re: [gentoo-dev] [PATCH 1/7] multibuild: introduce a generic framework for custom phase functions.

2013-03-10 Thread Michał Górny
On Sun, 10 Mar 2013 14:44:42 +0100 Ulrich Mueller wrote: > > On Sun, 10 Mar 2013, Michał Górny wrote: > > > Yep. That's why the non-quoted fragment has a safety check and dies > > if it doesn't. > > It doesn't matter if there's a safety check. Bash 4 features are > simply not allowed in the

Re: [gentoo-dev] [PATCH 1/7] multibuild: introduce a generic framework for custom phase functions.

2013-03-10 Thread Ulrich Mueller
> On Sun, 10 Mar 2013, Michał Górny wrote: > Yep. That's why the non-quoted fragment has a safety check and dies > if it doesn't. It doesn't matter if there's a safety check. Bash 4 features are simply not allowed in the tree. Ulrich

Re: [gentoo-dev] [PATCH 1/7] multibuild: introduce a generic framework for custom phase functions.

2013-03-10 Thread Michał Górny
On Sun, 10 Mar 2013 12:18:25 + Ciaran McCreesh wrote: > On Sun, 10 Mar 2013 13:16:46 +0100 > Ulrich Mueller wrote: > > > On Sun, 10 Mar 2013, Ulrich Mueller wrote: > > > > > On Sun, 10 Mar 2013, Michał Górny wrote: > > >> +DEPEND=">=app-shells/bash-4.2" > > >> + > > > > > Why is th

Re: [gentoo-dev] [PATCH 1/7] multibuild: introduce a generic framework for custom phase functions.

2013-03-10 Thread Ciaran McCreesh
On Sun, 10 Mar 2013 13:16:46 +0100 Ulrich Mueller wrote: > > On Sun, 10 Mar 2013, Ulrich Mueller wrote: > > > On Sun, 10 Mar 2013, Michał Górny wrote: > >> +DEPEND=">=app-shells/bash-4.2" > >> + > > > Why is this needed? > > Seems it's because of this: > > >> + declare -g -A _MULTIBUI

Re: [gentoo-dev] [PATCH 1/7] multibuild: introduce a generic framework for custom phase functions.

2013-03-10 Thread Ulrich Mueller
> On Sun, 10 Mar 2013, Ulrich Mueller wrote: > On Sun, 10 Mar 2013, Michał Górny wrote: >> +DEPEND=">=app-shells/bash-4.2" >> + > Why is this needed? Seems it's because of this: >> +declare -g -A _MULTIBUILD_EXPORTED_PHASES || die >> +local p >> +for p; do >> +_M

Re: [gentoo-dev] [PATCH 1/7] multibuild: introduce a generic framework for custom phase functions.

2013-03-10 Thread Ulrich Mueller
> On Sun, 10 Mar 2013, Michał Górny wrote: > +DEPEND=">=app-shells/bash-4.2" > + Why is this needed? Ulrich