Re: [gentoo-dev] Soliciting input for a non-maintainer update (NMU) GLEP

2013-06-27 Thread hasufell
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1

On 06/23/2013 05:01 AM, Rick Zero_Chaos Farina wrote:
 On 06/22/2013 06:11 AM, Pacho Ramos wrote:
 El sáb, 22-06-2013 a las 00:06 +, Robin H. Johnson escribió: 
 [...]
 I'm not going into review systems here at all, I'm simply
 trying to have a policy of what changes are welcomed/blocked
 WITHOUT interaction from the listed maintainer(s) of a given
 package/herd.
 [...]
 
 In my case I would like to be always notified a change has been 
 committed (even forwarding gentoo-commits message to me), that
 will help me to keep track of the committed changes, and learn
 more if they corrected a bug caused by me ;)
 
 I have myself on the gentoo-commits ML and then I filter out so
 that just changes to my packages make it to me.  You could further
 filter so that just changes to your packages where you are not the
 commiter make it to you...  There is ample information in the
 headers of the ML to do this kind of thing.
 

There is no meta information on the maintainer of a package (just the
comitter). You'd have to create a filter rule for every single package
afais, unless I'm missing something.
-BEGIN PGP SIGNATURE-
Version: GnuPG v2.0.20 (GNU/Linux)
Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/

iQEcBAEBAgAGBQJRzIHnAAoJEFpvPKfnPDWz1mwIAK0Ku2fT0Nv0EdvERXv/AIsw
EKnzSCCH01XKEVoP14ujXwD+JZQBKVkqOLICZN0hSUlkmYoUCJAxUtMrMp8dkoOX
+yR4yfa5Gm62CbgxI836T0j644ii0Z6vTdvg7ZLKVWc1/sGF736dm63CsoBRFCaO
Nk163csHShCYFdCUmdLZZGjGn2XYSbyA6hoS5Bjx8NrdaKHM6JDqB5UlcUlNjgQW
cv/OVFWiWeLZZMZzkLeItuZQFEhfLrNpJdZuzoVDiuZZLW1AtIwbWTSW7z1L1HhN
m2dtadw6xT9EoGnUM12gYKvPmiYiiulK/DCH5uJsyWGfA3ejmskGbR1a7ZCXSJM=
=b87U
-END PGP SIGNATURE-



Re: [gentoo-dev] Soliciting input for a non-maintainer update (NMU) GLEP

2013-06-27 Thread Rick Zero_Chaos Farina
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1

On 06/27/2013 02:18 PM, hasufell wrote:
 On 06/23/2013 05:01 AM, Rick Zero_Chaos Farina wrote:
 On 06/22/2013 06:11 AM, Pacho Ramos wrote:
 El sáb, 22-06-2013 a las 00:06 +, Robin H. Johnson
 escribió: [...]
 I'm not going into review systems here at all, I'm simply 
 trying to have a policy of what changes are welcomed/blocked 
 WITHOUT interaction from the listed maintainer(s) of a given 
 package/herd.
 [...]
 
 In my case I would like to be always notified a change has been
  committed (even forwarding gentoo-commits message to me),
 that will help me to keep track of the committed changes, and
 learn more if they corrected a bug caused by me ;)
 
 I have myself on the gentoo-commits ML and then I filter out so 
 that just changes to my packages make it to me.  You could
 further filter so that just changes to your packages where you
 are not the commiter make it to you...  There is ample
 information in the headers of the ML to do this kind of thing.
 
 
 There is no meta information on the maintainer of a package (just
 the comitter). You'd have to create a filter rule for every single
 package afais, unless I'm missing something.
 

You are missing nothing, that's what I did.

- -Zero
-BEGIN PGP SIGNATURE-
Version: GnuPG v2.0.19 (GNU/Linux)
Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/

iQIcBAEBAgAGBQJRzJKLAAoJEKXdFCfdEflKZW8P/22iQ23+KrIubCTWm67llIsB
SYzqnnUQZ85d21neRdq9A1wRrKDFHl2HKSXqavyb5sdO7myZN1jrpZyqYyg2B32O
/cADoO8KJVTk9vziRADX+ahYMMdfsFwkfxEOAY73u8UhhUnyI8uil51hGX0akpAu
tnFw/u5IYSN3tWa6/7bBuA/ZzmmwAB36Sf9qqBQ+F3wFBPDYJVdAiwnGmC6dHljx
D4O/YlLZffOXkU6nHNd8L8T7H0axQCMZeF7QvL6Js/jlclX+pqEsTC66AamOzXTb
bG+aDSWKOlWDU6yf/F7Rq5BBgoa/XV1CAoJubrlALf+2hLmhz2D7cbVf2/6jD7dE
udeaKE2aspYt8t6+oYWEvUG3ePeDjEPvkyKM+KI4V58hsIrRVSi4GkYBYwS7kgeo
Df6N6h++AO52k2x6xiXlBKx2+X6BGUT5p01ZVMLO/YMrJQcjTUyYn691iE1LitL1
xJJ08192LeyIOSoYkUNcQOmGG0nt5wpdz/sBNgNtXJxkM6bQBuLwr+yEZ2eQNuga
2wNPoWKBZGbDASv488DclP7rsilzxYAZypUue2KO7H3qGJeu/DWLOOHUpMiiewln
9xBj0vcKxCh8PEoKg8kVuX7bnj+RTUwEHnewAulcPizqGrYlZqwx6jThS1h6rAq5
0OL8WdxBJLAa2wGgTGNl
=2zi0
-END PGP SIGNATURE-



Re: [gentoo-dev] gnome-games.eclass: Eclass for installing all gnome-games

2013-06-27 Thread Pacho Ramos
Another try that finally fixes pending problems
# Copyright 1999-2013 Gentoo Foundation
# Distributed under the terms of the GNU General Public License v2
# $Header: /var/cvsroot/gentoo-x86/eclass/python-single-r1.eclass,v 1.16 
2013/04/07 17:02:52 mgorny Exp $

# @ECLASS: gnome-games
# @MAINTAINER:
# Gnome team gn...@gentoo.org
# @AUTHOR:
# Author: Pacho Ramos pa...@gentoo.org
# @BLURB: An eclass to build gnome-games.
# @DESCRIPTION:
# An eclass to build gnome-games using proper phases from gnome2 and
# games eclasses.

case ${EAPI:-0} in
0|1)
die Unsupported EAPI=${EAPI:-0} (too old) for ${ECLASS}
;;
2|3|4|5)
;;
*)
die Unsupported EAPI=${EAPI} (unknown) for ${ECLASS}
;;
esac

inherit autotools games gnome2

EXPORT_FUNCTIONS pkg_setup src_prepare src_configure src_compile src_install 
pkg_preinst pkg_postinst pkg_postrm

if [[ ! ${_GNOME_GAMES} ]]; then

DEPEND==dev-util/intltool-0.50.2-r1
RDEPEND=!gnome-extra/gnome-games

# @FUNCTION: gnome-games_pkg_setup
# @DESCRIPTION:
# Set proper phase defaults
gnome-games_pkg_setup() {
debug-print-function ${FUNCNAME} ${@}
games_pkg_setup
}

# @FUNCTION: gnome-games_src_prepare
# @DESCRIPTION:
# Set proper phase defaults
gnome-games_src_prepare() {
debug-print-function ${FUNCNAME} ${@}

# Fix intltoolize broken file:
# https://bugs.launchpad.net/intltool/+bug/398571
intltoolize --force --copy --automake || die intltoolize failed
eautoreconf

gnome2_src_prepare
}

# @FUNCTION: gnome-games_src_configure
# @DESCRIPTION:
# Set proper phase defaults, relying on gnome2_src_configure
# and passing extra arguments from egamesconf (games.eclass)
gnome-games_src_configure() {
debug-print-function ${FUNCNAME} ${@}
gnome2_src_configure \
--prefix=${GAMES_PREFIX} \
--libdir=$(games_get_libdir) \
--sysconfdir=${GAMES_SYSCONFDIR} \
--localstatedir=/var \
--localedir=/usr/share/locale \
$@
}

# @FUNCTION: gnome-games_src_compile
# @DESCRIPTION:
# Set proper phase defaults
gnome-games_src_compile() {
debug-print-function ${FUNCNAME} ${@}
gnome2_src_compile
}

# @FUNCTION: gnome-games_src_install
# @DESCRIPTION:
# Set proper phase defaults
gnome-games_src_install() {
debug-print-function ${FUNCNAME} ${@}
gnome2_src_install
prepgamesdirs
}

# @FUNCTION: gnome-games_pkg_preinst
# @DESCRIPTION:
# Set proper phase defaults
gnome-games_pkg_preinst() {
debug-print-function ${FUNCNAME} ${@}
gnome2_pkg_preinst
games_pkg_preinst
}

# @FUNCTION: gnome-games_pkg_preinst
# @DESCRIPTION:
# Set proper phase defaults
gnome-games_pkg_postinst() {
debug-print-function ${FUNCNAME} ${@}
gnome2_pkg_postinst
games_pkg_postinst
}

# @FUNCTION: gnome-games_pkg_postrm
# @DESCRIPTION:
# Set proper phase defaults
gnome-games_pkg_postrm() {
debug-print-function ${FUNCNAME} ${@}
gnome2_pkg_postrm
}

_GNOME_GAMES=1
fi
# Copyright 1999-2013 Gentoo Foundation
# Distributed under the terms of the GNU General Public License v2
# $Header: $

EAPI=5
GCONF_DEBUG=no

inherit gnome-games

DESCRIPTION=Five or More Game for GNOME
HOMEPAGE=https://live.gnome.org/Five%20or%20more;

LICENSE=GPL-2+
SLOT=0
KEYWORDS=~amd64
IUSE=

RDEPEND=
dev-libs/glib:2
=gnome-base/librsvg-2.32.0
=x11-libs/gtk+-3.4.0:3

DEPEND=${RDEPEND}
=dev-util/intltool-0.35.0
dev-util/itstool
virtual/pkgconfig



Re: [gentoo-dev] gnome-games.eclass: Eclass for installing all gnome-games

2013-06-27 Thread hasufell
On 06/27/2013 10:25 PM, Pacho Ramos wrote:
 Another try that finally fixes pending problems
 

 --localstatedir=/var \

is there a problem with

--localstatedir=${GAMES_STATEDIR} \


 gnome-games_src_prepare() {

I find it very strange that you run intltoolize and eautoreconf
unconditionally in an eclass.



Re: [gentoo-dev] gnome-games.eclass: Eclass for installing all gnome-games

2013-06-27 Thread Pacho Ramos
El jue, 27-06-2013 a las 22:38 +0200, hasufell escribió:
 On 06/27/2013 10:25 PM, Pacho Ramos wrote:
  Another try that finally fixes pending problems
  
 
  --localstatedir=/var \
 
 is there a problem with
 
 --localstatedir=${GAMES_STATEDIR} \
 

Yes, it ends up being /var/games/games because all gnome-games consumers
already append games by default

  gnome-games_src_prepare() {
 
 I find it very strange that you run intltoolize and eautoreconf
 unconditionally in an eclass.
 
 

The same - Until a new intltool version is released, all consumers of
this eclass will need it to get proper localedir being respected