[gentoo-dev] Re: SSL-Certificates and CAcert
Robin H. Johnson [EMAIL PROTECTED] posted [EMAIL PROTECTED], excerpted below, on Fri, 28 Sep 2007 15:45:41 -0700: On Fri, Sep 28, 2007 at 09:31:24AM +, Duncan wrote: Would it be possible to setup a gentoo-certs package, versioned like any other, with USE flags if necessary for installing where various browsers, etc can see them? That fails/makes-it-complicated for somebody accessing the Gentoo SSL services outside a Gentoo system. Fair point. Thanks. -- Duncan - List replies preferred. No HTML msgs. Every nonfree program has a lord, a master -- and if you use the program, he is your master. Richard Stallman -- [EMAIL PROTECTED] mailing list
[gentoo-dev] Re: [gentoo-commits] gentoo-x86 commit in sys-apps/portage: ChangeLog portage-2.1.3.11.ebuild portage-2.1.3.10.ebuild
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Donnie Berkholz wrote: You deleted a huge chunk of the ChangeLog. Might want to check for bugs in whatever tool you're using. That was intentional pruning since the ChangeLog was growing rather large. Next time I'll do a separate comment and/or say something about it in the commit message. Zac -BEGIN PGP SIGNATURE- Version: GnuPG v2.0.7 (GNU/Linux) iD8DBQFG/fKl/ejvha5XGaMRAmFnAKDWqLurFCXhn/boU3eQ8kdND1LZ3QCfcZf+ RNQ/eK7pi8rIcsePD0WeUa8= =7DTP -END PGP SIGNATURE- -- [EMAIL PROTECTED] mailing list
Re: [gentoo-dev] stripping out the DO NOT REPLY from bugzie emails
Andrew Gaffney [EMAIL PROTECTED] said: It seems that not everybody loves the new DO NOT REPLY TO THIS EMAIL header at the top of every bugzie email as much as robbat2 does. 1. if everybody hates it (full ack btw), why not remove it globally? 2. why doesn't bugzi receive mail (anymore?)? kind regards Thilo signature.asc Description: This is a digitally signed message part.
[gentoo-dev] Quoting patch for repoman
I put together a quick repoman patch to check for the quoting issues that've kept coming up in reviews lately. Give it a shot and fix it if you have problems. Thanks, Donnie --- repoman.orig2007-09-29 00:05:30.0 -0700 +++ repoman 2007-09-29 01:06:09.0 -0700 @@ -188,6 +188,7 @@ ebuild.majorsyn:This ebuild has a major syntax error that may cause the ebuild to fail partially or fully, ebuild.minorsyn:This ebuild has a minor syntax error that contravenes gentoo coding style, ebuild.badheader:This ebuild has a malformed header, + ebuild.quoting:This ebuild may fail to quote D, S, T, FILESDIR, or WORKDIR, metadata.missing:Missing metadata.xml files, metadata.bad:Bad metadata.xml files, virtual.versioned:PROVIDE contains virtuals with versions, @@ -218,6 +219,7 @@ RESTRICT.invalid, ebuild.minorsyn, ebuild.badheader, +ebuild.quoting, file.size, metadata.missing, metadata.bad, @@ -1329,6 +1331,8 @@ ignore_line = re.compile(r'(^$)|(^(\t)*#)') leading_spaces = re.compile(r'^[\S\t]') trailing_whitespace = re.compile(r'.*([\S]$)') + missing_quotes = re.compile(r'[^]\${?(D|S|T|FILESDIR|WORKDIR)}?\W') + missing_quotes_exclude = re.compile(r'\[\[.*[^]\${?(D|S|T|FILESDIR|WORKDIR)}?\W.*]/]/') readonly_assignment = re.compile(r'^\s*(export\s+)?(A|CATEGORY|P|PV|PN|PR|PVR|PF|D|WORKDIR|FILESDIR|FEATURES|USE)=') line_continuation = re.compile(r'([^#]*\S)(\s+|\t)\\$') linenum=0 @@ -1374,6 +1378,17 @@ myerrormsg = Trailing whitespace Syntax Error. Line %d % linenum stats[ebuild.minorsyn] +=1 fails[ebuild.minorsyn].append(x+/+y+.ebuild: %s % myerrormsg) + # Missing quotes check + missing_quotes_line = missing_quotes.search(line) + if missing_quotes_line: + for group in missing_quotes_line.group(): + match = missing_quotes_exclude.search(group) + if not match: + myerrormsg = Missing Quotes Error. Line %d % linenum + stats[ebuild.quoting] += 1 + fails[ebuild.quoting].append(x+/+y+.ebuild: %s % myerrormsg) + # Only need 1 match in a line to count the line + break # Readonly variable assignment check match = readonly_assignment.match(line) # The regex can give a false positive for continued lines,
Re: [gentoo-dev] Quoting patch for repoman
On 01:09 Sat 29 Sep , Donnie Berkholz wrote: I put together a quick repoman patch to check for the quoting issues that've kept coming up in reviews lately. Give it a shot and fix it if you have problems. Thanks, Donnie Woops, the last one didn't exclude [[ ]] cases properly because I screwed up the second regexp. Try this. Thanks, Donnie --- repoman.orig2007-09-29 00:05:30.0 -0700 +++ repoman 2007-09-29 01:33:27.0 -0700 @@ -188,6 +188,7 @@ ebuild.majorsyn:This ebuild has a major syntax error that may cause the ebuild to fail partially or fully, ebuild.minorsyn:This ebuild has a minor syntax error that contravenes gentoo coding style, ebuild.badheader:This ebuild has a malformed header, + ebuild.quoting:This ebuild may fail to quote D, S, T, FILESDIR, or WORKDIR, metadata.missing:Missing metadata.xml files, metadata.bad:Bad metadata.xml files, virtual.versioned:PROVIDE contains virtuals with versions, @@ -218,6 +219,7 @@ RESTRICT.invalid, ebuild.minorsyn, ebuild.badheader, +ebuild.quoting, file.size, metadata.missing, metadata.bad, @@ -1329,6 +1331,8 @@ ignore_line = re.compile(r'(^$)|(^(\t)*#)') leading_spaces = re.compile(r'^[\S\t]') trailing_whitespace = re.compile(r'.*([\S]$)') + missing_quotes = re.compile(r'[^]\${?(D|S|T|FILESDIR|WORKDIR)}?\W') + missing_quotes_exclude = re.compile(r'\[\[.*[^]\${?(D|S|T|FILESDIR|WORKDIR)}?\W.*\]\]') readonly_assignment = re.compile(r'^\s*(export\s+)?(A|CATEGORY|P|PV|PN|PR|PVR|PF|D|WORKDIR|FILESDIR|FEATURES|USE)=') line_continuation = re.compile(r'([^#]*\S)(\s+|\t)\\$') linenum=0 @@ -1374,6 +1378,17 @@ myerrormsg = Trailing whitespace Syntax Error. Line %d % linenum stats[ebuild.minorsyn] +=1 fails[ebuild.minorsyn].append(x+/+y+.ebuild: %s % myerrormsg) + # Missing quotes check + missing_quotes_line = missing_quotes.search(line) + if missing_quotes_line: + for group in missing_quotes_line.group(): + match = missing_quotes_exclude.search(group) + if not match: + myerrormsg = Missing Quotes Error. Line %d % linenum + stats[ebuild.quoting] += 1 + fails[ebuild.quoting].append(x+/+y+.ebuild: %s % myerrormsg) + # Only need 1 match in a line to count the line + break # Readonly variable assignment check match = readonly_assignment.match(line) # The regex can give a false positive for continued lines,
Re: [gentoo-dev] Quoting patch for repoman
On 01:33 Sat 29 Sep , Donnie Berkholz wrote: Take 3. Adds ROOT to variables checked. Thanks, Donnie --- repoman.orig2007-09-29 00:05:30.0 -0700 +++ repoman 2007-09-29 01:33:27.0 -0700 @@ -188,6 +188,7 @@ ebuild.majorsyn:This ebuild has a major syntax error that may cause the ebuild to fail partially or fully, ebuild.minorsyn:This ebuild has a minor syntax error that contravenes gentoo coding style, ebuild.badheader:This ebuild has a malformed header, + ebuild.quoting:This ebuild may fail to quote D, S, T, ROOT, FILESDIR, or WORKDIR, metadata.missing:Missing metadata.xml files, metadata.bad:Bad metadata.xml files, virtual.versioned:PROVIDE contains virtuals with versions, @@ -218,6 +219,7 @@ RESTRICT.invalid, ebuild.minorsyn, ebuild.badheader, +ebuild.quoting, file.size, metadata.missing, metadata.bad, @@ -1329,6 +1331,8 @@ ignore_line = re.compile(r'(^$)|(^(\t)*#)') leading_spaces = re.compile(r'^[\S\t]') trailing_whitespace = re.compile(r'.*([\S]$)') + missing_quotes = re.compile(r'[^]\${?(D|S|T|ROOT|FILESDIR|WORKDIR)}?\W') + missing_quotes_exclude = re.compile(r'\[\[.*[^]\${?(D|S|T|ROOT|FILESDIR|WORKDIR)}?\W.*\]\]') readonly_assignment = re.compile(r'^\s*(export\s+)?(A|CATEGORY|P|PV|PN|PR|PVR|PF|D|WORKDIR|FILESDIR|FEATURES|USE)=') line_continuation = re.compile(r'([^#]*\S)(\s+|\t)\\$') linenum=0 @@ -1374,6 +1378,17 @@ myerrormsg = Trailing whitespace Syntax Error. Line %d % linenum stats[ebuild.minorsyn] +=1 fails[ebuild.minorsyn].append(x+/+y+.ebuild: %s % myerrormsg) + # Missing quotes check + missing_quotes_line = missing_quotes.search(line) + if missing_quotes_line: + for group in missing_quotes_line.group(): + match = missing_quotes_exclude.search(group) + if not match: + myerrormsg = Missing Quotes Error. Line %d % linenum + stats[ebuild.quoting] += 1 + fails[ebuild.quoting].append(x+/+y+.ebuild: %s % myerrormsg) + # Only need 1 match in a line to count the line + break # Readonly variable assignment check match = readonly_assignment.match(line) # The regex can give a false positive for continued lines,
Re: [gentoo-dev] Quoting patch for repoman
On Saturday 29 September 2007, Donnie Berkholz wrote: On 01:09 Sat 29 Sep , Donnie Berkholz wrote: I put together a quick repoman patch to check for the quoting issues that've kept coming up in reviews lately. Give it a shot and fix it if you have problems. Woops, the last one didn't exclude [[ ]] cases properly because I screwed up the second regexp. Try this. does this work with multilines ? if [[ -e ${S}/asdfasdfasdf \ -f ${WORKDIR}/moo ]] then this is a crappy example, but entirely correct when the if statement gets real long ... -mike signature.asc Description: This is a digitally signed message part.
Re: [gentoo-dev] stripping out the DO NOT REPLY from bugzie emails
On Sat, Sep 29, 2007 at 09:23:21AM +0200, Thilo Bangert wrote: Andrew Gaffney [EMAIL PROTECTED] said: It seems that not everybody loves the new DO NOT REPLY TO THIS EMAIL header at the top of every bugzie email as much as robbat2 does. 1. if everybody hates it (full ack btw), why not remove it globally? Not everybody hates it, and it's there to dissuade users from replying to Bugzilla mail by hitting reply in the MUA. http://bugs.gentoo.org/show_bug.cgi?id=181172 2. why doesn't bugzi receive mail (anymore?)? We never supported Bugzilla email interface - it's been fraught with security holes and bugs, and sucks with spam. The address of [EMAIL PROTECTED] goes to the group of us that admin bugzilla (mainly me), and from that alone, I get 4-5 emails a week from that alias alone. Don't you get random less-than-clueful users emailing you instead of responding on Bugzilla? -- Robin Hugh Johnson Gentoo Linux Developer Infra Guy E-Mail : [EMAIL PROTECTED] GnuPG FP : 11AC BA4F 4778 E3F6 E4ED F38E B27B 944E 3488 4E85 pgpbyMm0a1Vbv.pgp Description: PGP signature
Re: [gentoo-dev] stripping out the DO NOT REPLY from bugzie emails
On 28-09-2007 18:31:06 -0500, Andrew Gaffney wrote: It seems that not everybody loves the new DO NOT REPLY TO THIS EMAIL header at the top of every bugzie email as much as robbat2 does. Because of that, robbat2, KingTaco, and I came up with a procmail recipe that uses sed to filter that new message out of bugzie emails. This has not actually been tested on incoming mails, so it may rape/eat your dog/sister. Enjoy. # Strip out DO NOT REPLY lines from bugzie emails :0 Hfw * ^From: [EMAIL PROTECTED] | sed -e '/^DO NOT REPLY TO THIS EMAIL/,+2d' Thanks. Most annoying is the many empty lines for normal comment mails that were added. You *must* scroll down now to just read the contents. Just removing those from the template (like it used to be, and is for the other kind of mails) would already help a lot. -- Fabian Groffen Gentoo on a different level -- [EMAIL PROTECTED] mailing list
Re: [gentoo-dev] stripping out the DO NOT REPLY from bugzie emails
On 29-09-2007 02:29:21 -0700, Robin H. Johnson wrote: On Sat, Sep 29, 2007 at 09:23:21AM +0200, Thilo Bangert wrote: Andrew Gaffney [EMAIL PROTECTED] said: It seems that not everybody loves the new DO NOT REPLY TO THIS EMAIL header at the top of every bugzie email as much as robbat2 does. 1. if everybody hates it (full ack btw), why not remove it globally? Not everybody hates it, and it's there to dissuade users from replying to Bugzilla mail by hitting reply in the MUA. http://bugs.gentoo.org/show_bug.cgi?id=181172 Isn't that tackled suffiently now by setting a bogus reply-to header? -- Fabian Groffen Gentoo on a different level -- [EMAIL PROTECTED] mailing list
Re: [gentoo-dev] stripping out the DO NOT REPLY from bugzie emails
On Sat, Sep 29, 2007 at 11:58:33AM +0200, Fabian Groffen wrote: Thanks. Most annoying is the many empty lines for normal comment mails that were added. You *must* scroll down now to just read the contents. Just removing those from the template (like it used to be, and is for the other kind of mails) would already help a lot. Many empty lines? I think your MUA is broken. It is exactly two lines of text added, and one blank line after them. Otherwise, take a screenshot of before and after to prove it. -- Robin Hugh Johnson Gentoo Linux Developer Infra Guy E-Mail : [EMAIL PROTECTED] GnuPG FP : 11AC BA4F 4778 E3F6 E4ED F38E B27B 944E 3488 4E85 pgpuR5a3C5XPx.pgp Description: PGP signature
Re: [gentoo-dev] stripping out the DO NOT REPLY from bugzie emails
On Saturday 29 September 2007, Robin H. Johnson wrote: On Sat, Sep 29, 2007 at 11:58:33AM +0200, Fabian Groffen wrote: Thanks. Most annoying is the many empty lines for normal comment mails that were added. You *must* scroll down now to just read the contents. Just removing those from the template (like it used to be, and is for the other kind of mails) would already help a lot. Many empty lines? I think your MUA is broken. It is exactly two lines of text added, and one blank line after them. no, his MUA isnt broken ... when comments get added, there are 5 blank lines between the bugzilla URI's and the start of actual content ... Otherwise, take a screenshot of before and after to prove it. ... however, i dont think it's a regression ... just that with the added 3 lines for the DO-NOT-REPLY crap text, the blank lines push the actual content further down -mike signature.asc Description: This is a digitally signed message part.
Re: [gentoo-dev] stripping out the DO NOT REPLY from bugzie emails
On Sat, Sep 29, 2007 at 07:05:31AM -0400, Mike Frysinger wrote: no, his MUA isnt broken ... when comments get added, there are 5 blank lines between the bugzilla URI's and the start of actual content ... Those existed before the change. Otherwise, take a screenshot of before and after to prove it. ... however, i dont think it's a regression ... just that with the added 3 lines for the DO-NOT-REPLY crap text, the blank lines push the actual content further down Not a bug with the template: === To: %to% Reply-To: DO NOT REPLY /dev/[EMAIL PROTECTED] Subject: [Bug %bugid%] %neworchanged%%summary% %threadingmarker% X-Bugzilla-Reason: %reasonsheader% X-Bugzilla-Product: %product% X-Bugzilla-Component: %component% X-Bugzilla-Keywords: %keywords% X-Bugzilla-Severity: %severity% X-Bugzilla-Resolution: %resolution% X-Bugzilla-Status: %status% DO NOT REPLY TO THIS EMAIL. Also, do not reply via email to the person whose email is mentioned below. To comment on this bug, please visit: Clear-Text: %urlbase%show_bug.cgi?id=%bugid% Secure: %sslbase%show_bug.cgi?id=%bugid% %diffs% --%space% Configure bugmail: %sslbase%userprefs.cgi?tab=email %reasonsbody% = I'll go and trace what generates the '%diffs%' portion, see if there is dumb code in there that generates too much whitespace. -- Robin Hugh Johnson Gentoo Linux Developer Infra Guy E-Mail : [EMAIL PROTECTED] GnuPG FP : 11AC BA4F 4778 E3F6 E4ED F38E B27B 944E 3488 4E85 pgpwU5HhaQHzY.pgp Description: PGP signature
Re: [gentoo-dev] stripping out the DO NOT REPLY from bugzie emails
Robin H. Johnson wrote: DO NOT REPLY TO THIS EMAIL. Also, do not reply via email to the person whose email is mentioned below. To comment on this bug, please visit: Please consider lowercasing the first sentence, to stop the yelling, and removing the repetition from the second sentence, which seems to treat the addressee as retarded. Suggested replacement: Do not reply to this email, nor to the person whose email address is mentioned below. To comment on this bug, please visit: Benno -- [EMAIL PROTECTED] mailing list
[gentoo-dev] Re: stripping out the DO NOT REPLY from bugzie emails
Fabian Groffen [EMAIL PROTECTED] posted [EMAIL PROTECTED], excerpted below, on Sat, 29 Sep 2007 12:01:39 +0200: On 29-09-2007 02:29:21 -0700, Robin H. Johnson wrote: On Sat, Sep 29, 2007 at 09:23:21AM +0200, Thilo Bangert wrote: Andrew Gaffney [EMAIL PROTECTED] said: It seems that not everybody loves the new DO NOT REPLY TO THIS EMAIL header at the top of every bugzie email as much as robbat2 does. 1. if everybody hates it (full ack btw), why not remove it globally? Not everybody hates it, and it's there to dissuade users from replying to Bugzilla mail by hitting reply in the MUA. http://bugs.gentoo.org/show_bug.cgi?id=181172 Isn't that tackled suffiently now by setting a bogus reply-to header? The problem is those replies may contain information of use in fixing the bug. If the mail gets null-spaced... Better to warn upfront that a reply via mail isn't going to have the intended results, AND bogus reply-to header it. -- Duncan - List replies preferred. No HTML msgs. Every nonfree program has a lord, a master -- and if you use the program, he is your master. Richard Stallman -- [EMAIL PROTECTED] mailing list
Re: [gentoo-dev] Re: stripping out the DO NOT REPLY from bugzie emails
On 29-09-2007 14:11:54 +, Duncan wrote: Fabian Groffen [EMAIL PROTECTED] posted [EMAIL PROTECTED], excerpted below, on Sat, 29 Sep 2007 12:01:39 +0200: On 29-09-2007 02:29:21 -0700, Robin H. Johnson wrote: On Sat, Sep 29, 2007 at 09:23:21AM +0200, Thilo Bangert wrote: Andrew Gaffney [EMAIL PROTECTED] said: It seems that not everybody loves the new DO NOT REPLY TO THIS EMAIL header at the top of every bugzie email as much as robbat2 does. 1. if everybody hates it (full ack btw), why not remove it globally? Not everybody hates it, and it's there to dissuade users from replying to Bugzilla mail by hitting reply in the MUA. http://bugs.gentoo.org/show_bug.cgi?id=181172 Isn't that tackled suffiently now by setting a bogus reply-to header? The problem is those replies may contain information of use in fixing the bug. If the mail gets null-spaced... I don't see your point. If you have a mailserver running on localhost that accepts mail for /dev/null (i.e. it thinks it is a valid email address) and discards it without notice, then that's your problem. Most of the time this is not the case and an immediate reject or a bounce message is the result. Better to warn upfront that a reply via mail isn't going to have the intended results, AND bogus reply-to header it. I agree warning is fine. However, I think there is a correlation between people hitting reply to bugzilla mails and people not reading/paying attention to such messages. I think the annoyance of having the message does not pay off against the technical limitation of not being able to reply any more, whereas the latter is very effective and the first probably not. -- Fabian Groffen Gentoo on a different level -- [EMAIL PROTECTED] mailing list
Re: [gentoo-dev] Re: stripping out the DO NOT REPLY from bugzie emails
Fabian Groffen wrote: The problem is those replies may contain information of use in fixing the bug. If the mail gets null-spaced... I don't see your point. If you have a mailserver running on localhost that accepts mail for /dev/null (i.e. it thinks it is a valid email address) and discards it without notice, then that's your problem. Most of the time this is not the case and an immediate reject or a bounce message is the result. Right! The bogus reply-to should either be an invalid address, in which case the sender will realize right away that the mail did not go anywhere, or there could be an autoresponder that tells the sender to use bugzilla's web interface. Or... you could keep the return address as-is, but use procmail to not accept mail unless it is from the bugzilla system (otherwise, autorespond as above). Any of these would be preferable to the 3 extra lines at the top of every email now that are not only annoying, but only useful to initiate the few who would attempt to reply. I agree warning is fine. However, I think there is a correlation between people hitting reply to bugzilla mails and people not reading/paying attention to such messages. I think the annoyance of having the message does not pay off against the technical limitation of not being able to reply any more, whereas the latter is very effective and the first probably not. Agreed. There are several technical solutions that are far more effective and less annoying than the banner. -Joe -- [EMAIL PROTECTED] mailing list
[gentoo-dev] Re: [gentoo-commits] gentoo-x86 commit in dev-java/java-gnome: ChangeLog java-gnome-4.0.4.ebuild
Donnie Berkholz kirjoitti: On 20:13 Thu 27 Sep , Petteri Raty (betelgeuse) wrote: betelgeuse07/09/27 20:13:33 Modified: ChangeLog Added:java-gnome-4.0.4.ebuild Log: Version bump for bug #193951. (Portage version: 2.1.3.9) 1.1 dev-java/java-gnome/java-gnome-4.0.4.ebuild file : http://sources.gentoo.org/viewcvs.py/gentoo-x86/dev-java/java-gnome/java-gnome-4.0.4.ebuild?rev=1.1view=markup plain: http://sources.gentoo.org/viewcvs.py/gentoo-x86/dev-java/java-gnome/java-gnome-4.0.4.ebuild?rev=1.1content-type=text/plain src_compile() { ./configure --prefix=/usr || die make || die Compilation of java-gnome failed if use doc; then make doc || die Making documentation failed fi } It can't use econf or emake? Would be nice to add some comments to that effect. Thanks, Donnie It can't. The ./configure script is handwritten in perl. emake probably makes sense. Regards, Petteri signature.asc Description: OpenPGP digital signature
Re: [gentoo-dev] stripping out the DO NOT REPLY from bugzie emails
Benno Schulenberg wrote: Robin H. Johnson wrote: DO NOT REPLY TO THIS EMAIL. Also, do not reply via email to the person whose email is mentioned below. To comment on this bug, please visit: Please consider lowercasing the first sentence, to stop the yelling, and removing the repetition from the second sentence, which seems to treat the addressee as retarded. Suggested replacement: Well, this really *is* targeting the retarded. There are many people who just don't pay any attention at all and will reply directly to the bugzie email. There's also the people who like to argue with the bug commenter but don't want to do it on the bug (which will make them look like an idiot to *everyone*), so they email the person directly. With this warning, I can completely ignore those retards without feeling bad :) -- Andrew Gaffney http://dev.gentoo.org/~agaffney/ Gentoo Linux Developer Catalyst/Installer + x86 release coordinator -- [EMAIL PROTECTED] mailing list
[gentoo-dev] Re: [gentoo-commits] gentoo-x86 commit in sci-mathematics/coq: ChangeLog coq-8.1_p1.ebuild
On Saturday 29 of September 2007 17:40:35 Markus Dittrich (markusle) wrote: - 02 Jul 2007; Piotr Jaroszyński [EMAIL PROTECTED] coq-8.0-r1.ebuild, + 02 Jul 2007; Piotr JaroszyÅski [EMAIL PROTECTED] coq-8.0-r1.ebuild, coq-8.0_p3.ebuild: (QA) RESTRICT clean up. Please use UTF-8 friendly stuff. -- Best Regards, Piotr Jaroszyński -- [EMAIL PROTECTED] mailing list
Re: [gentoo-dev] Quoting patch for repoman
On 04:52 Sat 29 Sep , Mike Frysinger wrote: does this work with multilines ? if [[ -e ${S}/asdfasdfasdf \ -f ${WORKDIR}/moo ]] then this is a crappy example, but entirely correct when the if statement gets real long ... No, it doesn't. That's why I just made it a warning instead of a failure, because it's not always going to work. Thanks, Donnie -- [EMAIL PROTECTED] mailing list
[gentoo-dev] Re: gentoo-x86 commit in x11-wm/awesome: awesome-1.2.ebuild Manifest metadata.xml ChangeLog
* Matsuu Takuto (matsuu) [EMAIL PROTECTED]: Revision ChangesPath 1.1 x11-wm/awesome/awesome-1.2.ebuild file : http://sources.gentoo.org/viewcvs.py/gentoo-x86/x11-wm/awesome/awesome-1.2.ebuild?rev=1.1view=markup plain: http://sources.gentoo.org/viewcvs.py/gentoo-x86/x11-wm/awesome/awesome-1.2.ebuild?rev=1.1content-type=text/plain src_unpack() { unpack ${A} cd ${S} sed -i \ -e /^CFLAGS/s/=.*-O3/= ${CFLAGS}/ \ -e /^LDFLAGS/s/-ggdb3/${LDFLAGS}/ \ -e /^CC/s/cc/$(tc-getCC)/ \ ^ This fails if tc-getCC returns the path to the compiler, if tc-getCC contains a slash. -e s:/usr/lib:/usr/$(get_libdir): \ -e s:/usr/local:/usr: \ config.mk || die sed failed } -- .: Torsten | :. -- [EMAIL PROTECTED] mailing list
Re: [gentoo-dev] Re: [gentoo-commits] gentoo-x86 commit in dev-java/java-gnome: ChangeLog java-gnome-4.0.4.ebuild
On Saturday 29 September 2007, Petteri Räty wrote: Donnie Berkholz kirjoitti: On 20:13 Thu 27 Sep , Petteri Raty (betelgeuse) wrote: betelgeuse07/09/27 20:13:33 Modified: ChangeLog Added:java-gnome-4.0.4.ebuild Log: Version bump for bug #193951. (Portage version: 2.1.3.9) 1.1 dev-java/java-gnome/java-gnome-4.0.4.ebuild file : http://sources.gentoo.org/viewcvs.py/gentoo-x86/dev-java/java-gnome/java -gnome-4.0.4.ebuild?rev=1.1view=markup plain: http://sources.gentoo.org/viewcvs.py/gentoo-x86/dev-java/java-gnome/java -gnome-4.0.4.ebuild?rev=1.1content-type=text/plain src_compile() { ./configure --prefix=/usr || die make || die Compilation of java-gnome failed if use doc; then make doc || die Making documentation failed fi } It can't use econf or emake? Would be nice to add some comments to that effect. It can't. The ./configure script is handwritten in perl. emake probably makes sense. it's always good to leave a comment in there where the ./configure script isnt autotools based ... ive tried switching packages that called ./configure before to econf only to find out they're not actually autotool based and so i just wasted sometime when a comment '# cant use econf as this isnt autotool based' would have saved it -mike signature.asc Description: This is a digitally signed message part.
Re: [gentoo-dev] Re: gentoo-x86 commit in x11-wm/awesome: awesome-1.2.ebuild Manifest metadata.xml ChangeLog
On Saturday 29 September 2007, Piotr Jaroszyński wrote: On Sunday 30 of September 2007 02:53:47 Mike Frysinger wrote: On Saturday 29 September 2007, Piotr Jaroszyński wrote: On Sunday 30 of September 2007 00:54:29 Torsten Veller wrote: This fails if tc-getCC returns the path to the compiler It doesn't, see toolchain-funcs.eclass. it may, see toolchain-funcs.eclass $CC is respected from user env and nothing stops the user from doing CC=/moo/moo/mr/compiler (and in fact, users have) the generally accepted sed separator is :, not /, for specifically this reason ... your CFLAGS/LDFLAGS should also get changed as that prevents people from doing `-L/foo` or `-I /moo` or such things right, sorry for the noise especially as it wasn't my commit in the first place :) it isnt noise if you learned something ... you *did* learn *something* didnt you ? flying puppies are awesome -mike signature.asc Description: This is a digitally signed message part.
Re: [gentoo-dev] Re: gentoo-x86 commit in x11-wm/awesome: awesome-1.2.ebuild Manifest metadata.xml ChangeLog
On Saturday 29 September 2007, Piotr Jaroszyński wrote: On Sunday 30 of September 2007 00:54:29 Torsten Veller wrote: This fails if tc-getCC returns the path to the compiler It doesn't, see toolchain-funcs.eclass. it may, see toolchain-funcs.eclass $CC is respected from user env and nothing stops the user from doing CC=/moo/moo/mr/compiler (and in fact, users have) the generally accepted sed separator is :, not /, for specifically this reason ... your CFLAGS/LDFLAGS should also get changed as that prevents people from doing `-L/foo` or `-I /moo` or such things -mike signature.asc Description: This is a digitally signed message part.
Re: [gentoo-dev] Re: gentoo-x86 commit in x11-wm/awesome: awesome-1.2.ebuild Manifest metadata.xml ChangeLog
On Sunday 30 of September 2007 00:54:29 Torsten Veller wrote: This fails if tc-getCC returns the path to the compiler It doesn't, see toolchain-funcs.eclass. -- Best Regards, Piotr Jaroszyński -- [EMAIL PROTECTED] mailing list
Re: [gentoo-dev] Re: gentoo-x86 commit in x11-wm/awesome: awesome-1.2.ebuild Manifest metadata.xml ChangeLog
On Sunday 30 of September 2007 02:53:47 Mike Frysinger wrote: On Saturday 29 September 2007, Piotr Jaroszyński wrote: On Sunday 30 of September 2007 00:54:29 Torsten Veller wrote: This fails if tc-getCC returns the path to the compiler It doesn't, see toolchain-funcs.eclass. it may, see toolchain-funcs.eclass $CC is respected from user env and nothing stops the user from doing CC=/moo/moo/mr/compiler (and in fact, users have) the generally accepted sed separator is :, not /, for specifically this reason ... your CFLAGS/LDFLAGS should also get changed as that prevents people from doing `-L/foo` or `-I /moo` or such things -mike right, sorry for the noise especially as it wasn't my commit in the first place :) -- Best Regards, Piotr Jaroszyński -- [EMAIL PROTECTED] mailing list