Re: [gentoo-dev] .desktop file cleanup
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Petteri Räty wrote: Results: http://dev.gentoo.org/~betelgeuse/desktop-files/results.txt While we're at it, why not bring those desktop files that are under our control more inline with the freedesktop standards? http://standards.freedesktop.org/menu-spec/latest/apa.html Speaking for myself, Edutainment is a ridiculous category for science programs and I intend to change the desktop files (for as many sci programs as I can) to something more acceptable, as well as send patches upstream. I'm thinking Science--Chemistry;Biology;Physics;etc... (although that doesn't quite fit the freedesktop standards either...) Thanks for Listening, je_fro - -- Jeffrey Gardner Gentoo Developer Public PGP Key ID: 4A5D8F23 hkp://pgpkeys.mit.edu -BEGIN PGP SIGNATURE- Version: GnuPG v2.0.7 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org iD8DBQFHWPy8iR2KxEpdjyMRApijAJ9qL5tMpx7haTV3K/2sh7/IEDt4PQCgp4GW 6G1S51YqnLgsTAO4kw5FSoQ= =Z3xe -END PGP SIGNATURE- -- [EMAIL PROTECTED] mailing list
[gentoo-dev] Re: [gentoo-commits] gentoo-x86 commit in sys-apps/dtc: metadata.xml ChangeLog dtc-1.0.0.ebuild Manifest
On 02:20 Fri 07 Dec , Luca Barbato (lu_zero) wrote:
1.1 sys-apps/dtc/dtc-1.0.0.ebuild
file :
http://sources.gentoo.org/viewcvs.py/gentoo-x86/sys-apps/dtc/dtc-1.0.0.ebuild?rev=1.1view=markup
plain:
http://sources.gentoo.org/viewcvs.py/gentoo-x86/sys-apps/dtc/dtc-1.0.0.ebuild?rev=1.1content-type=text/plain
src_compile () {
emake PREFIX=/usr LIBDIR=/usr/$(get_libdir)
}
src_install () {
make DESTDIR=${D} \
PREFIX=/usr \
LIBDIR=/usr/$(get_libdir) \
install
dodoc Documentation/manual.txt
}
Might want to sprinkle die()'s in there.. also curious why make instead
of emake in src_install().
Thanks,
Donnie
--
[EMAIL PROTECTED] mailing list
Re: [gentoo-dev] .desktop file cleanup
On 01:56 Fri 07 Dec , Jeffrey Gardner wrote: While we're at it, why not bring those desktop files that are under our control more inline with the freedesktop standards? http://standards.freedesktop.org/menu-spec/latest/apa.html Speaking for myself, Edutainment is a ridiculous category for science programs and I intend to change the desktop files (for as many sci programs as I can) to something more acceptable, as well as send patches upstream. I'm thinking Science--Chemistry;Biology;Physics;etc... (although that doesn't quite fit the freedesktop standards either...) Where are you quoting Edutainment from? I can't find it anywhere on that page. If you want to do something that doesn't fit the spec, get the spec fixed. Looking through that list of main categories, scientific packages might sorta fit in Education (to teach), Development (libraries and development tools), Graphics (sci-viz, molecular graphics, etc) or Office (to get work done), depending on each package's purpose. The additional categories seem to fit quite well. Thanks, Donnie -- [EMAIL PROTECTED] mailing list
Re: [gentoo-dev] .desktop file cleanup
On Fri, 07 Dec 2007, Jeffrey Gardner wrote: Edutainment is a ridiculous category for science programs s/for science programs// -- [EMAIL PROTECTED] mailing list
Re: [gentoo-dev] .desktop file cleanup
On Dec 6, 2007 6:48 PM, Petteri Räty [EMAIL PROTECTED] wrote: In celebration of the Finnish Independence Day let's cleanup the .desktop files we have in the three. * desktop-file-validate /usr/portage/x11-misc/ifpgui/files/ifpgui.desktop * desktop-file-validate /usr/portage/net-p2p/bittornado/files/bittornado.desktop * desktop-file-validate /usr/portage/net-p2p/mldonkey/files/mldonkey-gui.desktop Fixed. -- Santiago M. Mola Jabber ID: [EMAIL PROTECTED]
Re: [gentoo-dev] Re: New eclass osgi.eclass
Thanks all for this feedback. I think this is sufficient to warrant
some modifications as suggested, and I propose to postpone the
inclusion in tree a little bit.
Regarding performance, there is an important point to note as IMHO it
is much more penalizing than using basename or such.
The fact that I use the jar utility to unzip a file, combined with the
fact that jar does not have an option to specify a destination
directory, is troublesome. I have to copy the .jar file to the
destination directory and then remove it. This .jar file can be
several MBs of course.
Initially I was using zip but I replaced it with jar in order to avoid
a dependency on zip. But maybe it's not worth the performance penalty.
Regards,
Elvanör
On Dec 6, 2007 1:11 PM, Petteri Räty [EMAIL PROTECTED] wrote:
Steve Long kirjoitti:
Alistair Bush wrote:
Im sure Elvanor can't wait for you constructive feedback on his eclass
and depending on your feedback the eclass will enter the tree this
weekend.
A couple of very minor performance points, which I think are more
significant in eclasses. Firstly the basename thing Donnie pointed out
before:
Well usually you don't noticy any differences. In global scope things
could have some effect of course.
You have a couple of functions that take, say, 4 or 5 arguments. It would be
more robust to use a case, eg:
case $# in
5)..;;
4)..;;
*) die Incorrect use of $FUNCNAME;;
esac
..than if (($#4)); then ..; else .. ;fi
Well imho they are equivalent and eclass maintainers should go with what
they prefer.
With regard to:
debug-print-function ${FUNCNAME} $*
if you want debug-print-function to get the arguments correctly, use $@
not $* (cf 'Special Parameters' in man bash for a proper explanation: this
applies to all arrays. http://wooledge.org/mywiki/BashFAQ/073 shows how to
manipulate all members of an array, eg to add a prefix.)
Doesn't matter as arguments are just written to a file and for some
reason this form is used all over the base in eclasses but shouldn't
hurt to use [EMAIL PROTECTED] with new code.
This use of counter in _java-pkg_osgijar-fromfile is odd:
while [[ -n ${1} ]]; do
# while [[ $1 ]] or while (($#)) also work
if [[ ${1} == --noversion ]]; then
noversion=1
else
arguments[${counter}]=${1}
((++counter))
fi
shift 1 # just shift?
done
(([EMAIL PROTECTED] 3)) die At least three arguments (not
counting --noversion) are needed for java-pkg_osgijar-fromfile()
You can either just add to the array with: arguments+=($1)
or add using the counter: arguments[counter++]=$1
and then check: ((counter 3)) die ..
Arithmetic context[1] applies in array indexes, so you don't need to use a $
for variables and you can post/pre-incr etc there.
Yuu can also use it for C-style flags, with 0 as false and non-zero true:
if [[ ${noversion} == 1 ]];
can be
if ((noversion));
This is handy since unset variables evaluate as zero, which is false inside
((..)), so a simple flag=1 is all that's needed, ie you don't have to set a
default, although ofc it's more robust to do so, especially for functions.
declare -i flag=0 # makes a local var which can only have integer values
assigned (setting it to string typically evaluates to zero; arithmetic
context is used for all assignments, so a string which happens to be a
variable with an integer will return that value.)
[1] http://wooledge.org/mywiki/ArithmeticExpression
We really don't need to create the arguments array at all. We could just
check if ${1} is --noversion and then use shift. After that we can use
the positional arguments as usual so instead of ${arguments[0]} we can
use just ${1}.
Regards,
Petteri
���^����(� ��X��X�
Re: [gentoo-dev] Re: [gentoo-commits] gentoo-x86 commit in rox-base/rox-clib: ChangeLog rox-clib-2.1.10.ebuild
Donnie Berkholz [EMAIL PROTECTED] wrote: Instead of these subshells to save the original directory, a more common technique is pushd/popd. Another possibility is 'cd foo; stuff; cd -', but that doesn't stack. That's an excellent idea, I'll update these to not use subshells in the future. Is there some sort of equivalent way to back-out of whatever 'insinto' does to the environment? -- Jim Ramsay Gentoo/Linux Developer (rox,gkrellm) signature.asc Description: PGP signature
Re: [gentoo-dev] Re: New eclass osgi.eclass
Jean-Noël Rivasseau kirjoitti: The fact that I use the jar utility to unzip a file, combined with the fact that jar does not have an option to specify a destination directory, is troublesome. I have to copy the .jar file to the destination directory and then remove it. This .jar file can be several MBs of course. The jar utility supports writing to standard output and you can just use normal output redirection. See man jar. Regards, Petteri signature.asc Description: OpenPGP digital signature
[gentoo-dev] Re: .desktop file cleanup
Donnie Berkholz [EMAIL PROTECTED] posted [EMAIL PROTECTED], excerpted below, on Fri, 07 Dec 2007 00:28:50 -0800: On 01:56 Fri 07 Dec , Jeffrey Gardner wrote: Petteri Räty wrote: Results: http://dev.gentoo.org/~betelgeuse/desktop-files/results.txt While we're at it, why not bring those desktop files that are under our control more inline with the freedesktop standards? http://standards.freedesktop.org/menu-spec/latest/apa.html Speaking for myself, Edutainment is a ridiculous category Where are you quoting Edutainment from? I can't find it anywhere on that page. FWICT, he's referencing the results (the URL of which you snipped but I reincluded, above), which use Edutainment as a category in a couple places. It seems most agree that's ridiculous, and he's proposing something closer to the freedesktop standard instead. -- Duncan - List replies preferred. No HTML msgs. Every nonfree program has a lord, a master -- and if you use the program, he is your master. Richard Stallman -- [EMAIL PROTECTED] mailing list
Re: [gentoo-dev] RFC: categorizing RDEPEND to help --newuse
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
Petteri Räty wrote:
Please comment on my ideas in http://bugs.gentoo.org/show_bug.cgi?id=201499
Regards,
Petteri
As requested on the bug by other people, could you please explain what exactly
you are proposing, what problem it is solving and how it solves that. If you
throw in a free example you'll make me real happy,
thank you,
Marijn
- --
Marijn Schouten (hkBst), Gentoo Lisp project, Gentoo ML
http://www.gentoo.org/proj/en/lisp/, #gentoo-{lisp,ml} on FreeNode
-BEGIN PGP SIGNATURE-
Version: GnuPG v2.0.7 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org
iD8DBQFHWTIup/VmCx0OL2wRAtxkAKCTOGuMLMqdYE4ueSuviDL8M5tqOgCgoiFc
Pq/f+trtXxzsbdN14nOqRkg=
=r3wN
-END PGP SIGNATURE-
--
[EMAIL PROTECTED] mailing list
[gentoo-dev] Re: RFC: categorizing RDEPEND to help --newuse
Petteri Räty wrote: Please comment on my ideas in http://bugs.gentoo.org/show_bug.cgi?id=201499 http://bugs.gentoo.org/attachment.cgi?id=137968action=view seems to be the draft spec. I'd like to put in a request for a link dependency which is covered atm by build,target i guess. compile-against didn't quite seem to cover that (since it seemed to be more about rebuilding other packages) and I think it'd help for revdeps as well as representing one of the most fundamental deps. It would be good to get dependencies fully specced out for the future. -- [EMAIL PROTECTED] mailing list
