Re: [gentoo-dev] logging in openntpd 20080406-r3+

2013-11-29 Thread Diego Elio Pettenò
On Sat, Nov 30, 2013 at 1:55 AM, Peter Stuge  wrote:

> Conditionally patching openntpd in the ebuild if a system is using
> openrc is certainly the way to go.
>

You mean unconditionally here, right? Because pid files should be there,
full stop.

Diego Elio Pettenò — Flameeyes
flamee...@flameeyes.eu — http://blog.flameeyes.eu/


Re: [gentoo-dev] logging in openntpd 20080406-r3+

2013-11-29 Thread Peter Stuge
Paul B. Henson wrote:
> If openrc has issues managing services that don't drop pid files, maybe
> that should be looked into, or maybe openntpd could be patched to drop
> a pid file.

Conditionally patching openntpd in the ebuild if a system is using
openrc is certainly the way to go.


> But running in debug mode to prevent daemonizing, and then
> manually backgrounding it, is simply kludgy and distasteful :(...

Yes!


//Peter



Re: [gentoo-dev] logging in openntpd 20080406-r3+

2013-11-29 Thread Paul B. Henson
On Fri, Nov 29, 2013 at 09:49:03AM +0100, Lars Wendler wrote:

> I think there's some confusion on what the -d option actually does, so
> let me cite the relevant parts from "man 8 ntpd":
[...]
> Now let's discuss if this can be considered as "debug mode" or not.

Let me cite the relevant code ;) :

ntpd.c:
while ((ch = getopt(argc, argv, "df:nsSv")) != -1) {
switch (ch) {
case 'd':
lconf.debug = 1;

The person that wrote the code clearly intended -d to enable debugging. We
can discuss exactly what enabling debugging does, but I really don't think
there's any question as to whether or not -d should be considered debug
mode...

> If logging once was done via syslog this should not be changed. 
> So rather than making this available via USE flag being disabled
> by default I'd rather prefer to have the USE flag being enabled by
> default.  
>   
Also, running in debug mode precludes logging to syslog, as in debug mode
it just spews to stderr. Cause, well, it's for debugging, not routine
operation.

If openrc has issues managing services that don't drop pid files, maybe
that should be looked into, or maybe openntpd could be patched to drop
a pid file. But running in debug mode to prevent daemonizing, and then
manually backgrounding it, is simply kludgy and distasteful :(...




Re: [gentoo-dev] RFC: New project: Licenses

2013-11-29 Thread Roy Bamford
On 2013.11.22 09:38, Ulrich Mueller wrote:
> > On Thu, 21 Nov 2013, Roy Bamford wrote:
> 
> >> Indeed, that's one of the two TLPs that were suggested. The past 
> QA
> >> disliked having Licenses as their subproject, though. It depends 
> on
> >> how the role of QA is defined: If it is seen as primarily
> technical,
> >> then Licenses (which is largely non-technical) doesn't fit so 
> well.
> 
> > ... or maybe a sub committee of the Gentoo Foundation Inc?
> > because of the non technical and legal implications of the work.
> > Trustees get involved with licence corner cases anyway, so a team 
> of
> 
> > advisors would be a good fit.
> 
> I'd rather avoid the term "advisors", because we're no lawyers and
> therefore cannot give any legal advice.

Accepted.  Licenses already uses the trustees when legal advice is 
required.
> 
> It it clear that in some cases the licenses team will escalate issues
> to the trustees and not to the council. Nevertheless, I see a project
> (TLP or sub-project) as a good enough fit. So no need to invent new
> structures for us. The main goal of having a project page is to
> increase our visibility and to have a convenient starting point for
> organising our information in the wiki.
> 
> Ulrich
> 

The Foundation bylaws already allow for committees, none have been 
created yet but it would not be inventing a new structure. 

None of this has anything to do with Licenses having a project page 
or not.

-- 
Regards,

Roy Bamford
(Neddyseagoon) a member of
elections
gentoo-ops
forum-mods
trustees


pgp5yUWdCMgGZ.pgp
Description: PGP signature


Re: [gentoo-dev] logging in openntpd 20080406-r3+

2013-11-29 Thread Lars Wendler
Am Thu, 28 Nov 2013 08:55:56 -0700
schrieb Christoph Junghans :

> 2013/11/28 Rich Freeman :
> > On Wed, Nov 27, 2013 at 10:56 PM, Paul B. Henson 
> > wrote:
> >> On Fri, Nov 22, 2013 at 09:36:38PM +0100, Peter Stuge wrote:
> >>> Paul B. Henson wrote:
> >>> > In openntpd ebuilds starting with version  20080406-r3, logging
> >>> > was changed from using the default standard syslog to running
> >>> > the daemon in debug mode, logging to stderr, and having
> >>> > start_stop_daemon background the process itself and redirect
> >>> > the output to a log file.
> >>> >
> >>> > I think this is broken.
> >>>
> >>> Yes, I think it is really f-ing broken too.
> >>
> >> Well, looks like it's just you and me in that camp :(, quite
> >> disappointing no other devs stepped up with an opinion on this.
> >> Guess I'll just fix this in my local overlay and the rest of the
> >> users can fend for themselves.
> >
> > Did anybody actually talk to the maintainer about this and ask why
> > this was done?  That would probably be a good first step if you want
> > it to change.  Having 47 devs agree with you doesn't really
> > accomplish much if none of them care to maintain the package in
> > question.
> Paul talked to me via the bug tracker, bug 491134, and due to
> discussion we had there openntpd-20080406-r5 features a use flag to
> bring back syslog support (for details see the bug). This allows to
> run openntpd with two different ways of logging, via syslog (like Paul
> wants) and with a separate log file to avoid boot delays (like djc
> wants). We could easily make syslog logging the default, like
> polynomial-c suggested in another thread, but syslog is enabled in
> most profiles by default anyway.
> 
> >
> > Also, you can always publish your overlay.  :)
> >
> > Rich
> >
> 
> 
> 

I think I messed something up here.
Yesterday I tried to reply on the latest mail being in this discussion
thread but added Christoph's email address with a typo so the reply was
not sent at all. I then only sent the reply to him and not to the list.
So for completeness, here's my reply from yesterday:


[Begin of quote]

CCing ottxor (he's our openntpd maintainer) so he won't miss further
discussion about this.

Actually I partially do agree with the complaints that appeared in this
thread.
If logging once was done via syslog this should not be changed.
So rather than making this available via USE flag being disabled
by default I'd rather prefer to have the USE flag being enabled by
default.

I do not agree with Paul's suggestion to remove the -d option from the
init script again. Unfortunately openntpd does not create a PIDfile
once it gets started. This would not be a problem if openrc would not
require a PIDfile to _reliably_ determine if the daemon is still
running or not. So I think ottxor did the only right thing here. 
On the other hand since the daemon's init script starts the daemon with
-d I see occasional ntpd crashes on one of my systems. I'm still
investigating this and right now won't blame anyone.
Fixes for the boot delays have already been mentioned (don't use ntpd's
-s option) and other problems I cannot really see.

[End of quote]


I think there's some confusion on what the -d option actually does, so
let me cite the relevant parts from "man 8 ntpd":

  ntpd uses the adjtime(2) system call to correct the local
  system time without causing time jumps. Adjustments larger than
  128ms are logged using syslog(3) with LOG_INFO priority. The
  threshold value is chosen to avoid having local clock drift
  thrash the log files. Should ntpd be started with the -d
  option, all calls to adjtime(2) will be logged.

[snip]

  -d Do not daemonize. If this option is specified, ntpd will
 run in the foreground and log to stderr.

[snip]

  -v This option allows ntpd to send DEBUG priority messages
 to  syslog.



Now let's discuss if this can be considered as "debug mode" or not.


@Christoph: Sorry I messed up your nickname so badly :-/

-- 
Lars Wendler
Gentoo package maintainer


signature.asc
Description: PGP signature