[gentoo-portage-dev] [PATCH v2] EbuildBuild: call _record_binpkg_info earlier (bug 578204)

[Zac Medico]

Replace exit listener usage with a TaskSequence instance,
in order to guarantee that _record_binpkg_info executes
immediately after EbuildBinpkg. This approach is similar to
that used to fix bug 562264.

X-Gentoo-bug: 578204
X-Gentoo-bug-url: https://bugs.gentoo.org/show_bug.cgi?id=578204
---
[PATCH v2] Eliminated nested TaskSequence instance.

 pym/_emerge/EbuildBuild.py | 17 +++--
 1 file changed, 15 insertions(+), 2 deletions(-)

diff --git a/pym/_emerge/EbuildBuild.py b/pym/_emerge/EbuildBuild.py
index 95c14e4..ac786b0 100644
--- a/pym/_emerge/EbuildBuild.py
+++ b/pym/_emerge/EbuildBuild.py
@@ -6,6 +6,7 @@ from __future__ import unicode_literals
 import io
 
 import _emerge.emergelog
+from _emerge.AsynchronousTask import AsynchronousTask
 from _emerge.EbuildExecuter import EbuildExecuter
 from _emerge.EbuildPhase import EbuildPhase
 from _emerge.EbuildBinpkg import EbuildBinpkg
@@ -325,8 +326,12 @@ class EbuildBuild(CompositeTask):
pkg=self.pkg, 
scheduler=self.scheduler,
settings=self.settings)
binpkg_tasks.add(task)
-   task.addExitListener(
-   self._record_binpkg_info)
+   # Guarantee that _record_binpkg_info is 
called
+   # immediately after EbuildBinpkg. Note 
that
+   # task.addExitListener does not provide 
the
+   # necessary guarantee (see bug 578204).
+   binpkg_tasks.add(self._RecordBinpkgInfo(
+   ebuild_binpkg=task, 
ebuild_build=self))
 
if binpkg_tasks:
self._start_task(binpkg_tasks, self._buildpkg_exit)
@@ -335,6 +340,14 @@ class EbuildBuild(CompositeTask):
self._final_exit(build)
self.wait()
 
+   class _RecordBinpkgInfo(AsynchronousTask):
+
+   __slots__ = ('ebuild_binpkg', 'ebuild_build',)
+
+   def _start(self):
+   
self.ebuild_build._record_binpkg_info(self.ebuild_binpkg)
+   AsynchronousTask._start(self)
+
def _buildpkg_exit(self, packager):
"""
Released build dir lock when there is a failure or
-- 
2.7.2

[gentoo-portage-dev] [PATCH] EbuildBuild: call _record_binpkg_info earlier (bug 578204)

[Zac Medico]

Replace exit listener usage with a TaskSequence instance,
in order to guarantee that _record_binpkg_info executes
immediately after EbuildBinpkg. This approach is similar to
that used to fix bug 562264.

X-Gentoo-bug: 578204
X-Gentoo-bug-url: https://bugs.gentoo.org/show_bug.cgi?id=578204
---
 pym/_emerge/EbuildBuild.py | 20 +---
 1 file changed, 17 insertions(+), 3 deletions(-)

diff --git a/pym/_emerge/EbuildBuild.py b/pym/_emerge/EbuildBuild.py
index 95c14e4..2941511 100644
--- a/pym/_emerge/EbuildBuild.py
+++ b/pym/_emerge/EbuildBuild.py
@@ -6,6 +6,7 @@ from __future__ import unicode_literals
 import io
 
 import _emerge.emergelog
+from _emerge.AsynchronousTask import AsynchronousTask
 from _emerge.EbuildExecuter import EbuildExecuter
 from _emerge.EbuildPhase import EbuildPhase
 from _emerge.EbuildBinpkg import EbuildBinpkg
@@ -320,13 +321,18 @@ class EbuildBuild(CompositeTask):
phase="rpm", 
scheduler=self.scheduler,
settings=self.settings))
else:
+   # Use task_seq to guarantee that 
_RecordBinpkgInfo
+   # is called immediately after 
EbuildBinpkg, in order
+   # to solve bug #578204.
+   task_seq = TaskSequence()
task = EbuildBinpkg(
background=self.background,
pkg=self.pkg, 
scheduler=self.scheduler,
settings=self.settings)
-   binpkg_tasks.add(task)
-   task.addExitListener(
-   self._record_binpkg_info)
+   task_seq.add(task)
+   task_seq.add(self._RecordBinpkgInfo(
+   ebuild_binpkg=task, 
ebuild_build=self))
+   binpkg_tasks.add(task_seq)
 
if binpkg_tasks:
self._start_task(binpkg_tasks, self._buildpkg_exit)
@@ -335,6 +341,14 @@ class EbuildBuild(CompositeTask):
self._final_exit(build)
self.wait()
 
+   class _RecordBinpkgInfo(AsynchronousTask):
+
+   __slots__ = ('ebuild_binpkg', 'ebuild_build',)
+
+   def _start(self):
+   
self.ebuild_build._record_binpkg_info(self.ebuild_binpkg)
+   AsynchronousTask._start(self)
+
def _buildpkg_exit(self, packager):
"""
Released build dir lock when there is a failure or
-- 
2.7.2

[gentoo-dev] GSoC 2016: Extensions for the Gentoo Wiki

[Ankita Shukla]

Hi,

I am Ankita Shukla, a Computer Science senior undergraduate at Indian
Institute of Technology, Roorkee, India.

I have applied to Gentoo project 'Extensions for the Gentoo Wiki'.
The Gentoo Wiki has been the main documentation source for Gentoo for well
over two years now. It has plenty of content, but a few features (in the
form of extensions) need to be added to the software, MediaWiki, to provide
even better documentation.
Developing and integrating these extensions with the Gentoo Wiki will make
the wiki easier to use and people more efficient. At the end of the summer,
four new extensions would be added to the Gentoo wiki, including:

   - A document export pipeline for PDF and other common e-reader formats
   for the Gentoo Handbook.
   - Improve Handbook navigation on smartphones
   - Fork-a-page: A way for contributors to fork pages that are read-only
   for them, implement improvements, and allow the privileged developers to
   merge them back in easily.
   - Kernel configuration documentation: Ingest a set of .config parameters
   (CONFIG_FOO=M) and render the location and description for a set of current
   kernel versions.

The first point here

says
that I need to clone one of the repos and submit a patch for a bug and also
says that 'Your contact in Gentoo can help you determine which SCM and
repository you should use for this as well as a good bug to fix. ' :)

So, it would be really awesome if I could get a direction to some easy bugs
to fix. I'm looking for them too! :D

*Project Idea* -
https://wiki.gentoo.org/wiki/Google_Summer_of_Code/2016/Ideas/Extensions_for_the_Gentoo_Wiki

*Proposal* -
https://docs.google.com/document/d/1z8cOhYXn9JOK8MDObX12xUBfS-XaZ5b4iQ4iFchUVqA/edit#

*A small intro:*
I am Ankita Shukla, a Computer Science senior undergraduate at Indian
Institute of Technology, Roorkee, India.
I am a regular MediaWiki contributor and have also developed an extension
Spelling Dictionary [
https://www.mediawiki.org/wiki/Extension:SpellingDictionary, CODE -
https://git.wikimedia.org/log/mediawiki%2Fextensions%2FSpellingDictionary ]
for Gnome Outreachy Round#9 [https://www.gnome.org/opw/#participants]
(previously OPW). I also delivered a talk on the extension in the FOSSASIA
conference (March 18-20, 2016). I had also opened some tasks for Google
Code In 2015 in the same extension and was a mentor for them.
I’m also a big time Linux enthusiast. I've been using and experimenting
with different distros - had started off with Ubuntu, changed to Elementary
OS Luna and right now working on Linux MInt!

Looking forward to hearing from all of you! :)

-- 
Thanks and Regards,

Ankita Shukla
Computer Science Engineering
B.Tech Final Year (Senior)
Indian Institute of Technology Roorkee

Re: [gentoo-dev] ssh keys setup for git.gentoo.org after ssh-dss deprecation

[Paweł Hajdan , Jr .]

On 3/26/16 11:41 AM, Michał Górny wrote:
> On Sat, 26 Mar 2016 18:40:17 +0900
> Aaron Bauman  wrote:
>> Git SSH key changes are done manually by the infra team.  I just went 
>> through 
>> the same issue when I updated my keys.  Hope this helps.
> 
> Updated.

Thanks! Everything works now.

Should the docs also be updated to make this more obvious?

Some candidates:




(mentions DSA keys but looks like they're being deprecated in ssh now).

Paweł



signature.asc
Description: OpenPGP digital signature

Re: [gentoo-dev] ssh keys setup for git.gentoo.org after ssh-dss deprecation

[Michał Górny]

On Sat, 26 Mar 2016 18:40:17 +0900
Aaron Bauman  wrote:

> On Saturday, March 26, 2016 10:05:58 AM JST Paweł Hajdan, Jr. wrote:
> > I recently hit ssh-dss key deprecation
> > ( >   
> > l>), and PubkeyAcceptedKeyTypes=+ssh-dss on the client side allows me to  
> > keep access to Gentoo infrastructure I need.
> > 
> > I generated a new RSA key using instructions from
> > , and
> > added it to LDAP following
> > .
> > 
> > I can now login to dev.gentoo.org with just the new RSA key.
> > 
> > However, git.gentoo.org gives me access denied errors unless I use the
> > DSA key.
> > 
> > Is this expected?
> > 
> > I'm just wondering if it's some error on my side or something else.
> > 
> > Looking at
> > ,
> > I see things like:
> > - "DSA keys are preferred over RSA keys"
> > - "where possible users should be required to use DSA keys to authenticate"
> > 
> > Should I actually rather look at generating a ed25519 key?
> > 
> > Paweł  
> 
> Git SSH key changes are done manually by the infra team.  I just went through 
> the same issue when I updated my keys.  Hope this helps.

Updated.

-- 
Best regards,
Michał Górny



pgpcUNzTyWaM5.pgp
Description: OpenPGP digital signature

Re: [gentoo-dev] ssh keys setup for git.gentoo.org after ssh-dss deprecation

[Aaron Bauman]

On Saturday, March 26, 2016 10:05:58 AM JST Paweł Hajdan, Jr. wrote:
> I recently hit ssh-dss key deprecation
> ( l>), and PubkeyAcceptedKeyTypes=+ssh-dss on the client side allows me to
> keep access to Gentoo infrastructure I need.
> 
> I generated a new RSA key using instructions from
> , and
> added it to LDAP following
> .
> 
> I can now login to dev.gentoo.org with just the new RSA key.
> 
> However, git.gentoo.org gives me access denied errors unless I use the
> DSA key.
> 
> Is this expected?
> 
> I'm just wondering if it's some error on my side or something else.
> 
> Looking at
> ,
> I see things like:
> - "DSA keys are preferred over RSA keys"
> - "where possible users should be required to use DSA keys to authenticate"
> 
> Should I actually rather look at generating a ed25519 key?
> 
> Paweł

Git SSH key changes are done manually by the infra team.  I just went through 
the same issue when I updated my keys.  Hope this helps.

-- 
Cheers,
Aaron Bauman
Gentoo Linux Developer
GnuPG FP: 1536 F4B3 72EB 9C54 11F5  5C43 246D 23A2 10FB 0F3E

signature.asc
Description: This is a digitally signed message part.

[gentoo-dev] ssh keys setup for git.gentoo.org after ssh-dss deprecation

[Paweł Hajdan , Jr .]

I recently hit ssh-dss key deprecation
(),
and PubkeyAcceptedKeyTypes=+ssh-dss on the client side allows me to keep
access to Gentoo infrastructure I need.

I generated a new RSA key using instructions from
, and
added it to LDAP following
.

I can now login to dev.gentoo.org with just the new RSA key.

However, git.gentoo.org gives me access denied errors unless I use the
DSA key.

Is this expected?

I'm just wondering if it's some error on my side or something else.

Looking at
,
I see things like:
- "DSA keys are preferred over RSA keys"
- "where possible users should be required to use DSA keys to authenticate"

Should I actually rather look at generating a ed25519 key?

Paweł



signature.asc
Description: OpenPGP digital signature