[gentoo-dev] [PATCH] distutils-r1.eclass: Do not modify the HOME variable
This was only necessary when we ran phases in parallel.
Also, PMS says this variable should not be modified.
---
eclass/distutils-r1.eclass | 6 --
1 file changed, 6 deletions(-)
diff --git a/eclass/distutils-r1.eclass b/eclass/distutils-r1.eclass
index 7965e91..497bed5 100644
--- a/eclass/distutils-r1.eclass
+++ b/eclass/distutils-r1.eclass
@@ -628,12 +628,6 @@ distutils-r1_run_phase() {
# in the sys.path_importer_cache)
mkdir -p "${BUILD_DIR}/lib" || die
- # We need separate home for each implementation, for .pydistutils.cfg.
- if [[ ! ${DISTUTILS_SINGLE_IMPL} ]]; then
- local -x HOME=${HOME}/${EPYTHON}
- mkdir -p "${HOME}" || die
- fi
-
# Set up build environment, bug #513664.
local -x AR=${AR} CC=${CC} CPP=${CPP} CXX=${CXX}
tc-export AR CC CPP CXX
--
2.8.2
Re: [gentoo-dev] [PATCH] metadata.xsd: upstream maintainer must have exactly one element
On Fri, May 6, 2016 at 10:14 AM, Göktürk Yüksek wrote: > The change only reflects what's already in GLEP 68 [0] which itself > derives this condition from GLEP 46 [1] which has the following clause: > > """ > name should contain a block of text with upstream's name, is mandatory > and can only appear once. > """ > > It has been this way since ~2008 according to the GLEP bug [2]. Thanks. Still, if you want to elicit useful code reviews, my point stands that it's probably useful to include more context in your change requests. Cheers, Dirkjan
Re: [gentoo-dev] [PATCH] metadata.xsd: upstream maintainer must have exactly one element
Dirkjan Ochtman: > On Fri, May 6, 2016 at 1:16 AM, Göktürk Yüksek wrote: >> Signed-off-by: Göktürk Yüksek >> --- >> metadata.xsd | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/metadata.xsd b/metadata.xsd >> index 8bc6a4e..fe2c5d2 100644 >> --- a/metadata.xsd >> +++ b/metadata.xsd >> @@ -137,7 +137,7 @@ >> > minOccurs='0'/> >> > - minOccurs='0'/> >> + minOccurs='1'/> >> >> > type='upstreamMaintainerStatusAttrType' >> default='unknown'/> > > IMO this patch could do with a bit more rationale. Personally, I don't > like this change, as it seems enough in many cases to just add an > email address for an upstream maintainer (for example, maybe the > upstream maintainer is a mailing list?). > The change only reflects what's already in GLEP 68 [0] which itself derives this condition from GLEP 46 [1] which has the following clause: """ name should contain a block of text with upstream's name, is mandatory and can only appear once. """ It has been this way since ~2008 according to the GLEP bug [2]. > Cheers, > > Dirkjan > [0] https://wiki.gentoo.org/wiki/GLEP:68#Upstream_maintainer_descriptions [1] https://wiki.gentoo.org/wiki/GLEP:46 [2] https://bugs.gentoo.org/show_bug.cgi?id=234730 -- gokturk
Re: [gentoo-dev] [PATCH] metadata.xsd: upstream maintainer must have exactly one element
Dnia 6 maja 2016 09:39:24 CEST, Dirkjan Ochtman napisał(a): >On Fri, May 6, 2016 at 1:16 AM, Göktürk Yüksek >wrote: >> Signed-off-by: Göktürk Yüksek >> --- >> metadata.xsd | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/metadata.xsd b/metadata.xsd >> index 8bc6a4e..fe2c5d2 100644 >> --- a/metadata.xsd >> +++ b/metadata.xsd >> @@ -137,7 +137,7 @@ >> > minOccurs='0'/> >> > - minOccurs='0'/> >> + minOccurs='1'/> >> >> type='upstreamMaintainerStatusAttrType' >> default='unknown'/> > >IMO this patch could do with a bit more rationale. Personally, I don't >like this change, as it seems enough in many cases to just add an >email address for an upstream maintainer (for example, maybe the >upstream maintainer is a mailing list?). That's what the original GLEP said (sorry, i don't have the no handy, the one about upstream element). > >Cheers, > >Dirkjan -- Best regards, Michał Górny (by phone)
Re: [gentoo-dev] [PATCH] metadata.xsd: upstream maintainer must have exactly one element
On Fri, May 6, 2016 at 1:16 AM, Göktürk Yüksek wrote: > Signed-off-by: Göktürk Yüksek > --- > metadata.xsd | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/metadata.xsd b/metadata.xsd > index 8bc6a4e..fe2c5d2 100644 > --- a/metadata.xsd > +++ b/metadata.xsd > @@ -137,7 +137,7 @@ > minOccurs='0'/> > - minOccurs='0'/> > + minOccurs='1'/> > > type='upstreamMaintainerStatusAttrType' > default='unknown'/> IMO this patch could do with a bit more rationale. Personally, I don't like this change, as it seems enough in many cases to just add an email address for an upstream maintainer (for example, maybe the upstream maintainer is a mailing list?). Cheers, Dirkjan
