Re: [gentoo-dev] [PATCH 1/1] kernel-2.eclass: Add required @USAGE documentation to functions.

[Mike Gilbert]

On Mon, Dec 12, 2016 at 9:44 PM, Mike Gilbert  wrote:
> On Mon, Dec 12, 2016 at 7:34 PM, Mike Pagano  wrote:
>> According to PMS, @USAGE is required for functions.
>> This patch only touches comments and no code has been modified.
>
> PMS says nothing on the topic of eclass documentation syntax.
>
> Any requirements are imposed by the eclass-manpages awk script.

Maybe you were referring to the devmanual (not PMS)?

https://devmanual.gentoo.org/eclass-writing/index.html

Personally, I don't think it makes sense to add an empty @USAGE entry
for functions that take no arguments.

Re: [gentoo-dev] [PATCH 1/1] kernel-2.eclass: Add required @USAGE documentation to functions.

[Mike Gilbert]

On Mon, Dec 12, 2016 at 7:34 PM, Mike Pagano  wrote:
> According to PMS, @USAGE is required for functions.
> This patch only touches comments and no code has been modified.

PMS says nothing on the topic of eclass documentation syntax.

Any requirements are imposed by the eclass-manpages awk script.

[gentoo-dev] Re: Cross Post due to technical component - Thanks for all the fish

[Duncan]

Jorge Manuel B. S. Vicetto posted on Wed, 07 Dec 2016 15:36:20 + as
excerpted:

> On Wed, 7 Dec 2016, Jorge Manuel B. S. Vicetto wrote:
> 
> 
> 
>> I'm asking recuiters directly, but unless someone changed the rules and
>> I was distracted, irc is not mandatory.
> 
> I've got confirmation that nothing has changed, so irc is not mandatory.
> I hope this clears any misunderstandings and puts an end to any
> speculation.

Thank you. =:^)

-- 
Duncan - List replies preferred.   No HTML msgs.
"Every nonfree program has a lord, a master --
and if you use the program, he is your master."  Richard Stallman

[gentoo-dev] [warning] the bug queue has 98 bugs

[Alex Alexander]

Our bug queue has 98 bugs!

If you have some spare time, please help assign/sort a few bugs.

To view the bug queue, click here: http://bit.ly/m8PQS5

Thanks!

[gentoo-dev] [PATCH 1/1] kernel-2.eclass: Add required @USAGE documentation to functions.

[Mike Pagano]

According to PMS, @USAGE is required for functions.
This patch only touches comments and no code has been modified.

---
 eclass/kernel-2.eclass | 38 ++
 1 file changed, 34 insertions(+), 4 deletions(-)

diff --git a/eclass/kernel-2.eclass b/eclass/kernel-2.eclass
index b19a396..99449a6 100644
--- a/eclass/kernel-2.eclass
+++ b/eclass/kernel-2.eclass
@@ -128,8 +128,6 @@
 # @DESCRIPTION:
 # If set, this kernel is unsupported by Gentoo Security
 # to the current eclass maintainer :)
-# added functionality:
-# unipatch  - a flexible, singular method to extract, add and
remove patches.

 # @ECLASS-VARIABLE:  K_DEBLOB_AVAILABLE
 # @DEFAULT_UNSET
@@ -241,6 +239,7 @@ RESTRICT="binchecks strip"


 # @FUNCTION: debug-print-kernel2-variables
+# @USAGE:
 # @DESCRIPTION:
 # this function exists only to help debug kernel-2.eclass
 # if you are adding new functionality in, put a call to it
@@ -255,6 +254,7 @@ debug-print-kernel2-variables() {
 }

 # @FUNCTION: handle_genpatches
+# @USAGE: [--set-unipatch-list]
 # @DESCRIPTION:
 # add genpatches to list of patches to apply uf wanted

@@ -312,6 +312,7 @@ handle_genpatches() {
 }

 # @FUNCTION: detect_version
+# @USAGE:
 # @DESCRIPTION:
 # this function will detect and set
 # - OKV: Original Kernel Version (2.6.0/2.6.0-test11)
@@ -543,6 +544,7 @@ detect_version() {
 }

 # @FUNCTION: kernel_is
+# @USAGE: 
 # @DESCRIPTION:
 # user for comparing kernel versions
 # or just identifying a version
@@ -576,6 +578,7 @@ kernel_is() {
 }

 # @FUNCTION: kernel_is_2_4
+# @USAGE:
 # @DESCRIPTION:
 # return true if kernel is version 2.4
 kernel_is_2_4() {
@@ -583,6 +586,7 @@ kernel_is_2_4() {
 }

 # @FUNCTION: kernel_is_2_6
+# @USAGE:
 # @DESCRIPTION:
 # return true if kernel is version 2.6
 kernel_is_2_6() {
@@ -677,6 +681,7 @@ fi
 # Cross-compile support functions

 # @FUNCTION: kernel_header_destdir
+# @USAGE:
 # @DESCRIPTION:
 # return header destination directory
 kernel_header_destdir() {
@@ -686,6 +691,7 @@ kernel_header_destdir() {
 }

 # @FUNCTION: cross_pre_c_headers
+# @USAGE:
 # @DESCRIPTION:
 # set use if neccesary for cross compile support
 cross_pre_c_headers() {
@@ -693,6 +699,7 @@ cross_pre_c_headers() {
 }

 # @FUNCTION: env_setup_xmakeopts
+# @USAGE:
 # @DESCRIPTION:
 # set the ARCH/CROSS_COMPILE when cross compiling

@@ -712,6 +719,7 @@ env_setup_xmakeopts() {
 }

 # @FUNCTION: unpack_2_4
+# @USAGE:
 # @DESCRIPTION:
 # unpack and generate .config for 2.4 kernels

@@ -725,6 +733,7 @@ unpack_2_4() {
 }

 # @FUNCTION: unpack_2_6
+# @USAGE:
 # @DESCRIPTION:
 # unpack and generate .config for 2.6 kernels

@@ -750,6 +759,7 @@ unpack_2_6() {
 }

 # @FUNCTION: universal_unpack
+# @USAGE:
 # @DESCRIPTION:
 # unpack kernel sources

@@ -793,6 +803,7 @@ universal_unpack() {
 }

 # @FUNCTION: unpack_set_extraversion
+# @USAGE:
 # @DESCRIPTION:
 # handle EXTRAVERSION

@@ -803,6 +814,7 @@ unpack_set_extraversion() {
 }

 # @FUNCTION: unpack_fix_install_path
+# @USAGE:
 # @DESCRIPTION:
 # Should be done after patches have been applied
 # Otherwise patches that modify the same area of Makefile will fail
@@ -815,6 +827,7 @@ unpack_fix_install_path() {
 # Compile Functions

 # @FUNCTION: compile_headers
+# @USAGE:
 # @DESCRIPTION:
 # header compilation

@@ -871,6 +884,7 @@ compile_headers() {
 }

 # @FUNCTION: compile_headers_tweak_config
+# @USAGE:
 # @DESCRIPTION:
 # some targets can be very very picky, so let's finesse the
 # .config based upon any info we may have
@@ -890,6 +904,7 @@ compile_headers_tweak_config() {
 # install functions

 # @FUNCTION: install_universal
+# @USAGE:
 # @DESCRIPTION:
 # Fix permissions in tarball

@@ -901,6 +916,7 @@ install_universal() {
 }

 # @FUNCTION: install_headers
+# @USAGE:
 # @DESCRIPTION:
 # Install headers

@@ -940,6 +956,7 @@ install_headers() {
 }

 # @FUNCTION: install_sources
+# @USAGE:
 # @DESCRIPTION:
 # Install sources

@@ -978,6 +995,7 @@ install_sources() {
 }

 # @FUNCTION: preinst_headers
+# @USAGE:
 # @DESCRIPTION:
 # Headers preinst steps

@@ -988,6 +1006,7 @@ preinst_headers() {
 }

 # @FUNCTION: postinst_sources
+# @USAGE:
 # @DESCRIPTION:
 # Sources post installation function.
 # see inline comments
@@ -1082,6 +1101,7 @@ postinst_sources() {
 # pkg_setup functions

 # @FUNCTION: setup_headers
+# @USAGE:
 # @DESCRIPTION:
 # Determine if ${PN} supports arch

@@ -1101,6 +1121,7 @@ setup_headers() {
 }

 # @FUNCTION: unipatch
+# @USAGE: 
 # @DESCRIPTION:
 # Universal function that will apply patches to source

@@ -1364,9 +1385,8 @@ unipatch() {
 }

 # @FUNCTION: getfilevar
+# @USAGE:  
 # @DESCRIPTION:
-# getfilevar accepts 2 vars as follows:
-# getfilevar  
 # pulled from linux-info

 getfilevar() {
@@ -1392,6 +1412,7 @@ getfilevar() {
 }

 # @FUNCTION: detect_arch
+# @USAGE:
 # @DESCRIPTION:
 # This function sets ARCH_URI and ARCH_PATCH
 # with the neccessary info for the arch sepecific compatibility
@@ -1425,6 +1446,7 @@ detect_arch() {
 }

 # @FUNCTION: headers___fix
+# @USAGE: