Re: [gentoo-dev] [PATCH] perl-functions.eclass: Replace unnecessary eval with ${!var}

[Kent Fredric]

On Fri, 24 Feb 2017 14:11:57 +0100
Michał Górny  wrote:

> If there is no hurry to the other changes, maybe either of us could
> commit them all at once along with all those eval patches (say, in 6
> days)? The eutils change is going to cause almost everything to be
> regenerated anyway ;-).

If its going to sneak in the tail end of the mass eutils change, then I'm not
opposed.

I have to sit down anyway and work out wtf is going on with prefix+perl anyway,
because 2 new functions I was *intending* to help with prefix conditions have 
been
so far impossible to prove they actually do what they're supposed to do, due to
complete inability to get a working prefix (ie: gentoo-in-$HOME) install.

So my changeset might be greatly delayed by this.


pgpFPU8f503UJ.pgp
Description: OpenPGP digital signature

Re: [gentoo-dev] Removal of CVS headers

[Rich Freeman]

On Sat, Feb 25, 2017 at 10:12 AM, Ulrich Mueller  wrote:
>> On Sat, 25 Feb 2017, Sergei Trofimovich wrote:
>
>> Typical questions for tree-wide cleanups:
>
>> - Are new ebuilds forbidden to have '$Id$' or just discouraged?
>> - [same as above] Will new version of repoman complain about
>>   leftover '$Id$'?
>
> Not sure. That would have to be controlled via layout.conf, in case
> someone uses CVS or Subversion for their overlay?

It should certainly be forbidden in the main tree though, otherwise
what is the point in cleaning them up?

By all means be nice to people who want to have it in their overlays
and make it controllable in layout.conf, but it isn't like SVN or CVS
rely on keywords to function.

-- 
Rich

Re: [gentoo-dev] Removal of CVS headers

[Ulrich Mueller]

> On Sat, 25 Feb 2017, Sergei Trofimovich wrote:

> Typical questions for tree-wide cleanups:

> - Are new ebuilds forbidden to have '$Id$' or just discouraged?
> - [same as above] Will new version of repoman complain about
>   leftover '$Id$'?

Not sure. That would have to be controlled via layout.conf, in case
someone uses CVS or Subversion for their overlay?

> - Will the tool be available for people to cleanup their overlays?
>   sed 1-liner is good enough. Just make sure it will be in commit
>   message.

Good idea, I'll post my script once it's ready.

Ulrich


pgpRveN4KCTgj.pgp
Description: PGP signature

Re: [gentoo-dev] Removal of CVS headers

[Sergei Trofimovich]

On Sat, 25 Feb 2017 15:05:09 +0100
Ulrich Mueller  wrote:

> As the council has decided in its 2014-10-14 meeting (and confirmed
> again in the 2016-11-13 meeting), CVS headers should be removed after
> the migration to Git. Until recently, this was blocked by repoman
> still checking for the $Id$ line. The latter is now fixed in the
> stable repoman version.

Would be nice to have a link to the meeting notes. I guess it's:
https://projects.gentoo.org/council/meeting-logs/20141014-summary.txt

"""
Can we drop CVS headers post-migration?
Aye
"""

> Therefore, I am going to remove the remaining CVS headers throughout
> the tree (except for patches, of course) in two days from now.

Typical questions for tree-wide cleanups:

- Are new ebuilds forbidden to have '$Id$' or just discouraged?
- [same as above] Will new version of repoman complain about leftover '$Id$'?
- Will the tool be available for people to cleanup their overlays?
  sed 1-liner is good enough. Just make sure it will be in commit message.

Thanks!

-- 

  Sergei


pgpKKJaKir8M2.pgp
Description: Цифровая подпись OpenPGP

Re: [gentoo-dev] [PATCH v2] java-ant-2.eclass: Replace unnecessary evals with arrays

[James Le Cuirot]

On Wed, 22 Feb 2017 22:54:22 +0100
Michał Górny  wrote:

> Replace the horrifying use of evals along with quoting to pass multiple
> filenames whitespace-safe with much simpler bash arrays. While at it,
> also simplify the find-read loop.

I've given this a rough test. Some of the code paths are rarely used
and I suspect some are never used now but it looks good anyway. Please
go ahead.

-- 
James Le Cuirot (chewi)
Gentoo Linux Developer


pgpySOV3R0z6P.pgp
Description: OpenPGP digital signature

Re: [gentoo-dev] Removal of CVS headers

[Rich Freeman]

On Sat, Feb 25, 2017 at 9:05 AM, Ulrich Mueller  wrote:
>
> Therefore, I am going to remove the remaining CVS headers throughout
> the tree (except for patches, of course) in two days from now.
>

Speaking from git migration experience, I'd be really careful about
how you go about it.  Filtering the filename and ensuring only the top
few lines get touched would probably prevent a lot of issues.  Patches
are the biggest problem as you've noted, but offhand I'm not sure if
there were others.  I just remember that CVS keywords were a constant
headache during the migration as they seemed to pop up in places you
wouldn't think of.  Now, you're only concerned with the active tree so
that cuts down the opportunity for issues quite a bit (vs fixing all
the old commits as well).

-- 
Rich

[gentoo-dev] Removal of CVS headers

[Ulrich Mueller]

As the council has decided in its 2014-10-14 meeting (and confirmed
again in the 2016-11-13 meeting), CVS headers should be removed after
the migration to Git. Until recently, this was blocked by repoman
still checking for the $Id$ line. The latter is now fixed in the
stable repoman version.

Therefore, I am going to remove the remaining CVS headers throughout
the tree (except for patches, of course) in two days from now.

Ulrich


pgp74__LGVYF4.pgp
Description: PGP signature