Re: [gentoo-dev] Manifest2 hashes, take n+1-th: one hash to decide them all

2017-10-24 Thread Robin H. Johnson
On Tue, Oct 24, 2017 at 11:33:39PM +0200, Allan Wegan wrote: > >> That is currently the case with portage, but not an inevitable > >> consequence of having 3 hash functions in the Manifest. Portage could > >> be made to check only one or two of them (even by default), giving > >> the tie-breaking

Re: [gentoo-dev] [RFC] GLEP 65 v2: Post-install QA checks (now with post-merge checks)

2017-10-24 Thread Michael Orlitzky
On 10/17/2017 02:12 PM, Michał Górny wrote: > > Abstract > > > ... > The QA checks can inspect the installation image or live system respectively, Respective to what? > output and store both user- and machine-oriented QA warning logs, manipulate > the files and abort the install, as

Re: [gentoo-dev] Manifest2 hashes, take n+1-th: 3 hashes for the tie-breaker case

2017-10-24 Thread Allan Wegan
>> That is currently the case with portage, but not an inevitable >> consequence of having 3 hash functions in the Manifest. Portage could >> be made to check only one or two of them (even by default), giving >> the tie-breaking ability to those who need it, and speeding up things >> for those who

[gentoo-portage-dev] [PATCH v5] file_copy: use sendfile return value to measure bytes copied (bug 635126)

2017-10-24 Thread Zac Medico
The sendfile *offset parameter refers to the input file offest, so it cannot be used in the same way as the copy_file_range *off_out parameter. Therefore, add sf_wrapper function which implements the *off_out behavior for sendfile. Also update cfr_wrapper so that it does not rely on the fd_in

Re: [gentoo-dev] Manifest2 hashes, take n+1-th: 3 hashes for the tie-breaker case

2017-10-24 Thread Michał Górny
W dniu wto, 24.10.2017 o godzinie 13∶56 +0200, użytkownik Chí-Thanh Christopher Nguyễn napisał: > Michał Górny schrieb: > > Oh, and most notably, the speed loss will be mostly visible to users. > > An attacker would have to compute the additional hashes only > > if the fastest hash already

Re: [gentoo-dev] Manifest2 hashes, take n+1-th: 3 hashes for the tie-breaker case

2017-10-24 Thread Rich Freeman
On Tue, Oct 24, 2017 at 4:21 AM, Paweł Hajdan, Jr. wrote: > On 24/10/2017 06:11, Michał Górny wrote: >> W dniu wto, 24.10.2017 o godzinie 06∶04 +0200, użytkownik Michał Górny >> napisał: >>> Three hashes don't give any noticeable advantage. If we want a diverse >>>

Re: [gentoo-dev] Manifest2 hashes, take n+1-th: 3 hashes for the tie-breaker case

2017-10-24 Thread Chí-Thanh Christopher Nguyễn
Michał Górny schrieb: > Oh, and most notably, the speed loss will be mostly visible to users. > An attacker would have to compute the additional hashes only > if the fastest hash already matched, i.e. rarely. Users will have to > compute them all the time. That is currently the case with portage,

[gentoo-portage-dev] [PATCH v4] file_copy: use sendfile return value to measure bytes copied (bug 635126)

2017-10-24 Thread Zac Medico
The sendfile *offset parameter refers to the input file offest, so it cannot be used in the same way as the copy_file_range *off_out parameter. Therefore, add sf_wrapper function which implements the *off_out behavior for sendfile. Bug: https://bugs.gentoo.org/635126 --- [PATCH v4] ensures that

[gentoo-portage-dev] [PATCH v3] file_copy: use sendfile return value to measure bytes copied (bug 635126)

2017-10-24 Thread Zac Medico
The sendfile *offset parameter refers to the input file offest, so it cannot be used in the same way as the copy_file_range *off_out parameter. Therefore, add sf_wrapper function which implements the *off_out behavior for sendfile. Bug: https://bugs.gentoo.org/635126 --- [PATCH v3] adds an

Re: [gentoo-portage-dev] [PATCH] man/ebuild.5: Do not document internal functions.

2017-10-24 Thread Zac Medico
On 10/24/2017 01:48 AM, Ulrich Müller wrote: > Functions containing "hook" or "prep" in their name may not be used > or relied upon by ebuilds. Therefore they should not be documented > in ebuild(5) which describes the funtions available for ebuilds. > > PMS reference:

[gentoo-portage-dev] [PATCH] man/ebuild.5: Do not document internal functions.

2017-10-24 Thread Ulrich Müller
Functions containing "hook" or "prep" in their name may not be used or relied upon by ebuilds. Therefore they should not be documented in ebuild(5) which describes the funtions available for ebuilds. PMS reference: https://projects.gentoo.org/pms/6/pms.html#x1-14700011.3.3.16 --- man/ebuild.5 |

Re: [gentoo-dev] Manifest2 hashes, take n+1-th: 3 hashes for the tie-breaker case

2017-10-24 Thread Paweł Hajdan , Jr .
On 24/10/2017 06:11, Michał Górny wrote: > W dniu wto, 24.10.2017 o godzinie 06∶04 +0200, użytkownik Michał Górny > napisał: >> Three hashes don't give any noticeable advantage. If we want a diverse >> construct, we take SHA3. SHA3 is slower than SHA2 + BLAKE2 combined, so >> even with 3 threaded