Re: [gentoo-dev] Gentoo-CI can now filter on maintainers (also verbose output)

2019-07-25 Thread Michał Górny
Dnia July 26, 2019 5:17:31 AM UTC, Georgy Yakovlev napisał(a): >On Thursday, July 25, 2019 7:05:16 AM PDT Michał Górny wrote: >> Hi, >> >> Just a quick bit of news on gentoo-ci. >> >> Firstly, I've implemented support for quiet/verbose reports. So now >> the default report seen at [1] is not

Re: [gentoo-dev] Gentoo-CI can now filter on maintainers (also verbose output)

2019-07-25 Thread Georgy Yakovlev
On Thursday, July 25, 2019 7:05:16 AM PDT Michał Górny wrote: > Hi, > > Just a quick bit of news on gentoo-ci. > > Firstly, I've implemented support for quiet/verbose reports. So now > the default report seen at [1] is not that huge, and if somebody wants > all the details at [2]. > This is

Re: [gentoo-dev] [RFC] New QA policy: Packages must not disable installing manpages via USE flags

2019-07-25 Thread desultory
On 07/25/19 04:14, Kent Fredric wrote: > On Thu, 25 Jul 2019 00:10:49 -0400 > desultory wrote: > >> The user-side effects pf the proposal in question, were it to become >> policy, would be that anyone seeking to not install what is presently >> optional documentation would either be: >> (1)

Re: [gentoo-portage-dev] [RFC] Adding extra vars to md5-cache, for QA purposes

2019-07-25 Thread Michael Orlitzky
On 7/25/19 4:29 PM, Michał Górny wrote: >> >> * In the md5-cache entry, maybe use a common prefix like EXT_ for the >> extra keys in order to distinguish them from normal keys. > > Yeah, I was thinking of something like '__ext_foo', or '__ext[foo]'. > What are the pros/cons of this? The names

Re: [gentoo-portage-dev] [RFC] Adding extra vars to md5-cache, for QA purposes

2019-07-25 Thread Michał Górny
On Thu, 2019-07-25 at 12:57 -0700, Zac Medico wrote: > On 7/25/19 5:20 AM, Michał Górny wrote: > > Hi, > > > > TL;DR: I'd like to make it possible for ebuilds to define additional > > variables that will be stored in md5-cache. This would be useful for CI > > and other tooling that right now has

Re: [gentoo-portage-dev] [RFC] Adding extra vars to md5-cache, for QA purposes

2019-07-25 Thread Zac Medico
On 7/25/19 5:20 AM, Michał Górny wrote: > Hi, > > TL;DR: I'd like to make it possible for ebuilds to define additional > variables that will be stored in md5-cache. This would be useful for CI > and other tooling that right now has to parse ebuilds for other data. > > > The idea is to add a

Re: [gentoo-dev] Gentoo-CI can now filter on maintainers (also verbose output)

2019-07-25 Thread Kent Fredric
On Thu, 25 Jul 2019 16:05:16 +0200 Michał Górny wrote: > Thirdly, I've implemented filtering by maintainer. > > To get reports for developer foo, append ';maintainer=foo', e.g.: Thanks very much :). This will come in *very* handy for me :) pgp_LVJov6dDk.pgp Description: OpenPGP digital

[gentoo-dev] Gentoo-CI can now filter on maintainers (also verbose output)

2019-07-25 Thread Michał Górny
Hi, Just a quick bit of news on gentoo-ci. Firstly, I've implemented support for quiet/verbose reports. So now the default report seen at [1] is not that huge, and if somebody wants all the details at [2]. Secondly, the reports now explicitly list maintainers for the reported packages.

[gentoo-portage-dev] [RFC] Adding extra vars to md5-cache, for QA purposes

2019-07-25 Thread Michał Górny
Hi, TL;DR: I'd like to make it possible for ebuilds to define additional variables that will be stored in md5-cache. This would be useful for CI and other tooling that right now has to parse ebuilds for other data. The idea is to add a new incremental ebuild/eclass variable (technical name:

[gentoo-dev] [PATCH v2] user.eclass: Fix egetgroups bash compliance, and make it simpler

2019-07-25 Thread Michał Górny
Signed-off-by: Michał Górny --- eclass/user.eclass | 9 + 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/eclass/user.eclass b/eclass/user.eclass index fdf98caa6099..9dc15fa75d23 100644 --- a/eclass/user.eclass +++ b/eclass/user.eclass @@ -445,11 +445,12 @@ egetgroups() {

Re: [gentoo-dev] [PATCH] user.eclass: Fix egetgroups bash compliance, and make it simpler

2019-07-25 Thread Michał Górny
On Thu, 2019-07-25 at 10:14 +0200, Ulrich Mueller wrote: > > > > > > On Thu, 25 Jul 2019, Michał Górny wrote: > > - local defgroup=${egroups_arr[0]} > > + local g groups=( "${egroups_arr[0]}" ) > > # sort supplementary groups to make comparison possible > > - readarray -t exgroups_arr <

Re: [gentoo-dev] [RFC] New QA policy: Packages must not disable installing manpages via USE flags

2019-07-25 Thread Kent Fredric
On Thu, 25 Jul 2019 00:10:49 -0400 desultory wrote: > The user-side effects pf the proposal in question, were it to become > policy, would be that anyone seeking to not install what is presently > optional documentation would either be: > (1) wasting build time and space (and, depending on

Re: [gentoo-dev] [PATCH] user.eclass: Fix egetgroups bash compliance, and make it simpler

2019-07-25 Thread Ulrich Mueller
> On Thu, 25 Jul 2019, Michał Górny wrote: > - local defgroup=${egroups_arr[0]} > + local g groups=( "${egroups_arr[0]}" ) > # sort supplementary groups to make comparison possible > - readarray -t exgroups_arr < <(printf '%s\n' "${egroups_arr[@]:1}" | > sort) > - local

[gentoo-dev] [PATCH] user.eclass: Fix egetgroups bash compliance, and make it simpler

2019-07-25 Thread Michał Górny
Signed-off-by: Michał Górny --- eclass/user.eclass | 10 ++ 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/eclass/user.eclass b/eclass/user.eclass index fdf98caa6099..b237abdda045 100644 --- a/eclass/user.eclass +++ b/eclass/user.eclass @@ -445,11 +445,13 @@ egetgroups() {

Re: [gentoo-dev] [PATCH v2 4/5] vcs-snapshot.eclass: Detect and report invalid directory structure

2019-07-25 Thread Michał Górny
On Thu, 2019-07-25 at 09:37 +0200, Michał Górny wrote: > Detect when the archive does not contain a single top-level directory, > and abort in that case. Otherwise, --strip-components would result > in unpredictable mess. > > Signed-off-by: Michał Górny > --- > eclass/vcs-snapshot.eclass | 17

[gentoo-dev] [PATCH v2 3/5] vcs-snapshot.eclass: Add verbose einfo for unpacking

2019-07-25 Thread Michał Górny
Add an einfo call to make explicit notice of each archive being unpacked. Signed-off-by: Michał Górny --- eclass/vcs-snapshot.eclass | 1 + 1 file changed, 1 insertion(+) diff --git a/eclass/vcs-snapshot.eclass b/eclass/vcs-snapshot.eclass index 2e734c509d1a..312e9a4611e1 100644 ---

[gentoo-dev] [PATCH v2 5/5] vcs-snapshot.eclass: Detect unnecessary usage and complain

2019-07-25 Thread Michał Górny
Signed-off-by: Michał Górny --- eclass/vcs-snapshot.eclass | 12 1 file changed, 12 insertions(+) diff --git a/eclass/vcs-snapshot.eclass b/eclass/vcs-snapshot.eclass index 33abd9a7c190..dad586c9e40b 100644 --- a/eclass/vcs-snapshot.eclass +++ b/eclass/vcs-snapshot.eclass @@ -1,100

[gentoo-dev] [PATCH v2 4/5] vcs-snapshot.eclass: Detect and report invalid directory structure

2019-07-25 Thread Michał Górny
Detect when the archive does not contain a single top-level directory, and abort in that case. Otherwise, --strip-components would result in unpredictable mess. Signed-off-by: Michał Górny --- eclass/vcs-snapshot.eclass | 17 +++-- 1 file changed, 15 insertions(+), 2 deletions(-)

[gentoo-dev] [PATCH v2 2/5] vcs-snapshot.eclass: Update 'unusage' warning

2019-07-25 Thread Michał Górny
Nowadays both GitHub and GitLab snapshot do not need this eclass, so make it clear it's needed only for BitBucket. Also make the warning uppercase because people still don't read it. Signed-off-by: Michał Górny --- eclass/vcs-snapshot.eclass | 33 ++--- 1 file

[gentoo-dev] [PATCH v2 1/5] vcs-snapshot.eclass: Allow EAPI 7

2019-07-25 Thread Michał Górny
Signed-off-by: Michał Górny --- eclass/vcs-snapshot.eclass | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/eclass/vcs-snapshot.eclass b/eclass/vcs-snapshot.eclass index 316a37773d43..321e307b894d 100644 --- a/eclass/vcs-snapshot.eclass +++ b/eclass/vcs-snapshot.eclass

Re: [gentoo-dev] [PATCH 4/5] vcs-snapshot.eclass: Detect and report invalid directory structure

2019-07-25 Thread Michał Górny
On Thu, 2019-07-25 at 09:15 +0200, Ulrich Mueller wrote: > > > > > > On Thu, 25 Jul 2019, Michał Górny wrote: > > + readarray -t topdirs \ > > Not legal in EAPIs 0 to 5 which use bash-3.2. > I knew there was a reason I was doing it manually in all these eclasses! --

Re: [gentoo-dev] [PATCH 4/5] vcs-snapshot.eclass: Detect and report invalid directory structure

2019-07-25 Thread Ulrich Mueller
> On Thu, 25 Jul 2019, Ulrich Mueller wrote: >> +readarray -t topdirs \ > Not legal in EAPIs 0 to 5 which use bash-3.2. In fact, not legal in EAPIs 6 and 7 either, because the -t option doesn't exist in bash-4.2. signature.asc Description: PGP signature

Re: [gentoo-dev] [PATCH 4/5] vcs-snapshot.eclass: Detect and report invalid directory structure

2019-07-25 Thread Ulrich Mueller
> On Thu, 25 Jul 2019, Michał Górny wrote: > + readarray -t topdirs \ Not legal in EAPIs 0 to 5 which use bash-3.2. Ulrich signature.asc Description: PGP signature

[gentoo-dev] [PATCH 1/3] ruby-fakegem.eclass: enable EAPI 7

2019-07-25 Thread Hans de Graaff
Signed-off-by: Hans de Graaff --- eclass/ruby-fakegem.eclass | 11 +-- 1 file changed, 9 insertions(+), 2 deletions(-) diff --git a/eclass/ruby-fakegem.eclass b/eclass/ruby-fakegem.eclass index 1e8620c166d4..ab7b36eb7ae7 100644 --- a/eclass/ruby-fakegem.eclass +++

[gentoo-dev] [PATCH 2/3] ruby-fakegem.eclass: change default DOC recipe to use rdoc

2019-07-25 Thread Hans de Graaff
The previous default was "rake" but this turned out to be a poor choice because many packages do not implement "rake doc" and even if they do there are usually many local development environment assumption attached to that task. Using a consistent "rdoc" call that is handled by the eclass gets

[gentoo-dev] [PATCH 3/3] ruby-fakegem.eclass: warn about using the fallback gemspec

2019-07-25 Thread Hans de Graaff
The fallback gemspec does not contain dependencies so it will only work for packages without any runtime gem dependencies. It is easy to use it by mistake when switching from a gem to a source-based archive, because the source-based archive does not contain the generated metadata, but

[gentoo-dev] [PATCH 4/5] vcs-snapshot.eclass: Detect and report invalid directory structure

2019-07-25 Thread Michał Górny
Detect when the archive does not contain a single top-level directory, and abort in that case. Otherwise, --strip-components would result in unpredictable mess. Signed-off-by: Michał Górny --- eclass/vcs-snapshot.eclass | 16 ++-- 1 file changed, 14 insertions(+), 2 deletions(-)

[gentoo-dev] [PATCH 5/5] vcs-snapshot.eclass: Detect unnecessary usage and complain

2019-07-25 Thread Michał Górny
Signed-off-by: Michał Górny --- eclass/vcs-snapshot.eclass | 12 1 file changed, 12 insertions(+) diff --git a/eclass/vcs-snapshot.eclass b/eclass/vcs-snapshot.eclass index dbca6fd586d2..c01cf01f052c 100644 --- a/eclass/vcs-snapshot.eclass +++ b/eclass/vcs-snapshot.eclass @@ -58,6

[gentoo-dev] [PATCH 3/5] vcs-snapshot.eclass: Add verbose einfo for unpacking

2019-07-25 Thread Michał Górny
Add an einfo call to make explicit notice of each archive being unpacked. Signed-off-by: Michał Górny --- eclass/vcs-snapshot.eclass | 1 + 1 file changed, 1 insertion(+) diff --git a/eclass/vcs-snapshot.eclass b/eclass/vcs-snapshot.eclass index 2e734c509d1a..312e9a4611e1 100644 ---

[gentoo-dev] [PATCH 1/5] vcs-snapshot.eclass: Allow EAPI 7

2019-07-25 Thread Michał Górny
Signed-off-by: Michał Górny --- eclass/vcs-snapshot.eclass | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/eclass/vcs-snapshot.eclass b/eclass/vcs-snapshot.eclass index 316a37773d43..321e307b894d 100644 --- a/eclass/vcs-snapshot.eclass +++ b/eclass/vcs-snapshot.eclass

[gentoo-dev] [PATCH 2/5] vcs-snapshot.eclass: Update 'unusage' warning

2019-07-25 Thread Michał Górny
Nowadays both GitHub and GitLab snapshot do not need this eclass, so make it clear it's needed only for BitBucket. Also make the warning uppercase because people still don't read it. Signed-off-by: Michał Górny --- eclass/vcs-snapshot.eclass | 33 ++--- 1 file