Re: [gentoo-dev] Update your IRC handle in LDAP
On Sat, May 29, 2021 at 10:09:46AM +0200, Michał Górny wrote:
> On Sat, 2021-05-29 at 10:05 +0200, Ulrich Mueller wrote:
> > Please don't forget to update your IRC handle in LDAP. For example, if
> > you have moved from Freenode to Libera.Chat:
> >
> > $ perl_ldap -b user -E gentooIM irc://irc.freenode.net/
> > ${USER}
> > $ perl_ldap -b user -C gentooIM ircs://irc.libera.chat/
> > ${USER}
> >
>
> It would be also nice if you took this as an opportunity to grow up
> and start using your developer nickname instead of switching through
> silly nicknames all the time, so that people can actually find you.
I wouldn't say it this way, but yes, I agree that we should all use our
developer nics on irc.
Thanks,
William
signature.asc
Description: PGP signature
Re: [gentoo-dev] [PATCH] Create default implementation of pkg_pretend, move CONFIG_CHECK
On 5/30/21 2:55 PM, Ionen Wolkens wrote:
> On Sun, May 30, 2021 at 02:42:01PM -0400, Mike wrote:
>>
>>
>> On 5/30/21 2:28 PM, Ionen Wolkens wrote:
>>> On Sun, May 30, 2021 at 01:29:12PM -0400, mpag...@gentoo.org wrote:
From: Mike Pagano
As the purpose of pkg_pretend is to run sanity checks during
dependency calculation time, provide the default implementation
and perform CONFIG_CHECK within it.
See bug #759238
>>> [...]
+# @FUNCTION: linux-mod_pkg_pretend
+# @DESCRIPTION:
+# Check the CONFIG_CHECK options
+linux-mod_pkg_pretend() {
+
+ debug-print-function ${FUNCNAME} $*
+ # External modules use kernel symbols (bug #591832, #759238)
+ CONFIG_CHECK+=" !TRIM_UNUSED_KSYMS"
+}
>>>
>>> Is this not supposed to actually run the checks? Correct me if I'm
>>> missing something but it's just setting the value. linux-mod normally
>>> run the checks through linux-info_pkg_setup and its check_extra_config.
>>
>> Thanks for the analysis, Ionen.
>> The eclass does not actually run the check as it exists today.
>> Maybe there was a reason for that when it was originally coded?
>
> It does indirectly:
> # External modules use kernel symbols (bug #591832)
> CONFIG_CHECK+=" !TRIM_UNUSED_KSYMS"
>
> linux-info_pkg_setup;
> ^ checks ran here
>
> Older nvidia-drivers ebuild was kind of nasty with that, it did its
> own checks then the linux-mod.eclass' linux-info call did as well
> (duplicate messages), which I now let linux-mod handle.
>
>>
>>
>>> For nvidia-drivers, this value will also be lost for the pkg_setup test
>>> (needed to check, say.. gentoo-kernel emerged in-between) because I
>>> currently set a local CONFIG_CHECK="..." inside pkg_setup()
>>> (there's also a conditional CONFIG_CHECK, part of why not global)
>>>
>>> Some other ebuilds set CONFIG_CHECK in pkg_setup I believe.
>>
>> Maybe virtualbox-modules should do it's own CONFIG_CHECK as nvidia-drivers
>> does.
>> As that package is the impetus of this patch.
>>
>>> Not that I can't change this for nvidia, I guess I could set a global
>>> scope CONFIG_CHECK with !FATAL-only and += the non-fatal ones in
>>> pkg_setup to avoid message duplication.
>>>
>>> Have same concerns as mgorny wrt exported pkg_pretend, plus I'd also
>>> need to add my own pkg_pretend wrapper to check MODULES_OPTIONAL_USE
>>>
>>
>
Going to rescind this patch from consideration.
Mike
Re: [gentoo-dev] [PATCH] Create default implementation of pkg_pretend, move CONFIG_CHECK
On Sun, May 30, 2021 at 02:42:01PM -0400, Mike wrote:
>
>
> On 5/30/21 2:28 PM, Ionen Wolkens wrote:
> > On Sun, May 30, 2021 at 01:29:12PM -0400, mpag...@gentoo.org wrote:
> >> From: Mike Pagano
> >>
> >> As the purpose of pkg_pretend is to run sanity checks during
> >> dependency calculation time, provide the default implementation
> >> and perform CONFIG_CHECK within it.
> >>
> >> See bug #759238
> >>
> > [...]
> >>
> >> +# @FUNCTION: linux-mod_pkg_pretend
> >> +# @DESCRIPTION:
> >> +# Check the CONFIG_CHECK options
> >> +linux-mod_pkg_pretend() {
> >> +
> >> + debug-print-function ${FUNCNAME} $*
> >> + # External modules use kernel symbols (bug #591832, #759238)
> >> + CONFIG_CHECK+=" !TRIM_UNUSED_KSYMS"
> >> +}
> >
> > Is this not supposed to actually run the checks? Correct me if I'm
> > missing something but it's just setting the value. linux-mod normally
> > run the checks through linux-info_pkg_setup and its check_extra_config.
>
> Thanks for the analysis, Ionen.
> The eclass does not actually run the check as it exists today.
> Maybe there was a reason for that when it was originally coded?
It does indirectly:
# External modules use kernel symbols (bug #591832)
CONFIG_CHECK+=" !TRIM_UNUSED_KSYMS"
linux-info_pkg_setup;
^ checks ran here
Older nvidia-drivers ebuild was kind of nasty with that, it did its
own checks then the linux-mod.eclass' linux-info call did as well
(duplicate messages), which I now let linux-mod handle.
>
>
> > For nvidia-drivers, this value will also be lost for the pkg_setup test
> > (needed to check, say.. gentoo-kernel emerged in-between) because I
> > currently set a local CONFIG_CHECK="..." inside pkg_setup()
> > (there's also a conditional CONFIG_CHECK, part of why not global)
> >
> > Some other ebuilds set CONFIG_CHECK in pkg_setup I believe.
>
> Maybe virtualbox-modules should do it's own CONFIG_CHECK as nvidia-drivers
> does.
> As that package is the impetus of this patch.
>
> > Not that I can't change this for nvidia, I guess I could set a global
> > scope CONFIG_CHECK with !FATAL-only and += the non-fatal ones in
> > pkg_setup to avoid message duplication.
> >
> > Have same concerns as mgorny wrt exported pkg_pretend, plus I'd also
> > need to add my own pkg_pretend wrapper to check MODULES_OPTIONAL_USE
> >
>
--
ionen
signature.asc
Description: PGP signature
Re: [gentoo-dev] [PATCH] Create default implementation of pkg_pretend, move CONFIG_CHECK
On 5/30/21 2:28 PM, Ionen Wolkens wrote:
> On Sun, May 30, 2021 at 01:29:12PM -0400, mpag...@gentoo.org wrote:
>> From: Mike Pagano
>>
>> As the purpose of pkg_pretend is to run sanity checks during
>> dependency calculation time, provide the default implementation
>> and perform CONFIG_CHECK within it.
>>
>> See bug #759238
>>
> [...]
>>
>> +# @FUNCTION: linux-mod_pkg_pretend
>> +# @DESCRIPTION:
>> +# Check the CONFIG_CHECK options
>> +linux-mod_pkg_pretend() {
>> +
>> +debug-print-function ${FUNCNAME} $*
>> +# External modules use kernel symbols (bug #591832, #759238)
>> +CONFIG_CHECK+=" !TRIM_UNUSED_KSYMS"
>> +}
>
> Is this not supposed to actually run the checks? Correct me if I'm
> missing something but it's just setting the value. linux-mod normally
> run the checks through linux-info_pkg_setup and its check_extra_config.
Thanks for the analysis, Ionen.
The eclass does not actually run the check as it exists today.
Maybe there was a reason for that when it was originally coded?
> For nvidia-drivers, this value will also be lost for the pkg_setup test
> (needed to check, say.. gentoo-kernel emerged in-between) because I
> currently set a local CONFIG_CHECK="..." inside pkg_setup()
> (there's also a conditional CONFIG_CHECK, part of why not global)
>
> Some other ebuilds set CONFIG_CHECK in pkg_setup I believe.
Maybe virtualbox-modules should do it's own CONFIG_CHECK as nvidia-drivers does.
As that package is the impetus of this patch.
> Not that I can't change this for nvidia, I guess I could set a global
> scope CONFIG_CHECK with !FATAL-only and += the non-fatal ones in
> pkg_setup to avoid message duplication.
>
> Have same concerns as mgorny wrt exported pkg_pretend, plus I'd also
> need to add my own pkg_pretend wrapper to check MODULES_OPTIONAL_USE
>
--
Mike Pagano
Gentoo Developer - Kernel Project
Gentoo Sources - Lead
E-Mail : mpag...@gentoo.org
GnuPG FP : 52CC A0B0 F631 0B17 0142 F83F 92A6 DBEC 81F2 B137
Public Key :
http://http://pgp.mit.edu/pks/lookup?search=0x92A6DBEC81F2B137&op=index
Re: [gentoo-dev] [PATCH] Create default implementation of pkg_pretend, move CONFIG_CHECK
On Sun, May 30, 2021 at 01:29:12PM -0400, mpag...@gentoo.org wrote:
> From: Mike Pagano
>
> As the purpose of pkg_pretend is to run sanity checks during
> dependency calculation time, provide the default implementation
> and perform CONFIG_CHECK within it.
>
> See bug #759238
>
[...]
>
> +# @FUNCTION: linux-mod_pkg_pretend
> +# @DESCRIPTION:
> +# Check the CONFIG_CHECK options
> +linux-mod_pkg_pretend() {
> +
> + debug-print-function ${FUNCNAME} $*
> + # External modules use kernel symbols (bug #591832, #759238)
> + CONFIG_CHECK+=" !TRIM_UNUSED_KSYMS"
> +}
Is this not supposed to actually run the checks? Correct me if I'm
missing something but it's just setting the value. linux-mod normally
run the checks through linux-info_pkg_setup and its check_extra_config.
For nvidia-drivers, this value will also be lost for the pkg_setup test
(needed to check, say.. gentoo-kernel emerged in-between) because I
currently set a local CONFIG_CHECK="..." inside pkg_setup()
(there's also a conditional CONFIG_CHECK, part of why not global)
Some other ebuilds set CONFIG_CHECK in pkg_setup I believe.
Not that I can't change this for nvidia, I guess I could set a global
scope CONFIG_CHECK with !FATAL-only and += the non-fatal ones in
pkg_setup to avoid message duplication.
Have same concerns as mgorny wrt exported pkg_pretend, plus I'd also
need to add my own pkg_pretend wrapper to check MODULES_OPTIONAL_USE
--
ionen
signature.asc
Description: PGP signature
Re: [gentoo-dev] [PATCH] Create default implementation of pkg_pretend, move CONFIG_CHECK
On Sun, 2021-05-30 at 13:29 -0400, mpag...@gentoo.org wrote: > From: Mike Pagano > > As the purpose of pkg_pretend is to run sanity checks during > dependency calculation time, provide the default implementation > and perform CONFIG_CHECK within it. > > See bug #759238 > > Signed-off-by: Mike Pagano > --- > eclass/linux-mod.eclass | 17 - > 1 file changed, 12 insertions(+), 5 deletions(-) > > diff --git a/eclass/linux-mod.eclass b/eclass/linux-mod.eclass > index 11b0fd0cf..42e541ed1 100644 > --- a/eclass/linux-mod.eclass > +++ b/eclass/linux-mod.eclass > @@ -135,7 +135,7 @@ > # It's a read-only variable. It contains the extension of the kernel modules. > > inherit eutils linux-info multilib toolchain-funcs > -EXPORT_FUNCTIONS pkg_setup pkg_preinst pkg_postinst src_install src_compile > pkg_postrm > +EXPORT_FUNCTIONS pkg_setup pkg_preinst pkg_pretend pkg_postinst src_install > src_compile pkg_postrm > Have you verified that this doesn't override pkg_pretend in any of the eclasses used by the existing consumers? -- Best regards, Michał Górny
[gentoo-dev] [PATCH] Create default implementation of pkg_pretend, move CONFIG_CHECK
From: Mike Pagano
As the purpose of pkg_pretend is to run sanity checks during
dependency calculation time, provide the default implementation
and perform CONFIG_CHECK within it.
See bug #759238
Signed-off-by: Mike Pagano
---
eclass/linux-mod.eclass | 17 -
1 file changed, 12 insertions(+), 5 deletions(-)
diff --git a/eclass/linux-mod.eclass b/eclass/linux-mod.eclass
index 11b0fd0cf..42e541ed1 100644
--- a/eclass/linux-mod.eclass
+++ b/eclass/linux-mod.eclass
@@ -135,7 +135,7 @@
# It's a read-only variable. It contains the extension of the kernel modules.
inherit eutils linux-info multilib toolchain-funcs
-EXPORT_FUNCTIONS pkg_setup pkg_preinst pkg_postinst src_install src_compile
pkg_postrm
+EXPORT_FUNCTIONS pkg_setup pkg_preinst pkg_pretend pkg_postinst src_install
src_compile pkg_postrm
case ${MODULES_OPTIONAL_USE_IUSE_DEFAULT:-n} in
[nNfF]*|[oO][fF]*|0|-) _modules_optional_use_iuse_default='' ;;
@@ -157,7 +157,7 @@ RDEPEND="
)
${MODULES_OPTIONAL_USE:+)}"
DEPEND="${RDEPEND}
-${MODULES_OPTIONAL_USE}${MODULES_OPTIONAL_USE:+? (}
+ ${MODULES_OPTIONAL_USE}${MODULES_OPTIONAL_USE:+? (}
sys-apps/sed
kernel_linux? ( virtual/linux-sources virtual/libelf )
${MODULES_OPTIONAL_USE:+)}"
@@ -567,6 +567,16 @@ find_module_params() {
# default ebuild functions
#
+# @FUNCTION: linux-mod_pkg_pretend
+# @DESCRIPTION:
+# Check the CONFIG_CHECK options
+linux-mod_pkg_pretend() {
+
+ debug-print-function ${FUNCNAME} $*
+ # External modules use kernel symbols (bug #591832, #759238)
+ CONFIG_CHECK+=" !TRIM_UNUSED_KSYMS"
+}
+
# @FUNCTION: linux-mod_pkg_setup
# @DESCRIPTION:
# It checks the CONFIG_CHECK options (see linux-info.eclass(5)), verifies that
the kernel is
@@ -589,9 +599,6 @@ linux-mod_pkg_setup() {
return
fi
- # External modules use kernel symbols (bug #591832)
- CONFIG_CHECK+=" !TRIM_UNUSED_KSYMS"
-
linux-info_pkg_setup;
require_configured_kernel
check_kernel_built;
--
2.31.1
