Re: [gentoo-dev] Common options missed in OpenRC declarative scripts and how to improve them
On 2021-12-02 08:12:55, Alec Warner wrote: > > Can we automate any of it? Emit QA warnings? etc. > I would love to be proven wrong, but I don't think so. We have two main problems. First, The service scripts are POSIX sh, which is better than bash, but still can't easily be parsed for semantic information. Second, if the daemon is "special," then the service script is justified in being similarly unconventional. Unusual runtime behavior can't be statically detected, and I doubt that the well-behaved portion of daemons in the tree is large enough that we can warn about every script that smells a little bit fishy.
Re: [gentoo-dev] Common options missed in OpenRC declarative scripts and how to improve them
On 12/2/2021 7:34 AM, Michael Orlitzky wrote: On 2021-12-01 21:02:20, Brian Evans wrote: After a cursory scan of the Gentoo repository, I've noticed an overabundance of start_stop_daemon_args being declared in scripts committed. I would like to draw attention and see if we can clean these up together. A lot of this is covered in the service script guide: https://github.com/OpenRC/openrc/blob/master/service-script-guide.md There's a 2.5-year old bug to mention it in the devmanual: https://bugs.gentoo.org/684354 For sure, there are several points that document covers that are reiterated here. However some variable options are not covered there. They do exist in the openrc-run manual. My main point is how to best use these options and that some scripts are not taking full advantage. Brian OpenPGP_signature Description: OpenPGP digital signature
Re: [gentoo-dev] Common options missed in OpenRC declarative scripts and how to improve them
On Thu, Dec 2, 2021 at 4:34 AM Michael Orlitzky wrote: > > On 2021-12-01 21:02:20, Brian Evans wrote: > > After a cursory scan of the Gentoo repository, I've noticed an > > overabundance of start_stop_daemon_args being declared in scripts committed. > > > > I would like to draw attention and see if we can clean these up together. > > A lot of this is covered in the service script guide: > > https://github.com/OpenRC/openrc/blob/master/service-script-guide.md > > There's a 2.5-year old bug to mention it in the devmanual: > > https://bugs.gentoo.org/684354 > Can we automate any of it? Emit QA warnings? etc. -A
Re: [gentoo-dev] Common options missed in OpenRC declarative scripts and how to improve them
On 2021-12-01 21:02:20, Brian Evans wrote: > After a cursory scan of the Gentoo repository, I've noticed an > overabundance of start_stop_daemon_args being declared in scripts committed. > > I would like to draw attention and see if we can clean these up together. A lot of this is covered in the service script guide: https://github.com/OpenRC/openrc/blob/master/service-script-guide.md There's a 2.5-year old bug to mention it in the devmanual: https://bugs.gentoo.org/684354
