Re: [gentoo-dev] [PATCH] [committed] edo.eclass: update eclassdoc to clarify purpose
On 18.4.2022 20.59, Sam James wrote:
> Signed-off-by: Sam James
> ---
> eclass/edo.eclass | 7 +--
> 1 file changed, 5 insertions(+), 2 deletions(-)
>
> diff --git a/eclass/edo.eclass b/eclass/edo.eclass
> index 550d6770cb63..c2e7ed60083f 100644
> --- a/eclass/edo.eclass
> +++ b/eclass/edo.eclass
> @@ -10,9 +10,12 @@
> # @BLURB: Convenience function to run commands verbosely and die on failure
> # @DESCRIPTION:
> # This eclass provides the 'edo' command, and an 'edob' variant for
> ebegin/eend,
> -# which dies (exits) on failure and logs the command used verbosely.
> +# which logs the command used verbosely and dies (exits) on failure.
> #
> -
> +# This eclass should be used only where needed to give a more verbose log,
> e.g.
> +# for invoking non-standard ./configure scripts, or building objects/binaries
> +# directly within ebuilds via compiler invocations. It is NOT to be used
> +# in place of generic 'command || die' where verbosity is unnecessary.
> case ${EAPI} in
> 7|8) ;;
> *) die "${ECLASS}: EAPI ${EAPI:-0} not supported" ;;
Thanks for this clarification, had me wondering.
-- juippis
OpenPGP_signature
Description: OpenPGP digital signature
[gentoo-dev] [PATCH] [committed] edo.eclass: update eclassdoc to clarify purpose
Signed-off-by: Sam James
---
eclass/edo.eclass | 7 +--
1 file changed, 5 insertions(+), 2 deletions(-)
diff --git a/eclass/edo.eclass b/eclass/edo.eclass
index 550d6770cb63..c2e7ed60083f 100644
--- a/eclass/edo.eclass
+++ b/eclass/edo.eclass
@@ -10,9 +10,12 @@
# @BLURB: Convenience function to run commands verbosely and die on failure
# @DESCRIPTION:
# This eclass provides the 'edo' command, and an 'edob' variant for
ebegin/eend,
-# which dies (exits) on failure and logs the command used verbosely.
+# which logs the command used verbosely and dies (exits) on failure.
#
-
+# This eclass should be used only where needed to give a more verbose log, e.g.
+# for invoking non-standard ./configure scripts, or building objects/binaries
+# directly within ebuilds via compiler invocations. It is NOT to be used
+# in place of generic 'command || die' where verbosity is unnecessary.
case ${EAPI} in
7|8) ;;
*) die "${ECLASS}: EAPI ${EAPI:-0} not supported" ;;
--
2.35.1
Re: [gentoo-dev] [PATCH v4 0/1] Add edo.eclass
On Sun, 2022-04-17 at 18:34 +0100, Sam James wrote: > Changes since v3: > - EAPI check cleanup > - Fix long line in eclassdoc > > Changes since v2: > - Fix typo in eclass guard > - Rework description of edob > - Use 'einfo', not 'elog' > - Change die message for clarity > > Changes since v1: > - Add EAPI 7 support (useful for e.g. base-system@ ebuilds) > - Add 'edob' (edo with ebegin/eend for better logs log-running > commands, UX) > > Sam James (1): > edo.eclass: add new eclass > > eclass/edo.eclass | 45 + > 1 file changed, 45 insertions(+) > create mode 100644 eclass/edo.eclass > LGTM, let's get this in
[gentoo-dev] Last rites: unused java EAPI=6 libraries
# Volkmar W. Pogatzki (2022-04-17) # Unused java libraries. Removal in 30 days. dev-java/boot-bin dev-java/eclipsito dev-java/gcj-jdk dev-java/japitools dev-java/jboss-marshalling dev-java/jdbc-mssqlserver dev-java/jsr250 dev-java/maven-hawtjni-plugin dev-java/mimepull dev-java/oracle-javamail dev-java/xjavac - Flow
