Re: [gentoo-dev] proposal: use only one hash function in manifest files

2022-04-19 Thread Robin H. Johnson
On Wed, Apr 06, 2022 at 05:23:25PM +, Robin H. Johnson wrote:
> On Wed, Apr 06, 2022 at 02:15:02AM +0200, Jason A. Donenfeld wrote:
> > 2) Comparability: other distros use SHA2-512, as well as various
> > upstreams, which means we can compare our hashes to theirs easily.
> Can we expand on this specific thread for a moment?
> 
> I was the author of GLEP59 about changing the Manifest hashes, and I
> noted at the time, with references, that the effective strength of a set
> of hashes is only that of the strongest hash.
Bump for my parent message, that I'm very surprised at the lack of
responses to two messages in this thread.

https://archives.gentoo.org/gentoo-dev/message/18216da0128ee79733fa68bb77fa8b69
https://archives.gentoo.org/gentoo-dev/message/a9974ec34dfb25810dab47e3fa322a52

-- 
Robin Hugh Johnson
Gentoo Linux: Dev, Infra Lead, Foundation Treasurer
E-Mail   : robb...@gentoo.org
GnuPG FP : 11ACBA4F 4778E3F6 E4EDF38E B27B944E 34884E85
GnuPG FP : 7D0B3CEB E9B85B1F 825BCECF EE05E6F6 A48F6136



[gentoo-dev] Re: [PATCH 1/2] meson.eclass: disable PCH

2022-04-19 Thread Mike Gilbert
On Tue, Apr 19, 2022 at 2:21 PM Sam James  wrote:
>
> It's already masked and disabled in GCC and it causes a huge
> number of problems, but we need t odo this to avoid automagically
> trying to use PCH-even-once-it's-been-disabled-in-the-compiler.

ACK on both patches.



[gentoo-dev] [PATCH 2/2] meson.eclass: disable werror

2022-04-19 Thread Sam James
It's Gentoo policy to disable Werror where possible and this is
a builtin Meson option, so let's use it, to save needing to
add this all the time in ebuilds.

Closes: https://bugs.gentoo.org/754279
Signed-off-by: Sam James 
---
 eclass/meson.eclass | 4 
 1 file changed, 4 insertions(+)

diff --git a/eclass/meson.eclass b/eclass/meson.eclass
index 809cf10f8366..f2f7173f5a9a 100644
--- a/eclass/meson.eclass
+++ b/eclass/meson.eclass
@@ -329,6 +329,10 @@ meson_src_configure() {
# bug #839549), but in any case, we don't want to bother 
attempting
# this.
-Db_pch=false
+
+   # It's Gentoo policy to not have builds die on blanket -Werror, 
as it's
+   # an upstream development matter. bug #754279.
+   -Dwerror=false
)
 
if [[ -n ${EMESON_BUILDTYPE} ]]; then
-- 
2.35.1




[gentoo-dev] [PATCH 1/2] meson.eclass: disable PCH

2022-04-19 Thread Sam James
It's already masked and disabled in GCC and it causes a huge
number of problems, but we need t odo this to avoid automagically
trying to use PCH-even-once-it's-been-disabled-in-the-compiler.

Bug: https://bugs.gentoo.org/839549
Signed-off-by: Sam James 
---
 eclass/meson.eclass | 8 +++-
 1 file changed, 7 insertions(+), 1 deletion(-)

diff --git a/eclass/meson.eclass b/eclass/meson.eclass
index c094f4683913..809cf10f8366 100644
--- a/eclass/meson.eclass
+++ b/eclass/meson.eclass
@@ -1,4 +1,4 @@
-# Copyright 2017-2021 Gentoo Authors
+# Copyright 2017-2022 Gentoo Authors
 # Distributed under the terms of the GNU General Public License v2
 
 # @ECLASS: meson.eclass
@@ -323,6 +323,12 @@ meson_src_configure() {
--build.pkg-config-path 
"${BUILD_PKG_CONFIG_PATH}${BUILD_PKG_CONFIG_PATH:+:}${EPREFIX}/usr/share/pkgconfig"
--pkg-config-path 
"${PKG_CONFIG_PATH}${PKG_CONFIG_PATH:+:}${EPREFIX}/usr/share/pkgconfig"
--native-file "$(_meson_create_native_file)"
+
+   # gcc[pch] is masked in profiles due to consistent bugginess
+   # without forcing this off, some packages may fail too (like 
gjs,
+   # bug #839549), but in any case, we don't want to bother 
attempting
+   # this.
+   -Db_pch=false
)
 
if [[ -n ${EMESON_BUILDTYPE} ]]; then
-- 
2.35.1