[gentoo-portage-dev] [PATCH] find_smallest_cycle: don't merge satisfied PDEPEND too early

2020-12-02 Thread Zac Medico
5095c2023595a75e2848f1ad3dbe25b5fb451a44 because it gave PDEPEND higher priority than satisfied buildtime dependencies. Fixes: 5095c2023595 ("find_smallest_cycle: enhance search prioritization") Reported-by: josef64 in #gentoo-portage Bug: https://bugs.gentoo.org/754903 Signed-off-by: Zac Medico

[gentoo-portage-dev] Re: [PATCH] Updates for portage-3.0.11 release

2020-12-02 Thread Zac Medico
On 12/2/20 12:18 AM, Zac Medico wrote: > Signed-off-by: Zac Medico > --- > RELEASE-NOTES | 6 ++ > setup.py | 2 +- > 2 files changed, 7 insertions(+), 1 deletion(-) Please ignore. -- Thanks, Zac signature.asc Description: OpenPGP digital signature

[gentoo-portage-dev] [PATCH] Updates for portage-3.0.11 release

2020-12-02 Thread Zac Medico
Signed-off-by: Zac Medico --- RELEASE-NOTES | 6 ++ setup.py | 2 +- 2 files changed, 7 insertions(+), 1 deletion(-) diff --git a/RELEASE-NOTES b/RELEASE-NOTES index 61c3c3d16..7fff83017 100644 --- a/RELEASE-NOTES +++ b/RELEASE-NOTES @@ -1,6 +1,12 @@ Release Notes; upgrade information

[gentoo-portage-dev] [PATCH] Allow a package to replace its own buildtime dependency

2020-11-28 Thread Zac Medico
/756961 Signed-off-by: Zac Medico --- lib/_emerge/depgraph.py | 68 ++ lib/portage/dep/dep_check.py | 24 --- .../resolver/test_circular_choices_rust.py| 69 +++ 3 files changed, 139 insertions(+), 22 deletions

[gentoo-portage-dev] [PATCH] backtracking: fix virtual choices for circular deps (bug 757306)

2020-11-27 Thread Zac Medico
Fix virtual choices to be consistent with circular dependency backtracking choices. Fixes: f78a91e44e3e ("backtracking: adjust || preference to break dependency cycles") Bug: https://bugs.gentoo.org/757306 Signed-off-by: Zac Medico --- lib/portage/dep/dep_check.py | 7 +-- 1 fi

[gentoo-portage-dev] [PATCH v2] find_smallest_cycle: enhance search prioritization

2020-11-21 Thread Zac Medico
in a somewhat random location, even though that cycle may be composed of smaller independent cycles which would be safer to break individually. Bug: https://bugs.gentoo.org/754903 Signed-off-by: Zac Medico --- [PATCH v2] * Add a unit test case which demonstrates a significant flaw in the master branch

[gentoo-portage-dev] [PATCH] find_smallest_cycle: enhance search prioritization

2020-11-19 Thread Zac Medico
to build against latest versions of buildtime dependencies whenever possible. This should solve some cases of bug 199856 which have been triggered by unsafe reliance on installed packages to break cycles. Bug: https://bugs.gentoo.org/754903 Signed-off-by: Zac Medico --- lib/_emerge

[gentoo-portage-dev] [PATCH] emerge: Disable profile deprecation warning inheritance (bug 753497)

2020-11-08 Thread Zac Medico
the current profile node belongs to the same repo as the previous profile node. Bug: https://bugs.gentoo.org/753497 Signed-off-by: Zac Medico --- .../ebuild/_config/LocationsManager.py| 30 ++- .../ebuild/deprecated_profile_check.py| 9 +++--- 2 files changed, 27

[gentoo-portage-dev] [PATCH] make.conf: expand special *ROOT variables (bug 752147)

2020-11-01 Thread Zac Medico
Bug: https://bugs.gentoo.org/752147 Signed-off-by: Zac Medico --- lib/portage/package/ebuild/config.py | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/lib/portage/package/ebuild/config.py b/lib/portage/package/ebuild/config.py index a09fdbced..3be8f9f6d 100644

[gentoo-portage-dev] [PATCH] emerge: add --quickpkg-direct-root option

2020-11-01 Thread Zac Medico
Specify the root to use as the --quickpkg-direct package source. This root is assumed to be immutable during the entire emerge operation. The default is set to "/". Bug: https://bugs.gentoo.org/752066 Signed-off-by: Zac Medico --- lib/_emerge/actions.py

[gentoo-portage-dev] [PATCH] pid-sandbox: Forward SIGTSTP and SIGCONT (bug 704498)

2020-10-28 Thread Zac Medico
For correct operation of Ctrl+Z, forward SIGTSTP and SIGCONT to all sandboxed pids. Fixes: 37e4dc5ae842 ("pid-sandbox: pid-ns-init setsid support (bug 675870)") Bug: https://bugs.gentoo.org/704498 Signed-off-by: Zac Medico --- bin/pid-ns-init | 24 +++- 1 file c

[gentoo-portage-dev] [PATCH v2] emerge: enable parallel-fetch during pkg_pretend (bug 710432)

2020-09-20 Thread Zac Medico
pkg_pretend phases now run inside of the --keep-going retry loop, --keep-going is now able to recover from pkg_pretend failures, which fixes bug 404157. Bug: https://bugs.gentoo.org/404157 Bug: https://bugs.gentoo.org/710432 Signed-off-by: Zac Medico --- [PATCH v2] records failed packages for correct

[gentoo-portage-dev] [PATCH] emerge: enable parallel-fetch during pkg_pretend (bug 710432)

2020-09-19 Thread Zac Medico
://bugs.gentoo.org/710432 Signed-off-by: Zac Medico --- lib/_emerge/Scheduler.py | 94 +--- 1 file changed, 58 insertions(+), 36 deletions(-) diff --git a/lib/_emerge/Scheduler.py b/lib/_emerge/Scheduler.py index a69421288..20884986f 100644 --- a/lib/_emerge

[gentoo-portage-dev] [PATCH] _slot_confict_backtrack: group similar missed updates (bug 743115)

2020-09-19 Thread Zac Medico
, where the difference of 3 corresponds to the number of other similar setuptools updates available. Bug: https://bugs.gentoo.org/743115 Signed-off-by: Zac Medico --- lib/_emerge/depgraph.py | 25 --- lib/_emerge/resolver/backtracking.py | 7

[gentoo-portage-dev] Re: [PATCH] _slot_confict_backtrack: minimize conflict atoms (bug 743631)

2020-09-19 Thread Zac Medico
On 9/19/20 2:40 PM, Zac Medico wrote: > diff --git a/lib/_emerge/depgraph.py b/lib/_emerge/depgraph.py > index 3f864aefc..40e7d1325 100644 > --- a/lib/_emerge/depgraph.py > +++ b/lib/_emerge/depgraph.py > @@ -1797,6 +1797,12 @@ class depgraph: >

[gentoo-portage-dev] [PATCH] _slot_confict_backtrack: minimize conflict atoms (bug 743631)

2020-09-19 Thread Zac Medico
Prefer choices that minimize conflict atoms, so that choices which satisfy all parents are preferred. This reduces the minimum necessary backtrack tries from 21 to 7 for the unit test related to bug 743115. Bug: https://bugs.gentoo.org/743115 Bug: https://bugs.gentoo.org/743631 Signed-off-by: Zac

[gentoo-portage-dev] [PATCH] egencache: add --external-cache-only option (bug 741474)

2020-09-12 Thread Zac Medico
cache or index files are already capable of consuming files from the external cache directory (/var/cache/edb/dep). Bug: https://bugs.gentoo.org/737470 Signed-off-by: Zac Medico --- bin/egencache | 44 ++--- cnf/repo.postsync.d/example | 19

[gentoo-portage-dev] [PATCH] get_mirror_url: urlquote only for ftp, http, and https (bug 741474)

2020-09-12 Thread Zac Medico
literally, so urlquote must not be used. Fixes: c238d5f7ed264179c263f5a2da983c4ee50b4f00 Bug: https://bugs.gentoo.org/719810 Bug: https://bugs.gentoo.org/741474 Signed-off-by: Zac Medico --- lib/portage/package/ebuild/fetch.py | 8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff

[gentoo-portage-dev] [PATCH] selinux: encode os path arguments as UTF-8 (bug 741194)

2020-09-08 Thread Zac Medico
Encode path arguments as UTF-8, like portage.os wrapper. Fixes: 6137290b2bb8 ("selinux: python3 unicode paths, bug #430488") Bug: https://bugs.gentoo.org/741194 Signed-off-by: Zac Medico --- lib/portage/_selinux.py | 16 1 file changed, 8 insertions(+), 8 deletion

Re: [gentoo-portage-dev] [PATCH v5] env-update: create systemd user-session environment definition

2020-09-07 Thread Zac Medico
env-update so that a systemd user session > environment configuration file named > > /etc/environment.d/10-gentoo-env.conf > > is created. > > Thanks to Michael 'veremitz' Everitt, Arfrever Frehtes Taifersar > Arahesis, Ulrich Müller, Joakim Tjernlund, and Zac Medico for t

[gentoo-portage-dev] Re: [PATCH 0/2] Add binrepos.conf to support fetchcommand customization (bug 661332)

2020-09-07 Thread Zac Medico
On 9/6/20 11:31 PM, Zac Medico wrote: > Support /etc/portage/binrepos.conf as a replacement for the > PORTAGE_BINHOST variable. Behavior is similar to repos.conf, > initially supporting just the sync-uri attribute. Both binrepos.conf > and PORTAGE_BINHOST can be used simultaneously,

[gentoo-portage-dev] [PATCH 1/2] Add binrepos.conf to replace PORTAGE_BINHOST (bug 668334)

2020-09-07 Thread Zac Medico
be used simultaneously. The emerge --info output for binrepos.conf looks like this: Binary Repositories: example-binhost sync-uri: https://example.com/packages Bug: https://bugs.gentoo.org/668334 Signed-off-by: Zac Medico --- lib/_emerge/actions.py | 13 ++- lib/portage

[gentoo-portage-dev] [PATCH 2/2] binrepos.conf: support fetchcommand customization (bug 661332)

2020-09-07 Thread Zac Medico
Support customization of fetchcommand and resumecommand in binrepos.conf, allowing customized authentication mechanisms for each repository. Bug: https://bugs.gentoo.org/661332 Signed-off-by: Zac Medico --- lib/_emerge/BinpkgFetcher.py | 29 +++-- lib/portage/binrepo

[gentoo-portage-dev] [PATCH 0/2] Add binrepos.conf to support fetchcommand customization (bug 661332)

2020-09-07 Thread Zac Medico
repository. Zac Medico (2): Add binrepos.conf to replace PORTAGE_BINHOST (bug 668334) binrepos.conf: support fetchcommand customization (bug 661332) lib/_emerge/BinpkgFetcher.py| 29 -- lib/_emerge/actions.py | 13 ++- lib/portage/binrepo/__init__.py

[gentoo-portage-dev] [PATCH] make.conf: Treat __* variables as local and do not propagate them.

2020-09-05 Thread Zac Medico
From: Arfrever Frehtes Taifersar Arahesis Bug: https://bugs.gentoo.org/740588 Signed-off-by: Arfrever Frehtes Taifersar Arahesis Signed-off-by: Zac Medico --- lib/portage/package/ebuild/config.py | 6 ++ man/make.conf.5 | 4 +++- 2 files changed, 9 insertions(+), 1

Re: [gentoo-portage-dev] Re: [PATCH v4] env-update: create systemd env configuration if required

2020-09-04 Thread Zac Medico
On 9/4/20 8:39 AM, Florian Schmaus wrote: > On 9/3/20 7:57 PM, Florian Schmaus wrote: >> +systemd_profile_env_path = os.path.join(systemd_environment_dir, >> + "10-gentoo-profile-env.conf") >> +with open(systemd_profile_env_path, "w") as

Re: [gentoo-portage-dev] [PATCH v2] emerge --search: auto-detect regular expressions (bug 737480)

2020-09-02 Thread Zac Medico
On 9/1/20 11:08 PM, Michał Górny wrote: > On Tue, 2020-09-01 at 19:59 -0700, Zac Medico wrote: >> Automatically detect regular expressions when the search string >> contains any of these regular expression characters or character >> sequences: >> >> ^ $ * [ ]

Re: [gentoo-portage-dev] [PATCH v2] emerge --search: auto-detect regular expressions (bug 737480)

2020-09-02 Thread Zac Medico
On 9/1/20 11:08 PM, Michał Górny wrote: > On Tue, 2020-09-01 at 19:59 -0700, Zac Medico wrote: >> Automatically detect regular expressions when the search string >> contains any of these regular expression characters or character >> sequences: >> >> ^ $ * [ ]

[gentoo-portage-dev] [PATCH v2] emerge --search: auto-detect regular expressions (bug 737480)

2020-09-01 Thread Zac Medico
characters. Bug: https://bugs.gentoo.org/737480 Signed-off-by: Zac Medico --- [PATCH v2] Recognize .+ as suggested by Arfrever. lib/_emerge/actions.py | 1 + lib/_emerge/main.py| 6 ++ lib/_emerge/search.py | 12 +++- man/emerge.1 | 12 +++- 4 files changed, 29

[gentoo-portage-dev] [PATCH] egencache --update-pkg-desc-index: emulate esync --verbose output (bug 737470)

2020-09-01 Thread Zac Medico
browser [MU] www-client/opera-developer (72.0.3798.0): A fast and secure web browser [ U] x11-libs/gtksourceview (4.6.1-r1): A text widget implementing syntax highlighting and other features Bug: https://bugs.gentoo.org/737470 Signed-off-by: Zac Medico --- bin/egencache | 68

[gentoo-portage-dev] [PATCH] emerge --search: auto-detect regular expressions (bug 737480)

2020-08-31 Thread Zac Medico
://bugs.gentoo.org/737480 Signed-off-by: Zac Medico --- lib/_emerge/actions.py | 1 + lib/_emerge/main.py| 6 ++ lib/_emerge/search.py | 12 +++- man/emerge.1 | 11 ++- 4 files changed, 28 insertions(+), 2 deletions(-) diff --git a/lib/_emerge/actions.py b/lib/_emerge

[gentoo-portage-dev] [PATCH] dephgraph: Allow elimination of highest version after slot conflict (bug 439688)

2020-08-30 Thread Zac Medico
update to trigger rebuilds, therefore fix it to do so. Bug: https://bugs.gentoo.org/439688 Signed-off-by: Zac Medico --- lib/_emerge/depgraph.py | 9 - .../tests/resolver/test_slot_change_without_revbump.py | 4 ++-- lib/portage/tests/resolver

[gentoo-portage-dev] [PATCH] Use cached portage.getpid() function (bug 739540)

2020-08-29 Thread Zac Medico
Use the cached portage.getpid() function to avoid unnecessary syscalls, and update the cache after each call to os.fork() where the fork may invoke portage APIs. Bug: https://bugs.gentoo.org/739540 Signed-off-by: Zac Medico --- bin/quickpkg | 2 +- lib

[gentoo-portage-dev] Re: [PATCH 0/2] emerge: Add short -l option for --load-average (bug 699256)

2020-08-16 Thread Zac Medico
On 8/15/20 12:26 PM, Zac Medico wrote: > Add a short -l option for --load-average just like make(1) has. > > Bug: https://bugs.gentoo.org/699256 > Signed-off-by: Zac Medico > > Zac Medico (2): > emerge: Remove deprecated --changelog option (bug 699256) > eme

[gentoo-portage-dev] [PATCH] repoman: Add --jobs and --load-average options (bug 448462)

2020-08-16 Thread Zac Medico
). For the -j1 case (default), all dependency checks run in the main process as usual, so there is no significant performance penalty for the default case. Bug: https://bugs.gentoo.org/448462 Signed-off-by: Zac Medico --- repoman/lib/repoman/argparser.py | 9 ++ .../repoman/modules/scan

[gentoo-portage-dev] [PATCH 0/2] emerge: Add short -l option for --load-average (bug 699256)

2020-08-15 Thread Zac Medico
Add a short -l option for --load-average just like make(1) has. Bug: https://bugs.gentoo.org/699256 Signed-off-by: Zac Medico Zac Medico (2): emerge: Remove deprecated --changelog option (bug 699256) emerge: Add short -l option for --load-average (bug 699256) lib/_emerge/actions.py

[gentoo-portage-dev] [PATCH 2/2] emerge: Add short -l option for --load-average (bug 699256)

2020-08-15 Thread Zac Medico
Add a short -l option for --load-average just like make(1) has. Bug: https://bugs.gentoo.org/699256 Signed-off-by: Zac Medico --- lib/_emerge/main.py | 2 ++ man/emerge.1| 2 +- 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/lib/_emerge/main.py b/lib/_emerge/main.py index

[gentoo-portage-dev] [PATCH 1/2] emerge: Remove deprecated --changelog option (bug 699256)

2020-08-15 Thread Zac Medico
Bug: https://bugs.gentoo.org/699256 Signed-off-by: Zac Medico --- lib/_emerge/actions.py | 5 -- lib/_emerge/main.py| 3 +- lib/_emerge/resolver/output.py | 32 +--- lib/_emerge/resolver/output_helpers.py | 106 - man

Re: [gentoo-portage-dev] [PATCH 1/1] Revert "repoman: deprecate netsurf.eclass."

2020-08-14 Thread Zac Medico
On 8/14/20 2:43 PM, Michael Orlitzky wrote: > This reverts commit a73024729860f9224b8d1660d24c450080b67d9f. This > eclass was successfully purged from the tree, so the deprecation is no > longer needed. And eventually, to address an eblit infestation, > another eclass with the same name will

Re: [gentoo-portage-dev] profile masking

2020-08-14 Thread Zac Medico
On 8/14/20 1:42 PM, Zac Medico wrote: > On 8/14/20 1:08 PM, Ulrich Mueller wrote: >>>>>>> On Fri, 14 Aug 2020, Zac Medico wrote: >> >>> On 8/14/20 8:42 AM, Joakim Tjernlund wrote: >>>> Yes, I know I can add that in profile/package.mask but I am

Re: [gentoo-portage-dev] profile masking

2020-08-14 Thread Zac Medico
On 8/14/20 1:08 PM, Ulrich Mueller wrote: >>>>>> On Fri, 14 Aug 2020, Zac Medico wrote: > >> On 8/14/20 8:42 AM, Joakim Tjernlund wrote: >>> Yes, I know I can add that in profile/package.mask but I am looking >>> for the bigger pictu

Re: [gentoo-portage-dev] profile masking

2020-08-14 Thread Zac Medico
On 8/14/20 8:42 AM, Joakim Tjernlund wrote: > On Fri, 2020-08-14 at 17:31 +0200, Ulrich Mueller wrote: >>> On Fri, 14 Aug 2020, Joakim Tjernlund wrote: >> >>> When pkgs are masked in the profile, it affects all variants of that >>> pkgs, even the ones that are in other overlays. >>> Example:

[gentoo-portage-dev] [PATCH] lib/portage/xml/metadata.py: tolerate xml.parsers.expat import failures (bug 736912)

2020-08-12 Thread Zac Medico
Tolerate broken or missing xml support in python. This reverts a behavior change from commit 935c47d972d986f1822850618442c19c97e300c3. Fixes: 935c47d972d9 ("lib/portage/xml/metadata.py: fix ungrouped-imports w/refactor") Bug: https://bugs.gentoo.org/736912 Signed-off-by: Zac Medico

Re: [gentoo-portage-dev] RFC: conf-update.d hook dir for dispatch-conf

2020-08-08 Thread Zac Medico
On 8/3/20 1:13 AM, Florian Schmaus wrote: > Portage's dispatch-conf does historically only support RCS for > configuration file archival. There are currently two unresolved > feature requests to extend dispatch-conf support for further > configuration file management tools: > > - bug #260623 git

[gentoo-portage-dev] [PATCH 1/3 v2] Add cached portage.getpid() function

2020-08-08 Thread Zac Medico
Since getpid is a syscall, cache results, and update them via an after fork hook. Signed-off-by: Zac Medico --- lib/portage/__init__.py | 16 + .../tests/process/test_AsyncFunction.py | 24 +++ 2 files changed, 40 insertions(+) diff --git

[gentoo-portage-dev] [PATCH 0/3] sqlite: fork safety (bug 736334)

2020-08-07 Thread Zac Medico
Use a separate connection instance for each pid, since it is not safe to use a connection created in a parent process. See: https://www.sqlite.org/howtocorrupt.html Bug: https://bugs.gentoo.org/736334 Zac Medico (3): Add cached portage.getpid() function sqlite: add lazy connection init

[gentoo-portage-dev] [PATCH 3/3] sqlite: fork safety (bug 736334)

2020-08-07 Thread Zac Medico
Use a separate connection instance for each pid, since it is not safe to use a connection created in a parent process. See: https://www.sqlite.org/howtocorrupt.html Bug: https://bugs.gentoo.org/736334 Signed-off-by: Zac Medico --- lib/portage/cache/sqlite.py | 9 + lib

[gentoo-portage-dev] [PATCH 1/3] Add cached portage.getpid() function

2020-08-07 Thread Zac Medico
Since getpid is a syscall, cache results, and update them via an after fork hook. Signed-off-by: Zac Medico --- lib/portage/__init__.py | 14 +++ .../tests/process/test_AsyncFunction.py | 24 +++ 2 files changed, 38 insertions(+) diff --git

[gentoo-portage-dev] [PATCH 2/3] sqlite: add lazy connection init

2020-08-07 Thread Zac Medico
Signed-off-by: Zac Medico --- lib/portage/cache/sqlite.py | 29 - 1 file changed, 24 insertions(+), 5 deletions(-) diff --git a/lib/portage/cache/sqlite.py b/lib/portage/cache/sqlite.py index 55ae8f0e5..0395dd516 100644 --- a/lib/portage/cache/sqlite.py +++ b/lib

Re: [gentoo-portage-dev] [PATCH] lib/*: Fix useless-return

2020-08-07 Thread Zac Medico
On 8/7/20 12:06 PM, Aaron Bauman wrote: > * Python implies such things. Let's drop 'em and be consistent. > > Signed-off-by: Aaron Bauman > --- > lib/_emerge/EbuildPhase.py | 6 +++--- > lib/_emerge/resolver/output.py | 5 + > lib/portage/elog/mod_custom.py | 1 + >

Re: [gentoo-portage-dev] [PATCH] lib/*: exempt two core files from ungrouped-imports check

2020-08-06 Thread Zac Medico
On 8/6/20 5:03 PM, Aaron Bauman wrote: > * These will take some time to refactor/address if at all possible. > * Turn on ungrouped-imports check for entire repo > > Signed-off-by: Aaron Bauman > --- > lib/portage/__init__.py | 1 + > lib/portage/checksum.py | 15 --- > pylintrc

Re: [gentoo-portage-dev] [PATCH] *: drop all import __future__ statements

2020-08-06 Thread Zac Medico
On 8/6/20 6:12 PM, Aaron Bauman wrote: > * We only support Py3 now. > > Signed-off-by: Aaron Bauman > --- > bin/archive-conf | 4 +-- > bin/check-implicit-pointer-usage.py | 2 -- > bin/clean_locks | 4 +-- >

Re: [gentoo-portage-dev] [PATCH] lib/*: fix superfluous-parens and enable check

2020-08-06 Thread Zac Medico
On 8/5/20 9:05 PM, Aaron Bauman wrote: > Signed-off-by: Aaron Bauman > --- > lib/_emerge/actions.py | 14 +++--- > lib/_emerge/resolver/slot_collision.py | 4 ++-- > lib/_emerge/stdout_spinner.py| 2 +- > lib/_emerge/unmerge.py

Re: [gentoo-portage-dev] [PATCH 6/6] pylintrc: enable multiple-imports check

2020-08-06 Thread Zac Medico
On 8/5/20 4:51 PM, Aaron Bauman wrote: > Signed-off-by: Aaron Bauman > --- > pylintrc | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/pylintrc b/pylintrc > index b7091516c..5f4ec3278 100644 > --- a/pylintrc > +++ b/pylintrc > @@ -19,6 +19,7 @@ enable= > misplaced-future, >

[gentoo-portage-dev] Re: [PATCH] lib/portage/repository/config.py: fix trailing-comma-tuple

2020-08-04 Thread Zac Medico
On 8/4/20 7:35 PM, Aaron Bauman wrote: > * This fixes the one instance of trailing-comma-tuple in the repo > * A tuple does need created, but lets do so inside of parentheses as > expected > > Suggested-By: Sam James > Suggested-By: Zac Medico > Signed-off-by: Aaron

Re: [gentoo-portage-dev] [PATCH] DEVELOPING: Update minimum python version

2020-08-04 Thread Zac Medico
On 8/4/20 6:05 PM, Aaron Bauman wrote: > * Other style/readability fixes > > Signed-off-by: Aaron Bauman > --- > DEVELOPING | 18 +++--- > 1 file changed, 11 insertions(+), 7 deletions(-) Thanks, merged:

Re: [gentoo-portage-dev] [PATCH] pylintrc: add more module checks

2020-08-04 Thread Zac Medico
On 8/4/20 7:08 AM, Aaron Bauman wrote: > * Repo is already clear... so let's turn these on > > Signed-off-by: Aaron Bauman > --- > pylintrc | 25 - > 1 file changed, 16 insertions(+), 9 deletions(-) > > diff --git a/pylintrc b/pylintrc > index ad32f70d7..cd76d38dd

Re: [gentoo-portage-dev] [PATCH 1/4] pylintrc: turn on checks for reimported modules

2020-08-03 Thread Zac Medico
On 8/3/20 7:44 PM, Aaron Bauman wrote: > * also, really fix the enable module structure > > Signed-off-by: Aaron Bauman > --- > pylintrc | 20 +++- > 1 file changed, 11 insertions(+), 9 deletions(-) > > diff --git a/pylintrc b/pylintrc > index 690941715..ad32f70d7 100644 > ---

Re: [gentoo-portage-dev] [PATCH 4/4] pylintrc: enable more checks

2020-08-03 Thread Zac Medico
On 8/3/20 5:16 PM, Aaron Bauman wrote: > * These checks are already passing... so let's enable them so we do not > have regressions > * Sort the checks alphabetically and break into more manageable > structure > * Display all warnings/errors from pylint by enabling all messages as > all

Re: [gentoo-portage-dev] [PATCH 68/68] pylintrc: turn on trailing-whitespace

2020-08-03 Thread Zac Medico
On 8/3/20 3:43 PM, Aaron Bauman wrote: > Signed-off-by: Aaron Bauman > --- > pylintrc | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/pylintrc b/pylintrc > index 6f0eef386..7fd05f322 100644 > --- a/pylintrc > +++ b/pylintrc > @@ -12,7 +12,7 @@ > # --disable=W". > >

Re: [gentoo-portage-dev] [PATCH 18/18] pylintrc: enable unused-imports

2020-08-03 Thread Zac Medico
On 8/3/20 1:20 PM, Aaron Bauman wrote: > * Repo is now clear of unused-imports... so turn it on by default > > Signed-off-by: Aaron Bauman > --- > pylintrc | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/pylintrc b/pylintrc > index 19f59c165..6f0eef386 100644 > ---

Re: [gentoo-portage-dev] [PATCH 26/26] lib/portage/tests/emerge/test_simple.py: drop unused-import

2020-08-03 Thread Zac Medico
On 8/3/20 12:06 PM, Aaron Bauman wrote: > Signed-off-by: Aaron Bauman > --- > lib/portage/tests/emerge/test_simple.py | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) Thanks, merged the whole series:

Re: [gentoo-portage-dev] [PATCH] lib/_emerge/resolver/slot_collision.py: fix redefined-builtin W0622

2020-08-02 Thread Zac Medico
On 8/2/20 7:53 PM, Aaron Bauman wrote: > * This fixes the referenced warning by renaming the 'id' variable to > 'name' and the 'type' variable to 'atype' > * Additional cosmetic/style changes found along the way. > > Signed-off-by: Aaron Bauman Thanks, merged with s/atype/ctype/ and

Re: [gentoo-portage-dev] [PATCH] doc/api/conf.py: silence redefined-builtin for copyright

2020-08-02 Thread Zac Medico
On 8/2/20 7:21 PM, Aaron Bauman wrote: > * This locally silences the W0622 warning for the override of the > copyright which is required. > > Signed-off-by: Aaron Bauman > --- > doc/api/conf.py | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/doc/api/conf.py

[gentoo-portage-dev] [PATCH] cnf/repo.postsync.d/example: add egencache --update-pkg-desc-index (bug 735626)

2020-08-02 Thread Zac Medico
Add an egencache --update-pkg-desc-index example for users of app-portage/esearch to migrate to. Bug: https://bugs.gentoo.org/735626 Signed-off-by: Zac Medico --- cnf/repo.postsync.d/example | 15 ++- 1 file changed, 14 insertions(+), 1 deletion(-) diff --git a/cnf/repo.postsync.d

Re: [gentoo-portage-dev] [PATCH] Fix R0205 across all of repo.

2020-07-31 Thread Zac Medico
On 7/31/20 6:33 PM, Aaron Bauman wrote: > Do not need to inherit object in py3. > > All tests passed. > > Signed-off-by: Aaron Bauman > --- > bin/chpathtool.py| 2 +- > bin/doins.py | 10 +- > bin/ebuild-ipc.py| 2 +- > bin/egencache| 8 >

Re: [gentoo-portage-dev] pylint progress

2020-07-30 Thread Zac Medico
On 7/29/20 3:14 PM, Alec Warner wrote: > Hi, > > Recently I've begun to run pylint on the portage codebase. You can see > some recent PRs on this[0][1][2]. Most of the linter errors I've > fixed are what I consider 'fairly trivial'. In general I'm happy to > disable errors (or instances of

Re: [gentoo-portage-dev] [PATCH] portage/README: Update minimum Python version

2020-07-26 Thread Zac Medico
On 7/24/20 11:45 AM, Aaron Bauman wrote: > * Per commit e59ec1924d6db957a01c828ce294a7675be5b27c Py 2.7 has been > dropped and py3.6 is the minimum supported version > > Bug: https://bugs.gentoo.org/731114 > Signed-off-by: Aaron Bauman > --- > README | 2 +- > 1 file changed, 1 insertion(+),

[gentoo-portage-dev] [PATCH] MergeProcess: replace os.fork with multiprocessing.Process (bug 730192)

2020-07-19 Thread Zac Medico
Fix the MergeProcess _spawn method to call the superclass _spawn method, in order to replace os.fork with multiprocessing.Process, promoting a healthy state for the forked interpreter. Bug: https://bugs.gentoo.org/730192 Signed-off-by: Zac Medico --- lib/portage/dbapi/_MergeProcess.py | 102

[gentoo-portage-dev] [PATCH v2] ForkProcess: replace os.fork with multiprocessing.Process (bug 730192)

2020-07-17 Thread Zac Medico
() compatibility function. In case there's a legitimate need to inherit stdin for things like PROPERTIES=interactive support, create a temporary duplicate of fd_pipes[0] when appropriate, and restore sys.stdin and sys.__stdin__ in the subprocess. Bug: https://bugs.gentoo.org/730192 Signed-off-by: Zac

Re: [gentoo-portage-dev] [PATCH] Remove py<3.4 import compatibility

2020-07-17 Thread Zac Medico
On 7/17/20 6:58 AM, Michał Górny wrote: > --- > bin/binhost-snapshot | 5 +-- > lib/_emerge/BinpkgFetcher.py | 5 +-- > lib/_emerge/BlockerCache.py | 6 +--- > lib/portage/cache/anydbm.py | 31 +--- >

Re: [gentoo-portage-dev] [PATCH 3/3] Remove support code for Python < 3.4

2020-07-17 Thread Zac Medico
On 7/16/20 9:48 PM, Michał Górny wrote: > Signed-off-by: Michał Górny > --- > lib/_emerge/AsynchronousLock.py | 12 +--- > lib/_emerge/EbuildMetadataPhase.py| 12 +--- > lib/_emerge/FifoIpcDaemon.py | 30 +-- >

[gentoo-portage-dev] [PATCH] ForkProcess: replace os.fork with multiprocessing.Process (bug 730192)

2020-07-16 Thread Zac Medico
() compatibility function. In case there's a legitimate need to inherit stdin for things like PROPERTIES=interactive support, create a temporary duplicate of fd_pipes[0] when appropriate, and restore sys.stdin and sys.__stdin__ in the subprocess. Bug: https://bugs.gentoo.org/730192 Signed-off-by: Zac

Re: [gentoo-portage-dev] [PATCH] Clean up more py2 conditional code

2020-07-16 Thread Zac Medico
On 7/16/20 12:05 PM, Michał Górny wrote: > Closes: https://github.com/gentoo/portage/pull/575 > Signed-off-by: Michał Górny > --- > lib/portage/cache/anydbm.py | 4 +- > lib/portage/cache/mappings.py | 45 +--- > lib/portage/cache/sql_template.py

Re: [gentoo-portage-dev] [PATCH] Eliminate the most of explicit py3 conditionals

2020-07-16 Thread Zac Medico
On 7/16/20 5:18 AM, Michał Górny wrote: > Eliminate the most of py2/py3 conditions in the code. Leave a few > where the relevant code is unclear, they will be addressed later. > > Closes: https://github.com/gentoo/portage/pull/574 > Signed-off-by: Michał Górny > --- >

Re: [gentoo-portage-dev] [PATCH] Eliminate basestring/long/_unicode py3 compat

2020-07-15 Thread Zac Medico
On 7/14/20 11:07 PM, Michał Górny wrote: > Replace basestring and _unicode hacks with str, and long with int. > > Signed-off-by: Michał Górny > --- > bin/egencache | 7 +-- > lib/_emerge/BinpkgFetcher.py | 5 +- > lib/_emerge/BlockerCache.py

Re: [gentoo-portage-dev] [PATCH] Remove unnecessary time.monotonic() compat

2020-07-14 Thread Zac Medico
On 7/14/20 11:41 AM, Michał Górny wrote: > time.monotonic() is available since py3.3, so there's no need for > the compat anymore. > > Signed-off-by: Michał Górny > --- > lib/portage/dbapi/vartree.py | 7 ++-- > lib/portage/tests/util/futures/test_retry.py | 8 ++--- >

Re: [gentoo-portage-dev] [PATCH] Add caching to use_reduce, vercmp, and catpkgsplit

2020-07-13 Thread Zac Medico
On 7/12/20 11:30 PM, Chun-Yu Shei wrote: > Each of these functions is called repeatedly with the same arguments > many times. Cache sizes were selected to minimize memory use increase, > while still providing about the same speedup compared to a cache with > unbounded size. "emerge -uDvpU

Re: [gentoo-portage-dev] [PATCH] Add caching to use_reduce, vercmp, and catpkgsplit

2020-07-12 Thread Zac Medico
On 7/9/20 12:03 AM, Chun-Yu Shei wrote: > +def use_reduce(depstr, uselist=(), masklist=(), matchall=False, > excludeall=(), is_src_uri=False, \ > + eapi=None, opconvert=False, flat=False, is_valid_flag=None, > token_class=None, matchnone=False, > + subset=None): > + """ > + Takes

Re: [gentoo-portage-dev] [PATCH 1/3] Add caching to catpkgsplit function

2020-07-06 Thread Zac Medico
On 7/6/20 11:03 AM, Zac Medico wrote: > On 7/6/20 10:30 AM, Chun-Yu Shei wrote: >> I finally got a chance to try Sid's lru_cache suggestion, and the >> results were really good. Simply adding it on catpkgsplit and moving >> the body of use_reduce into a separate function

Re: [gentoo-portage-dev] [PATCH] travis.yml: drop python 2.7 (bug 731114)

2020-07-06 Thread Zac Medico
On 7/6/20 12:07 PM, Michał Górny wrote: > On Mon, 2020-07-06 at 11:42 -0700, Zac Medico wrote: >> It should be pretty safe to drop support for python2.7 at this point. >> > > We should probably also change the trove classifier to ... Python :: 3 > :: Only > Updated

[gentoo-portage-dev] [PATCH] travis.yml: drop python 2.7 (bug 731114)

2020-07-06 Thread Zac Medico
It should be pretty safe to drop support for python2.7 at this point. Bug: https://bugs.gentoo.org/731114 Signed-off-by: Zac Medico --- .travis.yml | 1 - tox.ini | 6 ++ 2 files changed, 2 insertions(+), 5 deletions(-) diff --git a/.travis.yml b/.travis.yml index 2132c8c87..d2935fdab

Re: [gentoo-portage-dev] [PATCH 1/3] Add caching to catpkgsplit function

2020-07-06 Thread Zac Medico
On 7/6/20 10:30 AM, Chun-Yu Shei wrote: > I finally got a chance to try Sid's lru_cache suggestion, and the > results were really good. Simply adding it on catpkgsplit and moving > the body of use_reduce into a separate function (that accepts tuples > instead of unhashable lists/sets) and

Re: [gentoo-portage-dev] [PATCH 0/2] Use consistent list of booleans & validate verify-commit-signature

2020-07-02 Thread Zac Medico
On 7/2/20 8:50 AM, Wynn Wolf Arbor wrote: > Hi, > > Whilst configuring a bunch of overlay repositories via repos.conf, I > discovered that not all boolean options take the same values. Some only > take 'true' and 'false', others are documented only as 'yes' or 'no', > but take 'true', 'false',

Re: [gentoo-portage-dev] Re: Speeding up Tree Verification

2020-06-30 Thread Zac Medico
On 6/30/20 10:29 AM, Sid Spry wrote: > On Mon, Jun 29, 2020, at 9:34 PM, Zac Medico wrote: >> On 6/29/20 7:15 PM, Sid Spry wrote: >>> On Mon, Jun 29, 2020, at 9:13 PM, Sid Spry wrote: >>>> Hello, >>>> >>>> I have some runnable pseudocod

Re: [gentoo-portage-dev] Re: Speeding up Tree Verification

2020-06-29 Thread Zac Medico
On 6/29/20 7:15 PM, Sid Spry wrote: > On Mon, Jun 29, 2020, at 9:13 PM, Sid Spry wrote: >> Hello, >> >> I have some runnable pseudocode outlining a faster tree verification >> algorithm. > > Ah, right. It's worth noting that even faster than this algorithm is simply > verifying > a .tar.xz. Is

[gentoo-portage-dev] Re: [PATCH] ecompress: optimize docompress -x precompressed comparison

2020-06-28 Thread Zac Medico
On 6/28/20 12:54 PM, Zac Medico wrote: > + LC_COLLATE=C sort -zu "${T}/.ecompress_skip_files" > > "${T}/.ecompress_skip_files_sorted"|| die > + LC_COLLATE=C sort -zu > "${T}/.ecompress_had_precompressed" &

[gentoo-portage-dev] [PATCH] ecompress: optimize docompress -x precompressed comparison

2020-06-28 Thread Zac Medico
Use sort and comm with temporary files in order to compare lists of docompress -x and precompressed files, since the file lists can be extremely large. Also strip ${D%/} from paths in order to reduce length. Bug: https://bugs.gentoo.org/721516 Suggested-by: Robin H. Johnson Signed-off-by: Zac

Re: [gentoo-portage-dev] Add caching to a few commonly used functions

2020-06-27 Thread Zac Medico
On 6/27/20 8:12 PM, Michał Górny wrote: > Dnia June 28, 2020 3:00:00 AM UTC, Zac Medico napisał(a): >> On 6/26/20 11:34 PM, Chun-Yu Shei wrote: >>> Hi, >>> >>> I was recently interested in whether portage could be speed up, since >>> dependency re

Re: [gentoo-portage-dev] Add caching to a few commonly used functions

2020-06-27 Thread Zac Medico
On 6/26/20 11:34 PM, Chun-Yu Shei wrote: > Hi, > > I was recently interested in whether portage could be speed up, since > dependency resolution can sometimes take a while on slower machines. > After generating some flame graphs with cProfile and vmprof, I found 3 > functions which seem to be

Re: [gentoo-portage-dev] [PATCH] ecompress: fix "Argument list too long" for sed (bug 727522)

2020-06-24 Thread Zac Medico
On 6/24/20 10:57 AM, Robin H. Johnson wrote: > On Tue, Jun 23, 2020 at 05:36:14PM -0700, Zac Medico wrote: >> From: Patrick McLean >> >> Use sed -f to feed commands to sed via stdin, in order to avoid >> the "Argument list too long" error reported in

[gentoo-portage-dev] [PATCH] ecompress: fix "Argument list too long" for sed (bug 727522)

2020-06-23 Thread Zac Medico
rg/727522 Signed-off-by: Zac Medico --- bin/ecompress | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/bin/ecompress b/bin/ecompress index 7aabc8e4c..1ab07ccd7 100755 --- a/bin/ecompress +++ b/bin/ecompress @@ -38,9 +38,10 @@ while [[ $# -gt 0 ]] ; do if [[ ${#

Re: [gentoo-portage-dev] [PATCH 2/2] Support PORTAGE_LOG_FILTER_FILE_CMD (bug 709746)

2020-06-22 Thread Zac Medico
On 6/22/20 7:46 AM, Brian Dolbec wrote: > > That's a lot of code...but I couldn't spot anything wrong, so looks good Thanks, merged: https://gitweb.gentoo.org/proj/portage.git/commit/?id=dd69ce742c62b9515cf7ae37e46bcf7f178777db -- Thanks, Zac signature.asc Description: OpenPGP digital

[gentoo-portage-dev] [PATCH 1/2] PipeLogger: non-blocking write to pipe (bug 709746)

2020-06-19 Thread Zac Medico
Add support to write to a non-blocking pipe instead of a log file. This is needed for the purposes of bug 709746, where PipeLogger will write to a pipe that is drained by anoher PipeLogger instance which is running in the same process. Bug: https://bugs.gentoo.org/709746 Signed-off-by: Zac Medico

[gentoo-portage-dev] [PATCH 0/2] Support PORTAGE_LOG_FILTER_FILE_CMD (bug 709746)

2020-06-19 Thread Zac Medico
is testing the patches in order to verify that they do not trigger emerge hangs like bug 716636. Bug: https://bugs.gentoo.org/709746 Bug: https://bugs.gentoo.org/716636 Zac Medico (2): PipeLogger: non-blocking write to pipe (bug 709746) Support PORTAGE_LOG_FILTER_FILE_CMD (bug 709746) lib/_emerge

[gentoo-portage-dev] [PATCH 2/2] Support PORTAGE_LOG_FILTER_FILE_CMD (bug 709746)

2020-06-19 Thread Zac Medico
binary file stream (refers to a pipe) that log content is written to. Bug: https://bugs.gentoo.org/709746 Signed-off-by: Zac Medico --- lib/_emerge/AbstractEbuildProcess.py | 3 +- lib/_emerge/BinpkgFetcher.py | 3 +- lib/_emerge/EbuildFetcher.py

Re: [gentoo-portage-dev] [PATCH] _writer: fix unsafe finally clause (bug 728580)

2020-06-18 Thread Zac Medico
On 6/18/20 7:13 AM, Brian Dolbec wrote: > On Thu, 18 Jun 2020 00:35:48 -0700 > Zac Medico wrote: > >> In the coroutine finally clause, do not call remove_writer in cases >> where fd has been closed and then re-allocated to a concurrent >> coroutine as in bug

[gentoo-portage-dev] [PATCH] _writer: fix unsafe finally clause (bug 728580)

2020-06-18 Thread Zac Medico
for use within a loop. Bug: https://bugs.gentoo.org/728580 Signed-off-by: Zac Medico --- lib/portage/util/futures/_asyncio/process.py | 11 - lib/portage/util/futures/_asyncio/streams.py | 50 ++-- 2 files changed, 33 insertions(+), 28 deletions(-) diff --git a/lib/portage/util

Re: [gentoo-portage-dev] erroneous behavior in 2-style USE dependencies?

2020-06-16 Thread Zac Medico
On 6/16/20 7:47 PM, Michael Lienhardt wrote: > > > On 6/16/20 11:59 PM, Zac Medico wrote: >> On 6/16/20 6:38 PM, Michael Lienhardt wrote: >>> With the first version of DEPEND, emerge succeed: >>> # emerge -pv app-misc/dummy-master >>> >>> Th

Re: [gentoo-portage-dev] erroneous behavior in 2-style USE dependencies?

2020-06-16 Thread Zac Medico
On 6/16/20 6:38 PM, Michael Lienhardt wrote: > > > On 6/16/20 9:31 PM, Zac Medico wrote: >> On 6/16/20 11:07 PM, Michael Lienhardt wrote: >>> I'm sorry, my client didn't allow to send plain text email anymore... >>> >>> So, here is my origin

  1   2   3   4   5   6   7   8   9   10   >