Re: [gentoo-dev] [PATCH 05/10] xdg.eclass: make EAPI 7 ready
On Wed, Jun 27, 2018 at 08:37:04AM +0200, Michał Górny wrote:
> W dniu śro, 27.06.2018 o godzinie 06∶58 +0200, użytkownik Ulrich Mueller
> napisał:
> > > > > > > On Tue, 26 Jun 2018, Marty E Plummer wrote:
> > > Add dev-util/desktop-file-utils and x11-misc/shared-mime-info to BDEPEND
> > > as a number of executables which will need to be executed on the build
> > > host are included in them.
> > > Package-Manager: Portage-2.3.40, Repoman-2.3.9
> > > ---
> > > eclass/xdg.eclass | 3 ++-
> > > 1 file changed, 2 insertions(+), 1 deletion(-)
> > > diff --git a/eclass/xdg.eclass b/eclass/xdg.eclass
> > > index 2a4e1f81abf..fc4bee30ca5 100644
> > > --- a/eclass/xdg.eclass
> > > +++ b/eclass/xdg.eclass
> > > @@ -26,6 +26,7 @@ DEPEND="
> > > dev-util/desktop-file-utils
> > > x11-misc/shared-mime-info
> > > "
> > > +[[ ${EAPI:-0} == [0123456] ]] || BDEPEND="${DEPEND}"
> >
> > Are these also needed in DEPEND? If not, you should set DEPEND="" in
> > EAPI 7.
> >
>
> Technically, they don't belong in either because they're run
> in pkg_post* phases only.
>
https://projects.gentoo.org/pms/7/pms.html#x1-680008.1
According to this, if I read it right, pkg_{pre,post}{inst,rm} deps
should go into PDEPEND; is that still correct in terms of EAPI7 and
such?
> --
> Best regards,
> Michał Górny
Re: [gentoo-dev] [PATCH 05/10] xdg.eclass: make EAPI 7 ready
On Wed, Jun 27, 2018 at 08:37:04AM +0200, Michał Górny wrote:
> W dniu śro, 27.06.2018 o godzinie 06∶58 +0200, użytkownik Ulrich Mueller
> napisał:
> > > > > > > On Tue, 26 Jun 2018, Marty E Plummer wrote:
> > > Add dev-util/desktop-file-utils and x11-misc/shared-mime-info to BDEPEND
> > > as a number of executables which will need to be executed on the build
> > > host are included in them.
> > > Package-Manager: Portage-2.3.40, Repoman-2.3.9
> > > ---
> > > eclass/xdg.eclass | 3 ++-
> > > 1 file changed, 2 insertions(+), 1 deletion(-)
> > > diff --git a/eclass/xdg.eclass b/eclass/xdg.eclass
> > > index 2a4e1f81abf..fc4bee30ca5 100644
> > > --- a/eclass/xdg.eclass
> > > +++ b/eclass/xdg.eclass
> > > @@ -26,6 +26,7 @@ DEPEND="
> > > dev-util/desktop-file-utils
> > > x11-misc/shared-mime-info
> > > "
> > > +[[ ${EAPI:-0} == [0123456] ]] || BDEPEND="${DEPEND}"
> >
> > Are these also needed in DEPEND? If not, you should set DEPEND="" in
> > EAPI 7.
> >
>
> Technically, they don't belong in either because they're run
> in pkg_post* phases only.
>
Huh. well, should there not be some way to specify that they are needed
for the pkg_post* phases or should I just drop them entirely?
> --
> Best regards,
> Michał Górny
Re: [gentoo-dev] [PATCH 05/10] xdg.eclass: make EAPI 7 ready
W dniu śro, 27.06.2018 o godzinie 06∶58 +0200, użytkownik Ulrich Mueller
napisał:
> > > > > > On Tue, 26 Jun 2018, Marty E Plummer wrote:
> > Add dev-util/desktop-file-utils and x11-misc/shared-mime-info to BDEPEND
> > as a number of executables which will need to be executed on the build
> > host are included in them.
> > Package-Manager: Portage-2.3.40, Repoman-2.3.9
> > ---
> > eclass/xdg.eclass | 3 ++-
> > 1 file changed, 2 insertions(+), 1 deletion(-)
> > diff --git a/eclass/xdg.eclass b/eclass/xdg.eclass
> > index 2a4e1f81abf..fc4bee30ca5 100644
> > --- a/eclass/xdg.eclass
> > +++ b/eclass/xdg.eclass
> > @@ -26,6 +26,7 @@ DEPEND="
> > dev-util/desktop-file-utils
> > x11-misc/shared-mime-info
> > "
> > +[[ ${EAPI:-0} == [0123456] ]] || BDEPEND="${DEPEND}"
>
> Are these also needed in DEPEND? If not, you should set DEPEND="" in
> EAPI 7.
>
Technically, they don't belong in either because they're run
in pkg_post* phases only.
--
Best regards,
Michał Górny
signature.asc
Description: This is a digitally signed message part
Re: [gentoo-dev] [PATCH 05/10] xdg.eclass: make EAPI 7 ready
> On Tue, 26 Jun 2018, Marty E Plummer wrote:
> Add dev-util/desktop-file-utils and x11-misc/shared-mime-info to BDEPEND
> as a number of executables which will need to be executed on the build
> host are included in them.
> Package-Manager: Portage-2.3.40, Repoman-2.3.9
> ---
> eclass/xdg.eclass | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
> diff --git a/eclass/xdg.eclass b/eclass/xdg.eclass
> index 2a4e1f81abf..fc4bee30ca5 100644
> --- a/eclass/xdg.eclass
> +++ b/eclass/xdg.eclass
> @@ -26,6 +26,7 @@ DEPEND="
> dev-util/desktop-file-utils
> x11-misc/shared-mime-info
> "
> +[[ ${EAPI:-0} == [0123456] ]] || BDEPEND="${DEPEND}"
Are these also needed in DEPEND? If not, you should set DEPEND="" in
EAPI 7.
Ulrich
pgpYvDrV0JO4f.pgp
Description: PGP signature
[gentoo-dev] [PATCH 05/10] xdg.eclass: make EAPI 7 ready
Add dev-util/desktop-file-utils and x11-misc/shared-mime-info to BDEPEND
as a number of executables which will need to be executed on the build
host are included in them.
Package-Manager: Portage-2.3.40, Repoman-2.3.9
---
eclass/xdg.eclass | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/eclass/xdg.eclass b/eclass/xdg.eclass
index 2a4e1f81abf..fc4bee30ca5 100644
--- a/eclass/xdg.eclass
+++ b/eclass/xdg.eclass
@@ -26,6 +26,7 @@ DEPEND="
dev-util/desktop-file-utils
x11-misc/shared-mime-info
"
+[[ ${EAPI:-0} == [0123456] ]] || BDEPEND="${DEPEND}"
fi
# @FUNCTION: xdg_src_prepare
@@ -34,7 +35,7 @@ fi
xdg_src_prepare() {
xdg_environment_reset
- has ${EAPI:-0} 6 && default
+ [[ ${EAPI:-0} == [012345] ]] || default
}
# @FUNCTION: xdg_pkg_preinst
--
2.17.1
[gentoo-dev] [PATCH 05/10] xdg.eclass: make EAPI 7 ready
Add dev-util/desktop-file-utils and x11-misc/shared-mime-info to BDEPEND
as a number of executables which will need to be executed on the build
host are included in them.
Package-Manager: Portage-2.3.40, Repoman-2.3.9
---
eclass/xdg.eclass | 1 +
1 file changed, 1 insertion(+)
diff --git a/eclass/xdg.eclass b/eclass/xdg.eclass
index 2a4e1f81abf..bd609f3a493 100644
--- a/eclass/xdg.eclass
+++ b/eclass/xdg.eclass
@@ -26,6 +26,7 @@ DEPEND="
dev-util/desktop-file-utils
x11-misc/shared-mime-info
"
+has ${EAPI:-0} 7 && BDEPEND="${DEPEND}"
fi
# @FUNCTION: xdg_src_prepare
--
2.17.1
