Re: [gentoo-dev] [PATCH 1/3] dune.eclass: restrict strip
On Mon, 2021-10-11 at 06:07 +0100, Sam James wrote: > This breaks at least ocamlopt. > > Closes: https://bugs.gentoo.org/803047 > Closes: https://bugs.gentoo.org/811315 > Signed-off-by: Sam James > --- > eclass/dune.eclass | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/eclass/dune.eclass b/eclass/dune.eclass > index 02a8a870ef43e..8a6e01893932a 100644 > --- a/eclass/dune.eclass > +++ b/eclass/dune.eclass > @@ -28,6 +28,9 @@ esac > # Do not complain about CFLAGS etc since ml projects do not use > them. > QA_FLAGS_IGNORED='.*' > > +# Breaks with ocamlopt > +RESTRICT="strip" > + err this is a terrible idea to do at such a large scale, esp. since nowadays you can use dostrip -x and provide proper comments as to what and why something breaks when stripped on a case by case basis
Re: [gentoo-dev] [PATCH 1/3] dune.eclass: restrict strip
> On Mon, 11 Oct 2021, Sam James wrote: > +# Breaks with ocamlopt > +RESTRICT="strip" Note that RESTRICT isn't accumulated across eclasses in EAPIs before 8. So for older EAPIs you may want to use RESTRICT+=" strip". Of course, this applies to the other two eclasses as well. Ulrich signature.asc Description: PGP signature
[gentoo-dev] [PATCH 1/3] dune.eclass: restrict strip
This breaks at least ocamlopt. Closes: https://bugs.gentoo.org/803047 Closes: https://bugs.gentoo.org/811315 Signed-off-by: Sam James --- eclass/dune.eclass | 3 +++ 1 file changed, 3 insertions(+) diff --git a/eclass/dune.eclass b/eclass/dune.eclass index 02a8a870ef43e..8a6e01893932a 100644 --- a/eclass/dune.eclass +++ b/eclass/dune.eclass @@ -28,6 +28,9 @@ esac # Do not complain about CFLAGS etc since ml projects do not use them. QA_FLAGS_IGNORED='.*' +# Breaks with ocamlopt +RESTRICT="strip" + EXPORT_FUNCTIONS src_compile src_test src_install RDEPEND=">=dev-lang/ocaml-4:=[ocamlopt?] dev-ml/dune:=" -- 2.33.0
