Re: [gentoo-dev] [PATCH 2/4] llvm.eclass: Update examples for newer LLVM versions

2019-04-30 Thread Michał Górny 
On Tue, 2019-04-30 at 18:57 +0200, Haelwenn (lanodan) Monnier wrote:
> [2019-04-30 07:38:56+0200] Michał Górny:
> > Signed-off-by: Michał Górny 
> > ---
> >  eclass/llvm.eclass | 12 +++-
> >  1 file changed, 7 insertions(+), 5 deletions(-)
> > 
> > diff --git a/eclass/llvm.eclass b/eclass/llvm.eclass
> > index 618a924bbb87..e4052a6400c0 100644
> > --- a/eclass/llvm.eclass
> > +++ b/eclass/llvm.eclass
> > @@ -17,18 +17,19 @@
> >  # a proper dependency string yourself to guarantee that appropriate
> >  # version of LLVM is installed.
> >  #
> > -# Example use for a package supporting LLVM 3.8 to 5:
> > +# Example use for a package supporting LLVM 5 to 7:
> >  # @CODE
> >  # inherit cmake-utils llvm
> >  #
> >  # RDEPEND="
> > -#   > +#   >  #  || (
> > +#  sys-devel/llvm:7
> > +#  sys-devel/llvm:6
> >  #  sys-devel/llvm:5
> > -#  sys-devel/llvm:4
> > -#  >=sys-devel/llvm-3.8:0
> >  #  )
> >  # "
> > +# DEPEND=${RDEPEND}
> >  #
> >  # LLVM_MAX_SLOT=5
> 
> Shouldn’t LLVM_MAX_SLOT be set to 7 as well?
> 

Indeed.  Thanks for catching that.

-- 
Best regards,
Michał Górny

Re: [gentoo-dev] [PATCH 2/4] llvm.eclass: Update examples for newer LLVM versions

2019-04-30 Thread Haelwenn (lanodan) Monnier 
[2019-04-30 07:38:56+0200] Michał Górny:
> Signed-off-by: Michał Górny 
> ---
>  eclass/llvm.eclass | 12 +++-
>  1 file changed, 7 insertions(+), 5 deletions(-)
> 
> diff --git a/eclass/llvm.eclass b/eclass/llvm.eclass
> index 618a924bbb87..e4052a6400c0 100644
> --- a/eclass/llvm.eclass
> +++ b/eclass/llvm.eclass
> @@ -17,18 +17,19 @@
>  # a proper dependency string yourself to guarantee that appropriate
>  # version of LLVM is installed.
>  #
> -# Example use for a package supporting LLVM 3.8 to 5:
> +# Example use for a package supporting LLVM 5 to 7:
>  # @CODE
>  # inherit cmake-utils llvm
>  #
>  # RDEPEND="
> -# +#  #|| (
> +#sys-devel/llvm:7
> +#sys-devel/llvm:6
>  #sys-devel/llvm:5
> -#sys-devel/llvm:4
> -#>=sys-devel/llvm-3.8:0
>  #)
>  # "
> +# DEPEND=${RDEPEND}
>  #
>  # LLVM_MAX_SLOT=5

Shouldn’t LLVM_MAX_SLOT be set to 7 as well?

>  #
> @@ -46,8 +47,9 @@
>  # # note: do not use := on both clang and llvm, it can match different
>  # # slots then. clang pulls llvm in, so we can skip the latter.
>  # RDEPEND="
> -#>=sys-devel/clang-4:=[llvm_targets_AMDGPU(+)]
> +#>=sys-devel/clang-6:=[llvm_targets_AMDGPU(+)]
>  # "
> +# DEPEND=${RDEPEND}
>  #
>  # llvm_check_deps() {
>  #has_version "sys-devel/clang:${LLVM_SLOT}[llvm_targets_AMDGPU(+)]"
> -- 
> 2.21.0
> 
>

[gentoo-dev] [PATCH 2/4] llvm.eclass: Update examples for newer LLVM versions

2019-04-29 Thread Michał Górny 
Signed-off-by: Michał Górny 
---
 eclass/llvm.eclass | 12 +++-
 1 file changed, 7 insertions(+), 5 deletions(-)

diff --git a/eclass/llvm.eclass b/eclass/llvm.eclass
index 618a924bbb87..e4052a6400c0 100644
--- a/eclass/llvm.eclass
+++ b/eclass/llvm.eclass
@@ -17,18 +17,19 @@
 # a proper dependency string yourself to guarantee that appropriate
 # version of LLVM is installed.
 #
-# Example use for a package supporting LLVM 3.8 to 5:
+# Example use for a package supporting LLVM 5 to 7:
 # @CODE
 # inherit cmake-utils llvm
 #
 # RDEPEND="
-#  =sys-devel/llvm-3.8:0
 #  )
 # "
+# DEPEND=${RDEPEND}
 #
 # LLVM_MAX_SLOT=5
 #
@@ -46,8 +47,9 @@
 # # note: do not use := on both clang and llvm, it can match different
 # # slots then. clang pulls llvm in, so we can skip the latter.
 # RDEPEND="
-#  >=sys-devel/clang-4:=[llvm_targets_AMDGPU(+)]
+#  >=sys-devel/clang-6:=[llvm_targets_AMDGPU(+)]
 # "
+# DEPEND=${RDEPEND}
 #
 # llvm_check_deps() {
 #  has_version "sys-devel/clang:${LLVM_SLOT}[llvm_targets_AMDGPU(+)]"
-- 
2.21.0