Re: [gentoo-dev] [PATCH 4/5] vcs-snapshot.eclass: Detect and report invalid directory structure

2019-07-25 Thread Michał Górny
On Thu, 2019-07-25 at 09:15 +0200, Ulrich Mueller wrote: > > > > > > On Thu, 25 Jul 2019, Michał Górny wrote: > > + readarray -t topdirs \ > > Not legal in EAPIs 0 to 5 which use bash-3.2. > I knew there was a reason I was doing it manually in all these eclasses! -- B

Re: [gentoo-dev] [PATCH 4/5] vcs-snapshot.eclass: Detect and report invalid directory structure

2019-07-25 Thread Ulrich Mueller
> On Thu, 25 Jul 2019, Ulrich Mueller wrote: >> +readarray -t topdirs \ > Not legal in EAPIs 0 to 5 which use bash-3.2. In fact, not legal in EAPIs 6 and 7 either, because the -t option doesn't exist in bash-4.2. signature.asc Description: PGP signature

Re: [gentoo-dev] [PATCH 4/5] vcs-snapshot.eclass: Detect and report invalid directory structure

2019-07-25 Thread Ulrich Mueller
> On Thu, 25 Jul 2019, Michał Górny wrote: > + readarray -t topdirs \ Not legal in EAPIs 0 to 5 which use bash-3.2. Ulrich signature.asc Description: PGP signature

[gentoo-dev] [PATCH 4/5] vcs-snapshot.eclass: Detect and report invalid directory structure

2019-07-24 Thread Michał Górny
Detect when the archive does not contain a single top-level directory, and abort in that case. Otherwise, --strip-components would result in unpredictable mess. Signed-off-by: Michał Górny --- eclass/vcs-snapshot.eclass | 16 ++-- 1 file changed, 14 insertions(+), 2 deletions(-) di